[17:04:13] <KateChapman>	 duesen: who else do you want to take a look at this patch prior to merging? https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/470099/
[17:16:51] <duesen>	 KateChapman: anomie probably knows this stuff best. Or Tim, or Gergö
[17:17:40] <KateChapman>	 okay thanks
[17:18:54] <duesen>	 i now restored my +1
[17:27:16] <KateChapman>	 I even added a review, my first time changing anything in gerrit :p
[20:08:06] <subbu>	 legoktm or anyone else really: know what might have cause this sortability change on a special page? https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Linter&diff=0&oldid=890649803#Linter_pages_no_longer_sortable?
[20:49:14] <Reedy>	 Definitely no change to that special page specifically
[20:54:54] <Reedy>	 subbu: https://github.com/wikimedia/mediawiki-extensions-Linter/blame/master/includes/LintErrorsPager.php#L97-L98
[20:56:35] <Reedy>	 Kinda looks like to me, it never was (at least, as defined by the extension)
[20:56:46] <subbu>	 so, that indicates that nothing changed from the beginning ...
[20:56:48] <subbu>	 right.
[20:57:43] <Reedy>	 It's possible site/user css might've changed that and made the table sortable
[21:56:02] <anomie>	 subbu: Someone should probably add #user-notice to T137900 so people are less likely to be surprised if Ieff8423 breaks any {{REVISIONID}}-using things. I'd do it myself, but I can't right now.
[21:56:03] <stashbot>	 T137900: Deal with poor edit stash hit rate due to Lua modules using {{REVISIONID}} - https://phabricator.wikimedia.org/T137900
[21:56:23] <subbu>	 will do
[21:57:04] <hauskatze>	 no more {{REVISIONID}}? I think there are a bunch of templates that use it :)
[21:57:09] <subbu>	 done
[21:57:42] <subbu>	 hauskatze, it supports the current use case of using it for previews .. /cc Krinkle who can answer more.
[21:57:56] <hauskatze>	 I'll check the task
[21:58:01] <anomie>	 hauskatze: That patch made it (when $wgMiserMode is set) return "-" instead of the actual revision ID. It'll still work for detecting preview mode, which is what people mostly seem to use it for.
[21:59:40] <hauskatze>	 so if you want, for example, use {{subst:REVISIONID}} or https://wiki.org/wiki/Special:RenameUser... &wpReason=[[{{REVISIONID}}|request]] ?
[22:00:36] <hauskatze>	 ie: https://es.wikipedia.org/w/index.php?title=Plantilla:Renombrar_usuario/2&action=edit
[22:00:51] <hauskatze>	 [{{fullurl:meta:Special:GlobalRenameUser|oldname={{urlencode:{{{1}}}}}&newname={{urlencode:{{ucfirst:{{{2}}}}}}}&reason={{urlencode:Per [[:es:Special:Permalink/{{REVISIONID}}|request on eswiki]]}}}}
[22:01:44] <anomie>	 hauskatze: Currently the rename links will probably still work because the change only affects content namespaces (i.e. ns0) and those are probably going to be in ns3 or ns4. But based on @todo comments in the patch the plan seems to be to eventually break those too.
[22:02:41] <hauskatze>	 anomie: aha - well for eswiki those are in the NS_PROJECT namespace but for Meta-Wiki the request page is in NS_MAIN. Will we have any replacement?
[22:04:01] <anomie>	 hauskatze: Looks like Meta will break then, unless NS_MAIN isn't configured as a content namespace there. I haven't heard of any replacement. Ask on the task, or people who were more involved with the patch.
[22:04:42] <hauskatze>	 anomie: Will do and will verify if NS_MAIN is content in Meta (I think it is)
[22:17:09] <Krinkle>	 hauskatze: link to an example? I'll be sure to fix it ahead of next week.
[22:20:04] <anomie>	 Krinkle: I believe the "usurp user" and "rename user" links on https://meta.wikimedia.org/wiki/Steward_requests/Username_changes would be some examples.
[22:20:05] <hauskatze>	 Krinkle: https://meta.wikimedia.org/w/index.php?search=insource%3A%7B%7BREVISIONID%7D%7D&title=Special%3ASearch&profile=advanced&fulltext=1&advancedSearch-current=%7B%7D&ns10=1 ?