[00:07:19] <tgr>	 in phpunit, you mean?
[00:08:35] <Reedy>	 On zuul
[00:08:48] <Reedy>	 blue background on each item and "skipped"
[08:27:32] <legoktm>	 skipped means something above failed and it requires that thing to pass so zuul skips the later jobs, since theoretically they'd also fail too
[09:16:05] <legoktm>	 https://tools.wmflabs.org/coverage/charts/mediawiki.png
[09:16:13] <legoktm>	 there's a big regression in core code coverage
[10:00:26] <_joe_>	 how's that possible?
[12:37:13] <Reedy>	 Is it doing something weird with file moves?
[12:37:14] <Reedy>	 13:19:57 Generating code coverage report in Clover XML format ... done
[12:37:14] <Reedy>	 13:20:50 +-----------------------------------------------------+--------+--------+
[12:37:14] <Reedy>	 13:20:50 | Filename                                            | Old %  | New %  |
[12:37:14] <Reedy>	 13:20:50 +-----------------------------------------------------+--------+--------+
[12:37:15] <Reedy>	 13:20:50 | includes/libs/filebackend/FSFileBackend.php         |  63.66 |  62.15 |
[12:37:18] <Reedy>	 13:20:50 | includes/libs/filebackend/FSFileBackendDirList.php  | 0      | 100.00 |
[12:37:20] <Reedy>	 13:20:50 | includes/libs/filebackend/FSFileBackendFileList.php | 0      | 100.00 |
[12:37:22] <Reedy>	 13:20:50 | includes/libs/filebackend/FSFileBackendList.php     | 0      |  77.27 |
[12:37:24] <Reedy>	 13:20:50 | includes/libs/filebackend/FileBackendStore.php      |  66.45 |  69.89 |
[12:37:26] <Reedy>	 13:20:50 | includes/libs/filebackend/SwiftFileBackend.php      |  56.48 |  93.85 |
[12:37:28] <Reedy>	 13:20:50 | includes/libs/lockmanager/FSLockManager.php         |  79.31 |  81.61 |
[12:37:31] <Reedy>	 13:20:50 +-----------------------------------------------------+--------+--------+
[12:37:37] <Reedy>	 That patch is adding a number of new other files (code being moved)
[12:49:06] <Reedy>	 then these...
[12:49:07] <Reedy>	 13:35:20 PHP Notice:  Undefined index: R in /opt/phpunit-patch-coverage/vendor/mediawiki/phpunit-patch-coverage/src/Git.php on line 57
[12:49:07] <Reedy>	 13:35:20 PHP Fatal error:  Uncaught Error: Cannot access empty property in /opt/phpunit-patch-coverage/vendor/mediawiki/phpunit-patch-coverage/src/Git.php:59
[16:25:38] <Krinkle>	 https://phabricator.wikimedia.org/T202470
[16:30:05] <Reedy>	 Yeah, that :)
[16:31:18] <Reedy>	 Krinkle: Handful more patches to merge to remove more phpcs exclusions if you're bored :
[16:31:19] <Reedy>	 :
[16:31:20] <Reedy>	 :)
[17:43:29] <xSavitar>	 Hi everyone! I'm Derick Alangi, a volunteer contributor to the Wikiverse. I joined this channel to learn more from other experience developers and I'm already doing that (for example, I check-in here and read conversations etc). Though I perceive this channel is for very serious issue, I'll try to follow best practices. I'm open to learn from you all. Thanks!
[17:43:48] <xSavitar>	 *issues
[17:44:26] <xSavitar>	 I'll want to make the world a better place by improving on MediaWiki.
[17:46:06] <xSavitar>	 For those who don't yet know, I'm from Cameroon (central part of Africa) and I've been in the wikiverse for quite a while (still ver young, 3 years)
[17:46:44] <xSavitar>	 I wish to learn as much as I can, not focusing on speed but depth. Slowly, I want to become better at Engineering :)
[17:46:55] <Krenair>	 Hi Derick
[17:47:05] <Krenair>	 welcome
[17:47:19] <xSavitar>	 Krenair: Thanks a lot, much appreciated!
[17:48:21] <xSavitar>	 On the wikis, I'm https://www.mediawiki.org/wiki/User:X-Savitar
[17:49:10] <Krenair>	 you've got like 4 pages of mediawiki/core merged commits so you're not entirely new here :)
[17:53:49] <xSavitar>	 Krenair: You're correct. Entirely new is the right word. I'm not that new but relative to others, I'm still new :)
[17:54:04] <xSavitar>	 but yeah, I just want to learn
[17:54:42] <xSavitar>	 I've just been around for 3 years and counting...
[17:57:48] <Reedy>	 9 years ago I was in the process of getting stranded in Berlin ;D
[17:59:12] <xSavitar>	 :D
[17:59:18] <paladox>	 lol
[17:59:24] <xSavitar>	 Reedy: You have a great sense of humor :)
[17:59:31] <Reedy>	 xSavitar: It's the truth
[17:59:55] <xSavitar>	 Reedy: Did you succeed? To get stranded in Berlin?
[17:59:59] <Reedy>	 Yup
[17:59:59] <Krenair>	 https://phabricator.wikimedia.org/T25223
[18:00:00] <Reedy>	 https://phabricator.wikimedia.org/T25223
[18:00:04] <Reedy>	 Krinkle: Snap :)
[18:00:15] <Reedy>	 ffs autocomplete
[18:00:16] <Krenair>	 :P
[18:00:26] <xSavitar>	 Omg
[18:00:29] <xSavitar>	 :D
[18:20:08] <paladox>	 You created a actual task because you were stranded? :P
[18:20:32] <Reedy>	 We didn't have anything much better to do
[18:20:55] <paladox>	 oh the iceland volcano
[18:35:41] * paladox remembers that volcano
[18:36:00] <paladox>	 Also that was the year Gordon brown said some inappropriate comments.
[19:20:32] <xSavitar>	 Reedy: mission accomplished.
[19:20:39] <xSavitar>	 You got stranded :)
[19:23:34] <Reedy>	 Quite a trek of a journey to get home
[19:25:09] <Krenair>	 Somehow I suspect you had a trek of a journey planned even without the disruption Reedy 
[19:25:35] <Reedy>	 I chose an airport at the other side of the UK to begin with... So a fair drive along the width of the UK
[19:26:46] <Krenair>	 So not Berlin to Manchester via Sydney or something? :P
[19:27:17] <paladox>	 Lol
[19:41:17] <xSavitar>	 Reedy: But that was the whole plan, get stranded and then trek home right? :D
[19:42:15] <xSavitar>	 Or maybe trekking home was just an exception that had to be caught (which you didn't see it coming)?
[19:43:08] <xSavitar>	 But well, all in all, you achieved your goal, congrats :)
[20:10:25] <legoktm>	 Reedy: the chart I linked is full coverage reports being graphed, not the partial phpunit-patch-coverage ones
[21:34:14] <Krinkle>	 legoktm: do you know what the drop is at the end? https://tools.wmflabs.org/coverage/charts/mediawiki.png
[21:34:28] * Krinkle hopes it's not his fault
[21:34:55] <Krinkle>	 I experimentally changes the job from php70 to php72 yesterday. Took a while to get right, but seems to work. based on it passing and publishing to doc.wm.o without issue
[21:34:59] <Krinkle>	 changed*
[21:35:23] <Krinkle>	 I suppose it's possible there's fewer unintentional use of fallback code.
[21:35:44] <Krinkle>	 less* whatever
[21:35:48] <Reedy>	 22:25:06 1) Rollback with confirmation should perform rollbacks after confirming intention:
[21:35:48] <Reedy>	 22:25:06 An element could not be located on the page using the given search parameters (".mw-rollback-link .jquery-confirmable-button-yes").
[21:35:49] <Reedy>	 boo
[21:42:34] <Krinkle>	 Reedy: Might need to reopen https://phabricator.wikimedia.org/T219440
[21:43:19] <Reedy>	 Mmm. Even if these CR+2 reapplies works, we probably should
[21:43:21] <Krinkle>	 I mean the added pause() was just waiting to fail at some point.
[21:43:26] <Reedy>	 It's obviously not fixed/mitigated :)
[21:43:29] <Krinkle>	 https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/502162/4/tests/selenium/specs/rollback.js
[21:54:21] <legoktm>	 Krinkle: changing to 72 could easily do that as more xdebug bugs get fixed
[21:54:51] <Krinkle>	 legoktm: Hm.. I've mostly seen its bug make code /not/ covered where it is.
[21:55:08] <Krinkle>	 was hoping it would rise
[22:04:26] <legoktm>	 same
[22:04:50] <legoktm>	 Krinkle: also maybe there's some legacy code (needed for PHP <= 7.2) that's no longer being executed?
[22:04:59] <legoktm>	 I should probably look through git log later instead of randomly guessing
[22:32:02] <Reedy>	 ~10% line decrease in .phpcs.xml
[22:32:08] <Reedy>	 this weekend