[01:14:28] Reedy: are you writing patches for the extensions? [01:15:08] tgr: https://gerrit.wikimedia.org/r/505355 [01:16:51] I guess we could kill streamFile too [01:17:03] Reedy: ConfirmAccount is the other one [01:17:21] and yeah, no reason not to kill it after that [01:17:38] Eww [01:17:50] ConfirmAccount is still using FSRepo which has been removed? [01:18:38] That code is rather broken [01:19:45] it's one of the reasonably well-maintained extensions [01:20:13] FSRepo was removed in 1.29 [01:20:18] but then I guess most people using it are on the last LTS? [01:20:42] Potentially [01:20:49] I think we can just s/FSRepo/FileRepo/ [01:21:22] what is that extension even doing with file repos? [01:22:04] "private files" [01:23:40] https://github.com/wikimedia/mediawiki-extensions-ConfirmAccount/search?q=FSREpo&unscoped_q=FSREpo [01:23:47] Does it save the un-created accounts on disk? [01:24:21] I don't see it writing to the repo, though [01:25:04] It does [01:25:37] https://github.com/wikimedia/mediawiki-extensions-ConfirmAccount/blob/master/business/AccountConfirmSubmission.php#L226-L243 [01:25:52] oops [01:25:54] I'm probably to blame [01:25:55] https://github.com/wikimedia/mediawiki-extensions-ConfirmAccount/commit/4a80558dc2a4092b5d06efc1a7860ec7ec6aeaec [01:26:13] Looks like I missed a couple [01:26:15] Easy to fix [01:28:19] tgr: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ConfirmAccount/+/505357 [01:28:24] Don't we bundle ConfirmAccount? [01:28:55] Nope [01:31:15] so I guess the idea is that this is used on serious business wikis and you need to upload your CV when requesting an account? [01:32:21] heh [01:33:57] https://phabricator.wikimedia.org/T121119#2825418 [01:33:59] Apparently [01:48:38] I doin't use CA anymore :) (also i stumbled on that error, i never used the CV functionaility) :) [21:53:56] legoktm: Hi, :), concerning T220313, should a soft deprecation and removal of its test be okay for now? [21:53:57] T220313: Is MWMessagePack unused and/or worth keeping around? - https://phabricator.wikimedia.org/T220313