[02:41:09] Ugh https://gerrit.wikimedia.org/g/mediawiki/extensions/Flow/+/2a868d12722f89d92aad67d01bf15f06b7e04024/container.php [14:50:15] V798-28k [14:50:59] woops.. wrong window [19:57:08] Reedy hi, wondering if you could review https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/News/+/506227/ please? [20:22:38] Krinkle: Per https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/502772, only for that var you mentioned, forget about the others? [20:26:52] xSavitar: I will make another commit that adopts packageFiles for the second module which uses the other variables. [20:27:02] then you can make a commit based on that as well for the others :) [20:27:30] Okay. I'll have to do a manual rebase as there seems to be merge conflicts. Thanks for the clarification Krinkle [20:27:31] this first one was easy, the complicated one is the other one. [20:27:36] Yeah, that's right. [20:27:37] Thanks! [20:29:04] Krinkle: the only issue is that the patch you want me to rebase on is not yet landed [20:29:16] xSavitar: That's okay, no? [20:29:16] Should I hold on a little? [20:29:32] In git you can stage many commits related to each other in a branch. [20:29:51] Yeah, I was just asking if I we need sometime to get it merged before I kick start [20:29:58] But in that case, I'll move the car :) [20:30:07] You can check out my commit ('git review -d 1234' or use the "Download / checkout" command), them make yours. Then when you run "git review" it will only upload yours, and it will be connected to mine. [20:30:19] Oh, right. Yeah, you can start. [20:56:12] Krinkle: incoming :)