[19:51:55] Krinkle: Hi, does https://gerrit.wikimedia.org/r/c/mediawiki/core/+/506920 make sense? Cc tgr|away [19:54:03] tgr: For the release notes thingy, I've prepared https://www.mediawiki.org/wiki/User:X-Savitar/Sub-pages/RELEASE-NOTES-thingy, I'll be using it for that purpose [19:54:16] not really, there's no functional difference and those are all deprecated methods anyway [19:54:44] tgr: :) [19:55:33] tgr: But I think that is what is supposed to be used in that case right? [19:55:39] *those cases [19:55:45] __METHOD__ and __FUNCTION__ can both be used in functions or methods [19:56:09] the only difference is that FUNCTION will never show the class name [19:56:17] not much value in ever using it, IMO [19:56:34] tgr: Reading this now, https://stackoverflow.com/questions/41354898/method-and-function [19:57:31] tgr: Yeah, cool. I've seen a few usage around: https://codesearch.wmflabs.org/search/?q=__FUNCTION__&i=nope&files=&repos= [19:58:09] So it seems it's a matter of preference [19:58:18] Outside a class, using both are the same [19:58:57] But inside a class, using __FUNCTION__ doesn't really make much sense as we want the class name too, reason being we can have 2 same function names in difference classes (for example) [19:59:28] but I think __FUNCTION__ is not entirely useless but that could be wrong in our MW context because everything seems to be classes :) [20:00:17] but thanks for your thoughts on this tgr :) [20:01:49] tgr: Wanna land it? [20:02:08] Due to other usage around in GlobalFunctions.php as well? [20:06:07] __METHOD__ is slightly nicer in that you don't have to worry about changing it when you refactor code and move it into a class [20:06:38] but more to the point there isn't much value in fixing minor subjective style issues in already deprecated code [20:07:18] o/