[00:05:24] <SMalyshev>	 James_F: now it builds fine... looks like the problem was on build side
[00:58:55] <James_F>	 SMalyshev: How odd.
[00:59:02] <James_F>	 SMalyshev: Want me to deploy it now?
[00:59:30] <SMalyshev>	 James_F: yes I think makes sense... though I have to run off now and will be back in couple of hrs. Can verify then
[00:59:48] <SMalyshev>	 but if we don't want to deploy on Friday then now sounds good :)
[00:59:52] * James_F grins.
[01:13:24] <James_F>	 SMalyshev: Hmm. Appears to fail in gate but pass in test. Fun.
[02:59:10] <SMalyshev>	 James_F: same failure, 01:07:59 [wfDebug] [debug] ApiUpload::performStash Stashing temporary file failed: UploadStashFileException Could not store file &#34;/tmp/MW_PHPUnit_Wikibase\MediaInfo\Tests\Integration\MultiLingualCap8mTFoR&#34; at &#34;mwstore&#58;//local-backend/local-temp/6/60/20190503010521!MW_PHPUnit_Wikibase\MediaInfo\Tests\Integration\MultiLingualCap8mTFoR.png&#34;. {"private":false}
[02:59:27] <SMalyshev>	 unfortunately I don't have a slightest idea what's wrong there
[03:02:28] <SMalyshev>	 I've submitted https://phabricator.wikimedia.org/T222416 that's probably as much as I can do here...
[17:24:39] <anomie>	 tgr, davidwbarratt: T222388 and T222409 seem related, if not somehow duplicates.
[17:24:40] <stashbot>	 T222388: Create a mechanism for SpecialPages and API modules to have dependencies injected into them - https://phabricator.wikimedia.org/T222388
[17:24:41] <stashbot>	 T222409: Standardize declarative object construction in MediaWiki - https://phabricator.wikimedia.org/T222409
[17:25:34] <tgr>	 more of a parent-child relationship I think
[17:25:39] <tgr>	 thanks for finding that
[17:28:27] <davidwbarratt>	 yeah I think they are related (and perhaps some overlap), but the former is about injecting services into whatever the format is, while the latter is about standardizing the format. 
[17:29:10] <davidwbarratt>	 though, T222409 could be done and just take into consideration T222388, or they could happen the other way around
[17:45:16] <anomie>	 Since the API and special pages both already have mechanisms (ApiModuleManager and SpecialPageFactory), just not very clear or standardized ones, I suspect just clarifying the existing mechanisms at the same time as standardizing for T222409 would probably be enough.
[17:45:17] <stashbot>	 T222409: Standardize declarative object construction in MediaWiki - https://phabricator.wikimedia.org/T222409
[20:51:01] <anomie>	 James_F: I can't comment in Gerrit at the moment, but looking at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/232214/64/includes/ApiTimedText.php I note it uses deprecated dieUsage() on line 137, and looking at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/232214/64/i18n/api/en.json you should use "&lt;track&gt;" instead of "<track>". Other than that the API bits seem good, haven't tested.
[20:55:41] <James_F>	 anomie: Oh, good spot, let's not make more tech debt. :-)
[21:02:44] <SMalyshev>	 is there some option that allows to show in the logs where SQL query is coming from?