[15:36:24] duesen: Is it trivial to fix or should be revert? I'm unable to merge anything in various repos https://phabricator.wikimedia.org/T222677 [15:38:11] duesen: also, do I understand correctly you'd like Bill to review this patch instead of me to learn MWDebugToolbar and/or other ways to see which queries are done on the page? That'd be fine by me, I can re-assign. – https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/496744/ [17:22:30] bpirkle: i forgot to mention something about testing the link batch patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/496744#message-c94eb0b06f78c4d3e7af728d7ca177446cc0875d [17:22:56] Krinkle: it just seemed like you were buisy, and so was I, so I punted it to bill :P [17:23:07] OK :) [17:23:42] I tend to use xdebug, not MWDebugToolbar, and I don't know much about it to be honest. If you want to introduce bill to the wonders of in-browser debugging, please do :) [17:23:59] (and maybe cc me, i'll probably learn something as well) [17:24:03] duesen: can you log sql queries with xdebug? [17:24:15] no, i can look at them while they happen [17:24:17] I thought those would go to debug.log only, or in-browser with debug toolbar [17:24:22] duesen: additional info noted, thank you [17:24:54] Krinkle: having them collected and presented in the browser is indeed much more convenient. xdebug is just the hammer i use for all the nails... [17:25:08] duesen: oh, I see. you'd debugger; query() or something like that [17:25:09] interesting [17:25:26] yes. you can put conditions on breakpoints, so it wouldn't trigegr for all queries [17:28:49] Conditional breakpoints rock, I'm a big xdebug fan. With that said, I also prefer to use the best tool for the job, and I do have the debug toolbar installed (although I haven't used it recently) [17:32:49] bpirkle: I'd be curious to know how debug toolbar interactis with the edit stash. krinle, do you happen to know? [17:33:01] *krinkle [17:33:25] would it somehow capture queries made by an intermediate call to the api? [17:33:41] debugtoolbar is tied to the debug buffer from the same web request only. [17:33:51] not load.php, ajax, or things you redirect over. [17:34:05] I usually tail debug.log instead as such. [18:36:14] bpirkle: I've re-reviewed the php error handling and documented some stuff - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/508653/ [18:36:49] Looks like we don't need to add any mapping for exception=>fatal. We did need to add one such case, but that was already done in https://github.com/wikimedia/mediawiki/commit/c8ca57f903da259f0 [18:36:54] so just some docu fixes :) [20:32:45] could use some help with a test. Here I'm passing a context that specifies a mutable test user (uid 3), the end result is that an option is saved in that user's preferences https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/507702/13/tests/phpunit/ApiQuestionStoreTest.php#58 [20:33:29] then I'm calling an API to read back data that is stored in that preference: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/507702/13/tests/phpunit/ApiQuestionStoreTest.php#59 but in the API context, the user is uid 1 (UTSysop) [20:50:14] nm, I think the problem is elsewhere