[00:00:52] yay [00:07:49] Thanks all for pushing this through today :) [00:08:25] ori too if you're still about. <3 for the narrowed repo test case [00:09:55] get these two patches merged, and then I'll make the patches for cssjanus [00:16:23] https://gerrit.wikimedia.org/r/509539 and https://gerrit.wikimedia.org/r/509540 [00:26:46] Reedy: You fixing the vendor patch? [00:26:59] Is it just being a dick about depends-on? [00:27:39] You'll need to bump https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/509539 too, right? [00:27:42] Or I can. [00:28:24] Bump what? [00:28:47] spdx-licenses and codesniffer. [00:29:37] They're not in the lock file.. [00:29:52] They're the reason it V-1'ed before. [00:31:29] codesniffer and spdx aren't in vendor at all [00:32:18] or is that when it's trying to install what core wants into the vendor dir [00:32:40] It is, yes. Fun. Circular dependency. I'll just force merge. [00:33:12] add the depends-on? [00:33:29] You can't depend from /vendor into /core. [00:33:53] The structure test in /core breaks. /core always has to depend on /vendor. [00:33:54] sillyness [00:34:06] The sooner we can dump /vendor the better. [00:47:48] hm.. codesniffer still breaking the build there? [00:48:54] Krinkle: The CI for /vendor runs CS from /core, which is incompatible with the new stuff in /vendor. It happens. Thankfully, rarely. [00:49:19] Krinkle: Everything else should Just Merge™, he says, jinxing us all. [00:50:49] Yeah, that sounds right [01:23:36] I half wonder if we should be backporting the cssjanus bump for PHP7 compat... [02:01:14] Reedy i would think so [02:01:40] as we at least support php 7.2 in mw 1.32 (i think) [02:02:44] "PHP 7.2 support is available in MediaWiki 1.31 and newer." [02:02:46] Joy [02:06:08] heh [05:13:01] <_joe_> oh wow you solved the cssjanus issues? [05:15:42] <_joe_> thanks all! [11:28:50] _joe_: well, it still needs to ride the train ;) [15:40:46] Reedy: Thanks for that awesome list of extensions using getTitle() [15:41:03] Sometimes, I wonder if you have all exts setup locally, do you? [15:41:19] Not setup, but checked out [15:41:37] Okay, must be a huge system with many many secondary memory [15:42:00] only 16GB ram on my macbook [15:42:18] I'm talking about your HDD, holding all extensions wow [15:42:32] Or is it just WMF deployed? I guess not [15:42:44] macs doin't use HDD :P [15:42:49] SDD :D [15:42:53] Older ones do [15:42:53] paladox: o/ [15:43:09] hi [15:43:09] I don't know who uses older ones except me [15:43:16] the extension folder... [15:43:17] 738,845,125 bytes (1.09 GB on disk) for 111,380 items [15:43:24] But that doesn't include all the git objects [15:43:27] Reedy yes, but that's going back quite a few years :) [15:43:56] Oh not bad. I actually thought it was more GBs [15:44:11] But yeah, sometimes, it comes in handy to have all exts in one place for search etc [15:44:12] In total all repos in gerrit are 45gb. [15:44:19] Oh my :D [15:44:37] Means my PC can hold them but I wonder if indexing will take a few years or so on PhpStorm [15:44:52] ;) [15:45:29] Is it even SDD, that should be SSD :( [15:45:33] typo, err [15:45:53] On the linux vm I do most of the git stuff... [15:46:05] It's 17GB including the os and other various crap I've got in there [15:47:36] And a few copies of mw core and stuff [15:47:42] Not insignificant... But not a horribly large amount [15:48:52] Yup [15:50:09] * paladox has quite a few copy's of gerrit's source code [15:51:31] paladox: eh [16:05:41] is anything wrong with CI today ? can't get my patch-set to trigger CI on Gerrit, eg: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/502484 [16:06:46] i think it's because of all the Depends-On you have [16:07:31] thanks for recheck, is there a limit or something ? or it just fails to start because of deps ? [16:08:13] Im not aware of any limit, but maybe because both changes depend on each other could be the cause? (though im not sure) [16:11:42] oh, could be so! [16:12:55] though, this one was triggering CI just fine until today and no new dependencies were added https://gerrit.wikimedia.org/r/c/mediawiki/core/+/504043 [16:16:12] could you have changed the commits that (that) change depends on? (Since depends-on takes a change id not a commit id). [16:21:27] that's a good question! [16:48:01] is there some way for me to achieve a re-check permission ? [16:52:59] vedmaka you need to submit a patch to whitelist your self here https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L59 [16:55:02] in gerrit the repo is integration/config [17:41:20] but I am already there, at least I was [17:42:04] yup, here I am https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L165 , I recall I was adding myself into 2 places of the file, I guess it was refactored since then, but I am still there [18:18:07] vedmaka: Circular dependencies causes problems for Jenkins, so it doesn't work as expected atm [20:46:58] thanks, it was it :)