[07:56:39] <Krenair>	 https://phabricator.wikimedia.org/T222935 appears to be a wmf.4 regression (i.e., from last week's train)
[08:48:09] <_joe_>	 Krenair: indeed, trying to ping the relevant people
[08:51:15] <_joe_>	 uhm any dev around? I don't think I'm the best person to handle an UBN! regression on MediaWiki
[09:27:04] <hashar>	 James_F: Reedy: any idea why mediawiki/core master branch has both RELEASE-NOTES-1.33 and RELEASE-NOTES-1.34 ? :)
[09:27:19] <hashar>	 seems to me 1.33 should have been dropped when we have cut REL1_34 
[09:34:15] <James_F>	 hashar: No. 1.33 notes are only merged in when REL1_33 gets *released*, not cut.
[09:34:27] <hashar>	 ok ok :]
[09:35:04] <James_F>	 hashar: Compare d6314935df54f9cfdf2e0ac06ced8167251de57c ebb3da76de05a4ddfd7c58348c5c1df404124ad7 75f5c2a653567ecdf24299c5873522732dc55d72
[09:36:45] <_joe_>	 James_F: so I should just not fix the non-en/non-qqq messages?
[09:36:57] <_joe_>	 re https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaEvents/+/508172/
[09:37:10] <duesen>	 fix for ubn issue in HttpRequestFactory, please review: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/509777 
[09:37:30] <James_F>	 _joe_: Yeah, just leave them and they'll get fixed by magic.
[09:37:32] <duesen>	 (yes, this is very embarrassing)
[09:37:35] <James_F>	 duesen: Already C+2'ed.
[09:37:43] <duesen>	 heh :D
[09:38:06] <duesen>	 James_F: will you also +2 the backport?
[09:38:09] <James_F>	 I'm surprised that phan didn't notice the issue. I thought that was what static analysis was for.
[09:38:18] <James_F>	 duesen: And deploy it, yes.
[09:38:31] <duesen>	 I'm very annoyed at myself for not making sure that the new methods have unit tests
[09:38:46] <James_F>	 Yes, that too. You work on the tests, I'll deploy the code.
[09:38:56] <duesen>	 kk
[09:49:39] <duesen>	 James_F: doing the tests properly is a bit of work. will be an hour or so
[10:04:27] <hashar>	 duesen: I found the issue :D
[10:05:09] <hashar>	 https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/504012/ is entirely broken :D
[10:05:20] <hashar>	 my explanation is at https://phabricator.wikimedia.org/T222935#5175940
[10:05:40] <hashar>	 oh
[10:05:40] <hashar>	 yeah
[10:05:45] <hashar>	 what you said on https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/509777/1/includes/http/HttpRequestFactory.php :]
[10:06:38] <hashar>	 which I guess we just need to cherry pick / deploy
[10:07:28] <hashar>	 which is https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/509783/ :D
[10:09:05] <James_F>	 hashar: Deploying now.
[10:13:11] <duesen>	 i'm terribly sorry :/
[10:13:30] <duesen>	 this is why unit tests for trivial code are improtant!
[10:13:44] <duesen>	 (they should be trivial to write, too)
[10:14:48] <hashar>	 :]
[10:15:16] <hashar>	 duesen: yeah that is why I really just wanted to revert the change ;D
[10:15:26] <hashar>	 what surprises me is that barely anything broke on the cluster
[10:17:00] <James_F>	 Yeah, shows we're not using it widely.
[10:18:01] <hashar>	 there is ExternalStoreHttp which got broken as well
[10:18:11] <hashar>	 but I have no idea whether prod uses that or someother external store mecanism
[10:39:37] <duesen>	 James_F, hashar: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/509786
[10:40:11] <hashar>	 E_BRAIN_PATCHSETS_THROWN_AT_RATE_LIMIT_EXCEED
[10:40:25] <duesen>	 hashar: I'm not aware of anything or anyone using ExternalStoreHttp. But that may just be due to ignorance
[10:40:48] <hashar>	 duesen: thanks a ton for the addition of tests! :]
[10:41:40] <duesen>	 \o/
[10:46:21] <James_F>	 +1
[10:51:24] <Krinkle>	 James_F: 
[10:51:25] <Krinkle>	 [{exception_id}] {exception_url} ErrorException from line 155 of /srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php: PHP Notice: Undefined variable: rlModulesArr
[10:51:29] <Krinkle>	 https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/7a22db2407f36431971f6865f2bbf23c9df1e317/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php#155
[10:52:43] <James_F>	 Fun.
[10:53:32] <Krinkle>	 James_F: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/506867/
[10:55:32] <Krinkle>	 James_F: T223085
[10:55:33] <stashbot>	 T223085: ErrorException from line 155 of /srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php: PHP Notice: Undefined variable: rlModulesArr - https://phabricator.wikimedia.org/T223085
[10:57:21] <James_F>	 Krinkle: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/509791
[11:13:48] <James_F>	 duesen: Code sniffer's not happy with your tests.
[12:02:22] <Krinkle>	 James_F: https://phabricator.wikimedia.org/T182024
[12:33:06] <Krinkle>	 duesen: sorry, I was wrong to assume it was from you :/
[13:50:56] <anomie>	 Reedy: What tool did you use to generate the output in T223010?
[13:50:57] <stashbot>	 T223010: Replace usages of Linker::link() - https://phabricator.wikimedia.org/T223010
[14:02:27] <duesen>	 anomie: I'm unable to connect to the meet session for our meeting
[14:02:35] <duesen>	 status 429 :/
[14:02:46] <duesen>	 CindyCicaleseWMF: --^
[14:16:07] <Reedy>	 anomie: It's from phpstorms "find usage", it has an export feature
[14:39:47] <anomie>	 Reedy: Thanks. I was hoping it was something I could easily apt-get install, oh well.
[15:39:02] <clarakosi>	 duesen: CindyCicaleseWMF bpirkle sorry. My computer just randomly restarted 
[15:39:36] <CindyCicaleseWMF>	 clarakosi: it gave us a good excuse to finally say goodbye ;-)
[15:40:04] <clarakosi>	 CindyCicaleseWMF: haha good :) 
[16:51:54] <_joe_>	 clarakosi: a mac, using chrome for hangouts?
[16:52:10] <_joe_>	 I'm having the same problem, but switching to firefox solved it for now, apparently
[16:52:51] <clarakosi>	 _joe_: yup!
[16:53:56] <clarakosi>	 Don't have any other meetings for today but will use firefox tomorrow 
[16:54:03] <_joe_>	 if it happens regularly, I suggest you try going to an apple store, it's covered by apple care
[16:54:09] <_joe_>	 it should be
[16:56:03] <clarakosi>	 this was the first time but if it keeps happening I'll take it to the apple store 
[17:05:00] <Krinkle>	 James_F: https://wikitech.wikimedia.org/wiki/Performance/Runbook/Fresnel
[17:59:36] <tgr>	 James_F: can you look at https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/509905 ? I want to put it in the SWAT today
[18:02:19] <Reedy>	 tgr: phpcs fails ;)
[18:02:46] <Reedy>	 Can we get a TODO: Remove this after X date or something?
[18:03:22] <tgr>	 i'll make a revert patch once it's merged
[18:03:47] <Reedy>	 WFM. Guess it'll only need to exist for a few days/weeks?
[18:03:55] <tgr>	 30 days
[18:04:23] <James_F>	 Yeah, what Reedy says, otherwise looks good.
[18:09:33] <duesen>	 anomie just asked by why i'm not in mediawiki-staff... and the answer is: because I couldn't join, and then forgot about it.
[18:09:38] <duesen>	 turns out i still can't join.
[18:09:42] <duesen>	 can someone invite me, please?
[18:09:55] <duesen>	 err, #wikimedia-staff
[18:10:17] <duesen>	 after 15 years, it's still confusing ;)
[18:15:25] <tgr>	 Reedy: can you look again? it's passing now
[18:15:48] <Reedy>	 James_F: Were you meaning phpcs or the end date or both?
[18:17:55] <James_F>	 The TODO.
[18:18:23] <tgr>	 todos tend to get forgotten
[18:18:38] <Reedy>	 Trudat
[18:18:39] <tgr>	 I was planning to make a revert patch and add some people on it
[18:18:53] <Reedy>	 But it's better than not knowing, or having to git blame or find other context
[18:19:48] <tgr>	 the code already makes it obvious that this is temporary, if someone happens to look at the right place in that 4000-line file
[18:19:54] <tgr>	 but I can add one, sure
[18:19:55] <James_F>	 A TODO with a date in it, and a revert patch, is best.
[18:21:00] <tgr>	 done
[18:21:58] <Reedy>	 Cheers
[18:25:00] <tgr>	 cross-wiki notifications look kind of broken, I wonder if it's the same issue
[18:27:34] <tgr>	 Reedy: thanks! are you already SWATting? I can do it otherwise
[18:27:46] <Reedy>	 It's already deployed :)
[18:31:21] <duesen>	 James_F: hm, now I can join #wikimedia-staff, but get kicked immediately, for lack of authorization. fun :)
[18:31:55] <duesen>	 I assumed you invited me earlier? 
[18:34:13] <tgr>	 I did, I doubt I can authorize you though
[18:35:20] <tgr>	 weren't you authorized earlier? or was that for your WMF nick?