[16:09:36] <legoktm>	 Reedy: I have one more IPUtils patch https://gerrit.wikimedia.org/r/518290 and then I think we're ready to tag a release?
[16:09:56] <Reedy>	 I didn't look too closely as it was mostly copy paste for the originals
[16:10:01] <Reedy>	 I'll have a look though yeah
[16:13:42] <legoktm>	 it's a pretty trivial library, but PHP parsoid wants to use it
[16:17:31] <Reedy>	 yeah, not a bad thing :)
[16:22:19] <Reedy>	 legoktm: the packagist/license images are broken on https://github.com/wikimedia/mediawiki-libs-IPUtils
[16:22:37] <legoktm>	 they wfm?
[16:23:03] <Reedy>	 https://camo.githubusercontent.com/3c59754842f1555e81fde420f7686896976dbca9/68747470733a2f2f706f7365722e707567782e6f72672f77696b696d656469612f69702d7574696c732f762f737461626c652e737667
[16:23:24] <Reedy>	 legoktm: Also... IP::isIPv4( '124.24.52.13' );
[16:23:31] <Reedy>	 there's no class IP :)
[16:23:44] <Reedy>	 There's also two @since tags left
[16:23:53] <legoktm>	 https://i.imgur.com/UnPymV7.png
[16:23:59] <legoktm>	 oops
[16:24:51] <Reedy>	 https://imgur.com/a/wk3ZPNB
[16:25:00] <Reedy>	 I'm guessing it's local and/or github CDN stuff then
[16:25:07] <Reedy>	 https://imgur.com/yzEZkQP
[16:25:16] <legoktm>	 o.o weird
[16:25:25] <legoktm>	 https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/IPUtils/+/518292 https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/IPUtils/+/518293
[16:36:00] <Krinkle>	 legoktm: late to the party, but a separate lib from IPSet seems a bit much?
[16:36:45] <Krinkle>	 Plans to merge?
[16:37:15] <legoktm>	 hmm, I created a separate library because IPSet had a kinda narrowly scoped name
[16:37:34] <legoktm>	 we could merge IPSet into IPUtils, should be straightforward
[16:45:45] <Reedy>	 shouldn't need to mess about with re-namespacing anything
[16:46:11] * legoktm afk -> food
[17:09:28] <Reedy>	 legoktm: Images working now
[17:09:37] <Reedy>	 Dunno if the pushed changes were enough to purge some cache
[17:14:00] <Reedy>	 			RE_IP_BYTE = '(?:25[0-5]|2[0-4][0-9]|1[0-9][0-9]|0?[0-9]?[0-9])';
[17:14:00] <Reedy>	 			RE_IP_ADD = '(?:' + RE_IP_BYTE + '\\.){3}' + RE_IP_BYTE;
[17:14:09] <Reedy>	 I see we have some JS that is similar, but not necessarily the same...
[17:14:49] <Reedy>	 legoktm: Only outstanding ? from me is whether we should necessarily do something with all the constants
[17:34:02] <legoktm>	 hmm
[17:34:15] <legoktm>	 the only usage of them outside of the IPUtils class itself is https://gerrit.wikimedia.org/g/mediawiki/core/+/a8f302118184c543ff58e9a93c0cf03c84bf712a/includes/api/ApiBase.php#1716
[17:50:46] <legoktm>	 Reedy: https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/IPUtils/+/518306