[13:20:31] ReleaseTaggerBot added projects: MW-1.31-release-notes, MW-1.32-notes. [13:20:34] Why does the bot add those tags... [13:20:44] When they're archived? [13:35:37] Reedy i noticed a mistake in the Release notes for 1.33, shouldn't === Changes since MediaWiki 1.32.0-rc.0 === that be === Changes since MediaWiki 1.33.0-rc.0 ===? [13:36:12] paladox: lol, yeah [13:36:15] noting it was already there [13:36:23] :D [13:36:24] but should fix it before we tag and release :) [13:36:39] feel free to make the patch, I'm just doing the point releases for 1.31/1.32 [13:37:19] Reedy https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/520239/ [13:39:46] thanks! [13:59:14] Reedy: Hi, I’m seeing this: https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php70-docker/21893/console, not sure if I get it. Some slow tests? [13:59:48] 14:52:16 There were 2 failures: [13:59:57] There's a couple of test failures under there [14:02:00] Yeah, I see them too. But is not related to the patch [14:02:15] But I agree with you, there are 2 failures. I thought it was because of the slow tests [14:02:20] :) [14:02:28] I think releng and perf are just trying to raise visibility of those [14:03:07] So you suggest the failures and the slow tests aren’t related, I think so since the failures are API related [14:03:20] but the slow tests are MCR related [14:03:55] I submitted T227086 though [14:03:55] T227086: Build failure with error "You should really fix these slow tests (>50ms)..." - https://phabricator.wikimedia.org/T227086 [17:43:03] nerd snipe: T226840 shows Set-Cookie headers going crazy and nobody has a good idea of why yet [17:43:05] T226840: Consistent HTTP 503 Varnish Error on some urls for some logged-in users (CentralAuth Set-Cookie storm) - https://phabricator.wikimedia.org/T226840 [18:45:42] tgr: have you seen ^ yet? [18:49:29] legoktm: yeah, looking [18:52:04] "It appears there is something on some wiki pages that triggers it, and I have reduced it to pages with a video." is really weird [18:52:36] which suggests that TMH is somehow messing it up? [19:04:21] legoktm: basically, something is calling Session::persist() a lot [19:05:12] legoktm: TMH is adding one or to unrelated response headers. [19:05:13] which doesn't explain why the central session ID changes with each call, but maybe some kind of race condition where the session is set and then immediately read and that results in a miss [19:05:18] causing it to reach the threshold [19:05:25] the number of CentralAuth cookies is not influenced by it [19:06:47] from the task it sounds like this is reproducible, so calling with X-Wikimedia-Debug would be a good first step [19:06:55] that adds a lot of detail to the logging [20:06:26] Who would be the right person to answer some CentralAuth questions in T227097? We're planning the Kask/session storage deploy and are wondering what things we might be at risk of breaking. [20:06:27] T227097: Make sure that we're taking CentralAuth into consideration for staging release - https://phabricator.wikimedia.org/T227097 [20:06:51] brion: we added you to the ticket because you are listed on mediawiki.org as the author, but not sure if you are the right person [20:07:01] using X-Wikimedia-Debug results in an 502 :/ [20:08:02] bpirkle: https://www.mediawiki.org/wiki/Developers/Maintainers is the list to use for this purpose [20:08:17] Where CentralAuth falls in the gap of deployed software that currently has no owner/steward. [20:08:32] Might wanna reach out to JR from RelEng to ask if a stewardship process can be started. [20:09:57] Krinkle: Fun! Thank you for the answer. Also, just because CentralAuth is being mentioned in other contexts in this channel today, we have not actually deployed, we are still just planning. So we didn't break anything. Yet, anyway. :) [20:13:59] At this stage, we mostly we want to know if we're properly understanding how its configuration works, and what we risk in deploying Kask. If actual changes to CentralAuth are warranted, we may take those on ourselves. [20:21:22] bpirkle: Yeah, don't know unfortunately. For the most part, I think CentralAuth only uses the core interfaces (session storage / main stash / session manager) for this nowadays, which are maintained somewhere between Readers Infra, CPT and Perf. [21:18:18] Reedy hi, wondering if you could force merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/RelatedArticles/+/520318 too please? :)