[01:39:56] <AaronSchulz>	 TimStarling: I guess that leaves https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Scribunto/+/519574/
[01:40:33] <TimStarling>	 right
[01:40:36] <AaronSchulz>	 TimStarling: actually, the core one is still blocked on a tiny parent patch https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/520148/
[01:41:10] <AaronSchulz>	 TimStarling: err, not that one
[01:42:00] <AaronSchulz>	 nevermind, my tab was outdated
[01:42:12] <TimStarling>	 yeah, the core change is merged
[05:19:28] <AaronSchulz>	 TimStarling: thanks, the other 2 patches (for PAGEID) end with https://gerrit.wikimedia.org/r/519352
[15:20:13] <davidwbarratt>	 uhh... this is weird... this patch is not submitting... any ideas why? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/520050/12
[15:20:36] <davidwbarratt>	 when I try to manually do it, I get the error "Could not perform action: Failed to submit 1 change due to the following problems: Change 520050: depends on change that was not submitted"
[15:21:13] <davidwbarratt>	 let me try rebasing it. :)
[15:39:37] <davidwbarratt>	 welp that fixed it. :)
[16:22:22] <Krinkle>	 tgr: TimStarling: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralAuth/+/523844/ is merged but not checked out on deploy1001, presumably not deployed either?
[17:15:17] <Krinkle>	 (reverted now)
[17:15:57] <Krinkle>	 kostajh: Nice bug found by codesonar - https://sonarcloud.io/project/issues?id=mediawiki-core&open=AWuzSDE9TV0IaTr2S-5x&resolved=false&sinceLeakPeriod=true&types=BUG
[17:16:02] <Krinkle>	 sonarcloud*
[17:26:43] <greg-g>	 Krinkle: he might be a little slow to respond now, I think today/tomorrow is the big "move to europe" day for him/family
[17:26:45] <greg-g>	 :)
[17:27:15] <Krinkle>	 greg-g: thx
[17:40:42] <Krinkle>	 1 min 30 s of the 6 min PHPUnit is Wikibase. – https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/3587/testReport/
[17:41:17] <Krinkle>	 (total job time, 16 min)
[21:26:18] <TimStarling>	 did I forget to do git submodule update or something? I don't still have that terminal open but SAL shows I did scap it
[21:29:33] <TimStarling>	 it fixes a UBN bug, you could have just deployed it
[21:33:59] <Krinkle>	 TimStarling: Indeed, the submodule wasn't updated, so the sync was a no-op.
[21:34:29] <Krinkle>	 I don't know the code or how to verify it and needed to do something else. Didn't want to change prod without time to see it through.
[21:35:03] <TimStarling>	 I don't have time to redeploy it, I'm on leave today
[21:35:06] <Krinkle>	 I didn't look at the task at the time, if I knew it was UBN perhaps I wouldve taken the time to roll it out.
[21:35:21] <TimStarling>	 got to go soon
[21:35:37] <Krinkle>	 notet hat wmf.14 was rolled back
[21:35:42] <Krinkle>	 I'll add it as a train blocker
[21:36:09] <Krinkle>	 So it'll get rolled out before we move forward again
[21:37:07] <Krinkle>	 yeah , I'm signing off now as well, don't worry. thx for the ping.