[15:35:29] clarakosi: Perhaps just make checkboxes on the tasks for the tests in the frameworks you are planning to write. I'll do the same. [15:36:35] duesen_: will do [15:41:15] clarakosi: i just updated https://phabricator.wikimedia.org/T228001 [15:51:39] duesen_: I think CindyCicaleseWMF wanted us to check the completed ones. Can you clarify CindyCicaleseWMF? [15:52:16] clarakosi: i was going to do that when the PRs are merged. [15:57:11] duesen_: ok. As far as the PRs they look ready to me [15:58:24] after the PRs are merged is fine [16:09:05] clarakosi: i just merged yours [16:15:19] duesen_: I think we can figure out the specifics of resources later (assuming we end up building phester). If you agree I can go ahead and merge yours [16:23:23] i just pushed an update, but I may have messed it up :) [16:23:28] you can merge either way [16:29:29] duesen_: done :) [17:01:39] duesen_: Hi, I see you’re the author of Extension:CategoryTree. A quick question please, is it possible to suppress translation pages and show only the default one the page was created in? [17:02:09] For example only the page in “en” and suppress showing /fr, /de, etc in the category tree? [17:02:16] xSavitar: I haven't touched it in y decade... [17:02:26] when I wrote it, this was not possible. [17:02:47] Oh okay! [17:02:49] perhaps make per-language categories? [17:03:01] sorry :) [17:03:40] Np [18:58:06] duesen_: I’ll add that feature as I need it for some work on a product. Will you be willing to review the patch? [19:03:55] duesen_: T229265 [19:03:56] T229265: Suppress translation/translated versions of a page and keep just the default in Category Tree - https://phabricator.wikimedia.org/T229265 [22:05:28] you could filter by page language, would require adding a new index though [22:17:51] tgr: I’m not sure but if your message was for me, I dropped this: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CategoryTree/+/526234. Thanks [22:18:08] It still has a TODO I need to clean up [22:33:41] that skips pages with slashes, not pages with translations [22:45:33] Köszönöm, I missed that. Fixing. [22:45:43] tgr: Appreciate it [22:55:58] tgr: I think I tried adjusting it now, another round of look if you have time. Thanks! [22:56:37] I completely missed the aspect of sub-pages that could have translations as well [22:57:41] xSavitar: that's one way to do it, although you should check it has more than one element [22:58:00] ie. you are not looking at an article called 'It', for example [22:58:25] the other way is to use Page::getLanguage [22:58:54] which only works for programmatic translations (Extension:Translate basically), which might or might not be preferable [23:00:00] Oh, so I’ll go for the count() + the isValidBuiltInCode(), I think that is better right? [23:00:27] Title::getPageLanguage, I mean [23:00:48] not sure which is better, depends on what you want to do [23:01:31] Let me read a little on Title::getPageLanguage() then see, thanks :) [23:01:33] some wikis use Translate, some just create subpages manually (e.g. Commons for template translation), depends on whether you want to filter those as well [23:03:02] the other non-straightforward decision is, do you want to show the default page or the page in the user's own language? [23:03:28] also what happens when Foo/en exists but Foo doesn't [23:03:28] tgr: The default page [23:03:52] That’s a good question, I’ve been thinking about that too but not figured out a way [23:04:15] In case Foo/en is the default page, the algorithm ATM will fail I think [23:04:17] I suppose, check if it exists, and if not just display the page normally [23:04:27] Okay!