[01:06:19] <Krinkle>	 legoktm: Might be an issue with extension repos at https://tools.wmflabs.org/coverage/charts/ - e.g. https://tools.wmflabs.org/coverage/charts/AdvancedSearch.png and others all dropping to zero and no further data points.
[01:07:27] <Krinkle>	 nvm, is just that one
[01:07:35] <Krinkle>	 https://tools.wmflabs.org/coverage/charts/WikibaseMediaInfo.png did drop as well, but to 10% not 0%.
[01:07:38] <Krinkle>	 so presumably genuine
[17:36:27] <Krinkle>	 James_F: Hm.. 'jquery.tipsy' is loaded by mmv?
[17:36:49] <Krinkle>	 (in the initial preloaded moduled)
[17:37:11] <James_F>	 Krinkle: Sadly.
[17:37:52] <Krinkle>	 Oh wow, and not a trivial amount of calls to it either.
[17:37:55] <Krinkle>	 aye, that's too bad.
[18:05:38] <James_F>	 Maybe I can lure Ed into replacing it at some point.
[19:06:27] <James_F>	 duesen: I wonder if you have an opinion on what to do about T231488? The multiple intricate patches being landed in the same week makes it very hard to revert…
[19:06:28] <stashbot>	 T231488: UploadFromChunks.php: Call to undefined method MediaWiki\FileBackend\FSFile\TempFSFileFactory::getTempFSFile() - https://phabricator.wikimedia.org/T231488
[19:06:38] <duesen>	 James_F: making a hot fix for the UploadFromChunks issue
[19:06:47] <James_F>	 duesen: Cool, thanks.
[19:07:00] <James_F>	 (This is why MW needs proper test coverage, *sighs*.)
[19:07:30] <duesen>	 James_F: yes - simetrical has been working hard to improve that. but making things testable means refactoring. which breaks things because there are no tests...
[19:07:59] <duesen>	 Also, testing all the different file backends is hard, because you need to have the actual backends set up...
[19:08:04] <duesen>	 anyway. I'll go and write code.
[19:08:10] <James_F>	 Oh, absolutely. But also MW has integration tests for uploading via API but not via actual UI, because the API was added later after we started to care about testing.
[19:08:18] <James_F>	 Systemic failure over years, sadly.
[19:10:38] <duesen>	 yay :P
[19:10:52] <duesen>	 James_F: one line patch is up, see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/533079
[19:10:55] <duesen>	 that *should* fix it
[19:11:04] <duesen>	 i'll work on a regression test now
[19:11:08] <James_F>	 Thanks.
[19:11:20] <duesen>	 note that i didn't test it :P
[19:11:37] <James_F>	 I have this great system to test it in called production. ;-)
[19:13:00] <duesen>	 James_F: ApiUploadTest has @group Broken
[19:13:02] <duesen>	 so it's skipped
[19:13:11] <duesen>	 it would have actually caught the issue
[19:13:34] <duesen>	 let's see how broken it is...
[19:14:02] * James_F sighs. Even better.
[19:14:29] <duesen>	 passes for me locally
[19:14:42] <duesen>	 i'll make a patch that enables it. let's see what jenkins has to say about it.