[10:17:55] Fatal error: Uncaught Error: Call to a member function isSafeToLoad() on null in /var/www/wiki/mediawiki/core/includes/cache/MessageCache.php on line 168 [10:18:13] Don't you love a fatal error when trying to handle an exception... [11:10:15] Reedy: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/533190 [11:10:50] heh, cheers. A git pull did seemingly fix whatever was causing the original excception [15:30:09] good old globals. they never fail to fail :) [17:04:51] bpirkle, wrt T221174 are you blocked on responses from us? [17:04:51] T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision? - https://phabricator.wikimedia.org/T221174 [17:07:26] subbu: Thanks for asking. I'm moving on that again. However, I am still curious about #11 on my list of questions (reuseExpansions). My plan was to complete my current task and file a follow-up task specifically for reuseExpansions. [17:09:05] tldr on that is: that feature has been disabled in the JS codebase for the past 3 years and restbase has removed the support for that since then .. so, it won't be supported on the php side either right now .. eventually we will get around to it, but we can tackle it at that time. so you can tick that off your list for now. [17:09:35] Great, thank you. [17:09:48] arlo has that task on his todo list but won't be able to it immediately so i thought i would check if you had anything urgent you needed resolved right away. [17:10:23] so, i'll let him know he can doesn't need to reprioritize that response right now. [17:10:39] s/can // [17:14:14] Yep, I'm good on that task now. I may want to discuss how best to pipe linting results from Parsoid back to the REST API for T221175, but I have an ugly workaround that I'll post later today, to at least give us something to critique. [17:14:15] T221175: POST /:domain/v3/transform/wikitext/to/lint/:title?/:revision? - https://phabricator.wikimedia.org/T221175 [17:42:17] duesen: speaking of external store - AbuseFilter also has a taste for storing non-revision blobs there [17:42:40] https://gerrit.wikimedia.org/g/mediawiki/extensions/AbuseFilter/+/6fa8e3fd07e29beec20f83a30236b097192fa1ca/includes/AbuseFilter.php#743 [17:42:58] although it does register them in the text table [17:53:57] Krinkle: yes, I have come across those. They tend to break horribly :P [17:54:28] But storing non-revision blobs is fine in general. That'S why we have the BlobStore interface. I supose we should have a few more implementations of thjat interface [21:11:53] James_F: Hi, I’m not sure if you’re the right person I should poke for this, but can we land https://gerrit.wikimedia.org/r/c/mediawiki/core/+/533254 quickly before #merge-conflicts? [21:12:11] Or can who can review please? [21:36:04] xSavitar: Hmm. I'm not sure that's a good idea; manually checking each one and splitting the tests into unit and integration would be better (but loads more work). [21:36:49] Yeah but I did it in one commit so that if anything goes wrong, we revert at once but I was extremely careful (too many files) :( [21:36:50] Also, "finally"? The MediaWikiIntegrationTestCase class name is new for 1.34, we'll not be retiring MediaWikiTestCase for at least a year. :-) [21:37:35] James_F: In that case, let me put a -2 and reboot things for maybe 1.36 right? [21:38:47] I've C-1'ed; I can be convinced that I'm wrong. :-) [21:40:14] Just abandoned, you made a very good point. Thanks! [21:40:18] James_F: Thanks