[16:24:17] Reedy: It's not going to be 5485a3dda0b188b2ff4d8d90476437215ecb9442 which is the only recent change to auth/ [16:24:41] https://phabricator.wikimedia.org/T232357#5475643 [16:25:58] Yeah, I'd concur on that too [16:26:18] * James_F is working through `git log --oneline --topo-order --no-merges 29c8d84c47aeffe491887155a5b825659709986a..` [16:51:52] Anything exciting? [17:31:01] Reedy: No. You? [17:31:08] Not really, nope [17:31:30] I'm now wondering if some config changed somewhere in the infrastructure. [17:35:42] It's slightly odd that the generic selenium user logs in fine before [19:49:57] Hi, can anyone help me with https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/519671/ [19:50:20] It's my patch which got reviewed by Krinkle with -1 but I don't know what I should do true [19:50:25] in file [19:53:14] Which bit don't you know what to do? [19:53:46] https://www.mediawiki.org/wiki/Deprecation_policy#Deprecation read the part that says "A hard deprecation occurs..." [20:01:07] What I should do in file [20:01:25] includes/pager/TablePager.php [20:01:55] As I understand I have to add wfDeprecated( __METHOD__, '1.xx' ); [20:02:00] But what should be in xx [20:03:15] Should it be like this: [20:03:15] final public function getBody() { [20:03:16] wfDeprecated( __METHOD__, '1.34' ); [20:03:16] $this->getOutput()->addModuleStyles( $this->getModuleStyles() ); [20:03:16] return parent::getBody(); [20:03:16] } [20:04:18] >The version number in the wfDeprecated() call MUST match the one in the @deprecated annotation, even if the hard deprecation occurs in a different release. [20:04:37] So it is 1.24 [20:04:40] Correct? [20:04:47] yes :) [20:04:59] What should I add in RELEASE-NOTES? [20:05:30] If you're only hard deprecating it, you potentially don't need release note [20:05:43] Krinkle told I need it [20:06:00] Read what he wrote :) [20:06:26] To I need release notes when I remove method from file [20:06:42] Indeed, you definitely need it for that [20:07:19] I made new PS can you check it? [20:13:28] Looks good to me [20:13:39] The only problem I see is there are still usages of the method [20:15:08] Where is it used? [20:15:55] Potentially 16 usages in various extensions [20:16:22] AbuseFilter, CentralNotice, CodeReview, LiquidThreads and SecurePoll for WMF deployed extensions [20:17:03] Hmm I see usage and in mediawiki/core https://codesearch.wmflabs.org/search/?q=getBody&i=fosho&files=&repos= [20:17:22] All getBody potentially aren't TablePager and its subclasses [20:18:43] Ok.. Let's do this later.. I doing homework currently. But... I have problem with https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/533544/ too... I don't know what is now wrong [20:23:06] The input when processed isn't ending up as what your test thinks it should be [20:26:28] hmm.. ok [20:27:13] I don't know if your two words are just the wrong way round [20:30:35] Reedy: You mean to: [20:30:36] 'Википедије', [20:30:36] 'Википедија', [20:30:36] 'genitive', [20:30:38] should be [20:30:51] Википедија Википедије genitive [20:30:58] Maybe, yes [20:31:07] I will try :) [20:31:15] You need to look at the parameters in your test function, is expected the right one? [20:31:28] If they're the right way round, then your grammar conversion isn't right [20:32:10] Википедија is nominative Википедије is genitive [20:35:37] So I should reorder it in test file or what? [20:39:39] Well, if your test cases are right... [20:40:13] public function testGrammar( $result, $word, $case ) { [20:40:13] $this->assertEquals( $result, $this->getLang()->convertGrammar( $word, $case ) ); [20:40:13] } [20:40:36] $this->assertEquals( 'Википедије', $this->getLang()->convertGrammar( 'Википедија', 'genitive' ) ); [20:40:54] If that is right, then your convertGrammar implementation is wrong [20:41:09] Википедије is genitive [20:41:18] Википедија is nominative [20:49:13] So I have to reorder test cases [20:49:39] I don't know [20:50:56] Nothing, I will leave it is as is.. I added Nikerabbit as reviewer maybe he will know to help [20:50:58] Looking at your code... [20:51:08] You're using $wgGrammarForms, but never assign anything to it? [20:52:06] How? [20:52:07] global $wgGrammarForms; [20:52:07] if ( isset( $wgGrammarForms['sr-ec'][$case][$word] ) ) { [20:52:07] return $wgGrammarForms['sr-ec'][$case][$word]; [20:52:07] } [20:52:27] That's what I'm just looking at [20:52:33] I dunno where $wgGrammarForms is supposed to be set [20:53:26] seems they get set [20:53:30] (at least in prod) [20:54:23] But I guess this is the problem [20:54:24] > var_dump( $wgGrammarForms['sr-ec']['genitive'], $wgGrammarForms['sr-el']['genitive'] ); [20:54:24] NULL [20:54:24] NULL [20:57:31] https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/blob/master/includes/WikimediaMessagesHooks.php#L1152-L1272 [20:57:38] If they're only defined in WikimediaMessages... [21:02:14] ... [21:05:10] https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/blob/master/includes/WikimediaMessagesHooks.php#L1152-L1272 is correct.. Right? [21:05:24] There is everything [21:05:53] I dunno if it's right, I don't speak/read/write serbian :) [21:06:01] But there's no genitive stuff there.. [21:06:10] Not that core tests should depend on an extension like this [21:08:20] $wgGrammarForms['sr-ec'] = [ [21:08:21] // genitive [21:08:21] 'генитив' => [ [21:08:21] 'Викиречник' => 'Викиречника', [21:08:21] 'Викицитат' => 'Викицитата', [21:08:21] 'Викизворник' => 'Викизворника', [21:08:23] 'Викикњиге' => 'Викикњига', [21:08:27] 'Википедија' => 'Википедије', [21:08:29] 'Википодаци' => 'Википодатака', [21:08:31] 'Викимедијина остава' => 'Викимедијине оставе', [21:08:33] It is all genitive [21:08:35] It is in Cyrillic [21:08:37] In latin: [21:08:43] $wgGrammarForms['sr-el'] = [ [21:08:43] // genitive [21:08:43] 'genitiv' => [ [21:08:45] 'Vikirečnik' => 'Vikirečnika', [21:08:47] 'Vikicitat' => 'Vikicitata', [21:08:49] 'Vikizvornik' => 'Vikizvornika', [21:08:51] 'Vikiknjige' => 'Vikiknjiga', [21:08:53] 'Vikipedija' => 'Vikipedije', [21:08:57] 'Vikipodaci' => 'Vikipodataka', [21:08:59] 'Vikimedijina ostava' => 'Vikimedijine ostave', [21:09:01] ], [21:09:03] It is correct all [21:09:05] Where isn't genitive stuff? [21:09:22] Well, the problem with your code.. [21:09:30] you're using "genitive" [21:09:38] if you look above.. it's "генитив" and "genitiv" [21:09:47] for example [21:10:08] генитив is translation on Serbian Cyrillic for genitive [21:10:11] sure [21:10:15] genitiv is translation on Serbian Latin for genitive [21:10:22] but PHP isn't going to convert array keys randomly from english to other languages [21:10:29] And your code definitely doesn't do it either [21:14:43] * Zoranzoki21 have headache [21:16:18] > var_dump( count( $wgGrammarForms['sr-ec']['genitive'] ), count( $wgGrammarForms['sr-ec']['genitiv'] ), count( $wgGrammarForms['sr-ec']['генитив'] ) ); [21:16:18] int(0) [21:16:18] int(0) [21:16:18] int(7) [21:17:42] wait a bit... [21:20:29] I am confused [21:20:38] I checking identical files [21:22:58] Maybe I should add forms in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/533544/5/resources/src/mediawiki.language/languages/sr-ec.js [21:23:09] Like in other files [21:23:32] switch ( form ) { [21:23:32] case 'instrumental': // instrumental [21:23:32] word = 's ' + word; [21:23:32] break; [21:23:32] case 'lokativ': // locative [21:23:33] word = 'o ' + word; [21:23:35] break; [21:23:37] } [21:23:39] return word; [21:23:41] }; [21:23:43] Example of Bosnian file [21:23:57] *some content of Bosnian file (resources/src/mediawiki.language/languages/bs.js) [21:28:10] Reedy: I need your help now.. I found something what maybe can be problem [21:28:20] 'Викиверзитету', [21:28:20] 'Викиверзитет', [21:28:20] 'locative', [21:28:48] It is Wikiversity.. It is not included here https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/blob/master/includes/WikimediaMessagesHooks.php#L1152-L1272 [21:28:51] Should I make patch? [21:29:10] If it's correct, and should be there, then sure [21:29:30] It is in testing case file but not in WikimediaMessagesHooks.php [21:30:30] Ok, I will make patch. You need to merge it [21:31:55] git clone is a bit slow today... [21:32:08] Ok, done.. Patch coming for 2 minutes [21:37:31] Reedy: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaMessages/+/535295 [21:38:28] Optionally merge and https://gerrit.wikimedia.org/r/501933 I want to have clear workflow on Gerrit