[13:16:43] <duesen>	 Krinkle: do you have time for a one line review? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/539514
[14:19:31] <Krinkle>	 (Done)
[14:45:26] <duesen>	 Krinkle: thanks!
[17:01:55] <duesen>	 Pchelolo: is there anything missing for a +2 on the getContentBlobsForBatch patch? I don't think anyone will merge it if you don't ;)
[17:02:16] <Pchelolo>	 duesen: lemme go over it again and I'll +2 it. 
[17:02:36] <Pchelolo>	 did you get any info from Nikerabbit regarding how it performs?
[17:09:52] <duesen>	 Pchelolo: yes, it's perfect :) https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/539380#message-48d58e80daff11b5ce5dd7483bc237556ebdb39e
[17:10:14] <duesen>	 With the patch, the export is as fast as with the old schema.
[17:10:33] <Pchelolo>	 oh, haha.. I haven't looked through all the comments.
[17:10:40] <duesen>	 can't blame you
[17:10:48] <Pchelolo>	 I'm wondering if we would need to use it for MessageWebExporter too... 
[17:11:02] <Pchelolo>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/537736
[17:11:08] <duesen>	 I'm thinking about doing the same for exports, but then we do have to expose all the ugly details. 
[17:12:13] <Pchelolo>	 s/MessageWebExporter/MessageWebImporter
[17:14:22] <duesen>	 Pchelolo: yes, looks like it. all that is used is the text, so no need for all the fancy stuff
[17:17:03] <Pchelolo>	 I'll update the patch
[17:17:48] <duesen>	 clarakosi: by the way, since I forgot to restore my +2 earlier: you can do that yourself. if merge failed due to flakyness, just remove the votes and give yourself CR+2. maybe say something like "restoring +2 by xyz after failure due to flaxy test". Or, what I usualyl put, "kicking jenkins" or "third time is a charm"...