[03:04:30] TIL section edit summary can have multiple sections ? [03:04:31] https://www.mediawiki.org/w/index.php?title=ResourceLoader/Core_modules&type=revision&diff=3399942&oldid=3388491&diffmode=source [03:33:57] Krinkle: Just manually (or gadget) created, I think. [03:43:47] James_F: Yeah, but core renders it!, that's pretty cool. [03:43:51] or maybe accidental :P [03:44:01] Probably accidental. [03:44:16] An unthinking /g on the regex. [13:16:24] Krinkle, James_F: It was clearly intentional as of r2985. It was originally added two weeks earlier in r2825 by the same author, in a way that could have been accidental or intentional. [13:50:08] anomie: Huh, interesting. [17:43:04] James_F: hm.. this graph ain't going in the right direction - https://grafana.wikimedia.org/d/000000037/mw-js-deprecate?refresh=1m&panelId=7&fullscreen&orgId=1&from=now-1y&to=now [17:43:58] I wonder how much of it is false-positives e.g. some tool triggering like (for key in window: window[key]) or something likek that [17:44:35] some of the newer unrelated ones are too similar in traffic to some other ones that suggests it's not explicit [17:45:03] A lot of the growth seems to be wgContentLanguage. Did Commons or Wikidata have a site script or default gadget change to use that? [17:45:54] I still thing fuzzing the data (returning null every 1% of requests) would be the fastest thing to reduce their use. ;-) But very aggressive, sadly. [17:46:22] we can prolly remove $j soon. [17:46:28] Could do one more run with tourbot to see where we're at [17:46:35] Right. [17:46:37] although also very marginal gain of course [17:46:42] Can tourbot fix wgTitle etc. uses? [17:47:05] For some cases yes, but not universally [17:47:46] Overall though, the numbers have been relatively low for the past year. This is aggregated for 24h [17:48:00] so I'm not really planning to do much more of non-mw.config global use [17:48:10] probably just gonna start disabling it by the wiki. [17:48:34] more worried about the next phase, which is removing some of the actual keys itself like T219340 which will be harder [17:48:34] T219340: Remove wgMonthNames and wgMonthNamesShort from mw.config - https://phabricator.wikimedia.org/T219340 [17:48:35] Right. That makes sense. [17:48:43] Yeah. [17:48:58] but I'm hopeful we can do it without too much disturbance :) [17:49:32] Did we disable it in beta and group0 already? [17:55:15] Umm. [17:55:18] * James_F goes hunting. [17:55:45] wgLegacyJavaScriptGlobals is false in group0, yes. [17:56:01] Not Beta Cluster though. [18:04:49] James_F: btw, we can start some 1.35 removals - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/541409/ [18:08:24] We can. I was mostly looking for 1.34 removals that need doing and backporting, but sure. :-) [18:08:37] right yeah, those too [18:09:49] James_F: hm.. so yeah, maybe beta cluster this week, then a few handpicked wikis opting in next week? (I can nominate commons and nl wiki) [18:10:24] could ask for more via tech news [18:12:13] Commons and nlwiki along with e.g. meta and wikidata would catch 90% of the issues, I imagine. [18:34:07] Anyone know offhand if there's a case where MW/CA sets passwords to ''? [18:35:02] (in the globaluser table) [18:38:31] MaxSem: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/541589 and friends for 1.34 (so that we don't have to deprecate)? [22:27:33] Krinkle: There's also https://gerrit.wikimedia.org/r/c/mediawiki/core/+/504076 BTW.