[16:22:25] <anomie>	 Krinkle: I don't see any problem with changing it. You'd have to ask a manager of some sort if you're asking if CPT should "own" the installer though.
[22:01:31] <Krinkle>	 anomie: thanks, yeah, that's a TODO I have for later.
[22:36:09] <paladox>	 Reedy hi, wondering if you could review https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/554176/ please? :)
[22:47:27] <Reedy>	 Wasn't that fixed already?
[22:47:29] <Reedy>	 Feels dejavu
[22:49:00] <Reedy>	 https://phabricator.wikimedia.org/T227461
[22:55:55] <Reedy>	 paladox: ^
[22:56:01] <Reedy>	 You should at least reference the task
[22:56:09] <paladox>	 oh
[22:56:31] <paladox>	 done
[22:57:18] <Reedy>	 Based on the comments on https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/527212
[22:57:25] <Reedy>	 We should probably be backporting these a bit further
[22:57:58] <paladox>	 yeh
[23:04:08] <paladox>	 Reedy i presume this https://gerrit.wikimedia.org/r/#/c/mediawiki/services/jobrunner/+/554123/ will also fix Deprecated: Function Redis::delete() is deprecated in /srv/jobrunner/src/RedisJobService.php on line 309
[23:04:45] <paladox>	 actually
[23:04:57] <paladox>	 nvm
[23:32:54] <paladox>	 hmm
[23:32:57] <paladox>	 i'm still getting:
[23:32:58] <paladox>	 Dec 02 23:32:39 mw3.miraheze.org jobchron[7748]: Deprecated: Function Redis::delete() is deprecated in /srv/jobrunner/src/RedisJobService.php on line 309
[23:33:25] <paladox>	 even though i applied https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/554180/
[23:36:00] <Reedy>	 paladox: Why would a patch to MW core fix a function call in the jobrunner code?
[23:36:05] <Reedy>	 Your linked patch above would seem more likely
[23:36:51] <Reedy>	 https://github.com/wikimedia/mediawiki-services-jobrunner/blob/master/src/RedisJobService.php#L309
[23:36:55] <paladox>	 ok, the fix i said nvm fixed it.
[23:37:00] <Reedy>	 The erroring line is a generic call
[23:37:01] <paladox>	 *to
[23:37:18] <paladox>	 Restored https://gerrit.wikimedia.org/r/#/c/mediawiki/services/jobrunner/+/554123/ now :)