[04:23:17] Anyone around to help me word a phabricator ticket? [18:17:17] Reedy for phab, do you suggest keepping it as is? Or just adding iLen rather than removing iSize? [18:17:20] *phan [18:17:34] Can we get/generate an updated version? [18:18:34] Reedy how would i do that? I've never touched phan config before. [18:18:40] I'm not sure either :) [18:18:47] Hence not wanting to just start changing it.. [18:18:55] But... // @phan-stub-for-extension redis@3.1.1 [18:19:06] heh [18:19:12] ok [18:19:14] Redis 5.0.3 is in debian stable [18:19:25] ah, i see. [18:19:32] So it would sound like we've got an old version of the stubs anyway [18:19:32] * paladox just reverts that [18:19:39] ah [18:19:45] Yeah, if it's not needed to make the patch pass, just revert it [18:19:58] Could be worth filing a task and tagging it phan to look at updating the stubs [18:20:19] php-redis is 4.2.0 too https://packages.debian.org/buster/php-redis [18:20:29] So I don't know exactly what version of what the 3.1.1 is etc [18:21:49] Reedy done https://phabricator.wikimedia.org/T239736 [18:21:51] "See for how to generate internal stubs for phan." [18:21:53] (and updated patch)