[16:30:07] does anyone know why setAuthenticationSessionData and $this->msg. conflict? [16:30:23] If they are both present, no error messages appear (as intended). When setAuthenticationSessionData is commented out, magically they reappear. [16:30:38] * TheSandDoctor points to https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/539649/14/includes/specialpage/LoginSignupSpecialPage.php for "real world" example [16:31:32] * TheSandDoctor has tried asking wikitech-l, but his emails are a spam blackhole now apparently [16:35:33] Why are validating a comment as an email? [16:36:55] https://phabricator.wikimedia.org/T233068 [16:36:59] @Reedy [16:37:26] Might want to leave a context comment... Cause that's not obvious for sure :) [16:37:37] will add that [16:37:43] but wondering why those two conflict [16:37:49] because it doesnt seem obvious to me [16:38:15] @Urbanecm has confirmed it isnt just me that it is happening to [16:38:19] @Reedy [16:38:26] I'd be surprised if it was a "local" issue [16:38:36] Also, you don't need to do.. [16:38:36] if ( !AuthManager::singleton()->getAuthenticationSessionData( 'reason-retry', false ) ) { [16:38:37] and [16:38:45] } elseif ( AuthManager::singleton() [16:38:45] ->getAuthenticationSessionData( 'reason-retry', false ) ) { [16:38:53] It's going to be true or false [16:42:37] updated in my local code [16:42:56] * TheSandDoctor is still surprised setAuthenticationSessionData conflicts [16:43:37] You'd probably need to ask Brad or Gergo, but I imagine both are probably mostly out for the holidays now [16:44:08] @Reedy who is Brad? [16:44:13] anomie [16:44:19] thanks [16:50:18] * TheSandDoctor has emailed both asking [16:50:21] thanks again @Reedy [16:51:07] I would've suggested just CC'ing them on the task to ask the question... [16:52:01] yeah...that would've been a better idea [16:55:47] anyhow, [16:55:52] * TheSandDoctor posted there too, CCing [16:56:07] I hope that you have wonderful holidays @Reedy! :) [16:56:10] Thanks again