[18:02:20] if I wanted to make changes to the diff engine used on WMF wikis, where should I go? Special:Version doesn't list Extension:Wikidiff2 (which is what I thought we used), rather https://github.com/wmde/Diff. Then there's includes/diff/DifferenceEngine.php in MW core itself. Which one? [18:02:33] also my Docker installation appears to use https://github.com/sebastianbergmann/diff [18:05:16] musikanimal: We run the C code in prod. [18:05:26] As patched by WMDE semi-recently, yes. [18:07:34] so https://github.com/wmde/Diff makes use of the wikidiff2 C++ library? I didn't see any references to it [18:08:12] Oh, no, that libary's for Wikibase diffs [18:10:39] https://www.mediawiki.org/wiki/Extension:Wikidiff2 is what we use, right? why isn't it listed at https://en.wikipedia.org/wiki/Special:Version ? [18:11:23] That's a PHP extension, not a MediaWiki extensions. [18:11:54] If you do `php -m` in production you'll see `wikidiff2` as one of the PHP extensions (modules). [18:12:12] That page really shouldn't be in the Extension: namespace, it's rather confusing. [18:12:24] haha yes it is! [18:13:41] alright then, so for WMF wikis, the wikidiff2 PHP extension and the core stuff in includes/diff are what I need to focus on [18:14:18] Yes. wikidiff2 is built from https://gerrit.wikimedia.org/g/mediawiki/php/wikidiff2/+/master [18:15:17] (Moved.) [18:15:17] awesome. Thank you!