[17:21:53] <addshore>	 duesen: got a clever way to go from a text id to the page using the new schemas?
[17:23:21] <duesen>	 addshore: in the new schema, there will soon be no textid
[17:23:48] <duesen>	 why do you need this? it seems backwards
[17:25:41] <addshore>	 so, rather, i mean I cant exactly do select * from content where content_address = 'tt:123' and figure out what page is causing issues when all i have is the text id
[17:26:33] <addshore>	 context, investigating a cache key, WANCache✌️global:SqlBlobStore-blob:enwiki:tt%3A946897750 , maybe i should just look it up in the cache and go from there
[17:29:10] <duesen>	 you can do where content_address = 'tt:123' and then work your way to the page via slot_content_id and slot_revision_id, then rev_page
[17:29:39] <duesen>	 For debugging, it should work fine. But there's no index on content_address, and none on slot_content_id either, iirc
[17:52:18] <addshore>	 duesen: takes 12 mins in production, but I guess that is okay :P
[17:55:35] <duesen>	 not great, but ok
[21:24:26] <James_F>	 anomie: I note a few repos are now upset about their API parameters, e.g. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/570119 -> "Validation failed: Value for PARAM_DEFAULT does not validate (code badvalue)"
[21:24:37] <James_F>	 anomie: Is there an easy way to sweep for the breakages?
[21:26:48] <anomie>	 James_F: Not that I know of, other than triggering CI to run for every repo (e.g. with a dummy patch) to see what fails.
[21:29:37] <James_F>	 Joy. OK, well, time to go fix some things.
[21:29:59] <anomie>	 James_F: For that one, BTW, it looks like it's actually coming from FlaggedRevs somehow.
[21:35:14] <James_F>	 Odd. Dependency load is WikibaseQualityConstraints => Wikibase => { a bunch of things but not FR or anything that leads to it, AFAICS }
[21:36:32] <anomie>	 I see it being loaded in https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php72-docker/11053/consoleText. The real question is where does the config for it come from in CI?
[21:37:17] <James_F>	 The only thing that pulls in FR is VE, and VE isn't pulled in by any of "'ArticlePlaceholder', 'CirrusSearch', 'cldr', 'Elastica', 'GeoData', 'Echo', 'PropertySuggester', 'WikibaseQualityConstraints', 'WikimediaBadges', 'WikibaseMediaInfo', 'WikibaseLexeme', 'skins/MinervaNeue', 'MobileFrontend'"
[21:37:37] <James_F>	 anomie: https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/master/zuul/parameter_functions.py#135
[21:38:29] <James_F>	 Oh, right. CirrusSearch => Cite => VisualEditor => FlaggedRevs.
[21:38:31] * James_F sighs.
[21:38:37] <James_F>	 Too many damn dependencies.
[21:40:44] <James_F>	 Is the example API query wrong?
[21:41:23] <James_F>	 In getExamplesMessages(), it shows `action=review&revid=12345&token=123AB&flag_accuracy=1&comment=Ok` but I don't see accuracy read in the execute()?
[21:41:56] <James_F>	 Oh, those are config, because of course they are.
[21:42:40] <Reedy>	 			/** @todo Once support for MediaWiki < 1.25 is dropped,
[21:42:40] <Reedy>	 			 * just use ApiBase::PARAM_HELP_MSG directly
[21:42:56] <James_F>	 Also that. We should do a general clean-up of that stuff.
[21:44:17] <James_F>	 https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/570146
[21:46:10] <Reedy>	 There's also getDescriptionMessage that can go away in numerous files...
[21:46:22] <Reedy>	 well, two
[21:47:40] <James_F>	 https://codesearch.wmflabs.org/deployed/?q=(getDescriptionMessage%7CgetExamples%7CgetParamDescription)%5C(&i=nope&files=&repos=
[21:49:30] <Reedy>	 Flow and CirrusSearch too then
[21:50:09] <anomie>	 James_F: So as far as I can tell, the only way to get that failure is to have $wgFlaggedRevsTags[???]['levels'] <= 0 for some "???" (and unset would be 0, of course). I haven't been able to find where $wgFlaggedRevsTags might get set in the first place for WikibaseQualityConstraints CI though.
[21:51:14] <James_F>	 anomie: Default out of extension.json is 3 for each of accuracy, depth, and style.
[21:52:14] <James_F>	 We hard-over-ride that for production to 'accuracy' => [ 'levels' => 2, … ] because everything about our code is terrible, it appears.
[21:52:35] <James_F>	 But I don't see it being reset by anything in CI intentionally.
[21:53:33] <MatmaRex>	 the default is a number but the list of allowed values contains strings. does that matter? anomie
[21:53:35] <MatmaRex>	 James_F:
[21:53:37] <MatmaRex>	 ^
[21:54:16] <MatmaRex>	 (i just had a FlaggedRevs failure on my unrelated patch so i came to see if anyone else is already solving the problem :) )
[21:54:32] <James_F>	 Hey MatmaRex, sorry for the disruption.
[21:54:44] <James_F>	 I'm slightly minded to just drop FR from VE's test matrix for now.
[21:54:55] <James_F>	 That'd avoid this breaking things for anyone not working on FR itself.
[21:55:12] <anomie>	 ... d'oh. You're right, MatmaRex
[21:55:42] <MatmaRex>	 James_F: eh, don't, i like it there
[21:56:04] <James_F>	 MatmaRex: Fine. But this is blocking merges in Wikibase, VE, Cirrus, Cite, …
[21:56:30] <MatmaRex>	 well we can fix it. should i make the patch?
[21:56:50] <James_F>	 Please.
[21:57:35] <James_F>	 strval -> intval?
[21:58:02] <anomie>	 https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/570150 should do it
[21:58:53] <James_F>	 Ah, they're always passed as strings instead? OK.
[23:29:14] <James_F>	 anomie: Hmm, now WikibaseLexeme paches are failing because they're testing for 'apierror-missingparam' and instead getting 'paramvalidator-missingparam'. Joy. Fix incoming.