[21:10:26] James_F: I'm looking at https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/59820/consoleFull, at 16:19:51 shouldn't it be excluding Standalone? [21:24:08] anomie: No; the idea is @Standalone @Database will always run as @Database. [21:24:31] anomie: Rather than set up two whole DB stacks for the very rare @Database tests we'd want to move out. [21:24:44] But if you think that's likely to be common, I can change quibble and re-build CI for that? [21:25:12] James_F: I was just observing that the tests get run twice, once for the --group Database run and once for the --group Standalone run. [21:25:31] Oh, huh. [21:26:26] Yeah. [21:28:26] I think it's fine for now, but irritating. [21:29:48] ` --group ... Only runs tests from the specified group(s)` [21:36:14] FYI, there are 67 Scribunto tests that are in both Database and Standalone, and 67 in Database but not Standalone. [21:36:44] Is that one test run that is split by engine? Or just happenstance? [21:38:18] It looks like phpunit excludes before it includes. [21:38:26] https://github.com/sebastianbergmann/phpunit/blob/HEAD/src/TextUI/TestRunner.php#L1110 [21:39:39] So @Foo @Bar --exclude-groups Foo --groups Bar will run nothing. [21:39:49] It's 67 tests that are run for both engines, yeah. [21:40:10] So the copies for LuaSandbox are non-Standalone, and the copies for LuaStandalone are Standalone. [21:40:21] * James_F nods. [21:51:36] anomie: Fixed in https://gerrit.wikimedia.org/r/c/integration/quibble/+/587872 – thanks for the spot. Will probably roll that out next week, along with another quibble change.