[20:16:31] Anyone tried to use namespaceDupes.php to fix *links tables recently? [23:01:47] can someone help clarify best practice / mandatory practice / recommendation on https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/593576/3/tests/phpunit/Parsoid/Config/SiteConfigTest.php#195 ... so I know what program to get behind? [23:06:33] I think we usually use dataproviders... [23:06:41] Unless you have 10-100K rows [23:06:44] ala https://github.com/wikimedia/password-blacklist/commit/4917f1e4301e1c98e53e2ea359f70ef9e23826df#diff-51f25c97b40887387d9ebd52fa1342db [23:08:23] is there a "prohibition" (that is a strong word) around using loops like I used it there or other benefits to using data providers instead of loops? [ sorry i am being lazy aksing qns. instead of maybe rtfm ] [23:09:00] AFAIK no [23:09:10] A quick look... there's 100+ foreach's in MW cores phpunit test dir [23:09:23] ok. [23:09:30] thanks. [23:09:40] There's definitely tests doing basically what you're doing [23:11:32] I guess it's a preference of dataproviders, but it's definitely not a hard and fast [23:13:37] got it. i suspect i'll end up getting inducted into that mode. :)