[17:32:12] <paladox>	 Reedy wondering if you could review https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralAuth/+/593766/ please? :)
[17:35:48] <Reedy>	 paladox: How exactly are those functions called to pass in the false?
[17:35:58] <Reedy>	 As it's a no-op in the CA repo as is
[17:36:32] <paladox>	 From what i see, it does https://github.com/wikimedia/mediawiki-extensions-CentralAuth/blob/f29b2e03bbc33981f71cde0b2f4d6603c068765c/includes/specials/SpecialGlobalRenameQueue.php#L535 which then calls https://github.com/wikimedia/mediawiki-extensions-CentralAuth/blob/f29b2e03bbc33981f71cde0b2f4d6603c068765c/includes/specials/SpecialGlobalRenameQueue.php#L548
[17:36:48] <paladox>	 We will be setting all that in a custom script (we just need the ability to disable the logger)
[17:37:42] <Reedy>	 That's what I was meaning... The CA code isn't calling that with any other value
[17:38:00] <Reedy>	 Though, I have to wonder if a config variable makes more sense
[17:38:07] <Reedy>	 Do you really need to enable/disable it on a user by user basis?
[17:38:20] <paladox>	 apparently so
[17:38:41] <paladox>	 Since usernames are PII, so we will have to rename users to randomly generated usernames.
[17:39:14] <Reedy>	 Sure
[17:39:20] <Reedy>	 But do you only need this feature for "some" users?
[17:39:34] <paladox>	 oh, yeh
[17:39:45] <Reedy>	 The other option is to have some sort of private log hidden behind a userright etc
[17:39:48] <paladox>	 ones that request info being delete
[17:43:39] <paladox>	 oh, actually. I think we could just hack up a class that extends GlobalRenameUser to override the rename method and remove log()
[17:44:19] <paladox>	 one thing i wonder is where does it log locally?
[17:50:05] <paladox>	 oh
[17:50:08] <paladox>	 found it, RenameuserSQL
[18:01:31] <paladox>	 appears that extending the class won't work as i thought it would (at least a nightmare).