[10:25:37] <tgr>	 Reedy: have you figured out the logo thing?
[12:11:49] <Reedy>	 tgr: Nope
[12:12:13] <tgr>	 I'll file a bug then
[12:12:32] <tgr>	 it's caused by the Vector refresh, probably
[12:12:45] <Reedy>	 Thanks
[12:12:55] <Reedy>	 I kinda presumed that.. But wasn't sure if it was intentional in some weird way
[12:13:37] <tgr>	 it uses a different logo which does not have text in it
[12:14:02] <tgr>	 that logo does not exist by default, apparently
[12:47:08] <kostajh>	 tgr: I was wondering about that too
[12:47:26] <kostajh>	 did you file something?
[12:50:06] <tgr>	 I'm in the middle of it
[12:50:55] <tgr>	 still not sure if this is bug or intentonal
[12:58:46] <tgr>	 looks like the default logo is missing even when desktop refresh is disabled? although it doesn't help that vagrant apparently sets the logo at three different places at least
[12:59:04] <tgr>	 does anyone have a vanilla setup to quickly verfiy that?
[12:59:31] <Reedy>	 My dev wiki should work...
[12:59:32] <tgr>	 for anons, $wgVectorDefaultSkinVersion will disable desktop refresh
[12:59:46] <tgr>	 $wgVectorDefaultSkinVersion = 1 I mean
[13:00:29] <Reedy>	 "Use legacy vector" logged in makes the logo reappear, yeah
[13:01:08] <Reedy>	 And wgLogo isn't set in LS on that wiki
[13:04:04] <tgr>	 is that a recent checkout?
[13:05:21] <tgr>	 seems like if the logo is not set in localsettings, it would not be set at all
[13:06:03] <Reedy>	 Yup
[13:06:47] <Reedy>	 /var/www/wiki/mediawiki/core/maintenance/eval.php(78) : eval()'d code:1:
[13:06:47] <Reedy>	 string(28) "/w/resources/assets/wiki.png"
[13:07:18] <Reedy>	 in Setup.php
[13:07:19] <Reedy>	 if ( $wgLogo === false ) {
[13:07:19] <Reedy>	 	$wgLogo = "$wgResourceBasePath/resources/assets/wiki.png";
[13:07:19] <Reedy>	 }
[13:21:03] <tgr>	 filed T251886
[13:21:04] <stashbot>	 T251886: Logo is missing in Vector using default settings - https://phabricator.wikimedia.org/T251886
[13:21:44] <tgr>	 not sure why it's missing for me even with skin version 1, but if that works for others, I won't spend time on figuring it out
[14:58:49] <James_F>	 Reedy: Do you not have wgLogos set?
[15:02:25] <Reedy>	 Why would I on my dev wiki?
[16:02:45] <James_F>	 Reedy: Oh, yeah, the fix for the installer hasn't landed yet.
[16:02:57] <Reedy>	 Well, that and my dev wiki was installed..
[16:03:00] * Reedy looks
[16:03:20] <Reedy>	 January 2011
[18:14:08] <ori>	 to request code review, are you supposed to add someone as 'assignee' or 'reviewer'?
[18:14:52] <DannyS712>	 generally reviewer
[18:15:29] <ori>	 thanks