[18:11:39] Hey folks. Who works on mobile web these days? [18:12:06] I'm trying to help research folks do some analytics with MW's redirect from the desktop to mobile version. [18:13:02] Persons or team? [18:13:14] Essentially, there's a URL param that gets stripped when someone gets redirected to the mobile version of the site and we'd like it to be preserved so that it shows up in the pageview analytics. [18:13:22] Reedy, yes. :) [18:13:35] Person or team would be helpful. [18:15:30] A lot is jon robson still I think [18:16:38] >Web (Desktop and Mobile Web) [18:17:15] Looks like Olga Vasileva might be the best person to poke to make progress as the product manager [18:17:48] Have you filed a task? :P [18:29:51] Woops. Connection issues. Thanks Reedy. [18:30:13] Haven't filed a task yet. Actually, I'm just helping a researcher know who to talk to. I'll ask him to file a task :) [20:56:50] Are there any up to date docs for adding new hooks etc? [20:59:35] they are still being developed - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/593982/ [21:00:14] `How to define a new hook`: [21:00:14] Create a hook interface, typically in a subnamespace called `Hook` relative to the caller namespace. For example, if the caller is in a namespace called `MediaWiki\Foo`, the hook interface might be placed in `MediaWiki\Foo\Hook`. [21:00:14] Add an implementation to the relevant HookRunner class. [21:37:46] Anyone know much about ApiResult::NO_VALIDATE ? [21:38:17] >If you think you need to use this, you're probably wrong. [21:38:21] i know [21:38:23] but i want to use it [21:38:25] :P [21:39:02] It reduces the execution of my api call lcoally from 25-30s to 4.7s [21:39:07] god knows what it would do in production [21:44:57] I do like some of the comments that surround its usage [21:44:57] https://gerrit.wikimedia.org/g/mediawiki/core/+/9757ee3405022858c45d784e8b042b31b3973359/includes/api/ApiFormatFeedWrapper.php#42 [21:52:15] Reedy: also [21:52:15] * addshore https://performance.wikimedia.org/xhgui/run/view?id=5eb482d69552621159cbd020 [21:52:26] want to tell me how Wikibase\Lib\Serialization\SerializationModifier::getPathParts uses 175 mb memory? :P [21:52:40] Wikibase is bloated? [21:53:27] heh, I mean the second one is using 127mb which is ApiResult::stripMetadataNonRecursive from core :P [21:54:11] which again, im not entirely convinced is needed [21:54:54] NO_VALIDATE seems a lot like a "I really know what I'm doing" type of flag [21:55:41] next to the wikibase integration with mediawiki api results I see htis [21:55:46] addMetaData true // The mediawiki api should always be given metadata [21:55:51] but, really, does it need it? [21:56:25] i can only assume that might be for formats other than json [21:56:47] Wouldn't be a shock [21:56:55] XML for example results in a lot of hacks