[13:54:38] Hmm. Other than Daniel, who can help me get my head around content handler stuff? I'm trying to sub-class JsonContent, but on save items are being written as JSON content model, not my custom one. [14:01:09] I'm guessing there's something you haven't overridden [14:02:39] I was guessing that too. [14:03:24] Is what you're wanting to save not JSON at all? Or JSON to some sort of specific schema? [14:03:34] The latter. [14:04:10] I think CollaborationKit did something like that [14:04:36] * James_F goes to stalk their code. [14:04:37] Thanks. [14:05:10] There's 16 things that subclass JsonContent... Presumably one or two of them must be doing something similar/useful [14:07:04] I'd have hoped so. :-) [14:07:28] The secure poll won't help though :P [14:08:22] Ha. [21:32:08] hi Core folks! [21:32:25] Anyone know what it would take to get donatewiki available via restbase? [21:32:37] The relevant URLs are currently returning errors [21:33:02] e.g. https://donate.wikimedia.org/api/rest_v1/page/mobile-html/Ways_to_Give gives a json-formatted 'not found' [21:33:18] and https://donate.wikimedia.org/api/rest_v1/ gives 'site info fetch failed' [21:36:31] It's already listed in https://phabricator.wikimedia.org/diffusion/GRBD/browse/master/scap/vars.yaml;c86e94f937cc26e40dd522949b69bf2c6d771318$59 [21:39:17] interesting Reedy - is that all that should be needed for it? Any idea what would be causing those errors then? [21:40:40] ejegg: Except, it's not, is it? :P [21:40:48] If you looked at my link, we both missed it [21:40:55] that's donate.wikimedia.org, not donate.wikipedia.org [21:41:17] Unhelpfully... The site responds on both... [21:41:38] but the wikimedia.org one is canonical? [21:41:58] yeah, the /rest_v1/ links I was looking at are wikiMedia.org and giving errors [21:43:16] ideally we would be able to serve the content on both, since we need to send folks to a thank you page on a wikiPedia.org subdomain to set banner-hide cookies [21:43:25] it's going ot be something simple and/or edge-case-y [21:43:46] but all the wikiPedia.org domains open in-app on cell phones with apps installed [21:44:39] so right now we can choose between not setting hide cookies, or showing app users an error page instead of a thank you page :( [21:44:50] ejegg: yeah we're going to have to fix that with app developers (I guess you already know this...) [21:45:30] I kinda would love to go back to the cookie-checking meta.wikimedia.org banner loader solution.... [21:45:51] hmmmmmmm [21:45:52] I wonder if the extra work we need for that isn't already gonna be done by Traffice for other similar issues caused by lack of 3rd party cookies [21:45:54] If https://www.mediawiki.org/wiki/Topic:Ty9zrnylsr4bpdw1 is right... [21:45:59] that is kinda looking more reasonable [21:45:59] * Reedy looks at eval.php [21:51:37] [url] => http://restbase.discovery.wmnet:7231 [21:51:37] [domain] => https://donate.wikimedia.org [21:51:37] [forwardCookies] => [21:51:37] [parsoidCompat] => [21:51:50] does that look right? [21:52:00] as the value of $wgVirtualRestConfig['modules']['restbase'] [21:52:02] for donatewiki? [21:52:20] it looks sensible [21:52:47] The only difference to enwiki is enwiki has electron [21:57:11] I bet if we ask Pchelolo the answer will be simple [21:57:41] reading [21:58:36] ejegg: please file a ticket like "add RESTBase to donate wiki", tag it with plarform engineering and assign to me [21:58:44] sure thing Pchelolo [21:58:45] need to do a little config change [21:58:56] will deal with it tomorrow, and deploy on monday [21:58:57] something else than vars.yaml? [21:59:22] Reedy: might need to see if eventbus/change-prop is enabled there too [21:59:40] EventBus extension is [21:59:57] ok. yeah, then it's just vars.yaml [22:00:07] it's already in there... [22:00:13] https://phabricator.wikimedia.org/diffusion/GRBD/browse/master/scap/vars.yaml;c86e94f937cc26e40dd522949b69bf2c6d771318$59 [22:00:20] I dunno if donate.wikipedia.org needs adding too [22:00:28] created Pchelolo: https://phabricator.wikimedia.org/T259309 [22:02:07] ok, I'll have a look, thank you [22:02:24] Thank YOU! [22:10:40] Pchelolo: thanks!! :)