[16:21:03] <Reedy>	 duesen_: Are you able to help out with the test failures relating to ActorMigration? :)
[16:29:35] <duesen_>	 Reedy: which test failures?
[16:30:03] <Reedy>	 Have a look at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/629732 and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/629733/1
[16:30:06] <Reedy>	 PHPCS fails are obviously simple
[16:30:15] <Reedy>	 I think most of the rest is a missing (int)..
[16:30:19] <Reedy>	 So PS2 might fix most of them
[16:30:43] <Reedy>	 cause the tests are failing with an '2' !== 2
[16:30:46] <Reedy>	 or similar errors
[16:31:08] <Reedy>	 yeah, it's looking good
[16:32:54] <Reedy>	 the current error zuul is showing for one test seems to be from a git/gerrit hiccup
[16:35:01] <Reedy>	 Yup
[16:35:06] * Reedy +2's that patch, and rebases the one ontop
[16:41:31] <Reedy>	 Hmm. Not quite
[16:41:36] <Reedy>	 Seems to have caused an AbuseFilter failure
[16:41:51] <Reedy>	 17:40:04 1) AbuseFilterSaveTest::testSaveFilter with data set "Success for only rules and description" (array(array('/* My rules */', 'Some new filter', false, true), array(false, true)))
[16:41:51] <Reedy>	 17:40:04 Trying to get property 'actor_id' of non-object
[16:43:45] <Reedy>	 https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/36794/console
[16:44:00] <Reedy>	 um, not that one
[16:44:07] <Reedy>	 https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/36795/console
[16:44:54] <Reedy>	 17:40:04 /workspace/src/includes/ActorMigration.php:260
[16:44:54] <Reedy>	 17:40:04 /workspace/src/includes/ActorMigration.php:288
[16:44:56] <Reedy>	 line 260...
[16:45:00] <Reedy>	 return (int)$row->actor_id;
[16:45:12] <Reedy>	 but it has the $row === false { return; } above
[16:51:44] <Reedy>	 That's REL1_35 happy
[17:21:23] <Reedy>	 How does this make any sense
[17:24:24] <Reedy>	 ok, it's a test issue
[17:25:53] <Reedy>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/629757
[17:25:56] <Reedy>	 stupid mock objects