[12:28:33] duesen: are you around, if so, could we chat about T262443? [12:28:33] T262443: Do not hit actual urls during phpunit tests - https://phabricator.wikimedia.org/T262443 [15:46:38] kostajh: he! I just got back in. My life is a bit crazy right now... [15:47:25] I have ten minutes now if it's urgent. otherwise, let's chat some time tomorrow, if that's ok for you. [15:49:00] One idea I have about this is that the error message could contain a hint about how to fix a test that is triggering it. [15:51:31] duesen: I think the patch needs to be reverted :/ [15:52:16] I left some comments here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/632820 [15:58:19] kostajh: I'd like to better understand the root cause of the issue you are seeing. Can you put a comment on the ticket saying how to reproduce it locally? I think the fix should be simple. I will look into it firt thing tomorrow. [16:01:21] Looks like something is calling installMockMwServices() without the second (new) parameter. [16:02:12] oh right, the parser tests do [16:02:23] tests/phpunit/suites/ParserTestTopLevelSuite.php [16:02:24] yeah [20:16:39] kostajh: I think I found a solution, but I'm not sure how to verify: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/632825/3/tests/phpunit/suites/ParserIntegrationTest.php [20:20:49] duesen: rebase the failing GE patches onto your core one and see? [20:47:13] Urbanecm: hm, I guess I could even make an empty patch for GE that Depends-On my core patch, and see if it passes. Maybe I'll do that tomorrow. Time for bed now. [20:47:32] yup, that should work too [20:47:36] good night duesen :) [20:47:51] * duesen waves [21:56:12] bd808: I see you're an owner for the wikimedia/iegreview.git [21:56:29] There's a bit of a backlog of i18n patches [21:56:46] Any chance you could take a look at them if you have a spare minute? [21:56:55] they aren't auto merging? [21:57:07] bd808: nope because they contain html [21:57:10] that project is kind of in ownership limbo right now [21:57:33] I was thinking in asking for +2 myself but I have not contributed to it... [21:57:56] So, just the latest commit needs to be reviewed, the others can be safely abandoned [21:57:57] hauskatze: if it makes you feel any better, there is no deployment happening either so the patches sitting gerrit are meh [21:58:55] I'm not sure the tool is still used? Otherwise it'd make sense to archive the repo [21:59:16] it is actively used, just not actively developed or maintained [21:59:28] Ah, that reminds me of something [21:59:30] :-) [22:00:02] oops, I thought this was -cloud and it's -core [22:00:08] sorry for the offtopic :-( [22:01:00] hauskatze: it would have been offtopic in cloud to bug me about a project that is running in prod that I wrote 5 job changes ago too. ;) [22:01:54] this was actually my "home" irc channel when I wrote that app in 2014 [22:04:48] bd808: sorry to bug you then in any case