[10:24:43] kostajh: seems to "almost" work, fixing now... [10:45:08] duesen: thanks [10:46:08] duesen: different topic, is there a way to see the list of valid / defined REST endpoints via rest.php? [10:55:45] kostajh: I'm afraid not. self-documentation would be great, but it's not implemented. and there are no swagger specs. Feel free to push for that :) [11:00:54] ok, so my fix addressed all issues coming from within parser tests, but there are still a couple coming from fixture setup in the top level test suite, it seems. [11:01:25] I may have to take a different approach afetrall. [11:17:56] duesen: schade. I'm trying to debug why Parsoid/PHP auto config isn't working, it would be nice to see if the route is recognized at all by MW [11:19:03] kostajh: for it to work the route file has to be present in the list passed to the constructor of MediaWiki\Rest\Router [11:19:40] If it's there but still not working, there may be a problem with the object spec, or with the path [11:19:52] thx, was just looking around there [11:20:03] a SpecialPage which just lists these might be nice [11:20:40] ok, right, yeah I only see a route from GrowthExperiments but nothing from VE, so that helps with debugging [11:21:37] the list comes in via ExtensionRegistry. something must be going wrong there. wrong key in extension.json? [11:24:05] I have no idea, VE does some magic with the auto config setup, there isn't a traditionally defined route in extension.json [11:30:07] You may need to add a hook to inject additional routes or routing files, then [11:30:48] Maybe tehre is anotehr way, but that would certainly work. [11:32:45] duesen: thanks, I'll follow up in T263928 [11:32:46] T263928: VisualEditor in 1.35 not working (404 / Permanent Loading) - https://phabricator.wikimedia.org/T263928 [11:38:32] kostajh: now patch for HttpRequestFactory is up, should work now. [11:58:28] should work ;) [11:59:04] duesen: if you want to test locally you can check out GrowthExpreiments and enable the extension, then php tests/phpunit/phpunit.php --filter="ParserIntegrationTest::testParse" [12:00:29] Thanks, I did that. Works locally. [12:04:39] hm, so what's happening in CI? [12:05:22] mm, different set of failures from RestStructureTest [14:16:22] kostajh: yea. previously, the creation of MultiHttpClient wasn't blocked. Doing so made things fail. hopefully fixed now. [16:01:07] kostajh: success! https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/633152 [21:28:33] // Extension exists. Now see if there are screenshots [21:28:33] $info = []; [21:28:33] if ( is_dir( "$absDir/screenshots" ) ) { [21:28:33] $paths = glob( "$absDir/screenshots/*.png" ); [21:28:37] Do we actually use this? :P [21:29:07] Reedy: yeah, the skins have them [21:29:29] Somehow I hadn't noticed that :)