[02:30:03] when I run composer phpunit, I am getting this error: "PHP Fatal error: Uncaught InvalidArgumentException: Key "CanonicalNamespaceNames" not found in input sources in /home/subbu/work/wmf/core/includes/config/ServiceOptions.php:56" Is something broken in my mediawiki install or am i missing some config somewhere? [02:33:18] Not the most helpful error message [02:37:05] too much yak shaving for this late in the evening. i'll retire for the night and come back to this tomorrow. [20:06:06] TimStarling: did you see T269325 ? [20:06:06] T269325: Implement a reasonable strategy for handling Excimer-style timeouts in MediaWiki - https://phabricator.wikimedia.org/T269325 [20:13:09] I guess we were mostly thinking the same thing [21:34:19] subbu: What extension? That means the code hasn't been updated for a breaking change in 1.34 (I think, possibly 1.35?). [21:36:27] subbu: Context for one of the discussions about this (in ArticleRatings): https://phabricator.wikimedia.org/T237032#5642176 [21:39:27] that is mediawiki core .. and only when running integration tests. [21:40:10] Huh. [21:40:57] subbu: Oh, are you using `composer phpunit:integration`? See T258089 where c.scott got the same issue. [21:40:58] T258089: Errors running `composer phpunit` and warnings running `composer phpunit:integration` on a clean install of mediawiki-core - https://phabricator.wikimedia.org/T258089 [21:41:23] That entry point isn't really official-official. [21:43:17] aha, scott ran into it too. neither one of phpunit or phpunit:integration are official? [21:44:33] The official system is via the maintenance script. [21:44:42] k [21:44:53] `sudo -u www-data php tests/phpunit/phpunit.php --wiki wiki --stop-on-error` inside your docker instance or whatever. [21:45:12] That's what CI runs, so if that passes you can merge regardless of whether it works. ;-) [21:45:21] got it.