[01:33:25] <AaronSchulz>	 legoktm: is that code anywhere?
[01:34:30] <legoktm>	 AaronSchulz: https://gerrit.wikimedia.org/r/c/mediawiki/services/pyglet/+/220686 it's really trivial
[04:02:38] <AaronSchulz>	 TimStarling: any idea what https://integration.wikimedia.org/ci/job/mediawiki-core-php72-phan-docker/38529/console is complaining about ?
[04:06:05] <TimStarling>	 no
[04:06:56] <TimStarling>	 just suppress it
[04:14:01] <TimStarling>	 grep for SecurityCheck-XSS, there are tons of false positives
[04:19:27] <AaronSchulz>	 seems like a time sink
[04:19:35] * AaronSchulz amends
[12:13:16] <liw>	 hullo, https://phabricator.wikimedia.org/T271804 needs urgent attention, as it's a train blocker
[12:29:16] <Majavah>	 liw: does the full url in that task contain PII? If not, could that be added to the task?
[12:32:12] <liw>	 Majavah, let me check (sorry, it's beeen a while since I conducted the train last)
[12:34:06] <liw>	 added more info
[12:34:50] <Majavah>	 I'm mostly looking for the get parameters passed to api.php, that doesn't really help that much
[12:37:14] <liw>	 URL parameters? there are none, it's a POST request
[12:38:14] <Majavah>	 oh
[14:07:15] <duesen>	 liw: looking into both issues with ApiQueryInfo now
[14:08:30] <liw>	 duesen, cool
[14:21:05] <duesen>	  patch is up, but needs review / merging / backport / deploy
[14:21:14] <duesen>	 i made a regression test as well
[14:23:11] <liw>	 duesen, very cool: I apologise for not being able to review PHP code
[15:26:43] <apergos>	 if musikanimal is around there's a comment on that patch awaiting their input
[16:21:35] <apergos>	 first +2 in mw core repo :-D only took 12 years!