[16:23:50] <hoo>	 duesen: ping
[16:24:31] <duesen>	 hoo: Hey! Long time no see :)
[16:25:06] <hoo>	 Indeed :)
[16:25:23] <hoo>	 So, we were just looking into https://gerrit.wikimedia.org/r/c/mediawiki/core/+/666519/21/includes/Revision/RevisionRecord.php#114
[16:27:02] <duesen>	 did it call any problems?
[16:27:09] <hoo>	 So Wikibase is tripping these off, by calling RevisionStore::getRevisionById
[16:27:28] <hoo>	 AFAICT we have the wiki ids set correctly throughout
[16:28:19] <duesen>	 Are you passing Title objects? If yes, that would be the issue. Title is always local. You need to use a PageIdentityValue instead. 
[16:28:40] <hoo>	 We don't, but something in core is creating titles here
[16:28:56] <hoo>	 I had the snippet handy… one sec
[16:29:31] <hoo>	 RevisionStore::newRevisionFromRowAndSlots has $page = $this->getTitle( $pageId, $revId, $queryFlags );
[16:30:33] <hoo>	 So that will never work for non-local wikis (if it's not supposed to, I guess we should warn right there)
[16:30:50] <duesen>	 Ok, let me have a look. 
[16:33:18] <duesen>	 The simple solution is to pass a PageIdentity yourself, instead of relying on the default.
[16:33:33] <hoo>	 I guess RevisionStore should be creating PageIdentityValue instead of Title                // TODO: WikiPageEntityMetaDataLookup should use RevisionStore::getQueryInfo,
[16:33:33] <hoo>	                 // then we could use RevisionStore::newRevisionFromRow here!
[16:33:41] <duesen>	 But you are right that falling back to getTitle() isn't working correctly.
[16:33:58] <hoo>	 That's from Wikibase
[16:34:13] <hoo>	 so doing it right(tm) there will be a bit more involved
[16:34:30] <hoo>	 Or we allow passing a page to getRevisionById
[16:36:09] <duesen>	 hm yea, that would actually be kind of nice
[16:36:30] <duesen>	 I'll poke around a bit, I'll have a patch up in half an hour or so I hope.
[16:36:37] <duesen>	 will ping you then
[16:36:46] <hoo>	 Cool, thanks :)
[17:22:13] <duesen>	 Making progress, writing tests now
[18:02:38] <duesen>	 hoo: i'm running into trouble with how the tests are written. Nearly there...
[18:15:11] <duesen>	 hoo: I made two patches, one allowing a page to be passed to getRevisionById, and one that makes getRevisionById work correctly cross-wiki even when no page is provided.
[18:15:14] <duesen>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/672499/1
[18:15:24] <duesen>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/672462/1
[18:16:22] <duesen>	 I see odd test failures. Will deal with them in a bit
[19:00:40] <hoo>	 duesen: Thanks for tackling this… I'll call it a day now, but I'll be sure to have a look tomorrow