[00:09:06] <TimStarling>	 I'm just going to wrap it up, it's overkill already, best to just make it mergeable as is and move on to the next thing
[00:09:50] <TimStarling>	 I'm going to rename it though, "debuginfo" is too vague
[00:11:21] <TimStarling>	 maybe it's OK as the trait name, there can only be one __debugInfo() so all modifications to it will have to go in this trait
[01:07:41] <AaronSchulz>	 TimStarling: do yet get the problem on https://gerrit.wikimedia.org/r/c/operations/puppet/+/654330 ?
[01:11:01] <TimStarling>	 I haven't really ever looked at puppet compiler output, so I don't understand why Krinkle is saying there has to be a difference
[01:11:40] <TimStarling>	 the links have expired (404) which makes it harder still to tell what is going on there, maybe needs a rebase?
[01:19:22] <AaronSchulz>	 if it uses the hierdata for labs, then it won't work, since it is only eqiad
[01:22:56] * AaronSchulz waits on a new job
[01:42:59] <AaronSchulz>	 TimStarling: https://puppet-compiler.wmflabs.org/compiler1002/28659/ looks fine
[01:44:50] <TimStarling>	 so Krinkle will probably approve it now?
[04:51:51] <legoktm>	 I was also surprised @noVarDump didn't need to be added to PHPCS somewhere, I guess the sniff is less restrictive now