[01:23:46] <TimStarling>	 AaronSchulz: it seems like you're asking me to spend 2-3 hours reviewing something that has no impact on production, or even a bug number
[01:24:35] <AaronSchulz>	 TimStarling: the first thing I want to use it for is the upsert() calls in SqlBagOStuff
[01:25:03] * AaronSchulz left those as TODO comments in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/666781
[01:25:58] <TimStarling>	 do we need upsert in SqlBagOStuff?
[01:29:55] <TimStarling>	 I was looking at T280220 yesterday, that thing is comically bad and is probably the cause of every other issue involving user table updates
[01:29:55] <stashbot>	 T280220: Error "Lock wait timeout exceeded" from User::loadFromDatabase (via API action=options) - https://phabricator.wikimedia.org/T280220
[01:31:15] <TimStarling>	 constantly spewing timeout errors into the logs
[01:31:23] <TimStarling>	 fixing it is probably less than a day of work
[01:39:05] <AaronSchulz>	 TimStarling: SqlBagOStuff uses autocommit mode and for x2 would be it's own connection
[01:40:56] <Krinkle>	 (ref T212129, switching MainStash from Redis to SqlBagOStuff on the new x2 cluster)
[01:40:57] <stashbot>	 T212129: Move MainStash out of Redis to a simpler multi-dc aware solution - https://phabricator.wikimedia.org/T212129