[01:27:07] <TimStarling>	 Pchelolo: if you're still around, could you look at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/685623 ?
[01:27:34] <TimStarling>	 if it's approved I'll backport and deploy it immediately
[01:50:32] <Pchelolo>	 TimStarling: responded. Sounds good to me if it fixes the UBN, but we'd want to look at LinkBatch again, now I see it's completely incorrect where this troublesome PageIdentityValue is constructed
[01:51:18] <TimStarling>	 it fixes the UBN for me locally, log formatter just shows plain text "#1234" without a link
[01:52:24] <TimStarling>	 right, a bunch of unit tests proving that this bug exists
[01:53:09] <Pchelolo>	 sounds good enough, we'll look more deep l into it tomorrow with Daniel, I'm not quite sure anymore what was he trying to achieve creating page identity value for red links. Easy to forget not every red link is equal
[01:54:04] <Pchelolo>	 btw, I fixed a DB error today caused by rc_actor patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/685521 - was wondering if you have better ideas then what I did
[02:05:34] <TimStarling>	 I think it's fine
[02:06:38] <TimStarling>	 if ChangesListSpecialPage is adding joins then it is responsible for making sure they have valid conditions. So ideally you would not have to duplicate that fix, it would be in the base class somehow
[02:07:20] <TimStarling>	 I don't think we need some sort of join reordering dependency engine
[22:45:12] <hoo>	 Pchelolo: duesen: https://phabricator.wikimedia.org/T282193 This is probably close to UBN