[04:07:47] TimStarling: thanks for the merges, uploading the new release now. Hopefully it will build the Windows DDL properly... [06:15:30] answer: they did! https://windows.php.net/downloads/pecl/releases/luasandbox/4.0.2/ [09:21:58] Looks like the --reuse-db flag on the phpunit wrapper has been broken for at least three years, and nobody complained. Any objections to removing it? I filed https://phabricator.wikimedia.org/T283146 [09:56:55] no git blame though? [10:02:06] it was added by freakolowsky for oracle support "with reuse-db oracle phpunit test run on oracle down to 1m 20s ;)" [10:02:54] he added both --reuse-db and --use-normal-tables in the same commit [10:05:04] this was 5933586266e5530d491cf0e518abfe0ed56e1c0a [10:05:42] anyway, seems to me that if the intended use of something is unclear, you should probably blame it before you delete it [10:31:55] @TimStarling you are better at git archeology than I am. All I came up with was me moving things around in I2e8335d50eefcc7a97c1cd122b509f0939eacc92 [10:31:55] and I0b84a0c4d174cbde830786028ee7568c4ea9fb5d. [10:32:26] I then went back as far as I could get things to run and confirmed that it was already broken. [10:34:54] @TimStarling since it has been broken for years without complaints, and we dropped Oracle support from core, I still think it should go. Do you think we should keep it? [10:35:09] I think it should go [10:35:20] I just think you should update your commit message [10:35:47] Will do. Thanks for the digging. Which part of the code did you "blame" to find this? [10:36:27] the archaeology trick in this case was to check out a random old version to get past the more recent file renames, I have a "plain" git checkout that I use for this purpose [10:36:49] I guessed 1.28, checked it out, grepped for reuse-db, then blamed that line [10:37:29] I mostly use "git gui blame" which is a gui tool for blame navigation, but phpstorm has a similar thing [10:38:48] there are only two references to reuse-db in 1.28, it's not so spread out. I used the one in tests/phpunit/MediaWikiTestCase.php [10:50:14] * Krinkle tends to use Gerrit or GitHub, click on an old release tag or branch, press T, go to the related file and blame from there. [11:27:53] @TimStarling going back to 1.28 before the blame is strong kung fu, I have to remember that :) [13:17:58] duesen: if the search term is uncommon enough, git log -S works wonders. [14:26:14] like tgr I use git log -S a lot as well ...