[00:00:16] 10MediaWiki-Debug-Logger, 10Continuous-Integration-Config, 10Patch-For-Review: Log suppressed errors with level=DEBUG - https://phabricator.wikimedia.org/T193472 (10Krinkle) @Tgr The task as written appears to be working as expected. We currently, and have for years, collect the "suppressed errors" in produc... [00:01:30] (03PS2) 10Gergő Tisza: Add a checker that stores hashes in local binary files [extensions/PwnedPasswords] - 10https://gerrit.wikimedia.org/r/478455 [00:02:59] 10Operations, 10PHP 7.0 support: Audit and sync INI settings as needed between HHVM and PHP 7 - https://phabricator.wikimedia.org/T211488 (10Krinkle) p:05Triage>03Normal [00:09:27] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10rafidaslam) a:03rafidaslam [00:14:41] 10Core Platform Team, 10MediaWiki-Special-pages, 10Wikimedia-production-error: Target deletion during page move fails - https://phabricator.wikimedia.org/T210739 (10Wbm1058) Is this still a problem? A week ago Friday I saw this error every time I tried to move over a page with history. It didn't seem random,... [00:16:23] 10MediaWiki-User-login-and-signup, 10MediaWiki-Vendor, 10Security-Reviews: Security review of bjeavons/zxcvbn-php - https://phabricator.wikimedia.org/T211489 (10Tgr) [00:16:38] 10MediaWiki-User-login-and-signup, 10MediaWiki-Vendor, 10Security-Reviews: Security review of bjeavons/zxcvbn-php - https://phabricator.wikimedia.org/T211489 (10Tgr) [00:16:44] 10MediaWiki-User-login-and-signup, 10MediaWiki-User-preferences, 10Patch-For-Review, 10Performance-Team (Radar): Display a password strength bar - https://phabricator.wikimedia.org/T32574 (10Tgr) [00:20:43] (03PS1) 10Gergő Tisza: Add bjeavons/zxcvbn-php [vendor] - 10https://gerrit.wikimedia.org/r/478456 (https://phabricator.wikimedia.org/T32574) [00:21:22] (03CR) 10Gergő Tisza: [C: 04-2] "Blocked on security review (T211489)." [vendor] - 10https://gerrit.wikimedia.org/r/478456 (https://phabricator.wikimedia.org/T32574) (owner: 10Gergő Tisza) [00:21:56] (03PS8) 10Gergő Tisza: Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [00:25:14] 10MediaWiki-Categories, 10Multimedia, 10UploadWizard: The Category field of UploadWizard doesn't enable to go through the category tree up and down - https://phabricator.wikimedia.org/T177687 (10SJu) p:05Triage>03High [00:31:00] 10MediaWiki-Categories, 10Multimedia, 10UploadWizard: The Category field of UploadWizard doesn't enable to go through the category tree up and down - https://phabricator.wikimedia.org/T177687 (10SJu) related to T42076 [00:32:21] 10Multimedia, 10UploadWizard: Missing Hot-cat-like categorization support in UploadWizard - https://phabricator.wikimedia.org/T85097 (10SJu) related to T177687 [00:35:04] 10MobileFrontend: iPad Pro/iOS 12.1: scrolling is broken when editing mobile site in source mode - https://phabricator.wikimedia.org/T211490 (10AxelBoldt) [00:37:52] (03CR) 10jerkins-bot: [V: 04-1] Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [00:39:16] (03CR) 10Krinkle: [C: 032] Add browser test for preview functionality to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/476585 (https://phabricator.wikimedia.org/T210758) (owner: 10Thiemo Kreuz (WMDE)) [00:39:53] 10CirrusSearch, 10Discovery-Search, 10Operations: Find an alternative to HHVM curl connection pooling for PHP 7 - https://phabricator.wikimedia.org/T210717 (10Krinkle) [00:53:27] (03Merged) 10jenkins-bot: Add browser test for preview functionality to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/476585 (https://phabricator.wikimedia.org/T210758) (owner: 10Thiemo Kreuz (WMDE)) [00:55:42] (03CR) 10jenkins-bot: Add browser test for preview functionality to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/476585 (https://phabricator.wikimedia.org/T210758) (owner: 10Thiemo Kreuz (WMDE)) [00:56:40] (03PS9) 10Gergő Tisza: Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [00:59:01] 04(no projects): iPad Pro/iOS 12.1: cursor jumps out of view when editing mobile site in source mode - https://phabricator.wikimedia.org/T211491 (10AxelBoldt) [01:09:31] (03CR) 10jerkins-bot: [V: 04-1] Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [01:12:42] 10Growth-Team, 10Notifications, 10StructuredDiscussions, 10TechCom: Remove custom 'CatchableFatalErrorException' logic from Echo/Flow code bases - https://phabricator.wikimedia.org/T208146 (10Krinkle) [01:13:12] 10WMSE-Riksarkivet-TORA: Add Bygdeband to Wikidata as a Property - https://phabricator.wikimedia.org/T210062 (10Salgo60) See [[ http://minancestry.blogspot.com/2018/12/bygdeband-swedish-site-containing-local.html | Blogpost ]] Next step: - speak with bygdeband -- explain how they can link - decide if Wiki... [01:13:58] 10WMSE-Riksarkivet-TORA: Add Bygdeband to Wikidata as a Property - https://phabricator.wikimedia.org/T210062 (10Salgo60) [01:14:48] 10WMSE-Riksarkivet-TORA: Add Bygdeband to Wikidata as a Property and match "Församlingar" - https://phabricator.wikimedia.org/T210062 (10Salgo60) [01:20:27] (03CR) 10Krinkle: [C: 031] "Given we do not require use of Yoda conditionals, their infrequent use is unexpected, cause for confusion, and increases cognitive overhea" [core] - 10https://gerrit.wikimedia.org/r/475066 (owner: 10Fomafix) [01:21:12] (03CR) 10Krinkle: [C: 032] No yoda conditions [core] - 10https://gerrit.wikimedia.org/r/475066 (owner: 10Fomafix) [01:22:35] (03CR) 10Krinkle: [C: 04-1] "Renaming modules is suspicious. Can you confirm that the name of the old module is not cached in any way in HTML or ParserOutput cache and" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/478451 (owner: 10Fomafix) [01:34:28] (03Merged) 10jenkins-bot: No yoda conditions [core] - 10https://gerrit.wikimedia.org/r/475066 (owner: 10Fomafix) [01:35:24] (03PS10) 10Gergő Tisza: Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [01:36:45] (03CR) 10jenkins-bot: No yoda conditions [core] - 10https://gerrit.wikimedia.org/r/475066 (owner: 10Fomafix) [01:37:55] (03PS11) 10Gergő Tisza: Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [01:42:59] (03CR) 10Krinkle: "I assume you're referring to https://github.com/wikimedia/mediawiki/blob/2ca16a7bd3bbf/resources/src/mediawiki.ui/components/radio.less." [core] - 10https://gerrit.wikimedia.org/r/475809 (owner: 10VolkerE) [01:44:50] (03CR) 10Krinkle: "Hm.. also check whether the upstream is meant to handle file-system paths. I believe our function is meant to handle that (it's use for ur" [core] - 10https://gerrit.wikimedia.org/r/477964 (owner: 10Reedy) [01:46:22] (03CR) 10Krinkle: [C: 032] ResourceLoaderContext: Add getConfig() method [core] - 10https://gerrit.wikimedia.org/r/478380 (owner: 10Catrope) [01:46:44] (03PS2) 10Krinkle: resourceloader: Add getConfig() method to ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/478380 (owner: 10Catrope) [01:46:48] (03CR) 10Krinkle: [C: 032] resourceloader: Add getConfig() method to ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/478380 (owner: 10Catrope) [01:51:44] (03CR) 10Krinkle: [C: 032] Provide a default for $wgVERPdomainPart at runtime [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/447934 (https://phabricator.wikimedia.org/T180192) (owner: 10Legoktm) [02:01:22] (03Merged) 10jenkins-bot: resourceloader: Add getConfig() method to ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/478380 (owner: 10Catrope) [02:01:24] (03Merged) 10jenkins-bot: Provide a default for $wgVERPdomainPart at runtime [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/447934 (https://phabricator.wikimedia.org/T180192) (owner: 10Legoktm) [02:03:39] (03CR) 10jenkins-bot: Provide a default for $wgVERPdomainPart at runtime [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/447934 (https://phabricator.wikimedia.org/T180192) (owner: 10Legoktm) [02:03:41] (03CR) 10jenkins-bot: resourceloader: Add getConfig() method to ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/478380 (owner: 10Catrope) [02:04:23] (03CR) 10Krinkle: Add wfGetErrorText, a global helper function for log error formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/467111 (owner: 10Gergő Tisza) [02:11:09] 10Advanced-Search, 10TCB-Team, 10Patch-For-Review, 10WMDE-QWERTY-Sprint-2018-11-20: Advanced search stuck showing three dots: "defaultUri is undefined" (Swedish wikis) - https://phabricator.wikimedia.org/T210684 (10Krinkle) Other industry examples: * (03CR) 10Krinkle: [C: 04-1] "See task for details (-1 for that), but if/when this goes, we should have tests as well." [core] - 10https://gerrit.wikimedia.org/r/477264 (https://phabricator.wikimedia.org/T210684) (owner: 10Thiemo Kreuz (WMDE)) [02:11:55] (03CR) 10Krinkle: Emit debug logs when filtering without title (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/466842 (https://phabricator.wikimedia.org/T144265) (owner: 10Daimona Eaytoy) [02:12:28] (03PS1) 10Krinkle: Revert "Pass $context to 'GetPreferences' hook" [core] - 10https://gerrit.wikimedia.org/r/478457 [02:12:49] (03PS21) 10Krinkle: [tests] Ensure only existing wikis are referenced from IS.php [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) (owner: 10Urbanecm) [02:13:22] (03CR) 10jerkins-bot: [V: 04-1] Revert "Pass $context to 'GetPreferences' hook" [core] - 10https://gerrit.wikimedia.org/r/478457 (owner: 10Krinkle) [02:13:58] (03CR) 10jerkins-bot: [V: 04-1] Revert "Pass $context to 'GetPreferences' hook" [core] - 10https://gerrit.wikimedia.org/r/478457 (owner: 10Krinkle) [02:14:00] (03CR) 10jerkins-bot: [V: 04-1] [tests] Ensure only existing wikis are referenced from IS.php [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) (owner: 10Urbanecm) [02:14:36] (03CR) 10Krinkle: [tests] Ensure only existing wikis are referenced from IS.php (031 comment) [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) (owner: 10Urbanecm) [02:26:13] 10Operations, 10monitoring, 10Patch-For-Review: Provision >= 50% of statsd/Graphite-only metrics in Prometheus - https://phabricator.wikimedia.org/T205870 (10Krinkle) [02:28:07] 10WMSE-Riksarkivet-TORA: Add Bygdeband to Wikidata as a Property and match "Församlingar" - https://phabricator.wikimedia.org/T210062 (10Salgo60) [02:29:36] 10Operations, 10monitoring, 10Patch-For-Review: Provision >= 50% of statsd/Graphite-only metrics in Prometheus - https://phabricator.wikimedia.org/T205870 (10Krinkle) [02:35:10] 10Operations, 10Performance-Team, 10monitoring, 10Patch-For-Review: Provision >= 50% of statsd/Graphite-only metrics in Prometheus - https://phabricator.wikimedia.org/T205870 (10Krinkle) > [ ] performance (generated from where?) @Peter When I looked at the data under `performance.*` on the Graphite serve... [03:00:06] 10Core Platform Team, 10Operations, 10ops-codfw, 10Services (doing), and 2 others: Reshape RESTBase Cassandra cluster for server refresh - https://phabricator.wikimedia.org/T210843 (10Eevans) [04:17:11] 10Operations, 10Operations-Software-Development, 10Patch-For-Review: Develop and deploy at least three Netbox reports to assist with data correctness and consistency - https://phabricator.wikimedia.org/T205899 (10crusnov) Note that Netbox does not allow one to create a second device with the same asset tag,... [04:46:50] (03PS1) 10CRusnov: Add "Coherence" check [software/netbox-reports] - 10https://gerrit.wikimedia.org/r/478458 [06:12:45] (03PS1) 10MaxSem: Hard deprecated SiteSQLStore::newInstance() [core] - 10https://gerrit.wikimedia.org/r/478459 [06:12:47] (03PS1) 10MaxSem: Hard deprecate LinkCache::addLink() [core] - 10https://gerrit.wikimedia.org/r/478460 [06:12:49] (03PS1) 10MaxSem: Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 [06:14:02] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (10Jnanaranjan_sahu) @Tgr Thanks for explaining. That solved the issue. (That was too simple but I have been struggling. My bad) Can't we make it simple and... [06:17:38] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 (owner: 10MaxSem) [06:17:41] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate LinkCache::addLink() [core] - 10https://gerrit.wikimedia.org/r/478460 (owner: 10MaxSem) [06:18:12] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 (owner: 10MaxSem) [06:18:30] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate LinkCache::addLink() [core] - 10https://gerrit.wikimedia.org/r/478460 (owner: 10MaxSem) [06:24:21] (03PS2) 10MaxSem: Hard deprecate LinkCache::addLink() [core] - 10https://gerrit.wikimedia.org/r/478460 [06:24:23] (03PS2) 10MaxSem: Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 [06:31:48] (03CR) 10Liuxinyu970226: [C: 031] Chinese Conversion Table Update 2018-3 [core] - 10https://gerrit.wikimedia.org/r/464941 (owner: 10Chiefwei) [06:39:50] (03CR) 10Shreyasminocha: [C: 04-1] Refactor most of jQuery code to vanilla JS (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [07:18:38] 10Toolforge: Pull python-socketio-client and python-websocket from backports - https://phabricator.wikimedia.org/T159025 (10Liuxinyu970226) [07:21:48] 10WMF-NDA-Requests: Volunteer NDA for Daimona - https://phabricator.wikimedia.org/T211042 (10kaldari) I'm happy to provide the manager approval, but you'll still need a C-level sign-off. [07:22:26] 10MobileFrontend: iPad Pro/iOS 12.1: cursor jumps out of view when editing mobile site in source mode - https://phabricator.wikimedia.org/T211491 (10Liuxinyu970226) [07:35:48] 10Commons, 10Wikimedia-Site-requests, 10User-Zoranzoki21: Please add http://idb.ub.uni-tuebingen.de/digitue to the wgCopyUploadsDomains whitelist of Wikimedia Commons - https://phabricator.wikimedia.org/T211466 (10Zoranzoki21) a:03Zoranzoki21 [07:40:40] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (10Tgr) You can, but that will result in an urlencoded POST body. Maybe that works too, I don't know what are the exact requirements for the upload API. As far... [07:52:18] (03PS1) 10Zoranzoki21: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478462 [07:52:20] (03PS1) 10Zoranzoki21: Disable unused Flow extension on de.wikiversity [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478463 (https://phabricator.wikimedia.org/T207626) [07:53:03] (03PS1) 10Zoranzoki21: Disable unused Flow extension on ur.wikibooks [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478464 (https://phabricator.wikimedia.org/T207627) [07:53:56] (03Abandoned) 10Zoranzoki21: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478462 (owner: 10Zoranzoki21) [07:55:51] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (10Jnanaranjan_sahu) Yes you are right. If I use file_gets_content(), I am getting authorization error. [07:59:33] (03PS1) 10Zoranzoki21: Remove FlaggedRevs for ptwikipedia [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478465 (https://phabricator.wikimedia.org/T211433) [08:01:15] 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Zoranzoki21: Remove FlaggedRevs for ptwikipedia - https://phabricator.wikimedia.org/T211433 (10Zoranzoki21) >>! In T211433#4807955, @Guilhermebm wrote: > Hello, @Zoranzoki21 . I don't know. What would happen if the database was removed? Thanks. See https... [08:03:09] (03CR) 10Zoranzoki21: [C: 04-1] "> So this is superseded by / already included in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Spark/+/424605/" [extensions/Spark] - 10https://gerrit.wikimedia.org/r/451600 (https://phabricator.wikimedia.org/T189687) (owner: 10Dheerajmalisetty) [08:05:11] 10Commons, 10Multimedia, 10UploadWizard: Server side flickr review - https://phabricator.wikimedia.org/T89131 (10kaldari) @Steinsplitter - Ah, I see. While `extended-reviewers` can technically review image licenses now, I think they can be trusted not to violate the review policy (or hack UploadWizard to do... [08:12:14] (03PS1) 10Zoranzoki21: Add http://idb.ub.uni-tuebingen.de/digitue to the wgCopyUploadsDomains [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478466 (https://phabricator.wikimedia.org/T211466) [08:18:15] (03CR) 10Arcayn: [C: 031] Automatically revoke statutory declaration when "car_travel" is unchecked [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478454 (https://phabricator.wikimedia.org/T211429) (owner: 10Urbanecm) [08:24:43] (03CR) 10Tpt: [C: 032] Fix neapolitan talk namespaces for ProofreadPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478443 (owner: 10MarcoAurelio) [08:27:19] (03PS1) 10Gergő Tisza: Add some missing groups to the privileged list [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478467 [08:29:32] (03Merged) 10jenkins-bot: Fix neapolitan talk namespaces for ProofreadPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478443 (owner: 10MarcoAurelio) [08:31:49] (03CR) 10jenkins-bot: Fix neapolitan talk namespaces for ProofreadPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478443 (owner: 10MarcoAurelio) [08:45:44] 10DBA: labsdb1004 replication broken for linkwatcher_linklog table - https://phabricator.wikimedia.org/T211210 (10Banyek) ETA is still 20hrs [08:58:15] (03CR) 10Smalyshev: [C: 031] Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 (owner: 10MaxSem) [09:25:14] 10Pywikibot: Update Arabic (ar) for fixes.py (Patch against Pywikibot core included) - https://phabricator.wikimedia.org/T211492 (10Meno25) [09:27:28] (03PS5) 10Daimona Eaytoy: Emit debug logs when filtering without title [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/466842 (https://phabricator.wikimedia.org/T144265) [09:29:14] (03CR) 10D3r1ck01: [C: 032] "SGTM!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/477537 (owner: 10D3r1ck01) [09:32:11] (03CR) 10D3r1ck01: [C: 032] "LGTM! Thanks @Marco :)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/478444 (https://phabricator.wikimedia.org/T210825) (owner: 10MarcoAurelio) [09:36:27] (03CR) 10D3r1ck01: [C: 031] "Thanks a lot Marco ;), I'm not a nap expert (or native) but this patch LGTM. I'm wondering if we should run this against a "nap" reviewer " [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/478441 (https://phabricator.wikimedia.org/T210826) (owner: 10MarcoAurelio) [09:50:38] (03Merged) 10jenkins-bot: [repo] Hooks: Fix PHPDoc comments in Hooks module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/477537 (owner: 10D3r1ck01) [09:50:40] (03Merged) 10jenkins-bot: Translate Scribunto namespaces to Neapolitan (nap) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/478444 (https://phabricator.wikimedia.org/T210825) (owner: 10MarcoAurelio) [09:51:40] (03CR) 10jenkins-bot: [repo] Hooks: Fix PHPDoc comments in Hooks module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/477537 (owner: 10D3r1ck01) [09:58:25] (03CR) 10jenkins-bot: Translate Scribunto namespaces to Neapolitan (nap) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/478444 (https://phabricator.wikimedia.org/T210825) (owner: 10MarcoAurelio) [10:02:44] 10Citoid, 10VisualEditor, 10Services (doing), 10User-Ryasmeen: Update zotero translators - https://phabricator.wikimedia.org/T174992 (10Mvolz) 05stalled>03Resolved [10:05:15] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Some regressions in production with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10Mvolz) [10:05:19] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): QIDs work locally but not in production with new translation-server - https://phabricator.wikimedia.org/T211148 (10Mvolz) 05Open>03Resolved [10:06:16] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): QIDs work locally but not in production with new translation-server - https://phabricator.wikimedia.org/T211148 (10Mvolz) Seems to be working now: https://en.wikipedia.org/api/rest_v1/data/citation/mediawiki/Q33415777 May have been timin... [10:07:01] (03PS1) 10Raimond Spekking: [Blue Spice Custom Menu] Register extension [translatewiki] - 10https://gerrit.wikimedia.org/r/478468 [10:07:15] (03CR) 10Raimond Spekking: [V: 032 C: 032] [Blue Spice Custom Menu] Register extension [translatewiki] - 10https://gerrit.wikimedia.org/r/478468 (owner: 10Raimond Spekking) [10:15:21] (03PS1) 10Raimond Spekking: [Count Down Clock] Register extension [translatewiki] - 10https://gerrit.wikimedia.org/r/478469 [10:15:29] (03CR) 10Raimond Spekking: [V: 032 C: 032] [Count Down Clock] Register extension [translatewiki] - 10https://gerrit.wikimedia.org/r/478469 (owner: 10Raimond Spekking) [10:17:53] (03PS1) 10Umherirrender: Use english for message text in SparqlException [core] - 10https://gerrit.wikimedia.org/r/478470 [10:18:40] (03PS2) 10Umherirrender: Use english for message text in SparqlException [core] - 10https://gerrit.wikimedia.org/r/478470 [10:22:37] (03PS1) 10Umherirrender: Use english for log text in AuthManagerSpecialPage [core] - 10https://gerrit.wikimedia.org/r/478471 [10:25:06] (03CR) 10Bartosz Dziewoński: [C: 031] "Needs rebase." [core] - 10https://gerrit.wikimedia.org/r/478457 (owner: 10Krinkle) [10:27:36] (03PS2) 10Umherirrender: Remove useless continue at end of loop [core] - 10https://gerrit.wikimedia.org/r/464790 (owner: 10Fomafix) [10:27:40] (03CR) 10Umherirrender: [C: 032] Remove useless continue at end of loop [core] - 10https://gerrit.wikimedia.org/r/464790 (owner: 10Fomafix) [10:30:13] (03PS2) 10Umherirrender: Use common function names for hook functions [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/472471 (owner: 10Fomafix) [10:30:17] (03CR) 10Umherirrender: [C: 032] Use common function names for hook functions [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/472471 (owner: 10Fomafix) [10:35:36] (03CR) 10Mainframe98: [C: 04-1] Convert UploadLocal to use extension registration (031 comment) [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/478438 (https://phabricator.wikimedia.org/T211428) (owner: 10MarcoAurelio) [10:41:45] (03Merged) 10jenkins-bot: Remove useless continue at end of loop [core] - 10https://gerrit.wikimedia.org/r/464790 (owner: 10Fomafix) [10:41:47] (03Merged) 10jenkins-bot: Use common function names for hook functions [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/472471 (owner: 10Fomafix) [10:44:00] (03CR) 10jenkins-bot: Remove useless continue at end of loop [core] - 10https://gerrit.wikimedia.org/r/464790 (owner: 10Fomafix) [10:46:15] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Billinghurst) I tell you what I find truly infuriating about this implementation 1) A soluti... [10:47:25] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Billinghurst) [10:49:58] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Billinghurst) Emended possibly reference to admins "locking themselves out". Locks are impos... [10:58:57] 10PAWS: "500 : Internal Server Error ordinal not in range(256)" when logging in with OAuth - https://phabricator.wikimedia.org/T211493 (10Vojtech.dostal) [11:07:38] (03PS1) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:08:22] (03PS2) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:09:17] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [11:14:19] (03CR) 10Fomafix: "I keep the previous module name for compatibility to cached versions in PS2." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/478451 (owner: 10Fomafix) [11:14:27] (03PS2) 10Fomafix: Move styles that only used in JavaScript to JavaScript module [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/478451 [11:16:43] (03PS3) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:17:39] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [11:18:50] (03PS3) 10Volans: validator: complete refactor of the validation [dns] - 10https://gerrit.wikimedia.org/r/478416 (https://phabricator.wikimedia.org/T182028) [11:19:30] (03CR) 10Volans: "Updated paste https://phabricator.wikimedia.org/P7896 with latest version output example." [dns] - 10https://gerrit.wikimedia.org/r/478416 (https://phabricator.wikimedia.org/T182028) (owner: 10Volans) [11:21:55] 10MediaWiki-extensions-EducationProgram, 10Wikimedia-Site-requests: Re-enable EP Namespaces in wmf-config - https://phabricator.wikimedia.org/T211494 (10Reedy) [11:25:20] (03PS4) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:25:51] 10MediaWiki-extensions-EducationProgram, 10Wikimedia-Site-requests: Re-enable EP Namespaces in wmf-config - https://phabricator.wikimedia.org/T211494 (10Reedy) [11:26:13] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [11:29:27] (03PS5) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:29:36] (03CR) 10Volans: "Nice! Minor comments inline." (035 comments) [software/netbox-reports] - 10https://gerrit.wikimedia.org/r/478458 (owner: 10CRusnov) [11:30:24] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [11:33:28] (03PS6) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:33:53] (03PS1) 10Reedy: Re-enable EP namespaces [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478473 (https://phabricator.wikimedia.org/T211494) [11:34:23] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [11:34:51] (03PS1) 10Umherirrender: Whitelist @after and @before phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/478474 [11:38:20] (03PS7) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:39:57] (03CR) 10Nathan fraignt: "> Patch Set 7:" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T211277) (owner: 10Nathan fraignt) [11:40:23] (03Abandoned) 10Umherirrender: Allow use of @type in code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/472522 (https://phabricator.wikimedia.org/T203922) (owner: 10Umherirrender) [11:40:42] 10MediaWiki-Codesniffer, 10Patch-For-Review: Allow deprecated @type in MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation - https://phabricator.wikimedia.org/T203922 (10Umherirrender) 05Open>03declined [11:41:18] (03CR) 10Nathan fraignt: [C: 031] Automatically revoke statutory declaration when "car_travel" is unchecked [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478454 (https://phabricator.wikimedia.org/T211429) (owner: 10Urbanecm) [11:50:08] (03PS1) 10Umherirrender: Improve paramater docs of NotifiedUsersTest::getTestData [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478475 [11:51:20] 10AbuseFilter, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Later), 10User-Daimona, 10Wikimedia-production-error: "User::loadFromSession called before the end of Setup.php" warning due to AbuseFilte... - https://phabricator.wikimedia.org/T151291 [11:56:37] (03PS3) 10Umherirrender: Add missing dependency on core module 'user.options' [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/478400 (owner: 10Fomafix) [11:56:39] (03CR) 10Umherirrender: [C: 032] Add missing dependency on core module 'user.options' [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/478400 (owner: 10Fomafix) [11:59:50] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Great work so far :) I've one thing, though :)" (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) (owner: 10Stibba) [12:00:46] (03Merged) 10jenkins-bot: Add missing dependency on core module 'user.options' [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/478400 (owner: 10Fomafix) [12:02:51] (03CR) 10Urbanecm: [C: 032] Automatically revoke statutory declaration when "car_travel" is unchecked [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478454 (https://phabricator.wikimedia.org/T211429) (owner: 10Urbanecm) [12:03:49] (03Merged) 10jenkins-bot: Automatically revoke statutory declaration when "car_travel" is unchecked [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478454 (https://phabricator.wikimedia.org/T211429) (owner: 10Urbanecm) [12:13:17] 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Automatically revoke statutory declaration when "car_travel" is unchecked - https://phabricator.wikimedia.org/T211429 (10Urbanecm) 05Open>03Resolved [12:13:33] (03CR) 10Umherirrender: build: Replace jshint with eslint & stylelint (034 comments) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) (owner: 10Stibba) [12:21:12] (03PS3) 10Shreyasminocha: Switch from babel-preset-env to @babel/preset-env [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) [12:32:07] (03PS3) 10Stibba: build: Replace jshint with eslint & stylelint [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) [12:34:21] 10Library-Card-Platform, 10Google-Code-in-2018, 10goodfirstbug: Add 'invalid' application status option - https://phabricator.wikimedia.org/T175249 (10Arcayn) a:03Arcayn [12:34:50] 10Wikidata: Wikidata dump of classes - https://phabricator.wikimedia.org/T211495 (10abian) [12:35:00] 10Wikidata: Wikidata dump of classes - https://phabricator.wikimedia.org/T211495 (10abian) [12:35:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Partial RDF dumps - https://phabricator.wikimedia.org/T46581 (10abian) [12:35:17] (03CR) 10Stibba: build: Replace jshint with eslint & stylelint (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) (owner: 10Stibba) [12:43:50] 10International-Developer-Events, 10Google-Code-in-2018: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10Dodecane) {F27453897} [12:43:54] 10Wikidata: Dump(s) of Wikidata classes - https://phabricator.wikimedia.org/T211495 (10abian) [12:45:29] 10Core Platform Team, 10Operations, 10ops-codfw, 10Services (doing), and 2 others: Reshape RESTBase Cassandra cluster for server refresh - https://phabricator.wikimedia.org/T210843 (10Eevans) [12:47:41] (03CR) 10Shreyasminocha: "Had to lower nyc's threshold for branches because updating babel and related dependencies caused branch coverage to drop significantly, pr" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) (owner: 10Shreyasminocha) [12:49:33] 10MediaWiki-General-or-Unknown, 10I18n: Missing passwordpolicies-policy-blockattacker message - https://phabricator.wikimedia.org/T211496 (10MarcoAurelio) [12:50:15] (03CR) 10Urbanecm: [C: 031] "LGTM, but I'd like to wait on Arcayn's review, as they commented on previous patch with issues the patch has." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [12:51:32] 10WMCZ-Tracker, 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm: Sorting by (pre)expeditures doesn't work - https://phabricator.wikimedia.org/T211277 (10Urbanecm) 05Resolved>03Open Reopening, for details see the merged commit linked above. [12:52:39] 10MediaWiki-General-or-Unknown, 10Security-Team, 10I18n: Missing passwordpolicies-policy-blockattacker message - https://phabricator.wikimedia.org/T211496 (10Reedy) p:05Triage>03Low It's because it's something added in wmf-config I think there's a task for this already [12:53:18] 10MediaWiki-General-or-Unknown, 10Security-Team, 10I18n: Missing passwordpolicies-policy-blockattacker message - https://phabricator.wikimedia.org/T211496 (10Reedy) [12:55:10] (03CR) 10Shreyasminocha: [C: 031] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [12:56:40] 10MediaWiki-extensions-Scribunto, 10I18n, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Localize Scribunto magic words and namespaces to Neapolitan - https://phabricator.wikimedia.org/T210825 (10MarcoAurelio) 05Open>03Resolved a:03Ruthven [12:56:49] 10MediaWiki-extensions-Scribunto, 10I18n, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11): Localize Scribunto magic words and namespaces to Neapolitan - https://phabricator.wikimedia.org/T210825 (10MarcoAurelio) [12:57:54] 10WMF-NDA-Requests: Volunteer NDA for Daimona - https://phabricator.wikimedia.org/T211042 (10MarcoAurelio) >>! In T211042#4808232, @kaldari wrote: > I'm happy to provide the manager approval, but you'll still need a C-level sign-off. Let's ping @VColeman for this. [12:58:32] 10WMCZ-Tracker: It isn't possible to order by amount on page of any individual ticket - https://phabricator.wikimedia.org/T211280 (10Nathan_fraignt) This isn't an issue with the amount, all the columns are impossible to order. Also see this error (occurs when actually clicking an order arrow/button): ` jquery.d... [13:01:24] (03PS1) 10Urbanecm: [typo] ruwikivnews instead of ruwikinews [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478476 [13:02:31] (03PS22) 10Urbanecm: [tests] Ensure only existing wikis are referenced from IS.php [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) [13:02:55] (03CR) 10Urbanecm: "PS22: Rebased on https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/478476, so tests vote +2." [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) (owner: 10Urbanecm) [13:03:34] 10WMCZ-Tracker: It isn't possible to order by amount on page of any individual ticket - https://phabricator.wikimedia.org/T211280 (10Stibba) settings.aaSorting seems to be false so there is probably an issue when the tables are created. [13:04:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: possible to create duplicate sitelinks - https://phabricator.wikimedia.org/T50260 (10Liuxinyu970226) [13:05:22] (03PS23) 10Urbanecm: [tests] Ensure only existing wikis are referenced from IS.php [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) [13:05:50] (03CR) 10Urbanecm: [tests] Ensure only existing wikis are referenced from IS.php (031 comment) [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) (owner: 10Urbanecm) [13:06:10] (03CR) 10jerkins-bot: [V: 04-1] [tests] Ensure only existing wikis are referenced from IS.php [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) (owner: 10Urbanecm) [13:06:20] 10WMCZ-Tracker: It isn't possible to order by amount on page of any individual ticket - https://phabricator.wikimedia.org/T211280 (10Nathan_fraignt) a:03Nathan_fraignt [13:07:40] (03PS8) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [13:08:06] (03PS9) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [13:08:21] (03PS24) 10Urbanecm: [tests] Ensure only existing wikis are referenced from IS.php [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) [13:09:56] (03CR) 10Nathan fraignt: "Added the fix to T211280 to this patchset. The bug is closely related to T211277, which was/is fixed with this patchset." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [13:10:17] 10Wikidata: Dump(s) of Wikidata instances of Q5 - https://phabricator.wikimedia.org/T211497 (10abian) [13:10:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Partial RDF dumps - https://phabricator.wikimedia.org/T46581 (10abian) [13:10:38] 10Wikidata: Dump(s) of Wikidata instances of Q5 - https://phabricator.wikimedia.org/T211497 (10abian) [13:10:46] 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wiktionary Cantonese - https://phabricator.wikimedia.org/T205546 (10Urbanecm) Scheduled for tomorrow EU SWAT. [13:11:18] (03PS2) 10Urbanecm: [typo] Use ruwikinews instead of ruwikivnews [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478476 [13:13:35] 10WMCZ-Tracker, 10Patch-For-Review: It isn't possible to order on page of any individual ticket - https://phabricator.wikimedia.org/T211280 (10Urbanecm) [13:14:03] (03PS25) 10Urbanecm: [tests] Ensure only existing wikis are referenced from IS.php [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) [13:15:04] 10Phabricator (Upstream), 10Upstream: "Custom Policy" box could provide more informations - https://phabricator.wikimedia.org/T211498 (10MarcoAurelio) [13:15:38] 10Wikidata: Dump(s) of Wikidata instances of Q5 - https://phabricator.wikimedia.org/T211497 (10abian) p:05Triage>03Low [13:15:59] 10Wikidata: Dump(s) of Wikidata classes - https://phabricator.wikimedia.org/T211495 (10abian) p:05Triage>03Low [13:16:40] (03CR) 10Urbanecm: [C: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [13:22:35] 10WMCZ-Tracker, 10Google-Code-in-2018, 10User-Urbanecm, 10goodfirstbug: Move the maximum number of rows ordinary user can import to settings.py - https://phabricator.wikimedia.org/T211486 (10Nathan_fraignt) a:03Nathan_fraignt [13:23:25] (03CR) 10Reedy: "This certainly isn't a blocker to merging the guzzle patch, just a "nice to have" if it'll work" [core] - 10https://gerrit.wikimedia.org/r/477964 (owner: 10Reedy) [13:25:25] (03PS10) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [13:26:40] 10Wikidata: Automatically delete empty Wikidata entities edited by a single user - https://phabricator.wikimedia.org/T211499 (10abian) [13:26:46] 10Wikidata: Automatically delete empty Wikidata entities edited by a single user - https://phabricator.wikimedia.org/T211499 (10abian) p:05Triage>03Lowest [13:27:43] (03CR) 10MarcoAurelio: "The translations have been actually provided by a Neapolitan speaker as referenced in the commit message of this patch. But if you prefer " [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/478441 (https://phabricator.wikimedia.org/T210826) (owner: 10MarcoAurelio) [13:28:23] (03CR) 10Aklapper: [C: 031] Fix typo "#$element" in the OOUI Documentation [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) (owner: 10Zoranzoki21) [13:30:44] (03PS1) 10Fomafix: Add missing dependency on core module 'user.options' [extensions/TwoColConflict] - 10https://gerrit.wikimedia.org/r/478477 [13:31:17] 10MediaWiki-User-login-and-signup, 10MediaWiki-Vendor, 10Security-Reviews: Security review of bjeavons/zxcvbn-php - https://phabricator.wikimedia.org/T211489 (10Reedy) Based on https://github.com/bjeavons/zxcvbn-php/pull/32 (seems a mismatch with the dropbox js version as detailed in https://github.com/bjeav... [13:32:56] 10Wikidata, 10Need-volunteer: Automatically delete empty Wikidata entities edited by a single user - https://phabricator.wikimedia.org/T211499 (10abian) [13:34:31] (03PS1) 10Daimona Eaytoy: Move a method out of AbuseFilter.php [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478478 [13:40:49] 10Wikipedia-Android-App-Backlog: As a user, I want to able to award tokens to articles. - https://phabricator.wikimedia.org/T211460 (10Reedy) Reward who? How? With what? Why? [13:52:24] (03CR) 10Matěj Suchánek: Migrate UserMerge to modern logging system (032 comments) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/461292 (https://phabricator.wikimedia.org/T72836) (owner: 10Matěj Suchánek) [14:00:55] 10Wikidata, 10Wikidata Query UI: Make installations of the WDQS UI identifiable - https://phabricator.wikimedia.org/T211500 (10abian) [14:01:02] (03PS1) 10Fomafix: Add missing dependency on core module 'user.options' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/478479 [14:01:08] 10Wikidata, 10Wikidata Query UI: Make WDQS UI completely configurable for other Wikibase installations - https://phabricator.wikimedia.org/T194175 (10abian) [14:01:10] 10Wikidata, 10Wikidata Query UI: Make installations of the WDQS UI identifiable - https://phabricator.wikimedia.org/T211500 (10abian) [14:01:28] (03CR) 10Urbanecm: [C: 031] "LGTM" [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478466 (https://phabricator.wikimedia.org/T211466) (owner: 10Zoranzoki21) [14:02:56] 10Wikidata, 10Wikidata Query UI: Make installations of the WDQS UI identifiable - https://phabricator.wikimedia.org/T211500 (10abian) [14:11:21] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Ankit-Maity) >>! In T150826#4808282, @Billinghurst wrote: > I tell you what I find truly infu... [14:14:22] (03PS23) 10Matěj Suchánek: Use actor table in AbuseFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445185 (https://phabricator.wikimedia.org/T188180) [14:17:57] (03PS1) 10Urbanecm: Internacionalize example files [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 [14:19:07] 10Phabricator (Upstream), 10Upstream: "Custom Policy" box could provide more informations - https://phabricator.wikimedia.org/T211498 (10Aklapper) {nav icon=certificate, name=Custom Policy} links to a Policy Details page. On that page, you mean the line`Can View: Custom Policy` should be more verbose? [14:21:32] 10MediaWiki-Categories, 10Multimedia, 10UploadWizard: The Category field of UploadWizard doesn't enable to go through the category tree up and down - https://phabricator.wikimedia.org/T177687 (10Aklapper) @Sju: Hi. As you prioritized this task, do you plan to work on fixing this task? If so, please feel free... [14:24:24] (03PS1) 10Nathan fraignt: Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) [14:26:47] (03PS2) 10Shreyasminocha: Internationalize example files [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:29:48] (03CR) 10Nathan fraignt: [C: 031] "Tested. Code LGTM!" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:34:36] 10MediaWiki-extensions-FlaggedRevs, 10Page-Previews: Page Previews should take into account FlaggedRevs' stabilization setting - https://phabricator.wikimedia.org/T211501 (10Jack_who_built_the_house) [14:36:03] (03CR) 10Urbanecm: [C: 032] Internationalize example files [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:36:58] (03CR) 10Takidelfin: Internationalize example files (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:37:02] (03Merged) 10jenkins-bot: Internationalize example files [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:37:52] 10MediaWiki-extensions-FlaggedRevs, 10Page-Previews: Page Previews should take FlaggedRevs' stabilization setting into account - https://phabricator.wikimedia.org/T211501 (10Jack_who_built_the_house) [14:38:52] (03CR) 10Takidelfin: Internationalize example files (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:44:08] (03PS1) 10Nathan fraignt: Fix grammar in messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 [14:45:14] (03CR) 10jerkins-bot: [V: 04-1] Fix grammar in messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [14:45:55] (03PS4) 10Daimona Eaytoy: Add unit tests for stashed edits [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454888 (https://phabricator.wikimedia.org/T201193) [14:46:01] (03PS5) 10Daimona Eaytoy: Add unit tests for profiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455173 (https://phabricator.wikimedia.org/T201193) [14:49:03] (03PS2) 10Nathan fraignt: Fix grammar in messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 [14:50:59] 10MediaWiki-extensions-OATHAuth, 10Patch-For-Review: Degrade/temporarily remove user rights/groups if 2FA isn't enabled - https://phabricator.wikimedia.org/T199118 (10Leaderboard) Not in favour of this change, considering the potential issues with 2FA (5 scratch codes that're displayed one-time? That's too lit... [14:51:49] (03CR) 10Daimona Eaytoy: [C: 04-1] "I'd actually like to investigate again saving old variables in cache (like we do for matched filters, tags etc.), and doing something else" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/423978 (https://phabricator.wikimedia.org/T191430) (owner: 10Daimona Eaytoy) [14:51:52] 10Growth-Team, 10MediaWiki-extensions-OATHAuth, 10Notifications: Users should be notified when only two scratch tokens are left - https://phabricator.wikimedia.org/T131788 (10Leaderboard) A better solution is for MW to just list out the remaining scratch codes left. [14:57:42] (03CR) 10Stibba: Fix grammar in messages in views.py (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [14:58:50] (03CR) 10jerkins-bot: [V: 04-1] Add unit tests for stashed edits [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454888 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [14:59:04] (03CR) 10Nathan fraignt: "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [14:59:13] (03CR) 10jerkins-bot: [V: 04-1] Add unit tests for profiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455173 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [15:00:44] (03CR) 10Nathan fraignt: "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:00:55] (03CR) 10Takidelfin: "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:01:17] (03CR) 10Takidelfin: "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:05:48] (03CR) 10Nathan fraignt: "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:07:20] (03CR) 10Stibba: [C: 031] "You're right, did not know. LGTM." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:08:22] (03CR) 10jerkins-bot: [V: 04-1] Add unit tests for profiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455173 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [15:08:50] (03PS5) 10Daimona Eaytoy: Add unit tests for stashed edits [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454888 (https://phabricator.wikimedia.org/T201193) [15:15:43] (03CR) 10Takidelfin: [C: 031] "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:16:03] (03PS6) 10Daimona Eaytoy: Add unit tests for profiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455173 (https://phabricator.wikimedia.org/T201193) [15:20:54] 10VisualEditor: Broken symlink to lib/ve/.stylelintrc.json - https://phabricator.wikimedia.org/T211502 (10D3r1ck01) [15:21:12] 10WMCZ-Tracker, 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm: Fix CSS violations - https://phabricator.wikimedia.org/T211150 (10takidelfin) a:05Bjornskjald>03takidelfin [15:21:53] 10WMCZ-Tracker, 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm: Fix CSS violations - https://phabricator.wikimedia.org/T211150 (10takidelfin) [15:22:03] (03PS1) 10Takidelfin: Stylelint: Fix stylelint violations [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478483 (https://phabricator.wikimedia.org/T211150) [15:28:27] 10Advanced Mobile Contributions, 10MediaWiki-History-or-Diffs, 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Design): It's not possible to undo edits from the revision history or d... - https://phabricator.wikimedia.org/T191706 [15:28:31] (03PS1) 10D3r1ck01: Fix incorrect return PHPDoc annotation VisualEditorHooks.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478484 [15:28:43] (03PS1) 10Maze: Fixing upload.py script breaking with url and description containing : [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 [15:28:46] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 (owner: 10Maze) [15:30:04] (03CR) 10jerkins-bot: [V: 04-1] Fixing upload.py script breaking with url and description containing : [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 (owner: 10Maze) [15:30:55] (03CR) 10Stibba: "Looks good! In import.html however is still a message that is hard-coded on '100' rows, perhaps that could be adjusted to the set number a" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [15:32:29] 04(no projects): Upload kulturnav: Uppfinnare i Sverige (Tekniska museet) - https://phabricator.wikimedia.org/T211503 (10Salgo60) [15:32:57] 04(no projects): Upload kulturnav: Uppfinnare i Sverige (Tekniska museet) - https://phabricator.wikimedia.org/T211503 (10Salgo60) [15:33:45] 10MediaWiki-Debian, 10MediaWiki-Releasing, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10RazeSoldier) [15:33:47] 10WMSE-Riksarkivet-TORA: Upload kulturnav: Uppfinnare i Sverige (Tekniska museet) - https://phabricator.wikimedia.org/T211503 (10Salgo60) [15:33:49] 10MediaWiki-Vendor, 10MW-1.31-release, 10MW-1.32-notes, 10MW-1.32-release, and 4 others: vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3 - https://phabricator.wikimedia.org/T206975 (10RazeSoldier) 05Open>03Resolved [15:36:02] (03CR) 10Shreyasminocha: [C: 031] Stylelint: Fix stylelint violations [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478483 (https://phabricator.wikimedia.org/T211150) (owner: 10Takidelfin) [15:46:38] (03PS1) 10D3r1ck01: content-providers: Use FormatJson::decode() instead of json_decode() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478486 [15:47:27] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478484 (owner: 10D3r1ck01) [15:50:10] (03PS1) 10Stibba: Remove (random?) 'user: (;;);' at right top of navigation [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478487 [16:02:04] (03PS1) 10D3r1ck01: CPs: MediaWikiServices & Service Wirings in MwApiContentProvider.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478488 [16:03:20] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478486 (owner: 10D3r1ck01) [16:04:58] (03PS2) 10D3r1ck01: CPs: MediaWikiServices & Service Wirings in MwApiContentProvider.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478488 [16:07:07] (03PS3) 10D3r1ck01: CPs: MediaWikiServices & Service Wirings in MwApiContentProvider.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478488 [16:07:36] (03PS4) 10D3r1ck01: MediaWikiServices & Service Wirings in MwApiContentProvider.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478488 [16:13:22] 10WMSE-Riksarkivet-TORA: Upload kulturnav: Uppfinnare i Sverige (Tekniska museet) - https://phabricator.wikimedia.org/T211503 (10Salgo60) 05Open>03Resolved Done see - List of [[ http://tinyurl.com/y8t4v2rm | members uploaded ]] [16:18:41] 10MediaWiki-Categories, 10Multimedia, 10UploadWizard: The Category field of UploadWizard doesn't enable to go through the category tree up and down - https://phabricator.wikimedia.org/T177687 (10SJu) @Aklapper: If nobody is capable to make functionality of UploadWizard at least comparable with the basic uplo... [16:22:47] (03CR) 10Shreyasminocha: [C: 031] "Wonder how this slipped in." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478487 (owner: 10Stibba) [16:35:45] 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Zache) I will assign this to @Dereckson because he was the person who enabled the testing period for 6 months (per T121995 and [[ https://gerrit.wikimedia.org/r/#/c/operations/mediawiki... [16:36:05] 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Zache) a:03Dereckson [16:39:54] (03CR) 10Arcayn: [C: 04-1] "Code LGTM but but the new method for sorting money columns is not only required in ticket_table but also in the grant_detail and grant_lis" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [16:41:49] 10MediaWiki-Categories, 10Multimedia, 10UploadWizard: The Category field of UploadWizard doesn't enable to go through the category tree up and down - https://phabricator.wikimedia.org/T177687 (10Aklapper) p:05High>03Triage That sounds like a valid [meta-level discussion](https://www.mediawiki.org/wiki/Bu... [16:44:20] (03CR) 10KartikMistry: [C: 032] Update jquery.ime from upstream [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/478417 (owner: 10Amire80) [16:45:34] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478488 (owner: 10D3r1ck01) [16:54:57] (03CR) 10Nathan fraignt: "> Patch Set 10: Code-Review-1" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [16:55:06] (03CR) 10Arcayn: "Looks like the patch didnt apply correctly on my machine. I apologise, index.html DOES sort correctly, but my original comments do stand. " [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [16:55:08] (03PS2) 10Urbanecm: Stylelint: Fix stylelint violations [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478483 (https://phabricator.wikimedia.org/T211150) (owner: 10Takidelfin) [16:55:25] (03CR) 10Arcayn: [C: 04-1] "(keeping cr-1 for now)" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [16:55:31] (03CR) 10Urbanecm: [C: 032] Stylelint: Fix stylelint violations [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478483 (https://phabricator.wikimedia.org/T211150) (owner: 10Takidelfin) [16:56:35] (03Merged) 10jenkins-bot: Stylelint: Fix stylelint violations [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478483 (https://phabricator.wikimedia.org/T211150) (owner: 10Takidelfin) [16:56:52] 10WMCZ-Tracker, 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm: Fix CSS violations - https://phabricator.wikimedia.org/T211150 (10Urbanecm) 05Open>03Resolved [16:58:45] (03CR) 10Urbanecm: "> Patch Set 10: -Code-Review" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [16:59:38] (03Merged) 10jenkins-bot: Update jquery.ime from upstream [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/478417 (owner: 10Amire80) [17:01:09] (03PS1) 10Daimona Eaytoy: Simplify static properties in AbuseFilterHooks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478489 [17:01:44] (03CR) 10Nathan fraignt: "> Patch Set 10:" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [17:01:51] (03CR) 10jenkins-bot: Update jquery.ime from upstream [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/478417 (owner: 10Amire80) [17:02:50] (03CR) 10Urbanecm: [C: 032] "> Patch Set 1: Code-Review+1" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478487 (owner: 10Stibba) [17:03:34] (03PS11) 10Nathan fraignt: Fix sorting of dates, (pre)expeditures and wages on ticket and grant tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [17:03:53] (03Merged) 10jenkins-bot: Remove (random?) 'user: (;;);' at right top of navigation [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478487 (owner: 10Stibba) [17:05:19] (03CR) 10Urbanecm: [C: 04-1] "> Patch Set 1:" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [17:10:06] 10WMCZ-Tracker, 10Google-Code-in-2018, 10User-Urbanecm: Upgrade Tracker's JS to ES6 - https://phabricator.wikimedia.org/T211144 (10Urbanecm) Per @takidelfin's request. [17:10:55] 10WMCZ-Tracker, 10Google-Code-in-2018, 10User-Urbanecm: Upgrade Tracker's JS to ES6 - https://phabricator.wikimedia.org/T211144 (10Urbanecm) https://codein.withgoogle.com/tasks/5222886546604032/ [17:12:37] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10ToBeFree) @Billinghurst , one comment above yours: "Allow blocked admins to block the user wh... [17:15:23] 10Growth-Team, 10MediaWiki-extensions-OATHAuth, 10Notifications: Users should be notified when only two scratch tokens are left - https://phabricator.wikimedia.org/T131788 (10Reedy) >>! In T131788#4808465, @Leaderboard wrote: > A better solution is for MW to just list out the remaining scratch codes left. I... [17:15:24] (03CR) 10Arcayn: "grant_list uses the grant_table datatable whereas grant_detail and topic_list both use the topic_table datatable which you might as well a" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [17:15:44] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Ignore null revisions when checking if a non-admin can overwrite a redirect - https://phabricator.wikimedia.org/T211504 (10ToBeFree) p:05Triage>03Lowest [17:16:00] (03PS2) 10Nathan fraignt: Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) [17:16:16] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Do not show a rollback link if all the affected edits are null revisions - https://phabricator.wikimedia.org/T211505 (10ToBeFree) p:05Triage>03Lowest [17:16:34] 10MediaWiki-extensions-OATHAuth, 10Patch-For-Review: Degrade/temporarily remove user rights/groups if 2FA isn't enabled - https://phabricator.wikimedia.org/T199118 (10Reedy) >>! In T199118#4808463, @Leaderboard wrote: > Not in favour of this change, considering the potential issues with 2FA (5 scratch codes th... [17:16:35] (03CR) 10Nathan fraignt: "> Patch Set 1: Code-Review-1" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [17:16:59] 10Growth-Team, 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion, 10Thanks: Thanking for a null revision should cause the same message as thanking for the log entry. - https://phabricator.wikimedia.org/T211506 (10ToBeFree) p:05Triage>03Lowest [17:17:08] (03CR) 10jerkins-bot: [V: 04-1] Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [17:17:23] 10Growth-Team, 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion, 10Thanks: Thanking for a null revision should cause the same message as thanking for the log entry. - https://phabricator.wikimedia.org/T211506 (10ToBeFree) p:05Lowest>03Triage [17:18:10] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Do not show a rollback link if all the affected edits are null revisions - https://phabricator.wikimedia.org/T211505 (10ToBeFree) p:05Lowest>03Triage [17:18:24] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Ignore null revisions when checking if a non-admin can overwrite a redirect - https://phabricator.wikimedia.org/T211504 (10ToBeFree) p:05Lowest>03Triage [17:18:49] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Generate entries for deletions and restores in page histories - https://phabricator.wikimedia.org/T72239 (10ToBeFree) Sub-tasks created. [17:28:11] (03PS3) 10Nathan fraignt: Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) [17:28:43] 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Dereckson) "Although the opinions are mixed about its positive/negative impact, that is clear it should be reverted." I've some difficulties with this concept. How can a thing could be... [17:30:42] (03CR) 10Esanders: [C: 04-1] ConfirmEdit: Support No CAPTCHA reCAPTCHA (032 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [17:31:29] 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Bencemac) Because we voted for a test period/temporary time, but currently this is the default settings. [17:35:17] (03CR) 10Esanders: [C: 04-1] ConfirmEdit: Support No CAPTCHA reCAPTCHA (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [17:36:49] 10ContentTranslation: CX2: MT abuse warning shown when draft is loaded - https://phabricator.wikimedia.org/T211507 (10Petar.petkovic) [17:47:00] (03CR) 10Esanders: [C: 04-1] ConfirmEdit: Support No CAPTCHA reCAPTCHA (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [17:54:24] 10WMF-Design, 10Wikimedia Design Style Guide, 10CSS, 10Design: Align the image on the Design Landing Page - https://phabricator.wikimedia.org/T197140 (10Iniquity) @Volker_E hm, so, Is it necessary to move this image too? {F27458071} [17:56:42] 10Commons, 10Wikimedia-Site-requests: Please add iCloud.com and other online storage hosts to the wgCopyUploadsDomains whitelist of Wikimedia Commons - https://phabricator.wikimedia.org/T211464 (10Dereckson) From a security point of view, the idea of the whitelist is: * to avoid to DDoS external networks from... [17:59:07] 10WMCZ-Tracker, 10Goal, 10User-Urbanecm: Allow users to enter photographs easily - https://phabricator.wikimedia.org/T211508 (10Urbanecm) [17:59:52] 10WMCZ-Tracker: Allow ordinary users to view their own TrackerProfile - https://phabricator.wikimedia.org/T211509 (10Urbanecm) [18:00:55] (03CR) 10Krinkle: [C: 032] [tests] Ensure only existing wikis are referenced from IS.php (031 comment) [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) (owner: 10Urbanecm) [18:01:06] (03PS1) 10Urbanecm: Add a way how to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:02:02] (03CR) 10jerkins-bot: [V: 04-1] Add a way how to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:02:27] (03PS2) 10Urbanecm: Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:02:50] (03CR) 10Krinkle: [C: 032] [typo] Use ruwikinews instead of ruwikivnews [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478476 (owner: 10Urbanecm) [18:03:23] (03CR) 10jerkins-bot: [V: 04-1] Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:04:01] (03Merged) 10jenkins-bot: [typo] Use ruwikinews instead of ruwikivnews [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478476 (owner: 10Urbanecm) [18:04:03] (03Merged) 10jenkins-bot: [tests] Ensure only existing wikis are referenced from IS.php [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) (owner: 10Urbanecm) [18:04:09] (03PS3) 10Urbanecm: Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:04:51] (03PS4) 10Urbanecm: Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:06:03] (03CR) 10jerkins-bot: [V: 04-1] Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:07:28] (03CR) 10Takidelfin: "Added Jenkins output from flake8" (032 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:07:30] (03CR) 10Arcayn: "Will let urbanecm decide whether this should affect cr" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [18:08:31] 10WMCZ-Tracker: addexampledata should create tickets with only self-generated users in requested_user field - https://phabricator.wikimedia.org/T211510 (10Urbanecm) [18:09:10] (03CR) 10jenkins-bot: [typo] Use ruwikinews instead of ruwikivnews [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478476 (owner: 10Urbanecm) [18:09:25] (03CR) 10jenkins-bot: [tests] Ensure only existing wikis are referenced from IS.php [mediawiki-config] - 10https://gerrit.wikimedia.org/r/467448 (https://phabricator.wikimedia.org/T115138) (owner: 10Urbanecm) [18:10:18] (03PS5) 10Urbanecm: Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:16:40] (03PS1) 10Urbanecm: Add migration to properly propagate new TrackerProfile Meta class [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478491 [18:16:52] (03CR) 10Urbanecm: [C: 032] Add migration to properly propagate new TrackerProfile Meta class [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478491 (owner: 10Urbanecm) [18:17:52] (03Merged) 10jenkins-bot: Add migration to properly propagate new TrackerProfile Meta class [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478491 (owner: 10Urbanecm) [18:19:23] (03PS6) 10Urbanecm: Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:25:06] 10MediaWiki-Debug-Logger, 10Continuous-Integration-Config, 10Patch-For-Review: Log suppressed errors with level=DEBUG - https://phabricator.wikimedia.org/T193472 (10Tgr) Current WMF config discards error-json entirely. I see your point about this change being problematic with the default config (it does see... [18:26:53] 10MediaWiki-extensions-JsonConfig: Content for temporary working copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 (10jeblad) 1. Feel free to figure out how to reproduce, I can't even get this behavior to go away. 2. An empty edit window, there are... [18:31:26] (03PS1) 10Urbanecm: Add system description field to tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478492 (https://phabricator.wikimedia.org/T211508) [18:32:16] 10Operations, 10Security-Team, 10Security: Fetching ORES API from en.wikipedia.org blocked in debug mode - https://phabricator.wikimedia.org/T211511 (10Krinkle) [18:32:20] 10Operations, 10Security-Team, 10Security: Fetching ORES API from en.wikipedia.org blocked in debug mode - https://phabricator.wikimedia.org/T211511 (10Krinkle) [18:32:29] 10Operations, 10Security-Team: Fetching ORES API from en.wikipedia.org blocked in debug mode - https://phabricator.wikimedia.org/T211511 (10Krinkle) [18:33:28] 10MediaWiki-Debug-Logger, 10Continuous-Integration-Config, 10Patch-For-Review: Log suppressed errors with level=DEBUG - https://phabricator.wikimedia.org/T193472 (10Krinkle) @Tgr That seems fine by me as a first step (separate channel). [18:34:25] 10MediaWiki-extension-requests, 10Patch-For-Review, 10Performance-Team (Radar): Develop an easy way for wikis to create a blackout protest - https://phabricator.wikimedia.org/T198890 (10Krinkle) [18:36:26] (03PS12) 10Nathan fraignt: Fix sorting of dates, (pre)expeditures and wages on all tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [18:36:59] (03CR) 10Nathan fraignt: "> Patch Set 11:" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [18:37:11] 10Operations: "sql" command fails with "sh: 1: mysql: not found" on mwdebug1002 - https://phabricator.wikimedia.org/T211512 (10Krinkle) [18:37:24] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates, (pre)expeditures and wages on all tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [18:38:59] (03PS6) 10Daimona Eaytoy: [WIP] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [18:41:08] (03CR) 10Nathan fraignt: "recheck" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [18:41:54] (03Abandoned) 10Urbanecm: Add system description field to tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478492 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:43:44] 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Tgr) >>! In T210224#4808558, @Bencemac wrote: > Because we voted for a test period/temporary time, not for default (currently this is the default setting). Actually we voted to test it... [18:46:57] (03CR) 10Esanders: [C: 032] ve.init.mw.TitleBlacklistSaveErrorHandler: Disallow retrying [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478238 (owner: 10Bartosz Dziewoński) [18:50:37] (03CR) 10Arcayn: [C: 031] "lgtm, great work" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [18:53:21] (03Merged) 10jenkins-bot: ve.init.mw.TitleBlacklistSaveErrorHandler: Disallow retrying [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478238 (owner: 10Bartosz Dziewoński) [18:53:38] 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10PHP 7.0 support: Confirm that post-send functions work fine with mediawiki under PHP 7 - https://phabricator.wikimedia.org/T209981 (10Krinkle) @BPirkle That might be a problem. It is already a source of uncertainty to me whether our e... [18:55:19] (03CR) 10jenkins-bot: ve.init.mw.TitleBlacklistSaveErrorHandler: Disallow retrying [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478238 (owner: 10Bartosz Dziewoński) [18:56:58] 10Performance-Team, 10Patch-For-Review, 10Performance-Team-notice, 10Security: Careless use of $wgExternalLinkTarget is insecure - https://phabricator.wikimedia.org/T133507 (10Krinkle) [18:57:09] 10Growth-Team: Help Panel: Show search link content and help link content inside help panel - https://phabricator.wikimedia.org/T211513 (10kostajh) [18:58:11] 10Performance-Team, 10Patch-For-Review, 10Performance-Team-notice, 10Security: Careless use of $wgExternalLinkTarget is insecure - https://phabricator.wikimedia.org/T133507 (10Krinkle) [19:00:34] (03PS1) 10Arcayn: Fix the grant_detail breadcrumb [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478493 [19:02:15] (03PS4) 10Krinkle: Special:AllMessages: Improve zebra striping on hover [core] - 10https://gerrit.wikimedia.org/r/473247 (owner: 10Bartosz Dziewoński) [19:08:46] (03CR) 10Kosta Harlan: [C: 032] Help panel: Make sure "view more" link is localized [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478376 (owner: 10Catrope) [19:10:22] (03PS10) 10Esanders: [WIP] Special:Preferences (OOUI): Re-design the view-only "basic" section [core] - 10https://gerrit.wikimedia.org/r/458626 (https://phabricator.wikimedia.org/T203727) (owner: 10Jforrester) [19:12:22] 10WMF-NDA-Requests: Volunteer NDA for Daimona - https://phabricator.wikimedia.org/T211042 (10MusikAnimal) [19:12:34] (03Merged) 10jenkins-bot: Help panel: Make sure "view more" link is localized [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478376 (owner: 10Catrope) [19:14:00] (03PS5) 10Krinkle: Special:AllMessages: Improve zebra striping on hover [core] - 10https://gerrit.wikimedia.org/r/473247 (owner: 10Bartosz Dziewoński) [19:14:02] (03PS1) 10Krinkle: Special:AllMessages: Remove 'id' attribute from message rows [core] - 10https://gerrit.wikimedia.org/r/478494 [19:14:16] (03CR) 10jenkins-bot: Help panel: Make sure "view more" link is localized [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478376 (owner: 10Catrope) [19:14:40] (03CR) 10Krinkle: "@Volker: I've removed a few hundred bytes (about 2x as much as this one introduces) with I53bd56e0d5a82fba65388e1c2da3c8349a138261. I thin" [core] - 10https://gerrit.wikimedia.org/r/473247 (owner: 10Bartosz Dziewoński) [19:15:48] (03CR) 10Krinkle: Special:AllMessages: Remove 'id' attribute from message rows (031 comment) [core] - 10https://gerrit.wikimedia.org/r/478494 (owner: 10Krinkle) [19:15:58] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Tgr) >>! In T150826#4808282, @Billinghurst wrote: > 1) A solution to a problem at enWP became... [19:16:39] 10MediaWiki-User-preferences, 10UI-Standardization, 10Patch-For-Review: Restructure and improve 'Basic information' section - https://phabricator.wikimedia.org/T203727 (10Esanders) What does "View global account info" do? [19:17:36] (03CR) 10Krinkle: [C: 04-1] "The special-casing on the client seems fine (although I'm not a 100% sure yet), but I would prefer for the server-side code to remain agno" [core] - 10https://gerrit.wikimedia.org/r/470181 (owner: 10Bartosz Dziewoński) [19:18:33] (03CR) 10Kosta Harlan: [C: 032] "Thanks for this." (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478379 (owner: 10Catrope) [19:19:48] 10VisualEditor: Broken symlink to lib/ve/.stylelintrc.json - https://phabricator.wikimedia.org/T211502 (10Esanders) There is a file in lib/ve/, but I don't know why this needs to be a symlink... [19:20:14] (03CR) 10jenkins-bot: Help panel: Factor out help panel link generation into its own function [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478379 (owner: 10Catrope) [19:23:43] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Special:Preferences (OOUI): Re-design the view-only "basic" section [core] - 10https://gerrit.wikimedia.org/r/458626 (https://phabricator.wikimedia.org/T203727) (owner: 10Jforrester) [19:23:50] (03CR) 10Kosta Harlan: [C: 032] Help panel: Move config vars into a data module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478381 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:24:23] 10Huggle: Deleting a subpage (Page/bla) removes the talk page of root page (Talk:Page) as associated talk page instead of Talk:Page/bla - https://phabricator.wikimedia.org/T203385 (10Petrb) 05Open>03Resolved [19:24:58] 10Huggle: sort out MacOS keystroke bug - https://phabricator.wikimedia.org/T210604 (10Petrb) 05Open>03Resolved a:03Petrb this actually seems to be resolved in Qt 5.12 [19:25:40] 10Huggle: Release huggle 3.4.5 - https://phabricator.wikimedia.org/T204034 (10Petrb) [19:26:31] 10Pywikibot, 10Pywikibot-replace.py, 10Patch-For-Review: Update Arabic (ar) for fixes.py (Patch against Pywikibot core included) - https://phabricator.wikimedia.org/T211492 (10Meno25) [19:27:58] (03Merged) 10jenkins-bot: Help panel: Move config vars into a data module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478381 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:28:52] (03PS4) 10Kosta Harlan: Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:29:00] 10VisualEditor: Broken symlink to lib/ve/.stylelintrc.json - https://phabricator.wikimedia.org/T211502 (10D3r1ck01) On the root of VisualEditor (repo), here is a symlink (with name `.stylelinkrc.json`) I see; {F27459124} The symlink points to a file in `lib/ve/.stylelintrc.json` but when I access this director... [19:29:40] (03CR) 10jenkins-bot: Help panel: Move config vars into a data module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478381 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:32:13] 10Operations: "sql" command fails with "sh: 1: mysql: not found" on mwdebug1002 - https://phabricator.wikimedia.org/T211512 (10Marostegui) I don't know if it used to work on the old hosts. MySQL client isn't installed there - not sure if it used to be and "got lost" when migrating to stretch. [19:34:20] 10JSDoc WMF theme, 10Google-Code-in-2018, 10Patch-For-Review: Remove the redundant Class:* heading from the page - https://phabricator.wikimedia.org/T207381 (10Stibba) 05Open>03Resolved [19:34:41] 10MediaWiki-User-login-and-signup, 10Security: No way to force a user to change their password if it's invalid - https://phabricator.wikimedia.org/T118774 (10Tgr) Logging skips would probably be a good start, we don't seem to be doing that now. (Or are we worried that it might highlight who have vulnerable pas... [19:38:30] (03CR) 10Kosta Harlan: [C: 032] Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:41:13] 10Cloud-Services, 10Horizon: Stop requiring two-factor authentication for horizon.wikimedia.org - https://phabricator.wikimedia.org/T161473 (10Tgr) Related: {T189531} [19:42:15] (03Merged) 10jenkins-bot: Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:44:04] (03CR) 10jenkins-bot: Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:48:55] (03PS1) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 [19:49:35] (03CR) 10Bartosz Dziewoński: [C: 032] "It used to be that hook handlers had to return true or false, but void return value is also okay since a few MediaWiki versions ago. The d" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478484 (owner: 10D3r1ck01) [19:49:53] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (owner: 10Urbanecm) [19:49:59] (03PS2) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [19:50:54] (03CR) 10D3r1ck01: "> It used to be that hook handlers had to return true or false, but void return value is also okay since a few MediaWiki versions ago. The" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478484 (owner: 10D3r1ck01) [19:50:57] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [19:51:01] (03PS3) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [19:51:32] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) [19:51:38] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) [19:52:02] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [19:52:09] 10MediaWiki-User-login-and-signup: Consider displaying a tooltip by the password input field to explain password requirements - https://phabricator.wikimedia.org/T211440 (10Tgr) A tooltip (if you mean in the traditional sense, ie. something shown on hover) does not seem useful as people have no reason to hover o... [19:52:39] 10MediaWiki-User-login-and-signup, 10Security, 10User-Tgr: Add password generator to account creation / password change form - https://phabricator.wikimedia.org/T151011 (10Tgr) [19:53:05] 10MediaWiki-User-login-and-signup, 10MediaWiki-User-preferences, 10Patch-For-Review, 10Performance-Team (Radar), 10User-Tgr: Display a password strength bar - https://phabricator.wikimedia.org/T32574 (10Tgr) [19:54:02] (03PS4) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [19:54:39] (03CR) 10Nouman: ConfirmEdit: Support No CAPTCHA reCAPTCHA (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [19:54:43] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Help panel: implement support for VE and MobileFrontend - https://phabricator.wikimedia.org/T211059 (10kostajh) @Catrope looks good! Moving back to "Ready for development" to implement the MobileFrontend bit. We'll... [19:54:59] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [19:56:09] 10Phabricator (Upstream), 10Upstream: "Custom Policy" box could provide more informations - https://phabricator.wikimedia.org/T211498 (10MarcoAurelio) Yes, that's it. Thanks. [19:56:51] 10Growth-Team, 10StructuredDiscussions, 10VisualEditor: Flow widgets lose focus styling after using an inspector - https://phabricator.wikimedia.org/T211515 (10Esanders) [19:57:10] (03PS5) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [19:58:08] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [20:01:18] 10VisualEditor, 10VisualEditor-CopyPaste: Error pasting nested lists from macOS Notes app - https://phabricator.wikimedia.org/T211516 (10cllu) [20:01:54] 10MediaWiki-User-login-and-signup, 10MediaWiki-Vendor, 10Security-Reviews: Security review of bjeavons/zxcvbn-php - https://phabricator.wikimedia.org/T211489 (10Tgr) Although the discussion there gives the impression that the bjeavons version actually does a better job. And the last commit to the Dropbox rep... [20:02:08] 10VisualEditor, 10VisualEditor-CopyPaste: Error pasting nested lists from macOS Notes app - https://phabricator.wikimedia.org/T211516 (10cllu) [20:03:46] (03Merged) 10jenkins-bot: Fix incorrect return PHPDoc annotation VisualEditorHooks.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478484 (owner: 10D3r1ck01) [20:03:52] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) See also T32574#4446825. [20:06:05] (03CR) 10jenkins-bot: Fix incorrect return PHPDoc annotation VisualEditorHooks.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478484 (owner: 10D3r1ck01) [20:06:48] 10WMCZ-Tracker: Allow ordinary users to view their own TrackerProfile - https://phabricator.wikimedia.org/T211509 (10Nathan_fraignt) MediaWiki username is also visible on the preferences page. [20:08:03] 10WMCZ-Tracker: Allow ordinary users to view their own TrackerProfile - https://phabricator.wikimedia.org/T211509 (10Urbanecm) [20:09:07] 10WMCZ-Tracker: Allow ordinary users to view their own TrackerProfile - https://phabricator.wikimedia.org/T211509 (10Urbanecm) Sorry, I wrote the description in a confusing way. I meant that it isn't possible to get the username in JavaScript code easily (I don't take scrapping preferences page as an easy way). [20:10:13] 10WMCZ-Tracker: Allow ordinary users to view their own TrackerProfile - https://phabricator.wikimedia.org/T211509 (10Nathan_fraignt) True. I thought you meant that it was impossible to see their username in general. [20:12:25] (03PS6) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [20:13:26] (03CR) 10Nathan fraignt: [C: 031] Fix the grant_detail breadcrumb [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478493 (owner: 10Arcayn) [20:13:42] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [20:14:18] (03PS1) 10Esanders: build: Update stylelint-config-wikimedia to 0.5.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478496 [20:15:35] 10Core Platform Team, 10Operations, 10ops-codfw, 10Services (doing), and 2 others: Reshape RESTBase Cassandra cluster for server refresh - https://phabricator.wikimedia.org/T210843 (10Eevans) [20:15:41] (03PS7) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [20:17:25] 10Parsoid-PHP, 10Patch-For-Review: Use lambda functions instead of .bind - https://phabricator.wikimedia.org/T205336 (10ssastry) 05Open>03Resolved a:03ssastry [20:22:37] (03PS1) 10Chunliang Lyu: Fix paste issue for nested lists from macOS Notes app [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/478497 (https://phabricator.wikimedia.org/T211516) [20:22:39] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/478497 (https://phabricator.wikimedia.org/T211516) (owner: 10Chunliang Lyu) [20:28:28] (03CR) 10Urbanecm: [C: 032] Fix sorting of dates, (pre)expeditures and wages on all tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [20:29:02] 10Huggle: Release huggle 3.4.5 - https://phabricator.wikimedia.org/T204034 (10Petrb) [20:29:19] 10Huggle: Release huggle 3.4.5 - https://phabricator.wikimedia.org/T204034 (10Petrb) Funnily enough I found a critical bug so release 3.4.6 right now [20:29:29] (03Merged) 10jenkins-bot: Fix sorting of dates, (pre)expeditures and wages on all tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [20:30:04] 04(no projects): Release Huggle 3.4.6 - https://phabricator.wikimedia.org/T211517 (10Petrb) [20:30:22] 10Huggle: Release Huggle 3.4.6 - https://phabricator.wikimedia.org/T211517 (10Petrb) a:03Petrb [20:31:10] (03PS2) 10Chunliang Lyu: Fix paste issue for nested lists from macOS Notes app [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/478497 (https://phabricator.wikimedia.org/T211516) [20:36:22] (03CR) 10Chunliang Lyu: "Would you help review this fix for nested lists from macOS Notes? Let me know if any further changes are required. Thanks." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/478497 (https://phabricator.wikimedia.org/T211516) (owner: 10Chunliang Lyu) [20:36:33] (03CR) 10Urbanecm: [C: 032] Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [20:37:40] (03Merged) 10jenkins-bot: Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [20:38:14] 10WMCZ-Tracker, 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm, 10goodfirstbug: Move the maximum number of rows ordinary user can import to settings.py - https://phabricator.wikimedia.org/T211486 (10Urbanecm) 05Open>03Resolved [20:39:40] (03PS1) 10Robingan7: Add logos. [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478498 [20:39:42] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478498 (owner: 10Robingan7) [20:46:09] 10VisualEditor: Make removal of image in Visual Editor possible - https://phabricator.wikimedia.org/T211518 (10Effeietsanders) [20:51:03] (03PS1) 10Esanders: Use VE focus/blur events for styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478499 (https://phabricator.wikimedia.org/T211515) [20:55:44] 10Huggle: Internal editor removes nbsp Unicode symbols - https://phabricator.wikimedia.org/T200637 (10Petrb) [20:55:46] 10Huggle: Release huggle 3.4.5 - https://phabricator.wikimedia.org/T204034 (10Petrb) 05Open>03Resolved a:03Petrb [20:55:48] (03PS1) 10Esanders: Remove unused mw-ui-field classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478501 [20:55:57] 10Huggle: Release Huggle 3.4.6 - https://phabricator.wikimedia.org/T211517 (10Petrb) p:05Triage>03Unbreak! [20:58:36] 10Huggle: Release Huggle 3.4.6 - https://phabricator.wikimedia.org/T211517 (10Petrb) [20:58:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/478500 (owner: 10L10n-bot) [20:59:07] (03CR) 10Esanders: "Thanks for this! Could you add a test case to ve.ce.Surface.test.js, similar to the Google Docs case you are fixing (line 2103)?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/478497 (https://phabricator.wikimedia.org/T211516) (owner: 10Chunliang Lyu) [20:59:42] (03PS5) 10Nouman: ConfirmEdit: Support No CAPTCHA reCAPTCHA [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) [20:59:45] 10VisualEditor-CopyPaste, 10Patch-For-Review, 10VisualEditor (Current work): Error pasting nested lists from macOS Notes app - https://phabricator.wikimedia.org/T211516 (10Esanders) [21:00:00] 10WMCZ-Tracker, 10Google-Code-in-2018, 10User-Urbanecm: addexampledata should create tickets with only self-generated users in requested_user field - https://phabricator.wikimedia.org/T211510 (10Urbanecm) https://codein.withgoogle.com/tasks/6523125417115648/ [21:02:29] (03CR) 10Nouman: ConfirmEdit: Support No CAPTCHA reCAPTCHA (034 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [21:17:06] 10Developer-Advocacy (Oct-Dec 2018), 10Google-Code-in-2018: Google Code-in 2018: Collect Feedback and Lessons Learned - https://phabricator.wikimedia.org/T205328 (10Ebe123) Some quick comments to jot down * Section 4.2 of the rules should be clarified either for GCI as a whole or for an org interpretation. (T2... [21:18:36] 10ContentTranslation, 10VisualEditor-ContentEditable, 10Patch-For-Review, 10VisualEditor (Current work): "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10Esanders) Part of the issue is that the infobox has no height because it is float:right, that is why the befor... [21:22:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/478502 (owner: 10L10n-bot) [21:23:34] 10MediaWiki-User-login-and-signup, 10Security, 10User-Tgr: Add password generator to account creation / password change form - https://phabricator.wikimedia.org/T151011 (10Tgr) There are two types of good password generation: # A medium-length string of random uppercase/lowercase/numbers (say 12 or 16 charac... [21:23:54] 10Math, 10Mathoid, 10Browser-Support-Apple-Safari: SVG-Fallback of MathML does not show umlauts in Safari 9.0.3 - https://phabricator.wikimedia.org/T130967 (10Pkra) @Kulla I think (though I may be wrong) that T50032 is a broader tracking issue that covers various input and output issues around complex scripts. [21:24:13] (03PS1) 10Daniel Kinzler: Print chained exceptions when maintenance script fails. [core] - 10https://gerrit.wikimedia.org/r/478503 [21:26:56] 10MediaWiki-extensions-Translate: MW with translation extension (meta.wikimedia.org) sometimes fails to open proper section on [edit source] of section - https://phabricator.wikimedia.org/T211519 (10Petrb) [21:27:10] (03CR) 10CRusnov: Add "Coherence" check (033 comments) [software/netbox-reports] - 10https://gerrit.wikimedia.org/r/478458 (owner: 10CRusnov) [21:27:27] (03PS1) 10Nathan fraignt: Fix: addexampledata only generates tickets with example users. [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478504 (https://phabricator.wikimedia.org/T211510) [21:27:31] 10VisualEditor, 10VisualEditor-ContentEditable: Come up with an alternative to having multiple slugs (invitations to add a paragraph) next to each other that preserves editing capabilities - https://phabricator.wikimedia.org/T107745 (10Esanders) > Detect when there are several elements in a row and show the in... [21:27:34] (03CR) 10CRusnov: Add "Coherence" check (031 comment) [software/netbox-reports] - 10https://gerrit.wikimedia.org/r/478458 (owner: 10CRusnov) [21:28:13] 10Huggle: Release Huggle 3.4.6 - https://phabricator.wikimedia.org/T211517 (10Petrb) [21:30:56] (03PS2) 10Robingan7: Add logos. [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478498 [21:32:35] 10Parsing-Team, 10Cloud-VPS (Ubuntu Trusty Deprecation): cloudvps: wikitextexp project trusty deprecation - https://phabricator.wikimedia.org/T204566 (10ssastry) The results are good. http://mw-expt-tests.wmflabs.org/ -- the failures are known issues with either db import and/or transient failures .. some of w... [21:34:54] 10WMCZ-Tracker, 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm: addexampledata should create tickets with only self-generated users in requested_user field - https://phabricator.wikimedia.org/T211510 (10Nathan_fraignt) a:03Nathan_fraignt [21:40:20] 10Goatification, 10International-Developer-Events, 10Wikimedia-Technical-Conference-2018, 10Google-Code-in-2018: GCI: Racconicorn Racoonmendations Sticker - https://phabricator.wikimedia.org/T207973 (10Stibba) {F27460155} [21:42:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AdvancedSearch] - 10https://gerrit.wikimedia.org/r/478506 (owner: 10L10n-bot) [21:43:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/478558 (owner: 10L10n-bot) [21:43:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/478511 (owner: 10L10n-bot) [21:44:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478551 (owner: 10L10n-bot) [21:46:00] 10Commons, 10Wikimedia-Site-requests: Please add iCloud.com and other online storage hosts to the wgCopyUploadsDomains whitelist of Wikimedia Commons - https://phabricator.wikimedia.org/T211464 (10Framawiki) Related: {T210330} [21:47:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478508 (owner: 10L10n-bot) [21:49:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Babel] - 10https://gerrit.wikimedia.org/r/478513 (owner: 10L10n-bot) [21:50:43] 10VisualEditor, 10VisualEditor-ContentEditable: Come up with an alternative to having multiple slugs (invitations to add a paragraph) next to each other that preserves editing capabilities - https://phabricator.wikimedia.org/T107745 (10Esanders) I think any proper solution to this requires a big re-think of bl... [21:51:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/478510 (owner: 10L10n-bot) [21:51:30] 10VisualEditor, 10VisualEditor-ContentEditable: Come up with an alternative to having multiple slugs (invitations to add a paragraph) next to each other that preserves editing capabilities - https://phabricator.wikimedia.org/T107745 (10Esanders) > For images we can guess that an image is floated using data in... [21:53:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/478520 (owner: 10L10n-bot) [21:54:06] (03CR) 10Urbanecm: [C: 032] Fix: addexampledata only generates tickets with example users. [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478504 (https://phabricator.wikimedia.org/T211510) (owner: 10Nathan fraignt) [21:55:13] (03Merged) 10jenkins-bot: Fix: addexampledata only generates tickets with example users. [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478504 (https://phabricator.wikimedia.org/T211510) (owner: 10Nathan fraignt) [21:56:09] 10WMCZ-Tracker, 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm: addexampledata should create tickets with only self-generated users in requested_user field - https://phabricator.wikimedia.org/T211510 (10Urbanecm) 05Open>03Resolved [21:58:09] (03PS3) 10Robingan7: Add logos. [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478498 [21:58:37] 10Cloud-Services, 10Horizon: Stop requiring two-factor authentication for horizon.wikimedia.org - https://phabricator.wikimedia.org/T161473 (10Krenair) Suggest decline per @chasemp, horizon by nature allows unrevertable actions and should definitely require 2FA for the majority of use cases. I would accept a l... [21:58:39] 10WMCZ-Tracker: Use REST API instead of non-standard pseudo-API - https://phabricator.wikimedia.org/T211521 (10Urbanecm) [22:00:37] 10WMCZ-Tracker, 10Patch-For-Review: It isn't possible to order on page of any individual ticket - https://phabricator.wikimedia.org/T211280 (10Urbanecm) 05Open>03Resolved [22:00:57] 10WMCZ-Tracker: Tests in Tracker fail from time to time from non-obvious reason - https://phabricator.wikimedia.org/T207310 (10Urbanecm) p:05High>03Low Not high priority anymore, as it doesn't break anything. [22:01:15] (03CR) 10Ebe123: [C: 04-1] "Should be frwikinews-2x.png, testwiki-1.5x.png, frwikinews-1.5x.png, testwiki-2x.png" [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478498 (owner: 10Robingan7) [22:02:42] (03CR) 10Prtksxna: [C: 04-2] "Hey Zoranzoki, sorry for the delayed response. The patchset is correct but you've made it in the wrong repository. The mediawiki repositor" [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) (owner: 10Zoranzoki21) [22:04:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478518 (owner: 10L10n-bot) [22:05:31] (03PS18) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [22:06:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478528 (owner: 10L10n-bot) [22:08:18] 10JSDoc WMF theme, 10Google-Code-in-2018, 10Patch-For-Review: Remove the redundant Class:* heading from the page - https://phabricator.wikimedia.org/T207381 (10Prtksxna) Thanks for your work on this, @Stibba {icon smile-o} [22:09:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/478523 (owner: 10L10n-bot) [22:13:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/478530 (owner: 10L10n-bot) [22:14:37] (03PS4) 10Robingan7: Add logos. [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478498 [22:15:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/FileImporter] - 10https://gerrit.wikimedia.org/r/478529 (owner: 10L10n-bot) [22:18:30] (03PS1) 10Urbanecm: [notifications] Internationalize subject [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478565 [22:20:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478531 (owner: 10L10n-bot) [22:21:11] 10WMCZ-Tracker: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10Urbanecm) [22:21:33] 10WMCZ-Tracker: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10Urbanecm) p:05Triage>03High [22:22:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478532 (owner: 10L10n-bot) [22:23:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/478536 (owner: 10L10n-bot) [22:27:04] (03PS3) 10Bjornskjald: Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) [22:27:11] (03CR) 10jerkins-bot: [V: 04-1] Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [22:27:41] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/JADE] - 10https://gerrit.wikimedia.org/r/478535 (owner: 10L10n-bot) [22:28:23] (03CR) 10Urbanecm: [C: 032] [notifications] Internationalize subject [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478565 (owner: 10Urbanecm) [22:29:00] (03PS5) 10Robingan7: Add logos. [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478498 [22:29:16] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10Core Platform Team Backlog (Watching / External), 10Technical-Debt: Audit and simplify MediaWiki initialisation code (Spring 2018) - https://phabricator.wikimedia.org/T189966 (10Krinkle) a:05Krinkle>03None Un-assigning for now as this isn't current... [22:29:21] (03Merged) 10jenkins-bot: [notifications] Internationalize subject [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478565 (owner: 10Urbanecm) [22:30:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478540 (owner: 10L10n-bot) [22:30:39] 10WMCZ-Tracker: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10takidelfin) a:03takidelfin [22:30:50] 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Zoranzoki21: Remove FlaggedRevs for ptwikipedia - https://phabricator.wikimedia.org/T211433 (10Guilhermebm) >>! In T211433#4808254, @Zoranzoki21 wrote: >>>! In T211433#4807955, @Guilhermebm wrote: >> Hello, @Zoranzoki21 . I don't know. What would happen i... [22:32:38] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Help Panel: Enable on beta labs - https://phabricator.wikimedia.org/T211206 (10kostajh) > the asterisk is not present until 'Review and submit' is clicked - should we co... [22:32:59] (03PS1) 10Urbanecm: [bugfix] Some notifications were always in English [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478566 [22:33:15] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) [22:33:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/478538 (owner: 10L10n-bot) [22:34:23] (03CR) 10Gergő Tisza: "This should be good to go barring security review of the library, but I feel the UX is not great and I would personally not enable somethi" [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [22:35:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478553 (owner: 10L10n-bot) [22:35:14] (03CR) 10Dvorapa: [C: 04-1] "Two comments here, but these are not important much. Have you tested your patch? I don't believe it is working (":" is excluded 20 lines a" (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 (owner: 10Maze) [22:35:42] (03PS1) 10QChris: Add .gitreview [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/478567 [22:35:44] (03CR) 10QChris: [V: 032 C: 032] Add .gitreview [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/478567 (owner: 10QChris) [22:36:06] (03PS6) 10Robingan7: Add logos. [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478498 [22:36:30] (03CR) 10Gergő Tisza: Add a password strength policy to validate the password (031 comment) [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [22:37:02] 10Cloud-VPS (Project-requests): Request creation of VPS project - https://phabricator.wikimedia.org/T211523 (10Videowiki123) [22:37:19] (03CR) 10Dvorapa: [C: 04-1] "Or maybe I'm wrong, let's check it again" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 (owner: 10Maze) [22:37:25] (03CR) 10Dvorapa: [C: 04-1] "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 (owner: 10Maze) [22:37:27] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/478549 (owner: 10L10n-bot) [22:37:42] 10Beta-Cluster-Infrastructure: Unable to access en/ko.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T211524 (10kostajh) [22:37:58] (03PS2) 10Dvorapa: Fixing upload.py script breaking with url and description containing : [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 (owner: 10Maze) [22:38:21] (03CR) 10Dvorapa: [C: 031] "I see, you added blank lines to the end of the file. Seems ok to me finally" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 (owner: 10Maze) [22:39:45] (03CR) 10jerkins-bot: [V: 04-1] Fixing upload.py script breaking with url and description containing : [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 (owner: 10Maze) [22:39:54] (03CR) 10Krinkle: redirects.dat - split non-canonical to separate section (031 comment) [puppet] - 10https://gerrit.wikimedia.org/r/292785 (https://phabricator.wikimedia.org/T133548) (owner: 10BBlack) [22:39:57] (03CR) 10Urbanecm: [C: 032] [bugfix] Some notifications were always in English [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478566 (owner: 10Urbanecm) [22:40:09] (03CR) 10Krinkle: [C: 04-1] "potential mistake, at least inconsistent with docs." [puppet] - 10https://gerrit.wikimedia.org/r/292785 (https://phabricator.wikimedia.org/T133548) (owner: 10BBlack) [22:40:42] (03PS3) 10Dvorapa: [bugfix] Fix upload.py breaking with url and description containing ":" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 (owner: 10Maze) [22:41:07] (03Merged) 10jenkins-bot: [bugfix] Some notifications were always in English [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478566 (owner: 10Urbanecm) [22:42:48] 10MediaWiki-User-login-and-signup, 10MediaWiki-User-preferences, 10Patch-For-Review, 10Performance-Team (Radar), 10User-Tgr: Display a password strength bar - https://phabricator.wikimedia.org/T32574 (10Tgr) I feel using zxcvbn as a standard password policy check is not good UX. One issue is that it can... [22:43:57] 10FormWizard, 10FormWizard-Gadget, 10Google-Code-in-2018: Design a logo for FormWizard Extension. - https://phabricator.wikimedia.org/T208193 (10Stibba) Here is my logo License: Attribution 4.0 International (CC BY 4.0) {F27460875} [22:44:01] (03CR) 10Dvorapa: "@Maze: What if the description starts with "-"?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 (owner: 10Maze) [22:45:04] 10Growth-Team: Help Panel: Show search link content and help link content inside help panel - https://phabricator.wikimedia.org/T211513 (10kostajh) [22:45:14] 10Beta-Cluster-Infrastructure: Unable to access en/ko.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T211524 (10Quiddity) [22:45:27] 10Beta-Cluster-Infrastructure: Unable to access en/ko.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T211524 (10Quiddity) p:05Normal>03Triage [22:46:54] 10Growth-Team: Help Panel: Show search link content and help link content inside help panel - https://phabricator.wikimedia.org/T211513 (10kostajh) [22:47:25] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy checks should be able to communicate details to client-side logic via the validatepassword API - https://phabricator.wikimedia.org/T211525 (10Tgr) [22:48:08] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) > And password checking methods should probably be able to return extra data that's communicated to the client via the password validation API module, so someth... [22:48:22] (03PS1) 10Takidelfin: Style: Fix button being to big [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [22:48:35] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) [22:48:53] (03PS2) 10Takidelfin: Style: Fix button being to big [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [22:50:00] (03PS3) 10Takidelfin: Style: Fix button being to big [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [22:51:18] (03PS4) 10Takidelfin: Style: Fix too big checkbox [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [22:51:53] (03PS5) 10Takidelfin: Style: Fix too big checkboxes [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [22:56:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikibaseLexeme] - 10https://gerrit.wikimedia.org/r/478560 (owner: 10L10n-bot) [22:59:19] 10Beta-Cluster-Infrastructure, 10Discovery-Search: Notice: Undefined index: search-chi in /srv/mediawiki/wmf-config/CommonSettings.php on line 1672 - https://phabricator.wikimedia.org/T211526 (10Krinkle) [22:59:28] (03CR) 10Maze: "Well, I just assumed '-' is used to mark switches. It seems to be the convention for most bot scripts. I would personally think myself tha" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/478485 (owner: 10Maze) [22:59:28] (03PS1) 10Krinkle: tests: Assert LabsServices contains all prod keys [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478569 (https://phabricator.wikimedia.org/T211526) [23:00:03] 10WMCZ-Tracker, 10Patch-For-Review: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10Urbanecm) Original: {F27461086} Now: {F27461091} [23:00:15] (03CR) 10jerkins-bot: [V: 04-1] tests: Assert LabsServices contains all prod keys [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478569 (https://phabricator.wikimedia.org/T211526) (owner: 10Krinkle) [23:03:29] (03PS2) 10Krinkle: tests: Assert LabsServices contains all prod keys [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478569 (https://phabricator.wikimedia.org/T211526) [23:04:14] (03CR) 10jerkins-bot: [V: 04-1] tests: Assert LabsServices contains all prod keys [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478569 (https://phabricator.wikimedia.org/T211526) (owner: 10Krinkle) [23:04:33] 10Beta-Cluster-Infrastructure, 10Discovery-Search, 10Patch-For-Review: Notice: Undefined index: search-chi in /srv/mediawiki/wmf-config/CommonSettings.php on line 1672 - https://phabricator.wikimedia.org/T211526 (10Krinkle) >>! In T211526#4808969, @gerritbot wrote: > Change 478569 had a related patch set upl... [23:07:52] (03PS2) 10CRusnov: Add "Coherence" check [software/netbox-reports] - 10https://gerrit.wikimedia.org/r/478458 (https://phabricator.wikimedia.org/T205899) [23:09:00] (03CR) 10CRusnov: "Fixed 'done'd below. Added null/blank serial check as a separate check." (033 comments) [software/netbox-reports] - 10https://gerrit.wikimedia.org/r/478458 (https://phabricator.wikimedia.org/T205899) (owner: 10CRusnov) [23:09:09] (03PS6) 10Takidelfin: Style: Fix too big checkboxes [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [23:10:03] 10WMCZ-Tracker, 10Patch-For-Review: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10takidelfin) {F27461240} [23:10:56] (03CR) 10Urbanecm: [C: 032] Style: Fix too big checkboxes [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) (owner: 10Takidelfin) [23:11:33] (03CR) 10Urbanecm: [C: 031] "looks reasonable" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478378 (owner: 10Takidelfin) [23:12:12] (03Merged) 10jenkins-bot: Style: Fix too big checkboxes [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) (owner: 10Takidelfin) [23:14:45] 10WMCZ-Tracker, 10Patch-For-Review: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10Urbanecm) 05Open>03Resolved [23:17:11] 10Core Platform Team, 10Parsing-Team: Notice: Undefined variable: wgTidyConf in /srv/mediawiki/wmf-config/CommonSettings.php on line 3672 - https://phabricator.wikimedia.org/T211527 (10Krinkle) [23:17:24] 10Core Platform Team, 10Parsing-Team: Notice: Undefined variable: wgTidyConf in /srv/mediawiki/wmf-config/CommonSettings.php on line 3672 - https://phabricator.wikimedia.org/T211527 (10Krinkle) p:05Triage>03Unbreak! [23:22:24] 10Beta-Cluster-Infrastructure, 10Operations: Unable to access en/ko.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T211524 (10Quiddity) [23:22:37] (03CR) 10Gergő Tisza: [C: 04-1] "checkUnblockSelf is invoked from checkExecutePermissions which runs on GET as well. When the user visits the base block page (Special:Bloc" [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:22:38] 10Beta-Cluster-Infrastructure, 10Operations: Unable to access beta cluster - https://phabricator.wikimedia.org/T211524 (10Quiddity) [23:23:43] 04(no projects): Copy and paste does not work in Source code editor - https://phabricator.wikimedia.org/T211528 (10MichaelSchoenitzer) [23:25:18] (03PS4) 10Gergő Tisza: Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:27:17] (03CR) 10Gergő Tisza: "Added a trivial fix. There are probably nicer ways to do it but I don't want to hold up this patch. (Same applies to my earlier comments a" [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:27:34] 10Beta-Cluster-Infrastructure: Unable to access beta cluster - https://phabricator.wikimedia.org/T211524 (10Krenair) [23:31:19] 10Beta-Cluster-Infrastructure: Unable to access beta cluster - https://phabricator.wikimedia.org/T211524 (10Krenair) interesting, API is up [23:34:10] (03CR) 10Gergő Tisza: [C: 032] "Tested, works as expected. (With the quirk that the user cannot use Special:Block, only Special:Block/, as the former fails" [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:36:13] 10Beta-Cluster-Infrastructure: Unable to access beta cluster - https://phabricator.wikimedia.org/T211524 (10Krenair) According to the deployment-mediawiki-07 apache logs it last handled a request at 2018-12-09T06:24:49. Restarting apache has fixed it: `name=Apache status on deployment-mediawiki-07 root@deploymen... [23:36:23] 10Beta-Cluster-Infrastructure: Unable to access beta cluster - https://phabricator.wikimedia.org/T211524 (10Krenair) a:03Krenair [23:39:53] 10Beta-Cluster-Infrastructure: Unable to access beta cluster - https://phabricator.wikimedia.org/T211524 (10Krenair) 05Open>03Resolved Since this is seemingly rare, this sort of problem would be unlikely to cause such huge problems in the production environment, and it just requires a simple service restart,... [23:42:55] 10Beta-Cluster-Infrastructure: Unable to access beta cluster - https://phabricator.wikimedia.org/T211524 (10Quiddity) Thanks! [23:47:53] (03Merged) 10jenkins-bot: Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:50:25] (03CR) 10jenkins-bot: Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:53:33] (03PS3) 10Chunliang Lyu: Fix paste issue for nested lists from macOS Notes app [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/478497 (https://phabricator.wikimedia.org/T211516) [23:54:39] 10Wikimedia-production-error: T206030 - https://phabricator.wikimedia.org/T211529 (10Krinkle) [23:54:49] 10Wikimedia-production-error: ApiQuerySiteinfo.php: PHP Notice: Undefined index: 103 - https://phabricator.wikimedia.org/T211529 (10Krinkle) [23:56:57] (03CR) 10Chunliang Lyu: "> Patch Set 2:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/478497 (https://phabricator.wikimedia.org/T211516) (owner: 10Chunliang Lyu) [23:58:41] (03PS1) 10Robingan7: Upload some new logos [mediawiki-config] - 10https://gerrit.wikimedia.org/r/478570 [23:59:24] 10Citoid, 10Wikidata, 10Wikidata-Gadgets: Autofill link for Wikidata's citoid gadget: wording - https://phabricator.wikimedia.org/T153685 (10MichaelSchoenitzer) This is fixed in my fork of CiteTool: https://www.wikidata.org/wiki/User:MichaelSchoenitzer/CiteTool May/Should I close this ticket? [23:59:28] 10Citoid, 10Wikidata, 10Wikidata-Gadgets: Autofill link for Wikidata's citoid gadget: data retrieval should be signified - https://phabricator.wikimedia.org/T153684 (10MichaelSchoenitzer) This is fixed in my fork of CiteTool: https://www.wikidata.org/wiki/User:MichaelSchoenitzer/CiteTool May/Should I close... [23:59:31] 10Citoid, 10Wikidata, 10Wikidata-Gadgets: Autofill link for Wikidata's citoid gadget should be closer to autofilled area - https://phabricator.wikimedia.org/T153683 (10MichaelSchoenitzer) This is fixed in my fork of CiteTool: https://www.wikidata.org/wiki/User:MichaelSchoenitzer/CiteTool May/Should I close...