[00:40:04] 10Maps, 10Cloud-VPS (Ubuntu Trusty Deprecation), 10User-TheDJ: Allow tiles1.wmflabs.org (or possibly entire eqiad-r?) access to osm postgres - https://phabricator.wikimedia.org/T212596 (10Peachey88) [00:43:47] (03PS1) 10MtMNC: Switch CSS -> LESS, refine markup for less styling, etc. [skins/Refreshed] (refreshed4-beta) - 10https://gerrit.wikimedia.org/r/481312 [00:45:50] (03CR) 10Dalba: [C: 03+2] [bugfix] Use P1334 property instead of P625 for test_no_qualifiers tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481294 (https://phabricator.wikimedia.org/T212593) (owner: 10Xqt) [00:46:10] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: TestItemClaimFilterPageGenerator.test_no_qualifiers test is failing at travis and appveyor - https://phabricator.wikimedia.org/T212593 (10Dalba) 05Open→03Resolved [00:47:21] (03Merged) 10jenkins-bot: [bugfix] Use P1334 property instead of P625 for test_no_qualifiers tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481294 (https://phabricator.wikimedia.org/T212593) (owner: 10Xqt) [00:48:30] (03PS1) 10AuroraAri: Allow TOC to "duplicate" existing anchors in MediaWiki [core] - 10https://gerrit.wikimedia.org/r/481313 (https://phabricator.wikimedia.org/T206906) [00:49:14] (03CR) 10jenkins-bot: [bugfix] Use P1334 property instead of P625 for test_no_qualifiers tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481294 (https://phabricator.wikimedia.org/T212593) (owner: 10Xqt) [00:52:50] 10MediaWiki-General-or-Unknown, 10Patch-For-Review: Dummy anchor with id="top" at the top of the page breaks links to section named "top" - https://phabricator.wikimedia.org/T206906 (10AuroraAri) a:03AuroraAri I've submitted a patch which adds a new `$reservedAnchors` array in the parser. If you attempt to c... [00:57:53] (03PS2) 10Subramanya Sastry: WIP: Add back generateTest, traceTime support and update transformTests.js [services/parsoid] - 10https://gerrit.wikimedia.org/r/481306 (https://phabricator.wikimedia.org/T205338) [01:02:21] 10MediaWiki-General-or-Unknown, 10Patch-For-Review: Dummy anchor with id="top" at the top of the page breaks links to section named "top" - https://phabricator.wikimedia.org/T206906 (10AuroraAri) Currently, if there's a single section heading called `top`, MediaWiki will assume that it's the only thing that ha... [01:05:12] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add back generateTest, traceTime support and update transformTests.js [services/parsoid] - 10https://gerrit.wikimedia.org/r/481306 (https://phabricator.wikimedia.org/T205338) (owner: 10Subramanya Sastry) [01:13:44] 10AutoWikiBrowser, 10WorkType-Maintenance: Should not add {{orphan}} or {[stub}} to {{geodis}} - https://phabricator.wikimedia.org/T212601 (10GoingBatty) [02:57:27] (03PS4) 10Ejegg: Pass READ_LATEST in $flags to Title::loadRestrictions [core] - 10https://gerrit.wikimedia.org/r/480574 (https://phabricator.wikimedia.org/T210983) [02:57:29] (03PS2) 10Ejegg: WikiPage::doUpdateRestrictions checks DB_MASTER [core] - 10https://gerrit.wikimedia.org/r/480990 (https://phabricator.wikimedia.org/T210983) [02:59:18] (03CR) 10Ejegg: "Thanks for the CR Aaron. The code does seem like a better place for that TODO." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/480574 (https://phabricator.wikimedia.org/T210983) (owner: 10Ejegg) [03:24:51] (03PS10) 10MR70: Show the queried duration in CheckUser logs [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) [03:26:38] (03CR) 10jerkins-bot: [V: 04-1] Show the queried duration in CheckUser logs [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [03:27:17] (03CR) 10jerkins-bot: [V: 04-1] Show the queried duration in CheckUser logs [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [03:31:28] (03PS11) 10MR70: Show the queried duration in CheckUser logs [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) [03:44:24] (03CR) 10MR70: Show the queried duration in CheckUser logs (036 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [03:51:03] (03PS31) 10Krinkle: initial commit [performance/fresnel] - 10https://gerrit.wikimedia.org/r/459409 (https://phabricator.wikimedia.org/T133646) [03:51:34] (03CR) 10jerkins-bot: [V: 04-1] initial commit [performance/fresnel] - 10https://gerrit.wikimedia.org/r/459409 (https://phabricator.wikimedia.org/T133646) (owner: 10Krinkle) [03:53:40] 10WM-Bot: $fullurl in @rc has been disfigured - https://phabricator.wikimedia.org/T97508 (10Peachey88) [04:01:34] (03PS6) 10MR70: Add user argument to unsuppressCrossWiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/481255 (https://phabricator.wikimedia.org/T212569) [04:03:00] (03PS32) 10Krinkle: initial commit [performance/fresnel] - 10https://gerrit.wikimedia.org/r/459409 (https://phabricator.wikimedia.org/T133646) [04:03:33] (03CR) 10jerkins-bot: [V: 04-1] initial commit [performance/fresnel] - 10https://gerrit.wikimedia.org/r/459409 (https://phabricator.wikimedia.org/T133646) (owner: 10Krinkle) [04:10:44] (03PS33) 10Krinkle: initial commit [performance/fresnel] - 10https://gerrit.wikimedia.org/r/459409 (https://phabricator.wikimedia.org/T133646) [04:12:06] (03PS34) 10Krinkle: initial commit [performance/fresnel] - 10https://gerrit.wikimedia.org/r/459409 (https://phabricator.wikimedia.org/T133646) [04:14:35] (03PS35) 10Krinkle: initial commit [performance/fresnel] - 10https://gerrit.wikimedia.org/r/459409 (https://phabricator.wikimedia.org/T133646) [04:31:57] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Performance-Team (Radar): Docker-based npm jobs have unwritable homedir - https://phabricator.wikimedia.org/T212602 (10Krinkle) [04:33:13] (03PS36) 10Krinkle: initial commit [performance/fresnel] - 10https://gerrit.wikimedia.org/r/459409 (https://phabricator.wikimedia.org/T133646) [04:39:42] (03PS3) 10Krinkle: Remove indirection of 'views' subnamespace [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481232 [04:39:46] (03PS3) 10Krinkle: utils: Document "XX" code and remove copy of CentralNotice logic [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481233 [04:39:50] (03PS2) 10Krinkle: Remove outdated use of jQuery in favour of native methods [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/481234 [06:06:44] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen, 10Verified-in-Phase0: Escape key inside the main editor should cancel VE mode and return to action=view - https://phabricator.wikimedia.org/T52868 (10Tgr) It is a somewhat traumatic experience when you press Esc too hard in a dialog (or try to use... [06:13:02] 10VisualEditor: VisualEditor loses work when you leave an unsaved cite dialog - https://phabricator.wikimedia.org/T212603 (10Tgr) [06:20:43] 10Citoid: Citoid should not add the language parameter to the cite template when the language matches the content language - https://phabricator.wikimedia.org/T212604 (10Tgr) [06:20:51] 10Citoid: Citoid should not add the language parameter to the cite template when the language matches the content language - https://phabricator.wikimedia.org/T212604 (10Tgr) [06:31:52] 10Citoid: Strange Citoid behavior for juhaszadoszakerto.hu - https://phabricator.wikimedia.org/T212605 (10Tgr) [06:40:11] 10Citoid: Use rel=author in Citoid - https://phabricator.wikimedia.org/T212606 (10Tgr) [06:46:27] 10VisualEditor, 10VisualEditor-MediaWiki-References: Integrate VisualEditor template dialog into cite dialog - https://phabricator.wikimedia.org/T212607 (10Tgr) [06:56:42] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Citoid drops anchor when generating cite web reference - https://phabricator.wikimedia.org/T212608 (10Tgr) [06:56:56] 10Citoid: Citoid drops anchor when generating cite web reference - https://phabricator.wikimedia.org/T212608 (10Tgr) [07:11:07] 10VisualEditor, 10VisualEditor-MediaWiki-References: VisualEditor should handle editing of duplicate references better - https://phabricator.wikimedia.org/T212609 (10Tgr) [07:11:33] (03PS1) 10Meno25: [i18n] Update Arabic (ar) at fixes.py [pywikibot] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/481314 (https://phabricator.wikimedia.org/T211492) [07:17:29] (03Abandoned) 10Meno25: [i18n] Update Arabic (ar) at fixes.py [pywikibot] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/481314 (https://phabricator.wikimedia.org/T211492) (owner: 10Meno25) [07:18:16] (03PS1) 10Meno25: [i18n] Update Arabic (ar) at fixes.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481315 (https://phabricator.wikimedia.org/T211492) [07:20:40] (03PS2) 10Meno25: [i18n] Update Arabic (ar) at fixes.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481315 (https://phabricator.wikimedia.org/T211492) [07:21:58] (03CR) 10jerkins-bot: [V: 04-1] [i18n] Update Arabic (ar) at fixes.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481315 (https://phabricator.wikimedia.org/T211492) (owner: 10Meno25) [07:26:16] (03CR) 10Meno25: [i18n] Update Arabic (ar) at fixes.py (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481284 (https://phabricator.wikimedia.org/T211492) (owner: 10Meno25) [07:28:45] (03CR) 10Meno25: ">" (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481284 (https://phabricator.wikimedia.org/T211492) (owner: 10Meno25) [07:29:13] (03Abandoned) 10Meno25: [i18n] Update Arabic (ar) at fixes.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481284 (https://phabricator.wikimedia.org/T211492) (owner: 10Meno25) [07:33:58] 10MediaWiki-Vagrant: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 - https://phabricator.wikimedia.org/T212552 (10brion) @Reedy I'm out of town for a couple days for the holiday so can't retest just now, will poke again later in the week. But I think it was around commit dca68a... [08:04:48] 10MediaWiki-Vagrant: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 - https://phabricator.wikimedia.org/T212552 (10brion) On the Mac (where the extensions installed but php-cli didn't), `php` was gone again when needed for composer runs via `vagrant git-update`: ` ... mwv_compo... [08:42:54] 10Security-Team, 10Core Platform Team Backlog (Watching / External), 10Epic, 10Patch-For-Review, 10TechCom-RFC (TechCom-Approved): Add support for Content-Security-Policy (CSP) headers in MediaWiki - https://phabricator.wikimedia.org/T135963 (10APerson) Can we exempt localhost URLs from this? It would im... [08:59:57] (03PS3) 10Xqt: [i18n] Update Arabic (ar) at fixes.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481315 (https://phabricator.wikimedia.org/T211492) (owner: 10Meno25) [09:31:51] 10Wikimedia-Site-requests, 10Goal, 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm: Provide HD logos for all projects - https://phabricator.wikimedia.org/T150618 (10Shreyasminocha) [09:51:27] 10ProofreadPage, 10CSS, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10Patch-For-Review: Convert Proofpage WE layout to use display flex - https://phabricator.wikimedia.org/T209939 (10Ankry) >>! In T209939#4842997, @TheDJ wrote: >> "CSS changes should be easy to test." > > You think this wasn't tested ? B... [10:09:19] (03CR) 10Xqt: [C: 03+2] "Thanks" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481315 (https://phabricator.wikimedia.org/T211492) (owner: 10Meno25) [10:09:50] 10Pywikibot, 10Pywikibot-replace.py, 10Patch-For-Review: Update Arabic (ar) for fixes.py - https://phabricator.wikimedia.org/T211492 (10Xqt) 05Open→03Resolved [10:10:51] (03Merged) 10jenkins-bot: [i18n] Update Arabic (ar) at fixes.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481315 (https://phabricator.wikimedia.org/T211492) (owner: 10Meno25) [10:12:57] (03CR) 10jenkins-bot: [i18n] Update Arabic (ar) at fixes.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481315 (https://phabricator.wikimedia.org/T211492) (owner: 10Meno25) [10:25:53] 10MediaWiki-extensions-CentralAuth, 10Outreachy (Round 17): CommentStore:newKey was deprecated - https://phabricator.wikimedia.org/T207187 (10Reedy) [10:32:19] 10Outreachy (Round 17): Outreachy microtask: Automation testing framework setup and running existing Echo node.js tests (#1) - https://phabricator.wikimedia.org/T204771 (10Reedy) [10:32:21] 10MediaWiki-extensions-CentralAuth, 10Outreachy (Round 17): CommentStore:newKey was deprecated - https://phabricator.wikimedia.org/T207187 (10Reedy) 05Open→03Invalid Deprecated call doesn’t look to be in master [10:36:11] 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralNotice: `MediaWiki internal error` after provisioning centralnotice role - https://phabricator.wikimedia.org/T198480 (10Reedy) Looks like update.php wasn’t run after enabling Translate? (CN depends on it I guess?) [10:41:23] 10MediaWiki-Vagrant: vagrant provision fails with role echo enabled - https://phabricator.wikimedia.org/T195225 (10Reedy) Does this still occur? Looking at that, it’s akerady failed before those lines star [10:43:24] 10MediaWiki-Vagrant: Vagrant has detected a configuration issue which exposes a vulnerability with the installed version of VirtualBox - https://phabricator.wikimedia.org/T210764 (10Reedy) p:05Triage→03Lowest Which version? Is it still there on newer versions? :p [10:46:41] 10MediaWiki-Vagrant: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 - https://phabricator.wikimedia.org/T212552 (10Reedy) You need {T70594} ;) [10:49:18] 10Internet-Archive, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Gadgets, and 2 others: Save contents of URLs linked from Wikidata in the Internet Archive - https://phabricator.wikimedia.org/T143488 (10Multichill) >>! In T143488#4677644, @Cyberpower678 wrote: > I am currently at that H... [11:09:02] 10ContentTranslation, 10WorkType-NewFunctionality: Allow different users to translate the same topic independently - https://phabricator.wikimedia.org/T86151 (10Strainu) >>! In T86151#4842911, @Pginer-WMF wrote: the old one will be deprecated soon We've been hearing that for at least 2 years, during which th... [11:59:48] 10CSS: Weird CSS tooltip behaviour on iOS devices - https://phabricator.wikimedia.org/T212610 (10XanonymusX) [12:01:34] (03PS7) 10Amire80: Split API messages from UploadWizard [translatewiki] - 10https://gerrit.wikimedia.org/r/481279 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [12:04:37] (03CR) 10Amire80: [C: 03+2] Move all apihelp translatable messages to separate files [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/481282 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [12:07:56] (03PS8) 10Amire80: Split API messages from UploadWizard [translatewiki] - 10https://gerrit.wikimedia.org/r/481279 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [12:08:15] (03Merged) 10jenkins-bot: Move all apihelp translatable messages to separate files [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/481282 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [12:08:17] (03PS3) 10Amire80: Move all apihelp translatable messages to separate files [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481280 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [12:09:21] (03CR) 10Amire80: [C: 03+2] Split API messages from UploadWizard [translatewiki] - 10https://gerrit.wikimedia.org/r/481279 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [12:09:38] (03CR) 10Amire80: [C: 03+2] Move all apihelp translatable messages to separate files [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481280 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [12:09:47] (03Merged) 10jenkins-bot: Split API messages from UploadWizard [translatewiki] - 10https://gerrit.wikimedia.org/r/481279 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [12:09:59] (03CR) 10jenkins-bot: Move all apihelp translatable messages to separate files [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/481282 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [12:19:28] (03CR) 10Amire80: [C: 03+2] "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481280 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [12:22:02] (03PS2) 10Amire80: Add aliases for Serbian language [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481277 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [12:26:54] (03CR) 10Amire80: [C: 03+2] Add aliases for Serbian language [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481277 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [12:33:16] (03Merged) 10jenkins-bot: Add aliases for Serbian language [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481277 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [12:35:41] (03CR) 10jenkins-bot: Add aliases for Serbian language [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481277 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [12:36:11] (03PS3) 10Amire80: Move SQL related files at SQL directory [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481278 (owner: 10Zoranzoki21) [12:50:42] (03CR) 10Amire80: [C: 03+2] Move SQL related files at SQL directory [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481278 (owner: 10Zoranzoki21) [12:50:54] (03PS4) 10Amire80: Move all apihelp translatable messages to separate files [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481280 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [12:55:33] (03Merged) 10jenkins-bot: Move SQL related files at SQL directory [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481278 (owner: 10Zoranzoki21) [12:55:52] 10MediaWiki-Vagrant: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 - https://phabricator.wikimedia.org/T212552 (10Reedy) Ah, yes. It seems running vagrant provision for a second time messes stuff up... [12:56:27] (03PS1) 10Reedy: Stop removing php-common [vagrant] - 10https://gerrit.wikimedia.org/r/481316 (https://phabricator.wikimedia.org/T212552) [12:56:46] (03PS2) 10Reedy: Stop removing php-common [vagrant] - 10https://gerrit.wikimedia.org/r/481316 (https://phabricator.wikimedia.org/T212552) [12:57:59] (03CR) 10jenkins-bot: Move SQL related files at SQL directory [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481278 (owner: 10Zoranzoki21) [12:59:44] (03CR) 10Amire80: [C: 03+2] "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481280 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [13:01:55] (03PS3) 10Reedy: Stop removing php-common [vagrant] - 10https://gerrit.wikimedia.org/r/481316 (https://phabricator.wikimedia.org/T212552) [13:04:45] (03Merged) 10jenkins-bot: Move all apihelp translatable messages to separate files [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481280 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [13:05:38] 10MediaWiki-Vagrant, 10Patch-For-Review: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 - https://phabricator.wikimedia.org/T212552 (10Reedy) @brion Want to give the above patch a go? Not perfect, but improves it a bit `lines=5 vagrant@vagrant:~$ dpkg -l | grep php rc libapa... [13:06:47] 10MediaWiki-Vagrant, 10Patch-For-Review: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 - https://phabricator.wikimedia.org/T212552 (10Reedy) >>! In T212552#4843306, @Reedy wrote: > While I agree we don't want `libapache2-mod-php7.0` installed, I'm not sure there's much issue... [13:07:14] (03CR) 10jenkins-bot: Move all apihelp translatable messages to separate files [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/481280 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [13:08:04] (03PS1) 10Reedy: Leave php7.0 installed [vagrant] - 10https://gerrit.wikimedia.org/r/481317 (https://phabricator.wikimedia.org/T212552) [13:08:45] (03PS2) 10Reedy: Leave php7.0 installed [vagrant] - 10https://gerrit.wikimedia.org/r/481317 (https://phabricator.wikimedia.org/T212552) [13:11:38] 10MediaWiki-Vagrant: vagrant provision repeatedly installing version 1.27.1.0a1 but then 1.27.0 persists - https://phabricator.wikimedia.org/T212611 (10Reedy) [13:12:16] (03PS1) 10Fomafix: Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/481318 (https://phabricator.wikimedia.org/T117845) [13:14:06] (03CR) 10Reedy: [C: 04-1] Change setScriptPath to use MW_INSTALL_PATH (035 comments) [core] - 10https://gerrit.wikimedia.org/r/481311 (https://phabricator.wikimedia.org/T212599) (owner: 10AuroraAri) [13:20:21] 10CSS: Weird CSS tooltip behaviour on iOS devices - https://phabricator.wikimedia.org/T212610 (10Aklapper) Hi, what makes this a MediaWiki issue? Does your custom CSS/HTML code behave differently when using it in, say, static HTML? If so, how? [13:32:45] 10CSS: Weird CSS tooltip behaviour on iOS devices - https://phabricator.wikimedia.org/T212610 (10XanonymusX) Well, as described above, the exact same HTML/CSS apparently works fine on the external website I have linked, the problems are only visible in MediaWiki (I have tested German WP and Testwiki). I can also... [13:37:15] (03PS1) 10Fomafix: Fix language names in test comments [core] - 10https://gerrit.wikimedia.org/r/481319 [13:50:45] (03CR) 10jerkins-bot: [V: 04-1] Fix language names in test comments [core] - 10https://gerrit.wikimedia.org/r/481319 (owner: 10Fomafix) [14:01:22] (03PS2) 10Fomafix: Fix comments in language class tests [core] - 10https://gerrit.wikimedia.org/r/481319 [14:13:00] 10Wikidata, 10Wikidata-Campsite, 10Wikidata-Query-Service, 10User-Smalyshev: Number of Senses is decreasing on ListeriaBot's report - https://phabricator.wikimedia.org/T210495 (10KaMan) @Smalyshev Not in this scale like previously but stull there are unstable values. For example in this diff https://www.w... [14:17:17] (03CR) 10Yaron Koren: [C: 03+2] "." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481307 (owner: 10Yaron Koren) [14:21:10] (03Merged) 10jenkins-bot: Add $wgCargoDBRowFormat setting [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481307 (owner: 10Yaron Koren) [14:23:01] (03CR) 10jenkins-bot: Add $wgCargoDBRowFormat setting [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481307 (owner: 10Yaron Koren) [14:35:09] (03PS1) 10Yaron Koren: Yet another fix for non-ASCII table names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481320 [14:37:04] (03PS2) 10Yaron Koren: Yet another fix for non-ASCII table names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481320 [14:43:56] (03CR) 10Yaron Koren: [C: 03+2] Yet another fix for non-ASCII table names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481320 (owner: 10Yaron Koren) [14:48:37] (03Merged) 10jenkins-bot: Yet another fix for non-ASCII table names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481320 (owner: 10Yaron Koren) [14:50:25] (03CR) 10jenkins-bot: Yet another fix for non-ASCII table names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481320 (owner: 10Yaron Koren) [15:09:37] 10Citoid: Citoid should not add the language parameter to the cite template when the language matches the content language - https://phabricator.wikimedia.org/T212604 (10Izno) The en.wp template //is// intelligent enough not to display it. The problem is that the hu.wp template is not up to date. See discussion... [15:12:17] 10Citoid: Citoid remarks from small language wikis - https://phabricator.wikimedia.org/T210797 (10Izno) `year` and `date` are synonyms on en.wp. [15:13:47] (03PS1) 10Zhuyifei1999: tools: Support LZMA and XZ formats [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481321 [15:18:59] 10Internet-Archive, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Gadgets, and 2 others: Save contents of URLs linked from Wikidata in the Internet Archive - https://phabricator.wikimedia.org/T143488 (10Cyberpower678) >>! In T143488#4843283, @Multichill wrote: >>>! In T143488#4677644, @... [15:19:08] 10Pywikibot, 10Documentation, 10Google-Code-in-2018, 10Pywikibot-Documentation, 10goodfirstbug: Pywikibot: Add missing docstring params - https://phabricator.wikimedia.org/T184115 (10AdityaJ) @jayvdb I would like to work on this task. [15:20:46] (03CR) 10Zhuyifei1999: "need to write tests" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481321 (owner: 10Zhuyifei1999) [15:26:59] 10Internet-Archive, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Gadgets, and 2 others: Save contents of URLs linked from Wikidata in the Internet Archive - https://phabricator.wikimedia.org/T143488 (10Cyberpower678) To answer your questions, IABot will be using the wbgetentities and w... [16:02:13] 10Citoid, 10Core Platform Team Backlog (Watching / External), 10Services (watching): DOI redirect handler for iopscience is very slow/ potentially causes citoid to behave oddly. - https://phabricator.wikimedia.org/T106374 (10Josve05a) [16:02:44] 10Wikimedia-Site-requests, 10Goal, 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm: Provide HD logos for all projects - https://phabricator.wikimedia.org/T150618 (10Shreyasminocha) I wrote [[ https://gist.github.com/shreyasminocha/b49505fce2efa071edd74bd74d6a7105 | a shell script ]] to semi-au... [16:03:57] 10Wikimedia-Site-requests, 10Goal, 10Patch-For-Review, 10User-Urbanecm: Provide HD logos for all projects - https://phabricator.wikimedia.org/T150618 (10Shreyasminocha) [16:05:07] (03CR) 10Brion VIBBER: [C: 03+1] "This is working on my Mac's instance, where the only problem was the 'php' cli command flapping in and out of existence. With this patch, " [vagrant] - 10https://gerrit.wikimedia.org/r/481317 (https://phabricator.wikimedia.org/T212552) (owner: 10Reedy) [16:05:46] 10Pywikibot, 10Documentation, 10Google-Code-in-2018, 10Pywikibot-Documentation, 10goodfirstbug: Pywikibot: Add missing docstring params - https://phabricator.wikimedia.org/T184115 (10Shreyasminocha) a:03AdityaJ [16:07:06] 10MediaWiki-Vagrant, 10Patch-For-Review: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 - https://phabricator.wikimedia.org/T212552 (10brion) >>! In T212552#4843306, @Reedy wrote: > @brion Want to give the above patch a go? Not perfect, but improves it a bit Much better on th... [16:09:09] (03CR) 10Huji: [C: 04-1] Show the queried duration in CheckUser logs (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [16:17:52] (03PS1) 10AdityaJ: Basestring is a description of parameter value's type [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481322 [16:34:57] (03PS1) 10Yaron Koren: Follow-up to bd52e43ea4b0 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481323 [16:36:57] (03PS2) 10Yaron Koren: Follow-up to bd52e43ea4b0 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481323 [16:39:42] (03CR) 10Xqt: [C: 03+2] Basestring is a description of parameter value's type [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481322 (owner: 10AdityaJ) [16:41:12] (03Merged) 10jenkins-bot: Basestring is a description of parameter value's type [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481322 (owner: 10AdityaJ) [16:42:20] (03CR) 10Yaron Koren: [C: 03+2] Follow-up to bd52e43ea4b0 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481323 (owner: 10Yaron Koren) [16:43:02] (03CR) 10jenkins-bot: Basestring is a description of parameter value's type [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481322 (owner: 10AdityaJ) [16:47:03] (03Merged) 10jenkins-bot: Follow-up to bd52e43ea4b0 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481323 (owner: 10Yaron Koren) [16:48:51] (03CR) 10jenkins-bot: Follow-up to bd52e43ea4b0 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/481323 (owner: 10Yaron Koren) [16:51:23] 10Pywikibot, 10Pywikibot-tests: paraminfo_tests.test_entities fails - https://phabricator.wikimedia.org/T211054 (10Xqt) I did it locally for wpbeta I guess. But their config could be changed in meantime. I’ll recheck it. [17:00:36] (03CR) 10Paladox: [C: 03+1] Leave php7.0 installed [vagrant] - 10https://gerrit.wikimedia.org/r/481317 (https://phabricator.wikimedia.org/T212552) (owner: 10Reedy) [17:03:35] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-Wikidata: newitem.py doesn't handle the case where interwiki links are present in the page content - https://phabricator.wikimedia.org/T199891 (10Xqt) p:05Triage→03Normal [17:25:59] 10AbuseFilter, 10Patch-For-Review, 10User-Daimona: Variables constantly don't appear in abuse filter log - https://phabricator.wikimedia.org/T176291 (10He7d3r) Here is a recent example of this problem: https://pt.wikipedia.org/wiki/Special:AbuseFilter/examine/log/4358048 https://pt.wikipedia.org/wiki/Tabata_... [17:54:53] 10AbuseFilter, 10Patch-For-Review, 10User-Daimona: Variables constantly don't appear in abuse filter log - https://phabricator.wikimedia.org/T176291 (10Daimona) @He7d3r Yeah, I'm well aware of the problem, I also constantly face it when I need to examine AbuseLog entries in order to tune filters. The patch a... [18:06:20] 10Indic-TechCom, 10Tools, 10User-Jayprakash12345: Create and Deploy Indic Wikisource Stats Tool - https://phabricator.wikimedia.org/T212517 (10Jayprakash12345) The tool is live now, But I am running `gen_stats.py` manually, I will setup cronjob. [18:21:11] (03CR) 10D3r1ck01: [C: 03+2] Remove documentation that does not add any information [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481251 (owner: 10Thiemo Kreuz (WMDE)) [18:31:44] (03CR) 10D3r1ck01: [C: 03+2] build: Add php-parallel-lint, MinusX and grunt-jsonlint [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/481177 (owner: 10Umherirrender) [18:34:51] (03Merged) 10jenkins-bot: Remove documentation that does not add any information [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481251 (owner: 10Thiemo Kreuz (WMDE)) [18:35:14] (03Merged) 10jenkins-bot: build: Add php-parallel-lint, MinusX and grunt-jsonlint [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/481177 (owner: 10Umherirrender) [18:38:55] 10Wikimedia-Site-requests: Add transwiki import sources on Urdu Wikipedia - https://phabricator.wikimedia.org/T212612 (10BukhariSaeed) [18:41:51] 10Wikimedia-Site-requests: Add transwiki import sources on Urdu Wikipedia - https://phabricator.wikimedia.org/T212612 (10BukhariSaeed) [18:42:11] 10Pywikibot, 10Documentation, 10Google-Code-in-2018, 10Pywikibot-Documentation, 10goodfirstbug: Pywikibot: Add missing docstring params - https://phabricator.wikimedia.org/T184115 (10Dvorapa) >>! In T184115#4843335, @AdityaJ wrote: > @jayvdb I would like to work on this task. Upload some first patch and... [18:42:18] 10Wikimedia-Site-requests: Add transwiki import on Urdu Wikipedia - https://phabricator.wikimedia.org/T212612 (10BukhariSaeed) [18:45:14] 10Wikimedia-Site-requests: Add transwiki import on Urdu Wikipedia - https://phabricator.wikimedia.org/T212612 (10BukhariSaeed) [19:04:02] (03CR) 10Nikerabbit: [C: 03+2] Prefer "self" references where possible [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481249 (owner: 10Thiemo Kreuz (WMDE)) [19:04:32] 10Wikimedia-Site-requests: Add transwiki import on Urdu Wikipedia - https://phabricator.wikimedia.org/T212612 (10BukhariSaeed) [19:06:56] 10Wikimedia-Site-requests, 10User-Zoranzoki21: Add transwiki import on Urdu Wikipedia - https://phabricator.wikimedia.org/T212612 (10Zoranzoki21) a:03Zoranzoki21 [19:09:42] (03CR) 10Brion VIBBER: [C: 03+1] "I might suggest adding to the commit summary something like "don't remove all PHP packages on every puppet run" to clarify the intent too " [vagrant] - 10https://gerrit.wikimedia.org/r/481317 (https://phabricator.wikimedia.org/T212552) (owner: 10Reedy) [19:21:45] (03Merged) 10jenkins-bot: Prefer "self" references where possible [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481249 (owner: 10Thiemo Kreuz (WMDE)) [19:23:41] 10MediaWiki-Change-tagging, 10MediaWiki-History-or-Diffs, 10Regression: Change tags in revision diffs are missing parenthesis - https://phabricator.wikimedia.org/T212613 (10matej_suchanek) [19:33:14] 10ProofreadPage, 10CSS, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10Patch-For-Review: Convert Proofpage WE layout to use display flex - https://phabricator.wikimedia.org/T209939 (10EncycloPetey) >>! In T209939#4843264, @Ankry wrote: > As we have already found a workaround, the delay does not seem to be... [19:37:29] (03PS1) 10Urbanecm: Block should disable login [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/481324 [19:37:50] (03CR) 10Urbanecm: [C: 03+2] Block should disable login [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/481324 (owner: 10Urbanecm) [19:38:04] (03Merged) 10jenkins-bot: Block should disable login [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/481324 (owner: 10Urbanecm) [19:51:31] 10Editing-team: Parser function to reflect "upright" - https://phabricator.wikimedia.org/T212614 (10jeblad) [19:52:43] (03PS24) 10Matěj Suchánek: Use actor table in AbuseFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445185 (https://phabricator.wikimedia.org/T188180) [20:01:10] (03CR) 10Matěj Suchánek: Migrate UserMerge to modern logging system (033 comments) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/461292 (https://phabricator.wikimedia.org/T72836) (owner: 10Matěj Suchánek) [20:14:23] 10Wikimedia-Site-requests, 10User-Zoranzoki21: Add transwiki import on Urdu Wikipedia - https://phabricator.wikimedia.org/T212612 (10Aklapper) From which specific wiki sites would you like to import? [20:15:43] 10MediaWiki-Parser: Parser function to reflect "upright" - https://phabricator.wikimedia.org/T212614 (10Aklapper) Removing #Editing-Team as it is up to teams what they plan to work on; adding #MediaWiki-Parser [20:17:58] 10Wikimedia-Site-requests, 10User-Zoranzoki21: Add transwiki import on Urdu Wikipedia - https://phabricator.wikimedia.org/T212612 (10MuhammadShuaib) >>! In T212612#4843396, @Aklapper wrote: > From which specific wiki sites would you like to import? As stated in above link of community consensus, these Wikis a... [20:22:38] 10ProofreadPage, 10CSS, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10Patch-For-Review: Convert Proofpage WE layout to use display flex - https://phabricator.wikimedia.org/T209939 (10Zdzislaw) @Ankry T209939#4829011 l looks good, and... I agree with you that this change should come back. @TheDJ The change... [20:57:24] (03CR) 10Nikerabbit: [C: 03+2] Make use of the …::class feature in some cases [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481250 (owner: 10Thiemo Kreuz (WMDE)) [21:09:42] (03Abandoned) 10Reedy: Stop removing php-common [vagrant] - 10https://gerrit.wikimedia.org/r/481316 (https://phabricator.wikimedia.org/T212552) (owner: 10Reedy) [21:10:06] (03PS3) 10Reedy: Leave php7.0 installed [vagrant] - 10https://gerrit.wikimedia.org/r/481317 (https://phabricator.wikimedia.org/T212552) [21:10:14] (03CR) 10Reedy: [C: 03+2] Leave php7.0 installed [vagrant] - 10https://gerrit.wikimedia.org/r/481317 (https://phabricator.wikimedia.org/T212552) (owner: 10Reedy) [21:10:45] (03Merged) 10jenkins-bot: Make use of the …::class feature in some cases [extensions/Translate] - 10https://gerrit.wikimedia.org/r/481250 (owner: 10Thiemo Kreuz (WMDE)) [21:11:08] 10MediaWiki-Vagrant, 10Patch-For-Review: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 - https://phabricator.wikimedia.org/T212552 (10Reedy) >>! In T212552#4843345, @brion wrote: >>>! In T212552#4843306, @Reedy wrote: >> @brion Want to give the above patch a go? Not perfect,... [21:11:15] (03Merged) 10jenkins-bot: Leave php7.0 installed [vagrant] - 10https://gerrit.wikimedia.org/r/481317 (https://phabricator.wikimedia.org/T212552) (owner: 10Reedy) [21:14:30] (03CR) 10jenkins-bot: Leave php7.0 installed [vagrant] - 10https://gerrit.wikimedia.org/r/481317 (https://phabricator.wikimedia.org/T212552) (owner: 10Reedy) [21:16:07] 10MediaWiki-Vagrant, 10Patch-For-Review: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 - https://phabricator.wikimedia.org/T212552 (10brion) 05Open→03Resolved a:03brion Woohoo! I'll close this out now as fixing my main case (on the Mac where it almost worked) and will c... [21:16:40] 10Wikidata, 10Wikidata-Campsite, 10Wikidata-Query-Service, 10User-Smalyshev: Number of Senses is decreasing on ListeriaBot's report - https://phabricator.wikimedia.org/T210495 (10Smalyshev) I think there's something weird is going on with Unicode encoding... The database reports two triples for IPA for `ht... [21:29:46] 10Huggle: Add toolbar icons to touchbar - https://phabricator.wikimedia.org/T212615 (10Petrb) [21:29:57] 10Huggle: Add toolbar icons to touchbar - https://phabricator.wikimedia.org/T212615 (10Petrb) p:05Triage→03Normal [21:33:40] (03CR) 10Gergő Tisza: Migrate UserMerge to modern logging system (032 comments) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/461292 (https://phabricator.wikimedia.org/T72836) (owner: 10Matěj Suchánek) [22:04:37] 10Lingua Libre: Install some MediaWiki extensions - https://phabricator.wikimedia.org/T196759 (10Yug) [22:09:37] 10Phabricator: Variable selector does not work on fawiki - https://phabricator.wikimedia.org/T212616 (10Huji) [22:12:31] (03PS1) 10Smalyshev: Set correct header [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/481325 [22:13:26] 10Lingua Libre: Install some MediaWiki extensions - https://phabricator.wikimedia.org/T196759 (100x010C) [22:14:17] 10Lingua Libre: Install some MediaWiki extensions - https://phabricator.wikimedia.org/T196759 (100x010C) @Yug: I've reverted your change, because SVG are natively supported by MediaWiki, no need of an additional extension. [22:26:15] 10Lingua Libre: Install some MediaWiki extensions - https://phabricator.wikimedia.org/T196759 (10Yug) @0x010C, does it actually work for you ? You can use the font awesome svg from [[ https://fontawesome.com/icons/microphone-alt?style=solid | here ]] ([[ blob:https://fontawesome.com/ea681a04-2d35-4642-b14d-70a00... [22:28:08] 10Lingua Libre: Use vector logo rather than raster logo - https://phabricator.wikimedia.org/T212581 (10Yug) a:030x010C [22:30:50] 10Lingua Libre: Use vector logo rather than raster logo - https://phabricator.wikimedia.org/T212581 (10Yug) [22:47:41] (03PS1) 10Samwilson: Coding style fixes [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/481326 [22:48:25] (03CR) 10MaxSem: [C: 03+2] Fix comments in language class tests [core] - 10https://gerrit.wikimedia.org/r/481319 (owner: 10Fomafix) [22:53:49] (03PS1) 10Krinkle: Use custom export branch for intuition.git export [translatewiki] - 10https://gerrit.wikimedia.org/r/481327 [22:54:01] (03PS2) 10Krinkle: Use custom export branch for intuition.git export [translatewiki] - 10https://gerrit.wikimedia.org/r/481327 [22:56:06] 10Lingua Libre: Allow click-play-listen while recording in Record Wizard > Studio - https://phabricator.wikimedia.org/T212583 (10Yug) [22:56:52] 10Lingua Libre: Install some MediaWiki extensions - https://phabricator.wikimedia.org/T196759 (100x010C) @Yug: This is unrelated to installing mediawiki extensions. MediaWiki (ans thus Lingua Libre) support the display of svg files, even if the upload of svg files is disabled locally. In fact, Lingua Libre is no... [22:59:22] 10Lingua Libre: Install some MediaWiki extensions - https://phabricator.wikimedia.org/T196759 (10Yug) Import from commons works ! * 0 * Cool... [23:06:53] (03Merged) 10jenkins-bot: Fix comments in language class tests [core] - 10https://gerrit.wikimedia.org/r/481319 (owner: 10Fomafix) [23:09:08] (03CR) 10jenkins-bot: Fix comments in language class tests [core] - 10https://gerrit.wikimedia.org/r/481319 (owner: 10Fomafix) [23:23:16] (03PS2) 10Samwilson: Coding style fixes [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/481326 [23:28:28] (03CR) 10MaxSem: [C: 03+2] Coding style fixes [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/481326 (owner: 10Samwilson) [23:32:10] (03Merged) 10jenkins-bot: Coding style fixes [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/481326 (owner: 10Samwilson) [23:34:20] (03CR) 10jenkins-bot: Coding style fixes [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/481326 (owner: 10Samwilson) [23:44:33] 10ProofreadPage, 10CSS, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10Patch-For-Review: Convert Proofpage WE layout to use display flex - https://phabricator.wikimedia.org/T209939 (10Ankry) >>! In T209939#4843383, @EncycloPetey wrote: >>>! In T209939#4843264, @Ankry wrote: >> As we have already found a w... [23:51:42] 10Toolforge: Toolforge archive_userindex not updated to use new comment table - https://phabricator.wikimedia.org/T212617 (10Sigma) [23:59:12] (03CR) 10Smalyshev: [C: 03+2] Set correct header [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/481325 (owner: 10Smalyshev)