[19:40:29] Channel is now logged [19:40:50] * RoanKattouw figured he'd make the statement about public logging in the topic actually true :) [19:41:09] (03CR) 10Krinkle: "I don't think we should be reserving space for the tab bar. If anything that's Vector's responsibility. However it has always been absolut" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109491 (owner: 10Esanders) [19:41:17] ha, I thought it was automatic [19:41:25] That's what everyone thought [19:42:56] (03CR) 10Krinkle: Fix toolbar margins in vector (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109491 (owner: 10Esanders) [20:11:45] (03PS2) 10Esanders: Fix toolbar margins in vector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109491 [20:19:36] (03PS1) 10Catrope: Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 [20:20:44] (03CR) 10jenkins-bot: [V: 04-1] Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 (owner: 10Catrope) [20:21:34] (03PS2) 10Catrope: Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 [20:24:04] RoanKattouw: Are you reviewing https://gerrit.wikimedia.org/r/#/c/109091/1 ? I was going to if you don't mind. [20:25:32] Krinkle: Go for it [20:25:37] I have to fix link inspector bugs [20:25:45] Also, let's drag Trevor out to lunch? [20:25:47] I'm getting hungry [20:26:22] (03CR) 10Krinkle: [C: 032] Simplify toDataElement (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109091 (owner: 10Esanders) [20:26:26] Krinkle: Re 109091, could you leave that until I get a chance to look at ... [20:26:29] ... it ... [20:26:33] maybe? [20:28:14] (03CR) 10Krinkle: [C: 032] Simplify toDataElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109091 (owner: 10Esanders) [20:29:17] (03Merged) 10jenkins-bot: Simplify toDataElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109091 (owner: 10Esanders) [21:12:24] gah really, VM? really? I just figured out how to start playing around with replacing image nodes in the transaction and my VM crashes. [21:13:06] (03PS1) 10Catrope: Followup 7994eae8c2: fix MWLinkInspector breakage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109738 [21:15:26] (03CR) 10Trevor Parscal: [C: 032] Followup 7994eae8c2: fix MWLinkInspector breakage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109738 (owner: 10Catrope) [21:16:33] (03Merged) 10jenkins-bot: Followup 7994eae8c2: fix MWLinkInspector breakage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109738 (owner: 10Catrope) [21:25:51] (03PS1) 10Krinkle: Minor clean up and doc fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109744 [21:26:06] (03PS2) 10Jhall: [Browser test] WIP New test(s) for editing with VisualEditor via mobile user interface. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108987 [21:28:44] (03CR) 10Catrope: [C: 032] Simplify toDomElements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109092 (owner: 10Esanders) [21:31:40] (03Merged) 10jenkins-bot: Simplify toDomElements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109092 (owner: 10Esanders) [21:31:58] (03CR) 10Catrope: [C: 032] Minor clean up and doc fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109744 (owner: 10Krinkle) [21:33:34] (03Merged) 10jenkins-bot: Minor clean up and doc fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109744 (owner: 10Krinkle) [21:34:50] eh, RoanKattouw re https://gerrit.wikimedia.org/r/#/c/109727/ <-- I think ed moved the ajax info request to ve.dm.MWImageNode [21:35:04] so now I'm all confused [21:35:15] Well I touched code that was still there, I didn't add anything [21:35:24] Oh, maybe Ed's commit is not merged yet? [21:35:28] it's not merged yet [21:35:35] and it's a big stack of commits, so I got confused [21:35:44] https://gerrit.wikimedia.org/r/#/c/109595/2/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js doesn't touch that API request [21:35:57] Oh wait: "Move image info API call to media node" [21:36:01] Maybe that's relevant :D [21:36:01] https://gerrit.wikimedia.org/r/#/c/109522/1 [21:36:26] Yeah, good catch [21:36:29] I'll have to rebase onto that [21:36:29] yeah, that one. I'm also a bit concerned about the changes I'm still doing to the media edit dialog [21:36:37] * mooeypoo will have some rebasin' [21:37:08] though if you can review alt text and position, which are relatively small changes, i think ed's stack can go on top of them [21:38:04] https://gerrit.wikimedia.org/r/#/c/105098/ alt text && https://gerrit.wikimedia.org/r/#/c/105225/ position [21:38:29] they depend on one another for convenience of review and work, they can actually be merged the other order around [21:39:06] I'm just getting really confused about what will change in the Edit Dialog while I continue doing the type change :p [21:41:17] (03CR) 10Krinkle: [C: 031] Fix toolbar margins in vector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109491 (owner: 10Esanders) [21:42:51] (03PS3) 10Catrope: Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 [21:43:19] (03CR) 10jenkins-bot: [V: 04-1] Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 (owner: 10Catrope) [21:46:19] TrevorParscal: Recent regression in oojs-ui? Or intentional? https://bugzilla.wikimedia.org/show_bug.cgi?id=60498 [21:46:20] (03PS1) 10Catrope: Add .tagName to MWGalleryNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109759 [21:46:53] Krinkle: it should be a silver border when disabled, that's a regression [21:48:13] Probably from the recent button refactor? [21:48:16] Krinkle: https://gerrit.wikimedia.org/r/109759 [21:52:21] RoanKattouw, I have a question about transactions if you have a moment. If I want to use "newFromDocumentInsertion" -- how do I create the 'newDoc' document to be inserted? Is there a transaction to create a new document? [21:52:48] or do I just go 'newFromInsertion' [21:54:20] mooeypoo: There's a method in ve.dm.Document for this, it's called a document slice I think. See how MWReferenceDialog doesi t [21:54:28] * mooeypoo nods [21:54:30] thanks [22:02:59] (03CR) 10Catrope: [C: 04-1] Fix layout of keyboard shortcuts page (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109483 (owner: 10Esanders) [22:14:01] (03CR) 10Esanders: Adding alternate text to media edit dialog (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105098 (owner: 10Mooeypoo) [22:15:08] (03CR) 10Catrope: [C: 032] Tests for RDFa attribute preservation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109255 (owner: 10Esanders) [22:16:07] (03Merged) 10jenkins-bot: Tests for RDFa attribute preservation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109255 (owner: 10Esanders) [22:19:20] (03CR) 10Esanders: Fix layout of keyboard shortcuts page (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109483 (owner: 10Esanders) [22:20:21] (03CR) 10Esanders: Tests for RDFa attribute preservation (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109255 (owner: 10Esanders) [22:20:27] (03PS2) 10Esanders: Fix layout of keyboard shortcuts page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109483 [22:22:18] (03CR) 10jenkins-bot: [V: 04-1] Fix layout of keyboard shortcuts page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109483 (owner: 10Esanders) [22:23:57] edsanders, should I refactor the altText / position on top of your refactor instead of going for merging them first? [22:24:17] (03PS1) 10Esanders: Fix typo in ve.ce.Surface test message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109769 [22:25:12] mooeypoo, that might be best, mainly because my stack is longer and more complex [22:25:30] yeah that's why I was thinking it might be better to merge my smaller ones first [22:25:48] but then you'll have to do a bit of rebasing again, seems a bit against the point [22:26:39] if you rebase I don't think you'll get that many real conflict, just logical ones [22:27:05] yeah, I'll do that. I noticed when you wrote that the inputs/fieldsets are changing [22:28:23] (03PS2) 10Krinkle: Add tagName to ve.dm.MWGalleryNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109759 (owner: 10Catrope) [22:28:47] (03CR) 10Krinkle: "Added ve.dm.MWExtensionNode.static.tagName to doc index." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109759 (owner: 10Catrope) [22:28:52] (03CR) 10Krinkle: [C: 031] Add tagName to ve.dm.MWGalleryNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109759 (owner: 10Catrope) [22:31:00] (03CR) 10Catrope: [C: 031] Add tagName to ve.dm.MWGalleryNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109759 (owner: 10Catrope) [22:33:32] (03CR) 10Krinkle: [C: 032] Add tagName to ve.dm.MWGalleryNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109759 (owner: 10Catrope) [22:33:39] (03CR) 10Catrope: [C: 032] Fix typo in ve.ce.Surface test message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109769 (owner: 10Esanders) [22:34:38] (03Merged) 10jenkins-bot: Add tagName to ve.dm.MWGalleryNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109759 (owner: 10Catrope) [22:34:42] (03Merged) 10jenkins-bot: Fix typo in ve.ce.Surface test message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109769 (owner: 10Esanders) [22:37:53] edsanders, this is failed because of lib/ve right? https://gerrit.wikimedia.org/r/#/c/109595/2 [22:38:09] i'm trying to figure out where to rebase my commit chain [22:39:07] (03CR) 10Catrope: [C: 032] Fix balancing of data in cloneSliceFromRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109481 (owner: 10Esanders) [22:39:34] edsanders: Does https://gerrit.wikimedia.org/r/#/c/109481/ fix https://bugzilla.wikimedia.org/show_bug.cgi?id=60117 ? [22:40:43] (03Merged) 10jenkins-bot: Fix balancing of data in cloneSliceFromRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109481 (owner: 10Esanders) [22:42:57] (03PS4) 10Krinkle: Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [22:44:05] mooeypoo, yes [22:44:21] RoanKattouw:https://bugzilla.wikimedia.org/show_bug.cgi?id=60502 [22:45:00] RoanKattouw, I think so [22:45:12] OK, awesome [22:45:29] (03CR) 10Krinkle: [C: 04-1] "Playing locally with this in the standalone demo (page=default/aliens) in Chrome shows it as very jerky. Something seems to be stuck in a " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [22:45:52] mooeypoo, you can base on that [22:46:00] * mooeypoo nods [22:46:01] k, will do [22:46:13] (03CR) 10Krinkle: "I suspect the hover gets in a loop because of the hover surface area changing and then no longer hovering and hovering again with little t" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [22:46:24] RoanKattouw, worth browser testing the cases you highlighted [22:46:58] The ones I listed on the bug you mean? [22:47:28] As in, https://bugzilla.wikimedia.org/show_bug.cgi?id=60117#c3 ? [22:47:59] (03CR) 10Catrope: [C: 032] Make keyboard shortcuts dialog footless [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109317 (owner: 10Esanders) [22:48:13] (03CR) 10Catrope: Fix layout of keyboard shortcuts page (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109483 (owner: 10Esanders) [22:48:15] (03CR) 10Esanders: "I tested the same page in Chrome & FF and it works fine. Might be a OS font issue as it scales using font-size?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [22:48:59] edsanders: Hah looks like we individually found that toolbar bug and found its cause :) [22:49:22] (03Merged) 10jenkins-bot: Make keyboard shortcuts dialog footless [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109317 (owner: 10Esanders) [22:50:20] (03CR) 10Krinkle: "http://i.imgur.com/rf4OmHu.png" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [22:50:27] RoanKattouw, (yes those ones) [22:50:34] RoanKattouw, You did? [22:57:06] (03CR) 10Krinkle: [C: 032] Attach container to DOM before initialising target in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109489 (owner: 10Esanders) [22:58:08] (03Merged) 10jenkins-bot: Attach container to DOM before initialising target in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109489 (owner: 10Esanders) [23:07:22] (03CR) 10Esanders: Fix layout of keyboard shortcuts page (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109483 (owner: 10Esanders) [23:08:40] (03CR) 10Esanders: [C: 032] Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 (owner: 10Catrope) [23:18:35] edsanders: Sorry, got distracted. Yeah there's a duplicate bug somewhere [23:19:18] ryasmeen: For testing copy/paste, could you specifically test the cases that I listed in my Bugzilla comment? https://bugzilla.wikimedia.org/show_bug.cgi?id=60117#c3 [23:19:49] RoanKattouw: yes, doing that [23:20:01] Sweet, thanks [23:20:26] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/103078/ see comments and http://i.imgur.com/SP90fMf.png [23:20:34] edsanders: Found it, it was https://bugzilla.wikimedia.org/show_bug.cgi?id=60183 , identified the cause and everything :) [23:47:20] edsanders, trying to rebase onto your commit, I get "fatal: Needed a single revision. Does not point to a valid commit: " [23:47:51] mooey: Then your local git doesn't know about that commit, you need to download it first [23:47:57] ohh [23:48:02] I didn't think about that [23:49:02] also RoanKattouw, I need to go to class soon, but i am having a hard time with transaction stuff. Are you going to be around tomorrow or just Tuesday? [23:49:16] I won't be on IRC tomorrow [23:49:21] But I'll be in the office on Wednesday [23:49:31] You can also contact me via email or hangout [23:49:34] Since I have those on my phone [23:49:38] wednesday, not tuesday, right ,tomorrow is tuesday. ha. er. [23:50:18] oh ok, cool. I've been wrestling with it all day -- I think I got some of it to work, but some fails on really weird problems (like, removes the node but doesn't insert a new one, etc, and attributes mismatch problem.. weird stuff) [23:50:29] OK [23:50:34] Is there a WIP in Gerrit? [23:50:39] not yet [23:50:51] I was mostly trying to figure things out [23:51:01] then realized I am yet again changing the MWMediaDialog [23:51:08] and I probably should do that on *top* of ed's commits