[00:19:40] <grrrit-wm>	 (03PS1) 10Alex Monk: Stop API error dialog popping up if you navigate away from the page while Parsoid loads [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110108 
[00:21:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Stop API error dialog popping up if you navigate away from the page while Parsoid loads [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110108 (owner: 10Alex Monk)
[00:22:58] <grrrit-wm>	 (03PS2) 10Alex Monk: Stop API error dialog popping up if you navigate away from the page while Parsoid loads [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110108 
[01:07:59] <superm401>	 Do you have any plans to enable VE as a Beta feature on Meta?
[01:08:28] <superm401>	 That would be helpful, I think.
[02:12:27] <grrrit-wm>	 (03PS5) 10Jhall: [Browsertest] WIP Setting up headless browsertests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108701 
[02:18:26] <grrrit-wm>	 (03PS1) 10Krinkle: Follow-up 7994eae8c2: Fix uncommitted loader change causing 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110121 
[02:49:25] <grrrit-wm>	 (03PS6) 10Jhall: [Browsertest] WIP Setting up headless browsertests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108701 
[06:23:46] <grrrit-wm>	 (03PS2) 10Krinkle: Follow-up 7994eae8c2: Fix uncommitted loader change causing 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110121 
[06:23:52] <grrrit-wm>	 (03PS3) 10Krinkle: Follow-up 7994eae8c2: Fix uncommitted loader change causing 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110121 
[08:05:50] <grrrit-wm>	 (03PS1) 10Krinkle: package.json: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/110144 
[09:26:40] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Follow-up 7994eae8c2: Fix uncommitted loader change causing 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110121 (owner: 10Krinkle)
[09:27:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up 7994eae8c2: Fix uncommitted loader change causing 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110121 (owner: 10Krinkle)
[16:54:32] <Elitre>	 hey edsanders, you around?
[16:54:41] <edsanders>	 hi
[16:55:18] <Elitre>	 hi! we heard that VE doesn't seem to work at ceb.wikipedia.org ; is this known?
[16:56:22] <Elitre>	 edsanders: I wonder if other wikis are affected?
[16:56:30] <edsanders>	 hm
[16:56:48] <edsanders>	 ceb?
[16:57:09] <Elitre>	 edsanders: yup. the page just keeps loading.
[16:58:05] <edsanders>	 I'm getting an exception from their Common.js
[16:58:39] <Elitre>	 good to know (I guess) :)
[16:58:55] <Elitre>	 anything we could do to fix this?
[16:59:19] <edsanders>	 they have an HTML comment on line 1062
[16:59:41] <edsanders>	 I'm guessing you need to be a local admin to fix it
[17:01:21] <edsanders>	 They need to delete '<!--hide script if it don't work'
[17:01:26] <edsanders>	 I'm guessing that will fix it
[17:01:54] <edsanders>	 well
[17:02:18] <edsanders>	 everything beneath it looks like it was supposed to be commented out, so that whole block to the end of the page
[17:04:07] <helderwiki>	 Oh God! That line is there since 2008!
[17:04:07] <helderwiki>	 https://ceb.wikipedia.org/w/index.php?title=MediaWiki:Common.js&diff=229178
[17:06:04] <Elitre>	 edsanders, helderwiki, so if they remove everything that was added with the edit you linked, things will work?
[17:06:36] <edsanders>	 Elitre, yup
[17:06:43] <helderwiki>	 probably
[17:06:57] <helderwiki>	 just be careful not to undo some of the more recent edits...
[17:07:08] <edsanders>	 the completely failure is probably quite recent, resource loader hasn't even been around that long
[17:08:03] <Elitre>	 helderwiki: edsanders, I won't touch anything :) I'll just tell the rest of the team that that is probably the reason why VE won't work, and we'll find a way. Thank you so much! <3
[17:59:01] <helderwiki>	 edsanders: I suggested an update for their common.js
[17:59:02] <helderwiki>	 https://ceb.wikipedia.org/w/index.php?title=Hisgot_sa_MediaWiki:Common.js#Bug_fixes_and_updates
[17:59:16] <helderwiki>	 The problem is none of their suyops seems to be active 
[17:59:48] <helderwiki>	 maybe someone with global editinterface rights could (review and) apply the changes?
[17:59:57] <helderwiki>	 Krinkle|detached: ?
[18:41:55] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Stop API error dialog popping up if you navigate away from the page while Parsoid loads [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110108 (owner: 10Alex Monk)
[18:43:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Stop API error dialog popping up if you navigate away from the page while Parsoid loads [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110108 (owner: 10Alex Monk)
[18:46:24] <RoanKattouw>	 superm401: We want VE on meta, but until the Translate extension fixes a nasty bug we can't really do that
[18:46:54] <RoanKattouw>	 superm401: In particular, Translate manages certain pages and won't let you edit them. VE can't discover this right now, so it lets you edit the page, then errors out on save
[18:47:10] <RoanKattouw>	 which is nasty and should be fixed before VE goes live onto any wiki with lots of Translate-managed pages
[19:07:21] <mooeypoo>	 hm.. does 'toggleClass' work only on strict boolean, or can I use it to resolve to 'false' (so, remove) on 'undefined' too? 
[19:08:13] <RoanKattouw>	 mooeypoo: When in doubt just cast to boolean using !!
[19:08:24] <mooeypoo>	 hmm good point.
[19:08:32] <mooeypoo>	 im trying to see if i can transform this:
[19:08:32] <mooeypoo>	 	if ( this.model.getAttribute( 'border' ) ) {
[19:08:33] <mooeypoo>	 		this.$image.addClass( 'thumbborder' );
[19:08:33] <mooeypoo>	 	}
[19:08:35] <mooeypoo>	 to 'toggleClass'
[19:09:09] <RoanKattouw>	 So if you pass toggleClass false, it will also remove the class if it exists
[19:09:17] * mooeypoo  nods

[19:09:19] <RoanKattouw>	 This may be what you want or it may not be
[19:09:52] <mooeypoo>	 Well, if there's a border attribute, there should be a border, otherwise there shouldn't be. So, if we change the attribute, it should adapt accordingly
[19:09:57] <mooeypoo>	 or .. am I missing something?
[19:33:02] <Krenair>	 RoanKattouw: Know of any VE bugs you think I could handle? I just checked bugzilla and there appear to be about 950 bugs open (and not patch_to_review) for VE
[19:33:21] <RoanKattouw>	 Yeah there are tons of open bugs, and also hundreds of untriaged bugs
[19:33:30] <RoanKattouw>	 Krenair: I have a meeting in -3 minutes (oops) but let me get back to you after
[19:33:48] <Krenair>	 heh okay, sorry
[19:52:00] <MatmaRex>	 Krenair: https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=%3Avisualeditor%20%21easy ? :)
[20:17:42] <edsanders>	 mooeypoo, you need to convert it to a boolean
[20:17:54] <edsanders>	 !!this.model.getAttribute()
[20:18:02] * mooeypoo  nods

[20:18:09] <mooeypoo>	 aye, ended up doing exactly that. Thanks edsanders 
[20:18:23] <edsanders>	 otherwise if it's null/undefined, the toggle will just.. toggle
[20:19:26] <mooeypoo>	 yeah that makes sense.
[20:19:42] <mooeypoo>	 I wasn't sure if !! casts correctly on undefined
[20:33:16] <mooeypoo>	 RoanKattouw_away, is there a difference between offset and outerRange.start for nodes?
[20:59:46] <RoanKattouw>	 mooeypoo: I think offset might be innerRange.start ?
[21:00:18] <mooeypoo>	 hm.
[21:00:26] <RoanKattouw>	 I don't know, I forget
[21:00:34] <RoanKattouw>	 Easiest way to find out is to try in the demo or something
[21:01:42] <mooeypoo>	 yaeh I've been experimenting. Got different problems when I try to insert nodes, though, I'm trying to see what I'm doing wrong.
[21:02:15] <mooeypoo>	 I think i'm going to put my WIP (even though it's a bit messy for now) on gerrit in a bit
[21:22:49] <grrrit-wm>	 (03PS1) 10Mooeypoo: [WIP] Image type inline to block and vise versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 
[21:23:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image type inline to block and vise versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 (owner: 10Mooeypoo)
[22:20:49] <grrrit-wm>	 (03PS1) 10Kaldari: Adding instructions for how to generate the distribution files. [oojs/ui] - 10https://gerrit.wikimedia.org/r/110245 
[22:22:06] <grrrit-wm>	 (03PS2) 10Kaldari: Adding instructions for how to generate the distribution files. [oojs/ui] - 10https://gerrit.wikimedia.org/r/110245 
[23:02:26] <grrrit-wm>	 (03CR) 10Kaldari: "I would consider also making the Node styles optional (modules/ve-mw/ce/styles/ve.ce.Node.css), or moving most of them into core skin styl" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 (owner: 10Jdlrobson)
[23:47:08] <Krenair>	 Hey Krinkle. Are you in the office?
[23:47:17] <Krinkle>	 I am
[23:47:24] <Krenair>	 Is Ro- oh, hi
[23:47:33] <Krinkle>	 Yep
[23:47:34] <Krenair>	 :)
[23:47:45] <Krinkle>	 Is there a sniper pointing at us?
[23:47:59] <Krinkle>	 What's up?
[23:47:59] <grrrit-wm>	 (03CR) 10Catrope: "We should split all of the omnibus CSS files (like ve.ce.Node.css) into separate files. With ResourceLoader there's no reason why we shoul" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 (owner: 10Jdlrobson)
[23:48:05] <RoanKattouw>	 Sorry Krenair 
[23:48:11] <RoanKattouw>	 I had a meeting then lunch then a meeting
[23:48:20] <RoanKattouw>	 You wanted bugs to work on
[23:48:23] <Krenair>	 meh, meetings :/
[23:48:26] <RoanKattouw>	 So let me see what I have
[23:48:47] <RoanKattouw>	 (Also thanks for fixing that annoying bug re error on closing the tab)
[23:48:56] <Krenair>	 yw
[23:49:06] <Krenair>	 I wasn't entirely happy with the fix but I couldn't see another way to do it
[23:49:25] <RoanKattouw>	 I mean it seems reasonable
[23:49:32] <RoanKattouw>	 What you're saying is that an abort is not an error
[23:49:48] <grrrit-wm>	 (03PS2) 10Krinkle: Update oojs to v1.0.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/108888 (owner: 10Jforrester)
[23:50:05] <Krenair>	 Except when it is, it seems. heh
[23:53:26] <RoanKattouw>	 Krenair: Rob owns https://bugzilla.wikimedia.org/show_bug.cgi?id=50897 but you could take that if you like
[23:56:29] <RoanKattouw>	 Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=54587 and https://bugzilla.wikimedia.org/show_bug.cgi?id=51701 are bugs from Ed's worklist that are a bit more complex but would probably help you learn things about VE's architecture
[23:57:23] <RoanKattouw>	 Krenair: They might be a bit daunting without having had a proper tour of the architecture first I suppose; which we should give you at some point
[23:59:02] <RoanKattouw>	 Krenair: Oh! This is a fun one. So, you know how we're all off in JS-land and not doing PHP too much, while you're coming from PHP-land? Here's a pending PHP-land bug https://bugzilla.wikimedia.org/show_bug.cgi?id=51260