[00:01:21] Hey guys, I'm currenty working on getting page content in VE on mobile to look (roughly) the same as regular page content on mobile. I was curious why VE creates a totally different DOM structure for thumbnails (and uses figure elements). Is this something that is also going to implemented in the regular parser at some point (replacing div.thumb > div.thumbinner)? This is a bit problematic for us since (1) our normal thumbnail styles don [00:01:21] get applied, (2) we have to add a bunch of !important overrides since VE explicitly styles this new DOM structure to look like Vector, which we don't want. [00:02:10] mooeypoo: ^ [00:02:15] RoanKattouw: Great. I'm going to take a look into these, probably tomorrow (or rather - this afternoon, it's 00:01 here now). Thank you [00:02:35] Right [00:03:17] Krenair: I also have a few bugs in more contained areas that might be easier to grok, like https://bugzilla.wikimedia.org/show_bug.cgi?id=49502 , https://bugzilla.ikimedia.org/show_bug.cgi?id=50240 and https://bugzilla.wikimedia.org/show_bug.cgi?id=50475 [00:03:51] But I'm just cannibalizing worklists because there are hundreds upon hundreds of open bugs and I'm not in a good position to just know them all and know which ones to send your way. James is, but he's on vacation this week [00:04:10] kaldari: You're talking about the
stuff? [00:04:14] yeah [00:05:14] So I think that eventually we do want the parser to output that. Parsoid certainly does already [00:05:29] We should probably move styles around so (2) is less of a problem [00:05:40] (i.e. VE styling it like Vector shouldn't be happening) [00:05:46] OK, those are both good to hear :) [00:05:56] Ideally Vector would style it as Vector [00:06:02] using
breaks non-JS IE6 compatibility, btw. :P [00:06:27] yeah, I imagine most of those styles should be handled by Vector (or the Mobile skin) at some point [00:10:31] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/108888/ [00:12:45] MatmaRex, that would be 1% of 0.2% or so? [00:14:02] 0.26% according to http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm [00:14:03] gwicke: no idea [00:14:23] and of those maybe 1% have JS disabled [00:14:33] (by "break compatiblity", i mean that non-HTML4 elements can not be styled on IE6, they always use default styles unless you do JS magic) [00:14:51] k [00:14:56] even less of a problem then [00:15:00] (not "break compatibility" as in "pages don't show", they'll just look messed up) [00:16:01] maybe 1 million requests per *month* [00:16:27] million here, million there [00:16:47] * MatmaRex is just playing devil's advocate :> [00:19:45] (03CR) 10Krinkle: [C: 031] Update oojs to v1.0.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/108888 (owner: 10Jforrester) [00:20:40] RoanKattouw: Can you merge ^ and > https://gerrit.wikimedia.org/r/#/c/110144/ [00:23:49] (03PS1) 10Krinkle: package.json: Update devDependencies [oojs/ui] - 10https://gerrit.wikimedia.org/r/110273 [00:25:24] (03CR) 10Krinkle: "Thanks to https://david-dm.org/wikimedia/oojs-ui#info=devDependencies&view=table for helping in finding outdated dependencies and their ch" [oojs/ui] - 10https://gerrit.wikimedia.org/r/110273 (owner: 10Krinkle) [01:13:52] (03PS1) 10Krinkle: unicodejs: Make tool executable, fix path [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110287 [01:17:15] (03PS1) 10Krinkle: unicodejs: Re-generate *properties.js from latest upstream data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110289 [01:18:12] (03CR) 10Krinkle: [C: 04-1] "Don't merge yet. We may need to update our wordbreak implementation depending on whether the others properties have breaking changes that " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110289 (owner: 10Krinkle) [01:18:47] (03CR) 10jenkins-bot: [V: 04-1] unicodejs: Re-generate *properties.js from latest upstream data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110289 (owner: 10Krinkle) [01:36:58] (03PS1) 10Alex Monk: Hide wikitext warning notification when the user removes the markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110295 [01:38:31] Krenair: lol, what happened to "but it's midnight here"? ;) [01:38:45] (03CR) 10jenkins-bot: [V: 04-1] Hide wikitext warning notification when the user removes the markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110295 (owner: 10Alex Monk) [01:38:56] RoanKattouw, yeah that didn't last long haha [01:39:03] (03CR) 10Krinkle: [C: 04-1] Adding instructions for how to generate the distribution files. (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/110245 (owner: 10Kaldari) [01:39:48] (03CR) 10Krinkle: Adding instructions for how to generate the distribution files. (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/110245 (owner: 10Kaldari) [01:41:31] (03PS2) 10Alex Monk: Hide wikitext warning notification when the user removes the markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110295 [01:46:57] (03PS3) 10Kaldari: Add instructions for how to generate the distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/110245 [01:48:19] (03CR) 10Krinkle: [C: 031] Add instructions for how to generate the distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/110245 (owner: 10Kaldari) [01:49:06] (03CR) 10Krinkle: [C: 032] Add instructions for how to generate the distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/110245 (owner: 10Kaldari) [01:49:32] (03Merged) 10jenkins-bot: Add instructions for how to generate the distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/110245 (owner: 10Kaldari) [01:49:54] (03PS4) 10Krinkle: [WIP] Add demo for dialogs and layouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/109006 [02:01:22] (03CR) 10Catrope: Hide wikitext warning notification when the user removes the markup (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110295 (owner: 10Alex Monk) [03:03:58] (03PS1) 10Krinkle: Use new jscs options, disable deprecated JSHint checkstyle options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110305 [04:09:58] (03CR) 10Catrope: [C: 04-1] "-1ing for now per inline comment, although we may end up merging this anyway" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110295 (owner: 10Alex Monk) [12:12:18] (03PS1) 10Zfilipin: [browser test] cucumber.yml is no longer needed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110356 [13:06:33] (03CR) 10Zfilipin: "Should we abandon this commit since this is implemented in the gem now?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108701 (owner: 10Jhall) [13:07:18] (03PS7) 10Esanders: The great image scaling rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109594 [13:46:02] (03CR) 10Esanders: "Ready for review" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109594 (owner: 10Esanders) [13:55:08] (03CR) 10Esanders: [C: 04-1] "Fine but for language variable ordering" (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105098 (owner: 10Mooeypoo) [16:11:59] (03Abandoned) 10Esanders: unicodejs: Re-generate *properties.js from latest upstream data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110289 (owner: 10Krinkle) [16:16:15] (03PS1) 10Esanders: Upgrade UnicodeJS to Unicode 6.3 spec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110387 [16:16:44] (03CR) 10Esanders: "New commit is here: I7a4729d084073ea2" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110289 (owner: 10Krinkle) [16:26:37] (03PS2) 10Esanders: Upgrade UnicodeJS to Unicode 6.3 spec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110387 [16:28:59] (03CR) 10Esanders: [C: 04-1] unicodejs: Make tool executable, fix path (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110287 (owner: 10Krinkle) [16:32:18] (03PS2) 10Esanders: WIP Show recent uploads in MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109670 [16:32:45] (03PS1) 10Zfilipin: Make it possible to run VisualEditor tests in headless mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110390 [16:34:39] (03CR) 10Cmcmahon: [C: 032] Make it possible to run VisualEditor tests in headless mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110390 (owner: 10Zfilipin) [17:15:51] RoanKattouw_away, I'm not sure there's much I can do to that patch [17:46:00] (03PS18) 10Mooeypoo: Adding alternate text to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105098 [17:53:49] (03PS15) 10Mooeypoo: Adding position setting to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105225 [18:01:16] Krenair: Yeah I don't know either :( we'll have to have a chat with James when he's back (Monday) to figure out what sort of bar we want to set for the correctness of that feature [18:01:33] Because obviously it was always a hack and never entirely correct [18:01:44] hi, guys. [18:02:01] sorry, depressing question on its way. [18:02:41] is there a page where I can find out which wikis still have VE as a beta feature? [18:03:00] No worries [18:03:08] Yes [18:03:24] It's not a page exactly, but there is a source of data [18:03:42] whatever, if it lists language codes I can still read it :) [18:09:01] RoanKattouw: I can haz a link? :) [18:09:16] Yeah give me a minute [18:09:23] * RoanKattouw is in a hangout on while on a train on 3G [18:10:01] RoanKattouw: of course! [18:18:40] Elitre: http://git.wikimedia.org/raw/operations%2Fmediawiki-config.git/HEAD/visualeditor.dblist is the list of all wikis that have VE installed [18:18:45] (03Abandoned) 10Jhall: [Browser test] WIP Modifications for PhantomJS compatibility [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/102960 (owner: 10Jhall) [18:18:50] http://git.wikimedia.org/raw/operations%2Fmediawiki-config.git/HEAD/visualeditor-default.dblist is the subset of those that have it enabled by default [18:19:50] Elitre: Other VE-related settings live in http://git.wikimedia.org/raw/operations%2Fmediawiki-config.git/HEAD/wmf-config%2FInitialiseSettings.php (search for VisualEditor). You may or may not be able to decipher them, but feel free to ask questions [18:20:58] RoanKattouw: I will. thanks. another question. there are a few wikipedias which should have VE *not* as a Beta Feature anymore. can you activate it there, or do we need James' presence? [18:21:16] (03Abandoned) 10Jhall: [Browsertest] WIP Setting up headless browsertests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108701 (owner: 10Jhall) [18:21:47] Elitre: I don't physically need James's presence to do so but I'm about to disappear for a week [18:21:58] So hit James up about that when he's back on Monday [18:21:59] (03CR) 10Jhall: [C: 032] [browser test] cucumber.yml is no longer needed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110356 (owner: 10Zfilipin) [18:22:25] And he should be able to cook up a config change and get it deployed in the Tuesday deployment [18:23:00] hey RoanKattouw, do you have krinkle somewhere around? [18:23:05] jenkins's qunit is broken [18:23:08] or something [18:23:24] RoanKattouw: ok, thanks. I think I should be ok with http://git.wikimedia.org/raw/operations%2Fmediawiki-config.git/HEAD/visualeditor-default.dblist . the wikis I'm thinking of aren't there, obviously. :/ [18:30:15] (03PS2) 10Krinkle: unicodejs: Make tool executable, fix path [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110287 [18:34:31] (03Merged) 10jenkins-bot: Make it possible to run VisualEditor tests in headless mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110390 (owner: 10Zfilipin) [18:34:48] Elitre: FYI: yesterday I suggested an update for [[ceb:MediaWiki:Common.js]] which might fix a few problems for them: [18:34:48] https://ceb.wikipedia.org/wiki/Mediawiki_talk:Common.js#Bug_fixes_and_updates [18:35:42] (03CR) 10jenkins-bot: [V: 04-1] Adding alternate text to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105098 (owner: 10Mooeypoo) [18:35:51] (03CR) 10jenkins-bot: [V: 04-1] Adding position setting to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105225 (owner: 10Mooeypoo) [18:38:47] (03Merged) 10jenkins-bot: [browser test] cucumber.yml is no longer needed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110356 (owner: 10Zfilipin) [18:40:11] (03CR) 10Jdlrobson: "Catrope could you give some guidance on how this might look from a VE desktop perspective? Would it be one module for styles with lots of " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 (owner: 10Jdlrobson) [18:52:11] helderwiki: hi, thanks. someone else took care of that, I'm sure they noticed your message. [18:53:30] Elitre: I think he fixed just the most emergencial parts of the JS, but I contacted him again: [18:53:30] https://meta.wikimedia.org/w/index.php?diff=7289140&oldid=7276927 [18:54:01] my comment in the talk page probably was not noticed since there are no active sysops on that wiki [18:54:17] *talk page = [[ceb:Hisgot sa MediaWiki:Common.js]] [19:01:39] * mooeypoo is off to class [19:01:44] see you guys later! [19:02:00] RoanKattouw_away, took a look into https://bugzilla.wikimedia.org/show_bug.cgi?id=50897 and (as I posted on the bug) discovered that FlaggedRevs breaks this... should FR be made to avoid veaction=edit as well? [19:05:45] thanks, helderwiki. I'll make sure he notices. [19:05:56] Ok :-) [19:08:02] Krenair: I can't recall French users complaining about this before. the shortcut is probably not so widely used yet. Since Roan, James and others are away, would you like me to ping them about them and get an answer when it's possible? it might take some days though. [19:08:53] It's fine I just wasn't sure how aware other extensions should be of VE [19:11:18] Krenair: why not just remove the FR accesskey when opening the editor and restore it after saving/cancelling? [19:11:27] Krenair: VE is certainly FR-aware already [19:11:35] or should be [19:11:56] krenair: I wouldn't know about that :) anyway, I'll ping you at https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis when I know more. [19:12:00] there's bugs thought� https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=flagged%20visual [19:12:03] though* [19:12:14] MatmaRex, $( '[accesskey=s]' ).attr( 'accesskey', undefined ); ? :) [19:12:19] sorry, wrong page :) [19:12:43] Krenair: basically [19:13:01] just restore it after closing the editor [19:13:13] Krenair: someone will just answer in that bug ;) [19:13:32] it already works like that with the regular editor [19:13:49] Elitre, um, I'm not really sure why users would really care how this is implemented... [19:16:57] krenair: not sure what you mean? I just said that that I or someone else will use that bug to reply to your question. [19:18:50] Elitre, you said you were going to ping me on frwiki? [19:20:29] Krenair: I corrected myself later, and said the bug would have been the right venue :) [19:20:43] ah ok [19:23:33] bye all [19:23:36] * Elitre waves [19:36:34] (03PS2) 10Trevor Parscal: FieldLayout, styling improvements and standardization [oojs/ui] - 10https://gerrit.wikimedia.org/r/108955 [19:38:14] (03PS3) 10Trevor Parscal: FieldLayout support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108958 [19:39:35] (03PS1) 10Alex Monk: Use accesskey=s on the save buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 [19:40:15] (03CR) 10jenkins-bot: [V: 04-1] FieldLayout support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108958 (owner: 10Trevor Parscal) [19:42:33] (03PS4) 10Trevor Parscal: FieldLayout support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108958 [19:48:07] (03CR) 10jenkins-bot: [V: 04-1] FieldLayout support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108958 (owner: 10Trevor Parscal) [20:12:30] Hey Trevor, are you a good person to talk to about the new DOM model in VE for images? [20:13:04] TrevorParscal: ^ [20:22:27] maybe? [20:22:56] admitedly, edsanders and RoanKattouw_away know more than I do about DM stuff, but I usually know enough to answer questions [20:22:59] what's crackin? [20:23:16] I'm also here [20:29:58] edsanders:https://bugzilla.wikimedia.org/show_bug.cgi?id=60642 , this is happening on test2 and mw.org [20:35:08] (03CR) 10Reedy: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110054 (owner: 10L10n-bot) [20:35:18] (03CR) 10Reedy: [C: 032] Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110054 (owner: 10L10n-bot) [20:36:22] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110054 (owner: 10L10n-bot) [20:39:48] TrevorParscal, esanders: I'm currently stuck between a rock and a hard place. I'm working on getting the mobile VE styling to not look like a total mess. The new image DOM is obviously a problem since none of the existing mobile thumbnail styling gets applied and VE provides it's own styles for them which are designed to match Vector. My solution was to add a bunch of !important overrides in MobileFrontend to make the VE styling match th [20:39:48] normal mobile styling for thumbnails. But I'm getting pushback from the other mobile devs who say this should be fixed on VE's side. There are basically two things that we would want to change, ideally: 1. Add some of the old classes to the new VE DOM (thumb and thumbinner specifically) and move the custom styling for them out of VE and into the skins. Thoughts? [20:40:48] kaldari: we should probably divide ve content styles from ve affordance styles, and make them both optional when including ve [20:41:15] then you can make all your own content styles without having to painstakingly recreate and maintain the affordance styles [20:41:26] simple as splitting the RL module I believe [20:42:15] Cool, is that something that would make sense for me to work on or the VE team? [20:43:54] well, jon did this for ooui already, that seemed to go over well enough [20:44:01] edsanders: your thoughts? [20:44:05] thar be dragons? [20:44:39] 1 sec [20:46:58] TrevorParscal, can you explain ve content vs ve affordance styles? [20:47:27] OK, I'm going to run off to grab some lunch, but I'd also love to hear your thoughts on making the new thumbnail DOM a bit more backwards compatible, as that would keep us from having to load a bunch more styles on mobile. [20:47:35] well, resize handles would be affordances, but the styling of image to make it look like vector would be contnet [20:47:42] would need some teasing apart [20:48:13] the other thing to note is that hopefully one day Parsoid with be the only renderer in town [20:48:19] right [20:48:52] Ideally the content styles would be pushed upstream [20:49:07] I think I even put todo comments next them [20:50:07] btw, speaking of resizing: I was recently wondering if we should try harder to set sizes relative to a default thumb size rather than as absolute sizes [20:50:30] the upright option (spectacularly misnamed) offers that ability [20:51:18] upright=1.5 would make the thumb 1.5x as large as a default thumb [21:05:53] wtf. Image syntax is ridiculous. [21:16:33] I think it was introduced in response to the bug in the default thumb size that only limits its width, but not its height [21:16:52] so portrait thumbs end up larger than landscape ones [21:17:20] the default value of upright is 0.75, which then works out about the same as the square bounding box we should have had to start with [21:18:09] sadly upright also only limits its width [21:18:29] which might also be the reason not to use it for scaling.. [21:18:39] pretty messed up overall [21:33:16] (03PS5) 10Trevor Parscal: Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [21:33:52] (03CR) 10Trevor Parscal: "Made some style changes, swapping which element had the border/height animation." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [21:33:56] (03CR) 10jenkins-bot: [V: 04-1] Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [21:35:04] (03PS4) 10Robmoen: WIP: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 [21:36:16] (03CR) 10jenkins-bot: [V: 04-1] WIP: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [22:25:45] (03PS2) 10Krinkle: Use new jscs options, disable deprecated JSHint checkstyle options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110305 [22:26:34] (03PS1) 10Jhall: [Browser test] WIP Headless test for VE verification on a fresh Mediawiki install (as on Integration server). [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110468 [22:53:22] (03PS5) 10Krinkle: [WIP] Add demo for dialogs and layouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/109006 [23:52:31] (03PS4) 10Jdlrobson: Make default OOJS UI styles optional [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 [23:52:33] (03PS4) 10Jdlrobson: Move VisualEditor toolbar to Overlay header [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 [23:53:55] (03CR) 10jenkins-bot: [V: 04-1] Make default OOJS UI styles optional [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 (owner: 10Jdlrobson) [23:54:55] (03CR) 10jenkins-bot: [V: 04-1] Move VisualEditor toolbar to Overlay header [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson)