[00:32:48] (03PS2) 10Divec: WIP:Fix handleEnter in nodes that don't split [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109693 [00:35:34] (03CR) 10Divec: "If you follow the recipe of bug 59911, is the current behaviour (with this patch) acceptable/desirable?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109693 (owner: 10Divec) [00:41:30] (03PS1) 10Alex Monk: Fix search results when $wgDebugToolbar is enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110478 [00:42:16] ^ I swear I've seen other JS code making that assumption about the API before [00:42:23] I wonder what else does it... [00:52:49] (03CR) 10Divec: "The documentation helps! Were the *properties.js files regenerated with unicodejs-properties.py ? If so, I guess (1) we should note so in " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110387 (owner: 10Esanders) [00:58:45] (03PS1) 10Krinkle: Gruntfile: Don't forget to watch css files as well [oojs/ui] - 10https://gerrit.wikimedia.org/r/110482 [00:59:07] (03CR) 10Trevor Parscal: [C: 032] Gruntfile: Don't forget to watch css files as well [oojs/ui] - 10https://gerrit.wikimedia.org/r/110482 (owner: 10Krinkle) [00:59:36] (03Merged) 10jenkins-bot: Gruntfile: Don't forget to watch css files as well [oojs/ui] - 10https://gerrit.wikimedia.org/r/110482 (owner: 10Krinkle) [00:59:38] (03PS6) 10Krinkle: [WIP] Add demo for dialogs and layouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/109006 [01:19:08] (03CR) 10Esanders: "Yes and yes." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110387 (owner: 10Esanders) [01:23:18] (03PS7) 10Krinkle: [WIP] Add demo for dialogs and layouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/109006 [01:38:33] (03CR) 10Esanders: [C: 04-1] Move VisualEditor toolbar to Overlay header (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson) [01:51:56] (03PS1) 10Jhall: Merge "Stop API error dialog popping up if you navigate away from the page while Parsoid loads" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110490 [01:54:02] (03Abandoned) 10Jhall: Merge "Stop API error dialog popping up if you navigate away from the page while Parsoid loads" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110490 (owner: 10Jhall) [01:54:31] wat. [01:55:12] JeffHall, if there is an issue with my patch set I would appreciate it if you could talk to me before trying to revert it [01:55:50] Krenair: Trying to revert two changes that completely broke the VE browsertests [01:56:09] Was it "Stop API error dialog popping up if you navigate away from the page while Parsoid loads"? Or is that completely unrelated? [01:56:12] Krenair: But I'm not very familiar with Gerrit, so I'm obviously doing somethign wrong [01:56:40] Krenair: Unrelated - I used a bad workflow and abandoned my change in Gerrit [01:56:44] ah, ok [01:56:59] Krenair: The bad commits are the two commits following the one you mentioned [01:57:34] You should be able to revert the bad changes by browsing to each and clicking the 'Revert change' button (next to Review and Cherry Pick To) [01:58:24] Krenair: Let me try that - like I said, I'm new to Gerrit! Thanks for the info [02:02:57] (03PS1) 10Jhall: Revert "Make it possible to run VisualEditor tests in headless mode" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110493 [02:04:36] (03CR) 10Jhall: [C: 032] "Doing a self-merge in the interests of getting VisualEditor browser tests back to a working state!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110493 (owner: 10Jhall) [02:05:43] (03Merged) 10jenkins-bot: Revert "Make it possible to run VisualEditor tests in headless mode" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110493 (owner: 10Jhall) [02:10:41] Krinkle, got a moment? [02:17:19] Krenair: Yep [02:17:53] Krinkle, I was working on https://bugzilla.wikimedia.org/show_bug.cgi?id=50240 (Have the link inspector inform users if they're linking to a disambiguation or redirect page, or reinserting the same link) [02:18:23] unfortunately I need to do an extra query to work out whether a given page is a redirect or a disambiguation (am hoping this will be okay) [02:18:48] (03CR) 10Krinkle: [C: 031] Upgrade UnicodeJS to Unicode 6.3 spec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110387 (owner: 10Esanders) [02:19:33] Krenair: If you need it always, it may be possible to do that from a generator query connected to the opensearch suggestions call [02:19:47] e.g. for each suggestion get some meta data [02:19:55] So far I got it working as a synchronous query but I'm expecting it will need to be async... Am not quite sure what the best way to make that work would be. The function that's doing the work needs to return the data so can't really sit around waiting for a callback to complete [02:20:17] Indeed, no sync requests unless needed for something important [02:20:33] Hm... [02:20:52] if it's not too much data, it might be worth it to do that way (getting ahead of time with generator combo call). It'll query it for more pages than you need, with the benefit of having it right away when the user selects an item. [02:21:01] So you can immediately act on it, or perhaps even display them differently in the first place [02:21:22] opensearch is it's own action, I don't think it can be used as a generator [02:23:06] (03CR) 10Catrope: [C: 031] "Looks reasonable to me, but I'm not very familiar with the intricacies of access keys. Timo, can you review?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 (owner: 10Alex Monk) [02:29:07] Krenair: There should still be a way to do that though [02:29:10] Not sure [02:29:41] either way, separate request can be done intermediary. We might want to optimise before merging, but OK for now. If there is no way to combine them I think 1 http request per selecting a link target is OK. [02:29:50] (03CR) 10Catrope: [C: 04-1] "Holy crap! Maybe, just maybe, the API shouldn't randomly convert opensearch output to something that isn't opensearch format (not to menti" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110478 (owner: 10Alex Monk) [02:31:01] Krinkle, Krenair: Unfortunately you can't use generators with opensearch [02:31:08] So you'll need two separate API queries [02:31:45] (That keyboard shortcut was supposed to go to nano, not xchat. -.-) [02:31:52] Krenair: If you're not already familiar, you can chain promises to make two queries in a way that's transparent to the caller [02:32:49] Depending on the nature of the information you might also be able to display the information to the user and then change it later when the second query result comes in, but that would be harder to fit into the LookupInputWidget API [02:33:08] (03PS2) 10Alex Monk: Fix search results when $wgDebugToolbar is enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110478 [02:33:36] RoanKattouw, I agree with you about the way wgDebugToolbar works in the API by the way [02:34:13] (03CR) 10jenkins-bot: [V: 04-1] Fix search results when $wgDebugToolbar is enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110478 (owner: 10Alex Monk) [02:34:42] oops. [02:34:42] (03PS3) 10Alex Monk: Fix search results when $wgDebugToolbar is enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110478 [02:36:12] (03CR) 10Catrope: [C: 032] Fix search results when $wgDebugToolbar is enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110478 (owner: 10Alex Monk) [02:36:35] I'll look into the disambig/redirect stuff again later. I need some sleep. [02:37:19] (03Merged) 10jenkins-bot: Fix search results when $wgDebugToolbar is enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110478 (owner: 10Alex Monk) [02:37:58] Dude it's 2:30 [02:38:01] Go to sleep already :) [02:48:18] Alright, gotta go to my flight, see you guys [03:23:24] (03PS1) 10Krinkle: Implement generateDocs.sh script [oojs/core] - 10https://gerrit.wikimedia.org/r/110506 [03:26:31] 01[13oojs.github.io01] 15none pushed 3 new commits to 06master: 02https://github.com/oojs/oojs.github.io/compare/8ac45c2d99f6...501023a5b3a8 [03:26:32] 13oojs.github.io/06master 14d6f9b39 15Timo Tijhof: Publish v1.0.7 release from npm [03:26:32] 13oojs.github.io/06master 143369fcc 15Timo Tijhof: Regenerate docs for v1.0.7 [03:26:33] 13oojs.github.io/06master 14501023a 15Timo Tijhof: index.html: Redirect to relative path [04:11:49] (03CR) 10Krinkle: [C: 04-1] Use accesskey=s on the save buttons (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 (owner: 10Alex Monk) [04:12:29] (03CR) 10Krinkle: "Accesskeys tend to be assigned via interface messages in extensions. Not sure this one is safe to use. If it is, we should probably try to" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 (owner: 10Alex Monk) [14:32:57] (03PS3) 10Esanders: Upgrade UnicodeJS to Unicode 6.3 spec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110387 [16:14:24] (03CR) 10Esanders: "Is this still WIP or ready for review?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/108955 (owner: 10Trevor Parscal) [16:40:15] (03CR) 10Esanders: [C: 031] FieldLayout, styling improvements and standardization (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/108955 (owner: 10Trevor Parscal) [16:42:10] (03CR) 10Esanders: [C: 031] Adding alternate text to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105098 (owner: 10Mooeypoo) [17:39:52] (03CR) 10Esanders: "FIXME: The toggle switch looks really narrow, and the grip barely moves at all when clicked. Could do with with being an extra em wide." [oojs/ui] - 10https://gerrit.wikimedia.org/r/107886 (owner: 10Trevor Parscal) [17:43:00] (03PS2) 10Alex Monk: Use accesskey=s on the save buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 [18:46:11] (03PS1) 10Jhall: [Browser test] Reintroduce headless browser test support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110606 [20:42:56] heyo, thought i would announce here that next friday is my last day at Wikia [20:43:15] i might still contribute to VE in my spare time, though :) [21:08:14] * mooeypoo shakes her fist at transactions [21:08:44] guys, anyone remembers how to check the latest transactions in the console? I can't find it [21:49:05] Heya. [21:49:11] hey James! [21:49:15] how's your vacation going? [21:49:34] It's been fun. [21:49:49] Am flying home tonight. [21:52:31] ooh back to the future again? [21:52:36] actually, back to the past. [21:52:51] or something. [21:53:00] :-) [21:53:10] Yeah, it's currently 08:53 on Saturday for me. :-) [21:54:30] James_F: Gotta get back in ti-ime [21:54:39] True. [21:58:16] Did you have a fun vacation James_F ? [21:58:52] mooeypoo: Yes; but far, far too hot. [21:59:17] Don't say that to Atlanta people, they might get jealous. [22:01:18] I'd have loved to have some snow [22:01:31] It was 38C in Canberra for a few of the days there. [22:01:45] Now I'm back in Sydney and it's "only" 34C. [22:01:59] If you have a stopover in the Northeast, just step out for a couple of minutes. [22:02:15] Direct flight, sorry. :-) [22:02:34] wow direct from Australia to SF !? [22:02:56] Yeah, it's 14 hours of doom. [22:03:03] oh, 14 hours isn't THAT bad. [22:03:09] Flights to Israel are ~12 [22:03:10] United have these 747s with no entertainment. [22:03:17] oh.. okay, that IS bad [22:03:39] Yeah. :-( [22:03:44] though when I worked in the airport, I went to Israel (12 hour flight) sitting on a folding attendant's seat near the bathroom. [22:03:52] So.. you're... not THAT bad. [22:03:53] It's OK in business class, but I'm not paid enough for that. [22:04:15] My seat *is* next to the bathroom, actually. [22:04:19] Oh well. [22:04:38] But it's reclining, and does not have a buckle ramming against your back... [22:04:41] I hope, at least. [22:04:51] how can such a long flight not have entertainment systems?? [22:05:20] Because United haven't invested in their fleet for over a decade? [22:05:42] Even internal flights in the US have entertainment systems. [22:05:56] I went on a 1-hr flight to Boston and there was an in-flight movie [22:06:15] which was rather amusing, since I couldn't finish it. You'd have thought they'd think that was obvious... [22:08:41] They're finally replacing them with 777s – but not 'til 1 April: http://www.ausbt.com.au/united-upgrades-sydney-melbourne-flights-to-boeing-777s [22:10:02] 777 are much smaller though than 747s [22:10:21] It's not always an "upgrade". Though if you have an entertainment system, I guess that counts [22:12:46] Yeah, the 777 economy seats are significantly better than the 747's. [22:13:10] But the reduction in seats (given that the planes fly full most of the time) means price increases (unless they add an extra flight or two). [22:13:13] Hey edsanders. [22:15:31] (03PS2) 10Mooeypoo: [WIP] Image type inline to block and vise versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 [22:16:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image type inline to block and vise versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 (owner: 10Mooeypoo) [22:16:25] (03Abandoned) 10Jhall: [Browser test] WIP New test for Page Settings menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103513 (owner: 10Jhall) [22:21:06] hey [22:37:23] Are Timo and Roan not around? [22:47:10] Roan's in Europe [22:48:55] Am just wondering about ve.init.mw.Target.static.apiRequest vs. mw.Api [22:59:47] Krenair: I think we wrapped the api calls in the VE-specific class for convenience. [23:02:17] James_F, have just been wondering how I might go about getting .abort to work when I'm using .then to chain query [23:02:36] Krenair: Afraid that's beyond me, sorry. :-( [23:03:30] James_F, by the way - don't know if you saw, but I made a few patches for VE [23:03:41] I did. Thanks. :-) [23:07:36] Have been trying to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=50240 but ran into some issues relating to synchronous querying. Most of it's fine there's just a nasty console error now because now .abort isn't working [23:10:56] (03PS1) 10Jforrester: Don't throw JS errors when opening MWExtensionInspector on the wrong node type [extensions/VisualEditor] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110652 [23:11:17] Krenair: Nice! :-0 [23:11:30] Krenair: That's been one of my hobby-horse bugs for a while. [23:13:16] Actually I will upload to gerrit with CR-1 so we can check this has turned out how you would expect [23:13:31] (03PS1) 10Alex Monk: Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 [23:13:39] (03CR) 10jenkins-bot: [V: 04-1] Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk) [23:13:40] * James_F nods. [23:13:57] hmph. needs a rebase [23:14:51] (03PS2) 10Alex Monk: Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 [23:16:01] (03CR) 10jenkins-bot: [V: 04-1] Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk) [23:20:47] (03PS3) 10Alex Monk: Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 [23:22:29] James_F, basically the way this looks at the moment is that redirects and disambig pages are separate from the rest of the matches, in their own sections. I wasn't sure if you guys had something different in mind [23:22:56] Krenair: Hmm. Interesting. [23:23:20] Krenair: That might work. I was initially thinking of icons and greying-out/italicising results, but that might be confusing. [23:29:06] (03CR) 10Alex Monk: [C: 04-1] Mark disambiguation and redirect pages in the link inspector (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk) [23:32:02] (03PS1) 10JGonera: Make MobileViewTarget scroll to desired section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110655 [23:37:41] (03PS1) 10Jhall: [Browser test] WIP New test for VE Page Settings menu. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110659 [23:55:59] (03CR) 10Krinkle: Mark disambiguation and redirect pages in the link inspector (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk)