[00:06:56] <grrrit-wm>	 (03PS1) 10Jforrester: Add tagName to ve.dm.MWGalleryNode [extensions/VisualEditor] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110826 
[00:08:33] <grrrit-wm>	 (03PS3) 10Krinkle: unicodejs: Make tool executable, fix path [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110287 
[00:09:15] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] unicodejs: Make tool executable, fix path [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110287 (owner: 10Krinkle)
[00:10:08] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update oojs to v1.0.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/108888 (owner: 10Jforrester)
[00:10:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: unicodejs: Make tool executable, fix path [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110287 (owner: 10Krinkle)
[00:11:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update oojs to v1.0.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/108888 (owner: 10Jforrester)
[00:31:37] <Krenair>	 James_F, hey, you around?
[01:03:00] <James_F>	 Krenair: Yes.
[01:03:03] <James_F>	 Krenair: How are you?
[01:05:02] <Krenair>	 James_F, feeling much better thanks
[01:06:05] <Krenair>	 James_F, I was wondering if you had any bugs in mind that you think I could handle
[01:06:07] <James_F>	 Good.
[01:06:11] * James_F  looks.

[01:06:17] <Krenair>	 I went through some that Roan sent me already
[01:06:24] <James_F>	 Nice. :-)
[01:07:24] <James_F>	 Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=52848 might be worth working on. There's also https://gerrit.wikimedia.org/r/#/c/32700/ that needs some love.
[01:10:02] <James_F>	 Krenair: Also https://bugzilla.wikimedia.org/show_bug.cgi?id=50206 and actually making https://gerrit.wikimedia.org/r/#/c/72108/ work (will need to be re-ported).
[01:10:52] <James_F>	 Krenair: And https://bugzilla.wikimedia.org/show_bug.cgi?id=49502 ?
[01:10:53] <James_F>	 ;-)
[01:10:58] * James_F  cackles.

[01:11:13] <James_F>	 Krenair: No urgency or screaming rush, and don't feel like you have to do all/any of them. :-)
[01:15:16] <Krenair>	 James_F, how is Nischay's feedback stuff related to VE?
[01:17:09] <James_F>	 Krenair: We (well, rmoen and Krinkle|detached) were working on it to make it more useful for VE feedback.
[01:17:30] <James_F>	 Krenair: Specifically, the problem that many bug reports are useless without UA information.
[01:18:33] <James_F>	 Krenair: I'd note BTW that that patch really needs a RELEASE_NOTES entry (thankfully it doesn't yet have one, otherwise it'd be off MW1.20 ;-)).
[01:20:20] <Krenair>	 James_F, 49502 - sounds like something that's handled by my existing patch for disambig/redirects...?
[01:20:51] <James_F>	 Krenair: Yeah – worth checking that the behaviour is as described?
[01:20:56] <Krenair>	 ok
[01:21:22] <James_F>	 Krenair: Also, does your patch only apply to the link suggestion box, or also for transclusion and category suggestion?
[01:21:28] <Krenair>	 amazon silk blacklisting - what needs to be done here? 
[01:21:38] <James_F>	 (And if so, are there special cases that need to be considered?)
[01:21:39] <Krenair>	 James_F, only for link suggestion...
[01:21:44] <James_F>	 Ah. Boo.
[01:22:24] <James_F>	 Amazon Silk uses a funny UA string that jQuery.client doesn't have the ability to match on; someone needs to sit down and re-work the regex so that it can. Right now my WIP is simply some failing tests.
[01:22:49] <Krenair>	 I see
[01:23:05] <Krenair>	 alright, over the next few days I'll look into these
[01:23:09] <James_F>	 Now the code it's calling is in a different repo, which makes for fun times.
[01:23:13] <James_F>	 Cool. Thank you! :-)
[01:26:27] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110808 (owner: 10L10n-bot)
[01:27:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110808 (owner: 10L10n-bot)
[01:31:34] <grrrit-wm>	 (03PS3) 10Jforrester: Use new jscs options, disable deprecated JSHint checkstyle options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110305 (owner: 10Krinkle)
[01:32:33] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "PS3 is a rebase onto master (with re-generated …properties.js files)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110305 (owner: 10Krinkle)
[01:32:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use new jscs options, disable deprecated JSHint checkstyle options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110305 (owner: 10Krinkle)
[01:47:38] <Krenair>	 James_F, I actually can't reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=49502 on the latest master...
[01:51:57] <grrrit-wm>	 (03PS4) 10Jforrester: Use new jscs options, disable deprecated JSHint checkstyle options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110305 (owner: 10Krinkle)
[01:56:38] <Krenair>	 James_F, is https://bugzilla.wikimedia.org/show_bug.cgi?id=57462 a dupe of https://bugzilla.wikimedia.org/show_bug.cgi?id=47779 ?
[01:59:37] <James_F>	 Krenair: Hmm. Yeah, I think 49502 got fixed haphazardly.
[02:00:21] <James_F>	 Krenair: And no; 57462 is making the one-way switch available on clicking the edit source tab.
[02:01:02] <James_F>	 Krenair: Whereas 47779 is a much bigger thing about magically avoiding re-serialising bugs when switching back and forth between VE and WT.
[02:02:37] <James_F>	 Krenair: In 57462, currently if you're in VE and have made some changes and click "edit source", you get an OK/cancel alert – in Chrome, "Are you sure you want to go back to view mode without saving first? \n \n Are you sure that you want to leave this page?".
[02:03:35] <James_F>	 Krenair: The idea is to change that alert into one that says "Do you wish to switch to wikitext mode with changes, or discard them?" and get [Switch], [Switch discarding changes] and [Cancel] or something.
[02:03:40] <James_F>	 Krenair: If that makes sense?
[02:03:52] <Krenair>	 James_F, ah, yes, I think so
[02:03:56] <James_F>	 Kk.
[02:24:41] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Implement generateDocs.sh script [oojs/core] - 10https://gerrit.wikimedia.org/r/110506 (owner: 10Krinkle)
[02:24:53] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] package.json: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/110144 (owner: 10Krinkle)
[02:25:18] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Localisation updates from https://translatewiki.net. [oojs/ui] - 10https://gerrit.wikimedia.org/r/110761 (owner: 10L10n-bot)
[02:25:32] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] package.json: Update devDependencies [oojs/ui] - 10https://gerrit.wikimedia.org/r/110273 (owner: 10Krinkle)
[02:26:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [oojs/ui] - 10https://gerrit.wikimedia.org/r/110761 (owner: 10L10n-bot)
[02:26:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: package.json: Update devDependencies [oojs/ui] - 10https://gerrit.wikimedia.org/r/110273 (owner: 10Krinkle)
[02:26:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implement generateDocs.sh script [oojs/core] - 10https://gerrit.wikimedia.org/r/110506 (owner: 10Krinkle)
[02:27:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: package.json: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/110144 (owner: 10Krinkle)
[02:28:22] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "C'mon npm, don't die on me here." [oojs/core] - 10https://gerrit.wikimedia.org/r/110506 (owner: 10Krinkle)
[02:28:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implement generateDocs.sh script [oojs/core] - 10https://gerrit.wikimedia.org/r/110506 (owner: 10Krinkle)
[02:39:37] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110828 
[02:40:31] <grrrit-wm>	 (03PS2) 10Jforrester: Update VE core submodule to master (4792b08) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110828 
[02:59:19] <grrrit-wm>	 (03PS6) 10Jforrester: Add updateSubmodule.sh script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108180 (owner: 10Catrope)
[02:59:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add updateSubmodule.sh script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108180 (owner: 10Catrope)
[03:04:01] <grrrit-wm>	 (03PS7) 10Jforrester: Add updateSubmodule.sh script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108180 (owner: 10Catrope)
[03:06:02] <grrrit-wm>	 (03CR) 10Jforrester: "PS6 adds the short hash of the submodule to the title of the commit if it's master." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108180 (owner: 10Catrope)
[03:08:41] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] Use new jscs options, disable deprecated JSHint checkstyle options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110305 (owner: 10Krinkle)
[03:13:02] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Add updateSubmodule.sh script (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108180 (owner: 10Catrope)
[03:14:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add updateSubmodule.sh script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108180 (owner: 10Catrope)
[03:15:42] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Use new jscs options, disable deprecated JSHint checkstyle options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110305 (owner: 10Krinkle)
[03:16:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use new jscs options, disable deprecated JSHint checkstyle options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110305 (owner: 10Krinkle)
[03:35:28] <grrrit-wm>	 (03PS3) 10Jforrester: Update VE core submodule to master (5092503) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110828 
[03:36:56] <Krenair>	 James_F, ^ worksforme?
[03:37:07] <Krenair>	 woops... that's https://bugzilla.wikimedia.org/49502
[03:37:19] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Update VE core submodule to master (5092503) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110828 (owner: 10Jforrester)
[03:37:19] <James_F>	 Krenair: Sounds good. Want me to fiddle or you?
[03:37:33] <James_F>	 Krenair: Also, it's 03:37. :-)
[03:38:06] <Krenair>	 yes... have been waiting until I get tired but am about to give up and try to sleep anyway
[03:38:12] <James_F>	 Ha.
[03:38:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (5092503) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110828 (owner: 10Jforrester)
[04:54:50] <RoanKattouw>	 mooeypoo: ve.instances[0].model.documentModel.completeHistory IIRC
[05:39:09] <RoanKattouw>	 mooeypoo: [05:54]	RoanKattouw	mooeypoo: ve.instances[0].model.documentModel.completeHistory IIRC
[05:39:26] <mooeypoo>	 heya RoanKattouw 
[05:39:45] * RoanKattouw  waves from early morning in Brussels

[05:39:54] <mooeypoo>	 thanks :) I need to keep it around. Also, I *think* I found a bug in ve.dm.Document method
[05:39:55] <RoanKattouw>	 I've been awake since 3:50, up since 4:30
[05:40:00] <RoanKattouw>	 Ooh!
[05:40:01] <mooeypoo>	 eek
[05:40:15] <mooeypoo>	 that's early.. jetlag?
[05:40:16] <RoanKattouw>	 I suppose it's past 6:30 now so I can go get breakfast
[05:40:19] <RoanKattouw>	 Yeah, well
[05:40:23] <RoanKattouw>	 I could have stayed up last night
[05:40:29] <RoanKattouw>	 But I chose to just go to sleep at 20:30 again
[05:40:38] <mooeypoo>	 well you're only there for a couple of days
[05:40:45] <mooeypoo>	 might as well not get used to the jetlag completely
[05:40:46] <RoanKattouw>	 Like the night before, only that time I slept till the alarm at 9 due to jetlag
[05:41:03] <RoanKattouw>	 I would have actually made the Friday standup if I had had 3G on the train from Brussels Airport to Brussels Central
[05:41:24] <RoanKattouw>	 Which is funny because I also attended the Thursday standup from a train (from SF to Palo Alto), and I hadn't slept in between the two
[05:41:46] <RoanKattouw>	 And yeah, I'm going home tomorrow
[05:41:50] <mooeypoo>	 hehe
[05:41:52] <RoanKattouw>	 Not too much of a point adjusting to the timezone
[05:41:56] <mooeypoo>	 yeah that's quick
[05:42:02] <mooeypoo>	 but did you have time to have some fun ?
[05:42:30] <mooeypoo>	 Wait... Brussels!!! ... SPECULOOS.
[05:42:36] <mooeypoo>	 .... mmmmmmmm.
[05:42:44] <mooeypoo>	 Right? I think that's its origin.
[05:44:03] <RoanKattouw>	 Yeah speculoos is Belgian I think
[05:44:06] <mooeypoo>	 oh, your country seems to be sharing it with belgium. 
[05:44:07] <RoanKattouw>	 I looked this up on Wikipedia
[05:44:12] <RoanKattouw>	 Speculaas is the Dutch cookie
[05:44:13] <mooeypoo>	 Wikipedia is never wrong.
[05:44:20] <RoanKattouw>	 Speculoos is the adaptation of it to cookie butter, IIRC
[05:44:31] <RoanKattouw>	 or whatever it is, speculoos is a Belgian adaptation of speculaas
[05:44:32] <mooeypoo>	 They brought Speculoos to "Le Pain Quotidient" here in NYC
[05:44:41] <RoanKattouw>	 Trader Joe's has it too
[05:44:58] <mooeypoo>	 I thought at first it was whachamacall it.. the halloween fruit.. pumpkin
[05:44:59] <RoanKattouw>	 They sell speculoos cookie butter
[05:45:02] <RoanKattouw>	 right
[05:45:07] <RoanKattouw>	 No, it most definitely is not
[05:45:18] <mooeypoo>	 and then my mouth was attacked with cinammony cookie bliss
[05:45:28] <RoanKattouw>	 You know, it's funny
[05:45:39] <RoanKattouw>	 Until this winter I had never tasted an actual gingerbread cookie
[05:45:45] <mooeypoo>	 Ha really?
[05:45:47] <RoanKattouw>	 I ate one in London and was surprised it tasted of ginger
[05:45:59] <RoanKattouw>	 Then I realized that gingerbread and speculaas are different
[05:46:11] <RoanKattouw>	 And my country has substituted speculaas at every opportunity
[05:46:32] <mooeypoo>	 I support this notion.
[05:46:33] <mooeypoo>	 I ate my first one in the USA too, we don't really have those in Israel. But a couple of months ago I bought Gingersnap cookies... they were *spicy*.
[05:46:45] <mooeypoo>	 Spicy cookies are so confusing.
[05:46:48] <RoanKattouw>	 Either way, there is a chocolate store next to the hotel so I'm definitely hitting that place up before I go home
[05:46:56] <RoanKattouw>	 I've promised Belgian chocolate to several people
[05:47:09] <mooeypoo>	 They're tasty, but... spicy... you want more, but your mouth is confused. You expect sweet, but then you get spice. Very disorienting.
[05:47:27] <mooeypoo>	 oh, nice, yes, Belgian Chocolate.
[05:49:21] <mooeypoo>	 RoanKattouw, btw, if you have a moment -- is "writeElement()" method in ve.dm.Document being called every time we add an element or just inline ones?
[05:49:50] <mooeypoo>	 because it fails, and it fails in a justified manner ("data is undefined" -- and it actually isn't defined as far as I saw) but it only fails for me on adding inline images, not on blocks.
[05:50:36] <grrrit-wm>	 (03Abandoned) 10Jforrester: [WIP] Do not allow to resize thumb image to be bigger than original file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/71285 (owner: 10Inez)
[05:51:52] <RoanKattouw>	 Hmmm
[05:52:10] <RoanKattouw>	 writeElement() is an internal function somewhere, right
[05:52:25] <RoanKattouw>	 Yeah, in fixupInsertion
[05:52:58] <mooeypoo>	 hm.
[05:53:05] <RoanKattouw>	 mooeypoo: I don't recall the details, I wrote that code a long time ago. Is your code in Gerrit where I can reproduce this on my own machine and see a call trace?
[05:53:07] <mooeypoo>	 ok,I'll keep tracing it
[05:53:50] <RoanKattouw>	 I also don't see a data variable
[05:54:18] <mooeypoo>	 yeah but my code is ugly and most probably has more problems (like I am pretty sure I'm not defining my mwInlineImage properly, etC) --- but in any case, it's here: https://gerrit.wikimedia.org/r/#/c/110234/
[05:54:28] <mooeypoo>	 RoanKattouw, but towards the end of that method, there's a for loop that uses data
[05:54:36] <mooeypoo>	 isn't that weird? :\
[05:54:56] <mooeypoo>	 data is undefined as far as I can see... but then, it only fails on inline. So either I"m not defining things properly and there's actually something missing
[05:55:08] <mooeypoo>	 or it's only called on the inline element, and data is undefined is a bug
[05:56:10] <RoanKattouw>	 Do you mean in fixupInsertion rather than in writeElement?
[05:56:22] <mooeypoo>	 hang on i'm loading the vm again
[05:56:31] <RoanKattouw>	 Is the data parameter to fixupInsertion undefined? Because THAT would be weird
[05:56:43] <mooeypoo>	 line 849 in ve.dm.Document
[05:56:44] <mooeypoo>	 for ( i = 0; i < data.length; i++ ) {
[05:57:12] <mooeypoo>	 and you're right, it's in fixupInsertion
[05:57:14] <RoanKattouw>	 OK yeah then it's being called wrong
[05:57:15] <mooeypoo>	 ahh
[05:57:20] <RoanKattouw>	 data is a parameter documented as being an array
[05:57:21] <mooeypoo>	 I just noticed
[05:57:21] <mooeypoo>	 whoops
[05:57:26] <RoanKattouw>	 So it definitely shouldn't be undefined
[05:57:39] <mooeypoo>	 well, it seems that I am not sending the right data, then
[05:57:46] <mooeypoo>	 but  Iam not entirely sure what I'm missing
[05:57:55] <RoanKattouw>	 Are you passing the correct data to newFromInsertion? Note that it takes an array, not a single {type:'foobar'} object
[05:58:05] * mooeypoo  nods

[05:58:07] <mooeypoo>	 I.. thought so
[05:58:17] <RoanKattouw>	 And that data is the 3rd parameter
[05:58:30] <mooeypoo>	 ignore the mess, look at line #382 https://gerrit.wikimedia.org/r/#/c/110234/2/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js
[05:58:49] <mooeypoo>	 I either make an array for mwInlineImage or for mwBlockImage
[05:59:06] <RoanKattouw>	 Ahm
[05:59:07] <RoanKattouw>	 Or not
[05:59:15] <mooeypoo>	 what? no?
[05:59:20] <RoanKattouw>	 It's if ( ... ) { newNode = something; } else if ( ... ) { newNode = something; }
[05:59:26] <RoanKattouw>	 What if neither of those two conditions is tre?
[05:59:29] <RoanKattouw>	 *true
[05:59:34] <RoanKattouw>	 Then newNode will be undefined
[05:59:37] <mooeypoo>	 yeah, you're right
[05:59:39] <RoanKattouw>	 and there's nothing protecting against that case that I can see
[05:59:43] <mooeypoo>	 ... ha
[05:59:57] <mooeypoo>	 it shouldn't happen btw, one of those MUST be right
[06:00:04] <mooeypoo>	 look at the higher-up condition
[06:00:11] <mooeypoo>	 but you are right, I should make an "else" instead
[06:00:12] <RoanKattouw>	 I mean maybe it's written so that conceptually that shouldn't happen, but yeah
[06:00:21] <RoanKattouw>	 From the condition at the top it seems like this shouldn't be possible
[06:00:31] <mooeypoo>	 it shouldn't theoretically, but I'll change it anyways
[06:00:34] <RoanKattouw>	 Oh!
[06:00:38] <RoanKattouw>	 attr and attrs.type , can they differ?
[06:01:03] <RoanKattouw>	 Yes they can!
[06:01:06] <mooeypoo>	 yes
[06:01:08] <mooeypoo>	 ha
[06:01:11] <mooeypoo>	 they're completely different
[06:01:25] <RoanKattouw>	 If you'd reordered the code above to process the type attribute last, they would be the same
[06:01:29] <RoanKattouw>	 But in any case, that's confusing
[06:01:39] <mooeypoo>	 yeah no I need to rearrange the entire method anyways
[06:01:41] <RoanKattouw>	 *would have been the same
[06:01:50] <mooeypoo>	 right now it was mostly "let's see if that works" sort of thing
[06:02:06] <mooeypoo>	 I plan to refactor the .teardown method anyways
[06:02:12] <RoanKattouw>	 You ideally shouldn't be relying on attr having the same value as attrs.type , that makes the code unclear and prone to breakage precisely by someone adding another attribute below type
[06:02:22] <RoanKattouw>	 Anyways
[06:02:34] <mooeypoo>	 oh, attr is just there to be a cache for the test
[06:02:36] <RoanKattouw>	 With that mystery solved, it's now 7am and I'm hungry
[06:02:42] <RoanKattouw>	 So I'm gonna go grab breakfast
[06:03:12] <mooeypoo>	 instead of going "if (X.val()) { something=X.val() } that calls .val() or .data() or whatever multiple times
[06:03:18] <mooeypoo>	 but ywah, I'm going to fix it up anyways.
[06:03:29] <mooeypoo>	 RoanKattouw_away, Thanks and enjoy your food .. and your chocolate!
[07:32:04] <grrrit-wm>	 (03PS3) 10Mooeypoo: [WIP] Image type inline to block and vise versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 
[07:32:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image type inline to block and vise versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 (owner: 10Mooeypoo)
[07:40:55] <mooeypoo>	 hmm.
[07:43:24] <mooeypoo>	 hm. RoanKattouw would it be horrible if instead of going for Transaction, I "cheat" and use the fragment's insertContent() method? since the fragment is my current node, and I don't collapse the selection, it replaces that node. But I am not sure if that's smart in context of block-to-inline and vise versa.
[07:43:47] <mooeypoo>	 insertContent() performs a transaction as well, but will it "know" to set inline into the paragraph and block out, etc? 
[07:44:42] <RoanKattouw>	 That would be fine
[07:46:26] <RoanKattouw>	 insertContent() does a removal followed by an insertion, pretty much the same thing you're doing
[07:47:16] <RoanKattouw>	 If instead of using insertContent() you'd be doing a removal followed by an insertion yourself, using insertContent() would be OK and actually a bit better because it's clearer what's going on and there's less code duplication
[07:49:49] <mooeypoo>	 Yeah, it seemed better also for consistency.. otherwise I have to keep track of the offset or range.start
[07:50:15] <mooeypoo>	 Also, I need to replace this.mediaNode with the new node, and if it is the new selection, it should be easy to do.
[07:55:12] <RoanKattouw>	 (Heading to the conference, back in ~2h)
[07:55:24] <mooeypoo>	 Enjoy!
[07:55:31] <mooeypoo>	 and thanks :)
[12:45:20] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 (owner: 10Mooeypoo)
[13:22:49] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105247 (owner: 10Mooeypoo)
[14:17:21] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109670 (owner: 10Esanders)