[08:41:47] (03CR) 10Jforrester: [C: 032] Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111077 (owner: 10L10n-bot) [08:43:02] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111077 (owner: 10L10n-bot) [12:30:38] (03PS1) 10Esanders: Don't allow extensions to have no content by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 [12:30:40] (03PS1) 10Esanders: Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 [12:32:56] (03CR) 10jenkins-bot: [V: 04-1] Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 (owner: 10Esanders) [12:43:27] (03CR) 10Siebrand: [C: 031] "Looks like this addresses the comment I made earlier today. Thanks." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 (owner: 10Esanders) [15:50:50] (03PS2) 10Esanders: Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 [15:55:21] (03PS1) 10Esanders: Fix 'use existing reference' list rendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111203 [16:17:07] (03PS1) 10Esanders: Fix usage of '$' in MWReferenceSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111205 [17:01:02] (03CR) 10Jforrester: [C: 031] Don't allow extensions to have no content by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [17:01:07] (03CR) 10Jforrester: [C: 031] Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 (owner: 10Esanders) [18:06:56] (03CR) 10Krinkle: [C: 031] Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 (owner: 10Esanders) [18:07:29] (03CR) 10Krinkle: [C: 031] Fix usage of '$' in MWReferenceSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111205 (owner: 10Esanders) [18:08:57] (03CR) 10Krinkle: "Hm.. how does the user interface react?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [18:19:38] (03CR) 10Jforrester: "The behaviour looks good from my testing." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109693 (owner: 10Divec) [18:20:59] (03CR) 10Esanders: WIP:Fix handleEnter in nodes that don't split (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109693 (owner: 10Divec) [18:25:57] (03CR) 10Catrope: [C: 032] Fix 'use existing reference' list rendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111203 (owner: 10Esanders) [18:27:14] (03Merged) 10jenkins-bot: Fix 'use existing reference' list rendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111203 (owner: 10Esanders) [18:28:26] (03PS1) 10Jforrester: Fix 'use existing reference' list rendering [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111229 [18:28:41] (03PS1) 10Jforrester: Fix 'use existing reference' list rendering [extensions/VisualEditor] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111232 [18:33:14] I'm still getting "Cannot join #wikimedia-staff (Channel is invite only)" every 30s [18:33:24] can't even seen how to stop it from trying [18:51:46] edsanders: you can stop the messages by fully leaving the channel on your client (close it completely, usually right clicking on the channel will give you an option). That said, still having the issue? [18:52:11] Jamesofur, it isn't open in my client [18:52:26] hmmm, possibly in a list for you to auto join? [18:53:33] edsanders: identify to nickserv if you haven't, and ask someone to re-invite you if you have [18:53:48] i hear marktraceur can invite people there [18:54:04] ok, I believe I am identified [18:54:04] (you know, this is kinda funny, i know who to poke to join the staff channel) [18:55:05] I can! [18:55:16] (ohai MatmaRex, I changed my nick) [18:56:38] edsanders: Fixed once and for all, I hope [18:57:17] thanks [18:57:38] edsanders: I bet it's because you don't have a cloak, and someone added the mode change wrong [18:57:49] rdwrer: huh [19:05:54] (03PS3) 10Mooeypoo: Prevent the dialog from applying changes on bad input [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/110907 [19:05:55] (03CR) 10jenkins-bot: [V: 04-1] Prevent the dialog from applying changes on bad input [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/110907 (owner: 10Mooeypoo) [19:33:34] (03PS4) 10Mooeypoo: Prevent the dialog from applying changes on bad input [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/110907 [19:34:27] edsanders: https://gerrit.wikimedia.org/r/#/c/111205/ isn't cleanup, right? This fixes the MWReferenceSearchWidget from no longer being broken (all references look empty without that patch) [19:55:15] (03CR) 10Siebrand: [C: 031] Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 (owner: 10Esanders) [20:11:18] edsanders: nvm, that was indeed broken but fixed by the underlying commit [20:12:09] (03CR) 10Krinkle: [C: 032] Fix usage of '$' in MWReferenceSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111205 (owner: 10Esanders) [20:13:21] (03Merged) 10jenkins-bot: Fix usage of '$' in MWReferenceSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111205 (owner: 10Esanders) [20:22:11] (03CR) 10Krinkle: "Aside from the organisational choice of splitting it up using modules (as opposed to a skinStyles switch or some other method), the main i" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 (owner: 10Jdlrobson) [21:02:34] (03PS3) 10Alex Monk: Use accesskey=s on the save buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 [21:22:34] (03CR) 10Krinkle: Use accesskey=s on the save buttons (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 (owner: 10Alex Monk) [21:23:24] (03CR) 10Krinkle: Use accesskey=s on the save buttons (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 (owner: 10Alex Monk) [21:40:11] Krinkle, yup [21:55:33] we should really have a code review script that checks i18n files for order and qqq entries [21:56:16] although we might put Siebrand out of a job... [21:57:51] (03PS1) 10Trevor Parscal: Give menus of lookup widgets correct width and text size [oojs/ui] - 10https://gerrit.wikimedia.org/r/111339 [21:58:03] (03PS1) 10Trevor Parscal: Only populate lookup widget menus asynchronously [oojs/ui] - 10https://gerrit.wikimedia.org/r/111340 [21:58:08] TrevorParscal, are you around? [21:58:33] yeah [21:58:34] howdy [21:58:40] I can't figure out why inline iamges don't have context menu popping up. [21:58:56] ok, you on master? [21:59:01] I imagine it is because we didn't use to be able to edit them, but I can't bring it back [21:59:02] aye [22:00:25] let me see if I can reproduce [22:00:53] I see the resize handle (only one) but no context menu [22:04:25] yup, I see the same [22:04:42] I thought it was something with focusable node, but that doesn't seem to be it [22:04:47] the resize handles are no longer on 4 corners, only the corner opposite the anchor - so that is normal [22:05:10] but the context should either embed or float, certainly not just dissapear [22:05:22] yeah, that's fine, but the context is gone. I think it's somewhere off screen? [22:05:41] I can't figure out what happened to it. The positioning method seems to be right [22:06:27] the context is visibility:hidden [22:06:49] there's supposed to be some logic that decides to embed or not, I will look there first [22:10:50] TrevorParscal, yeah, but as far as I saw, it depends mostly on the image size [22:15:47] true, perhaps there's something to do with it not being a block, looking still [22:16:00] * mooeypoo nods [22:16:55] the only way it could become visibility:hidden is if something calls hide [22:17:00] so, I'm working backwards from there [22:20:16] Could it be something that was done on purpose, because inline nodes couldn't have Caption? [22:20:39] TrevorParscal, I was thinking that since media edit dialog used to only have caption, maybe it was shut off for inline images? [22:20:47] I just couldn't find it if it was. [22:22:42] I don't think we've ever had the media edit dialog on inline images [22:22:59] yeah I know [22:23:06] so was it purposefully shut off for it? [22:23:33] I know inspectors include specific nodes [22:23:49] the context finds the tools for node [22:24:10] ve.ui.MWMediaEditDialogTool.static.modelClasses = [ ve.dm.MWBlockImageNode ]; [22:24:41] never turned on [22:25:08] because it they have no captions [22:25:10] ... okay, so I"ve been looking everywhere except the tool [22:25:43] I did a search for MWBlockImageNode :) [22:26:15] ha! should'a thought of that. I was going over ve.ui.Context and compared MWBlockImageNode to MWInlineImageNode [22:26:30] dang it, yeah, I just found that too [22:26:32] ed is too fast [22:27:20] woot, that does it. [22:27:34] now I need to figure out what to do with the caption when it doesn't exist, but that's relatively easy. [22:27:36] thanks guys! [22:27:43] yeah, the dialog isn't designed for that node though, so tread carefully [22:28:05] TrevorParscal, yeah, I'm going to have to see if I can adjust it [22:28:14] It switches between Block and Inline images now [22:28:26] (or will, once I submit my WIP) [22:31:05] nice [22:36:19] (03PS2) 10Trevor Parscal: [WIP] Only populate lookup widget menus asynchronously [oojs/ui] - 10https://gerrit.wikimedia.org/r/111340 [22:36:50] (03PS2) 10Trevor Parscal: Give menus of lookup widgets correct width and text size [oojs/ui] - 10https://gerrit.wikimedia.org/r/111339 [22:56:02] (03PS3) 10Trevor Parscal: Only populate lookup widget menus asynchronously [oojs/ui] - 10https://gerrit.wikimedia.org/r/111340 [22:56:23] (03PS4) 10Trevor Parscal: Only populate lookup widget menus asynchronously [oojs/ui] - 10https://gerrit.wikimedia.org/r/111340 [23:14:58] (03PS5) 10Robmoen: WIP: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 [23:15:17] (03CR) 10Robmoen: [C: 04-1] WIP: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [23:16:14] (03CR) 10jenkins-bot: [V: 04-1] WIP: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [23:36:08] just FYI (probably won't apply to you guys, but just in case) https://github.com/Wikia/app/pull/2636/files