[00:03:12] (03CR) 10Krinkle: [C: 032] Fix 'use existing reference' list rendering [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111229 (owner: 10Jforrester) [00:03:15] (03CR) 10Krinkle: [C: 032] Fix 'use existing reference' list rendering [extensions/VisualEditor] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111232 (owner: 10Jforrester) [00:04:21] (03Merged) 10jenkins-bot: Fix 'use existing reference' list rendering [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111229 (owner: 10Jforrester) [00:05:22] (03Merged) 10jenkins-bot: Fix 'use existing reference' list rendering [extensions/VisualEditor] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111232 (owner: 10Jforrester) [01:03:23] (03PS1) 10Trevor Parscal: [WIP] Auto-select first auto-added required param and fix param order [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111389 [02:15:33] (03PS2) 10Jhall: [Browser test] Test VisualEditor availability on production wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111142 [10:14:12] (03PS1) 10Hashar: [browser test] bump mediawiki-selenium to 0.1.20 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111429 [10:18:04] (03Abandoned) 10Hashar: [browser test] bump mediawiki-selenium to 0.1.20 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111429 (owner: 10Hashar) [10:23:14] (03PS3) 10Esanders: WIP Show recent uploads in MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109670 [10:26:06] (03CR) 10Hashar: "I have triggered the experimental browser tests on CI Jenkins using firefox headless: http://integration.wikimedia.org/ci/job/Visualeditor" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110606 (owner: 10Jhall) [10:28:14] (03CR) 10Hashar: "Apparently cucumber with firefox headless managed to accomplish the "Given I am at my user page" step:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110606 (owner: 10Jhall) [10:37:36] (03CR) 10Zfilipin: [C: 04-1] [Browser test] Reintroduce headless browser test support (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110606 (owner: 10Jhall) [11:06:08] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109670 (owner: 10Esanders) [11:38:47] (03PS1) 10Esanders: Internal paste rules and type conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111435 [11:39:15] (03PS2) 10Esanders: Implement surface paste rules for media/ref dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110960 [11:39:24] (03CR) 10jenkins-bot: [V: 04-1] Implement surface paste rules for media/ref dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110960 (owner: 10Esanders) [15:01:09] hi edsanders, according to James you're the one who will deal with https://bugzilla.wikimedia.org/show_bug.cgi?id=60897, so, thanks :) [15:48:22] (03PS1) 10Esanders: Allow style attributes to be pasted from other VE instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111456 [16:44:46] rdwrer: BTW, get the impression that https://gerrit.wikimedia.org/r/#/c/100800/ might be a WIP? :-) [16:45:16] hashar is my favorite. [16:47:09] (03PS1) 10Jforrester: Set wfUseMW down to MW 1.22 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111463 [16:57:42] Elitre, actually it looks like a Parsoid issue [17:06:09] edsanders: How does the data-ve-ignore get in? [17:06:19] I put it there [17:06:35] but that's not the issue [17:06:46] the issue is that there's a list and a span at all [17:06:50] Parsoid should be ignoring them [17:07:33] I thought data-ve-ignore only got slapped in when content was copied to the clipboard? [17:09:32] it's done by toDomElements [17:09:56] there's no distinction between converting for Parsoid and converting for the clipboard [17:10:54] but even if we got rid of it, we'd still have the list and the span because the about grouping isn't working [18:17:57] (03CR) 10Catrope: [C: 032] Set wfUseMW down to MW 1.22 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111463 (owner: 10Jforrester) [18:18:30] (03CR) 10Catrope: [C: 032] Add paste rules to surface widget config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110959 (owner: 10Esanders) [18:19:09] (03Merged) 10jenkins-bot: Set wfUseMW down to MW 1.22 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111463 (owner: 10Jforrester) [18:19:40] (03Merged) 10jenkins-bot: Add paste rules to surface widget config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/110959 (owner: 10Esanders) [18:27:48] (03CR) 10Catrope: [C: 032] Internal paste rules and type conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111435 (owner: 10Esanders) [18:28:59] (03Merged) 10jenkins-bot: Internal paste rules and type conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111435 (owner: 10Esanders) [18:35:35] hey, ve folks. [18:35:39] what do you think about images? [18:35:50] RoanKattouw_away, so when we've merged a core change that a MW change depends on, what do we need to do to make the MW change mergeable? [18:35:50] They're preeeeeetty [18:36:10] we fixed a bunch of image-related bugs in parsoid recently. so are we breaking stuff? did we unblock you? are you still waiting for something in particular? [18:36:22] which bugs? [18:36:47] I'm not aware of being blocked on anything [18:38:58] mooeypoo is probably most affected by this [18:39:35] by what? [18:40:29] mooeypoo, image editing fixes in parsoid [18:42:02] edsanders: Does the core change break things in MW that need to be fixed in the same commit, or not? [18:42:33] (03CR) 10Catrope: [C: 032] Allow style attributes to be pasted from other VE instances (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111456 (owner: 10Esanders) [18:42:42] (03CR) 10Catrope: [C: 04-1] Allow style attributes to be pasted from other VE instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111456 (owner: 10Esanders) [18:43:29] (03CR) 10Catrope: The great image scaling rewrite of 2014 (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109594 (owner: 10Esanders) [18:44:00] gwicke, oh, these were a couple of weeks ago though no? [18:44:07] RoanKattouw, it does [18:44:42] the alternate text, position and type wikitext duplication etc, and changing the size to 2d [18:44:46] changed the structure of pasteRules [18:44:51] Right, that one [18:45:09] image scaling one too probably [18:45:39] There's a script for this but 1) I'm not sure if it's merged yet and 2) it doesn't address this case [18:45:54] So hang on, I'm reviewing the image scaling commit and then I'll process them both [18:46:05] And tell you what I'm doing while I do it [18:46:42] (03PS2) 10Esanders: Allow style attributes to be pasted from other VE instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111456 [18:46:49] (03CR) 10Esanders: Allow style attributes to be pasted from other VE instances (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111456 (owner: 10Esanders) [18:47:04] mooeypoo, much of that was only deployed on Monday [18:47:21] that was the first deployment since mid-December [18:47:47] gwicke, oh, ok, as far as I can see everything's okay so far -- I was checking things with VE master and Parsoid master, so it should be good [18:48:33] rummana is testing a lot of the image editing stuff, she found a couple of bugs, but none seem to be related to parsoid changes [18:49:22] (03CR) 10Catrope: [C: 04-1] The great image scaling rewrite of 2014 (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109594 (owner: 10Esanders) [18:49:59] RoanKattouw: It's merged. [18:50:05] mooeypoo, cool [18:50:19] James_F: ? [18:50:56] RoanKattouw: The script to sync VE-MW and VE-core is merged with the TODOs still in it. [18:51:02] RoanKattouw: Krinkle|detached and I did it on Saturday. [18:51:14] Ah OK [18:51:36] I have run that script [18:51:57] but only as an empty update, not merged with another commit [18:52:19] mooeypoo: anyway, let us know if you've got any other high priority blocking bugs wrt images. i'll probably be shifting focus to language variant stuff in about a week or so. [18:52:33] * mooeypoo nods [18:52:34] edsanders: Run the script, then commit --amend it to work. [18:52:38] thanks cscott ! [18:52:43] (03PS1) 10Catrope: Update VE core submodule to master (76ff210) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111494 [18:53:08] (03PS2) 10Catrope: Update VE core submodule to master (bb8d19c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111494 [18:53:22] RoanKattouw, ^^ that's a breaking change [18:53:34] Is it? [18:53:36] oh wait not [18:53:40] I thought only the second one was breaking? [18:53:44] I removed the second one and kept the first [18:53:45] that's just the first pasteRule change [18:53:45] yeah [18:54:04] You can do updateSubmodule.sh where = the hash of the merge commit immediately preceding the merge commit for the breaking change [18:54:50] Yes. [19:07:46] edsanders: Could you merge https://gerrit.wikimedia.org/r/111494 please? [19:07:59] Once that's merged I can rerun the script then squash the resulting commit into your change [19:08:27] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (bb8d19c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111494 (owner: 10Catrope) [19:09:03] Thanks [19:09:42] (03Merged) 10jenkins-bot: Update VE core submodule to master (bb8d19c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111494 (owner: 10Catrope) [19:10:01] edsanders: You said you were working on https://bugzilla.wikimedia.org/show_bug.cgi?id=59781 , right? [19:10:32] nope [19:11:22] I worked on something similar [19:12:00] so we allow lists in references [19:12:07] (03PS3) 10Catrope: Implement surface paste rules for media/ref dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110960 (owner: 10Esanders) [19:12:15] (03CR) 10jenkins-bot: [V: 04-1] Implement surface paste rules for media/ref dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110960 (owner: 10Esanders) [19:12:29] But *foo\n*bar will only detect a list if it sees '\n*' [19:12:43] in the PHP parser [19:12:54] so the Parsoid generates 'bad' wikitext [19:13:06] solutions: [19:13:16] 1. Fix PHP parser (eww) [19:13:32] 2. Fix Parsoid to always insert a \n before */# for lists [19:13:44] 3. Disable lists in references [19:13:57] (we already disable lists in captions) [19:16:43] edsanders: #2 has my preference [19:16:49] But #3 can be done as a temporary fix [19:16:57] Although ... well not really [19:17:06] Because you could have existing refs with lists in them [19:17:43] (03PS4) 10Catrope: Implement surface paste rules for media/ref dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110960 (owner: 10Esanders) [19:19:40] edsanders: #2 is the right fix, surely? [19:19:49] RoanKattouw, that's okay unless they delete the extra linebreak [19:19:53] probably [19:21:27] (03PS2) 10Trevor Parscal: Auto-select first auto-added required param and fix param order [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111389 [19:21:29] (03CR) 10Catrope: [C: 032] Implement surface paste rules for media/ref dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110960 (owner: 10Esanders) [19:21:36] (03PS1) 10Trevor Parscal: Fix-up offset when transplanting transclusion parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111501 [19:21:49] James_F|Away: Are you OK with me making the gallery inspector experimental or otherwise disable it until it's fixed? [19:22:05] RoanKattouw: What fixes are you expecting to do? [19:22:10] RoanKattouw: The Safari bug? [19:23:12] RoanKattouw: Experimental is fine, though. [19:23:38] I think we need to do 2 & 3 [19:23:53] (03Merged) 10jenkins-bot: Implement surface paste rules for media/ref dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110960 (owner: 10Esanders) [19:23:58] For references and captions we need to discourage anything other than one paragraph [19:24:58] edsanders: mediawiki.org/wiki/VisualEditor:TestReferenceContents :_) [19:25:27] Hello! [19:25:47] Hey InezK. :-) [19:26:28] James_F|Away: There are lots of things broken in the gallery inspector, including its behavior when you type nothing and close it again (empty gallery) [19:26:59] RoanKattouw: I have a quick question. Do you see any downsides (possible bugs) to this situation: in model block image has caption as a child, but because it is frameless block image that caption is not added as a child in view. So basically view and model are not in sync. [19:27:00] James_F|Away, exactly: the fact the multi\nline combines onto one line shows you how the extension is supposed to be used. Yes you can get complex structure in there but you really shouldn't [19:27:05] (03PS3) 10Catrope: Auto-select first auto-added required param and fix param order [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111389 (owner: 10Trevor Parscal) [19:27:13] InezK: That sounds fine [19:27:15] (03PS2) 10Trevor Parscal: Fix-up offset when transplanting transclusion parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111501 [19:27:19] RoanKattouw: I thought that one was fixed by Ed, but sure. [19:27:20] (03PS3) 10Trevor Parscal: Fix-up offset when transplanting transclusion parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111501 [19:27:39] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/111178/ specifically (go go edsanders). [19:27:57] Oh sweet, OK [19:28:09] RoanKattouw: and by not added as a child in view I mean in the view tree (not the DOM only) so node.children.length = 0, but node.model.children.length = 1 [19:28:09] I hadn't gotten around to looking at all of Ed's changes yet [19:28:10] RoanKattouw: If we need to pull it, pull it. [19:28:18] James_F|Away: Yeah I'll evaluate later [19:28:23] Rummana's given me this slew of bugs [19:28:26] RoanKattouw: Yeah, edsanders's wonderful and actually writes code, unlike some people. :-P *cough* [19:28:31] RoanKattouw: Yeah. :-( [19:30:12] I need to get out more [19:31:20] edsanders: Psh. You need to come to SF and mainline bug fixes more. Oh, wait. :-) [19:31:30] (03CR) 10Esanders: "It closes and nothing gets inserted. Current it closes and a weird transparent focusable node getting inserted." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [19:37:45] divec: hey, I sent you an email [19:37:50] is Menna stilla wake? [19:40:47] (03PS1) 10Esanders: Hide structure tools in MWReferences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111507 [19:41:37] (03CR) 10Jforrester: [C: 032] Hide structure tools in MWReferences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111507 (owner: 10Esanders) [19:43:14] (03Merged) 10jenkins-bot: Hide structure tools in MWReferences [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111507 (owner: 10Esanders) [19:46:33] (03PS1) 10Esanders: Exclude galleries from reference/caption surface tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111509 [19:48:20] (03CR) 10Jforrester: [C: 032] Exclude galleries from reference/caption surface tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111509 (owner: 10Esanders) [19:49:26] (03Merged) 10jenkins-bot: Exclude galleries from reference/caption surface tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111509 (owner: 10Esanders) [19:53:06] I think the names of all the MW tools and dialogs (as in the .name properties by which they are registered) should be 'mw' prefixed [19:53:21] does anyone disagree ( RoanKattouw_away TrevorParscal ) [19:54:32] or are there cases where we have tools in core we want overwritten? [19:57:32] RoanKattouw_away, thoughts on: https://bugzilla.wikimedia.org/show_bug.cgi?id=60897 [19:58:14] 1. Re-evaluate templates a block/inline every time we get a fresh rendering from Parsoid (async transactions, ew..) [19:58:53] 2. Some hacky workaround (???) [19:59:43] 3. Throw in the towel and disable useful clipboard contents until we've sorted block/inline templates [20:00:59] 2. Just thought of one: give the converter a 'forClipboard' mode flag, and only populate clipboard contents if that is set [20:05:47] (03PS1) 10Trevor Parscal: Describe index argument correctly in addItems documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/111513 [20:05:49] (03CR) 10jenkins-bot: [V: 04-1] Describe index argument correctly in addItems documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/111513 (owner: 10Trevor Parscal) [20:06:05] edsanders: mw-prefixing sounds fine [20:06:45] edsanders: #2 sounds reasonable as a short-term fix [20:07:13] hey guys, there's a VE quiestion on #-tech. [20:07:16] question* [20:07:19] RoanKattouw, if we had a core mediaEdit tool, would we still want the MW mediaEdit tool prefixed? [20:07:27] #1 would be nice but 1) should wait for Moriel's work re converting block/inline images which will have reusable stuff for this and 2) is icky because of asynchronicity [20:07:34] edsanders: Hmm, probably not [20:07:38] We also don't prefix link [20:07:42] Specifically so it overrides [20:08:21] so maybe not prefix? [20:09:04] Yeah probably not prefix unless needed [20:09:26] MatmaRex: Answered; thanks for bringing that to our attention! [20:10:30] I'm adding a way to take a message key and get a function which when executed will return the localized message (defers the lookup so we can declare messages in static properties without having to make the static property accept a message key) [20:10:49] right now some of ooui takes message keys, some of it takes strings [20:11:31] I'm going to make it uniform so it all takes strings or functions that return strings, and you can wrap a message key lookup using a function when that's needed [20:12:14] what do I call this function, deferMsg? staticMsg? doThatThingYouDo? [20:12:21] any thoughts? [20:12:33] I have no brilliant ideas but I think that deferMsg is reasonable [20:15:13] (03CR) 10Catrope: [C: 04-1] Don't allow extensions to have no content by default (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [20:15:32] (03CR) 10Catrope: Don't allow extensions to have no content by default (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [20:22:18] (03CR) 10Catrope: [C: 04-1] Auto-select first auto-added required param and fix param order (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111389 (owner: 10Trevor Parscal) [20:24:13] (03PS1) 10Esanders: Add 'forClipboard' mode to converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111517 [20:28:31] (03PS1) 10Esanders: Only generate transclusion contents for clipboard [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111518 [20:28:59] (03CR) 10jenkins-bot: [V: 04-1] Only generate transclusion contents for clipboard [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111518 (owner: 10Esanders) [20:32:55] (03CR) 10Catrope: [C: 032] Add 'forClipboard' mode to converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111517 (owner: 10Esanders) [20:33:33] (03CR) 10Catrope: [C: 032] Fix-up offset when transplanting transclusion parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111501 (owner: 10Trevor Parscal) [20:34:02] (03Merged) 10jenkins-bot: Add 'forClipboard' mode to converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111517 (owner: 10Esanders) [20:34:15] (03CR) 10Catrope: [C: 031] Only generate transclusion contents for clipboard [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111518 (owner: 10Esanders) [20:36:38] (03PS1) 10Catrope: Update VE core submodule to master (aa02be3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111519 [20:38:28] (03CR) 10Catrope: [C: 032] Allow style attributes to be pasted from other VE instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111456 (owner: 10Esanders) [20:38:45] (03CR) 10Catrope: [C: 04-2] "Hold on, more changes coming" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111519 (owner: 10Catrope) [20:39:36] (03Merged) 10jenkins-bot: Allow style attributes to be pasted from other VE instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111456 (owner: 10Esanders) [20:39:43] (03PS8) 10Catrope: The great image scaling rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109594 (owner: 10Esanders) [20:40:11] (03CR) 10Catrope: [C: 032] The great image scaling rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109594 (owner: 10Esanders) [20:41:12] (03PS2) 10Catrope: Update VE core submodule to master (b9598c6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111519 [20:41:27] (03Merged) 10jenkins-bot: The great image scaling rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109594 (owner: 10Esanders) [20:45:11] (03PS5) 10Catrope: Move image info API call to media node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109522 (owner: 10Esanders) [20:45:13] (03PS7) 10Catrope: The great image scaling rewrite of 2014 (MW) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109595 (owner: 10Esanders) [20:46:03] (03PS2) 10Catrope: Only generate transclusion contents for clipboard [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111518 (owner: 10Esanders) [20:47:23] (03CR) 10jenkins-bot: [V: 04-1] The great image scaling rewrite of 2014 (MW) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109595 (owner: 10Esanders) [20:48:42] (03PS6) 10Catrope: Move image info API call to media node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109522 (owner: 10Esanders) [20:48:57] (03CR) 10Catrope: [C: 032] Move image info API call to media node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109522 (owner: 10Esanders) [20:52:57] (03PS4) 10Catrope: Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 [20:53:08] (03PS8) 10Esanders: The great image scaling rewrite of 2014 (MW) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109595 [20:54:12] (03CR) 10jenkins-bot: [V: 04-1] Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 (owner: 10Catrope) [20:55:12] (03CR) 10jenkins-bot: [V: 04-1] The great image scaling rewrite of 2014 (MW) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109595 (owner: 10Esanders) [20:55:21] (03PS9) 10Catrope: The great image scaling rewrite of 2014 (MW) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109595 (owner: 10Esanders) [20:56:12] (03PS5) 10Catrope: Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 [20:56:13] (03CR) 10jenkins-bot: [V: 04-1] Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 (owner: 10Catrope) [20:56:31] (03PS19) 10Mooeypoo: Adding alternate text to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105098 [20:56:38] (03PS16) 10Mooeypoo: Adding position setting to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105225 [20:56:48] (03PS6) 10Mooeypoo: [WIP] Add image type change to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105247 [20:56:53] (03PS4) 10Mooeypoo: [WIP] Image type inline to block and vise versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 [20:57:09] what... just happened [20:57:21] oh, RoanKattouw's rebasing [20:57:27] Sorry [20:57:34] (03PS7) 10Esanders: Implement SVGMaxSize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109604 [20:57:53] RoanKattouw, thanks :) i thought my (not yet sent, actually) review affected the entire stack or something [20:58:34] (03CR) 10Catrope: [C: 032] The great image scaling rewrite of 2014 (MW) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109595 (owner: 10Esanders) [21:00:07] (03CR) 10Catrope: [C: 04-1] Implement SVGMaxSize (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109604 (owner: 10Esanders) [21:00:52] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image type inline to block and vise versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 (owner: 10Mooeypoo) [21:02:14] RoanKattouw_away, so, I'm in the middle of working on that top branch in the stack, and didn't send my fixes to review yet -- how would that be affected by the rebase? should I stop, rebase, reapply...? or... just send to review and then re-rebase, or.. git stash, rebase, and reapply? [21:03:37] TrevorParscal, the more I'm working on this, the more I think I should stop and talk to you about it... when would you have time to discuss media edit dialog stuff relating to adding functionality for inline images? [21:03:53] there are a couple of possibilities, I think we should sort them out before I go on [21:03:57] (03PS1) 10Jhall: [Browser test] Get transclusion test back to working with Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111531 [21:13:39] (03PS2) 10Jhall: [Browser test] Get transclusion test back to working with Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111531 [21:14:48] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111531 (owner: 10Jhall) [21:16:01] (03Merged) 10jenkins-bot: [Browser test] Get transclusion test back to working with Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111531 (owner: 10Jhall) [21:26:27] Krinkle|detached: I'm a bit late, but let's do this thing [21:34:45] mooeypoo: i need to eat something, then we can talk, sorry I didn't see the message earlier [21:34:54] * mooeypoo nods [21:35:11] no rush, I'm working on the more "obvious" things for the moment, but some behavior we probably should talk about [21:35:14] TrevorParscal, bon apetit [22:38:47] TrevorParscal: if you finished eating: https://gerrit.wikimedia.org/r/#/c/95822/ is eager for a review [22:39:28] lookin [22:42:28] matanya: could I get some more details (in the commit message) of what the symptoms, diagnosis and fix is here? [22:43:29] yes TrevorParscal as said in the bug one developed a gadget in he.wiki [22:43:43] the problem is that tipsy adds the user class *after* it [22:43:43] calculates the tip's dimensions [22:44:18] right, that makes sense [22:45:05] so the fix changes the order [22:45:40] and hence that class is added in the right context and the dimensions are correct [22:45:55] i see a larger problem though - why the hell would tipsy set classname = 'tipsy' (yes, i see the comment, but that's crap!) [22:46:00] this patch is OK [22:46:32] but tipsy should be removing it's classes surgically, not wiping the whole class attribute clean [22:46:43] yes, i agree it is weird, but i'm focusing on the my own itch [22:46:44] then you don't need a silly className option [22:46:55] sure, who is going to clean this up though? :( [22:47:14] i don't know enough js, i can ask one to look at [22:47:50] if you don't mind, merge this fix, and add a comment about what should be done [22:47:58] and i'll get it done [22:48:05] i did merge it, I'm just annoyed that tipsy is such a POS [22:48:38] tipsy [22:48:40] what's tipsy [22:49:00] that one? http://onehackoranother.com/projects/jquery/tipsy/ [22:49:14] yes InezK [22:49:41] InezK: the question is actually "who's tipsy"... [22:49:51] probably the freaking author of this garbage code [22:49:51] you are tipsy, that's obvious one [22:49:54] ;) [22:50:03] TrevorParscal: are you guys going to use it in VE? [22:50:07] never! [22:50:50] it would be so trivial to add to ooui, and it's so poorly written, and it adds a dependency - no chance [22:51:42] TrevorParscal: if you want someone to fix the rest, please leave a comment there :) [22:55:02] matanya: well, if there are gadgets depending on the className option, it's pretty much too late to make good decisions, the author of tipsy has screwed us [22:55:05] mooeypoo: Sorry, was in a meeting. Which change are you working on that I rebased? [22:57:12] RoanKattouw, nevermind, I figured it out. The changes I made weren't applied anyways. [22:57:23] OK [22:57:27] I'm trying to figure out the best way to get Media Edit dialog to work on both inline and block images [22:57:53] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (b9598c6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111519 (owner: 10Catrope) [22:58:26] (03CR) 10Catrope: [C: 032] Only generate transclusion contents for clipboard [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111518 (owner: 10Esanders) [22:58:47] oy, thogh I did just mess my commit up. RoanKattouw how do I take out lib/ve from the commit? :\ I again accidentally did 'git commit --all --amend' instead of adding individually without lib/ve [22:59:09] something with reset lib/ve? reset head of.. bha. I need to have this plastered on my wall [22:59:10] mooeypoo: git reset HEAD^ lib/ve ; git commit --amend [22:59:17] ah, close. [22:59:24] (03Merged) 10jenkins-bot: Update VE core submodule to master (b9598c6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111519 (owner: 10Catrope) [23:00:14] (03Merged) 10jenkins-bot: Move image info API call to media node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109522 (owner: 10Esanders) [23:00:47] (03PS1) 10Esanders: Hide automatic reference names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111626 [23:01:17] (03Merged) 10jenkins-bot: The great image scaling rewrite of 2014 (MW) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109595 (owner: 10Esanders) [23:01:42] hm. RoanKattouw ok, I seem to need your help again with git. I'm about to 'git review' and it gives me the outstanding commits list, but at least two of those seem to be already merged [23:02:30] (03Merged) 10jenkins-bot: Only generate transclusion contents for clipboard [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111518 (owner: 10Esanders) [23:02:32] (03CR) 10Catrope: [C: 031] "Code looks reasonable, but deferring to James for the "should we do this" decision." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111626 (owner: 10Esanders) [23:03:02] TrevorParscal, thoughts: https://gerrit.wikimedia.org/r/#/c/109670/ [23:03:25] RoanKattouw, https://dpaste.de/ZkkA [23:03:40] RoanKattouw, we already ignore the names of auto-numbered references when they are freshly created (i.e. auto/ prefixed) [23:04:13] this is just making it consistent after it has been saved and re-opened [23:04:14] Right, OK [23:04:15] RoanKattouw, 61d010d & ba45289 are already merged... i'm a bit concerned they appear in that list. [23:04:33] mooeypoo: Should be fine [23:04:40] You probably just haven't run git fetch in a while [23:04:56] that won't apply any changes to the underlying commits? [23:05:05] after having it happen once, I keep being paranoid [23:05:07] Nope [23:05:10] If the hashes are the same, it won't [23:05:26] ok then. Going for it. [23:05:34] (03PS5) 10Mooeypoo: [WIP] Image type inline to block and vise versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 [23:11:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image type inline to block and vise versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 (owner: 10Mooeypoo) [23:14:52] mooeypoo: *vice [23:15:04] bah, thank you [23:15:27] (03PS6) 10Mooeypoo: [WIP] Image type inline to block and vice versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 [23:15:37] I'll need to brainstorm with TrevorParscal for the rest of this to work properly [23:16:38] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image type inline to block and vice versa [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 (owner: 10Mooeypoo) [23:16:51] (03CR) 10Esanders: [WIP] Image type inline to block and vice versa (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 (owner: 10Mooeypoo) [23:18:54] FYI guys I am waiting for a reply on https://bugzilla.wikimedia.org/show_bug.cgi?id=50206#c4 [23:20:01] (03PS8) 10Esanders: Implement SVGMaxSize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109604 [23:22:28] (03CR) 10Esanders: Implement SVGMaxSize (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109604 (owner: 10Esanders) [23:23:57] Krenair: We probably want it to be like the toolbar in that it is in the position where it is now when that position is visible, or in a fixed position otherwise [23:24:05] But that may be tricky [23:24:36] You should talk to Krinkle (who is still AWOL, I haven't seen him today) or James_F|Away (who is at the product offsite) [23:24:54] the what? [23:25:09] Big meeting of doom [23:31:40] Hmm turns out Krinkle is here, he's just not paying attention to this channel, and he's busy with something else [23:32:01] AFVCBITO [23:32:12] Absent From Visualeditor Corner But In The Office [23:32:15] (03CR) 10Esanders: "Chicken." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111626 (owner: 10Esanders) [23:32:23] Hi *wave* [23:33:06] (03CR) 10Catrope: [C: 032] Hide automatic reference names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111626 (owner: 10Esanders) [23:33:35] (03CR) 10Catrope: [C: 032] Implement SVGMaxSize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109604 (owner: 10Esanders) [23:34:32] TrevorParscal: I heard that :P [23:35:09] (03CR) 10jenkins-bot: [V: 04-1] Hide automatic reference names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111626 (owner: 10Esanders) [23:35:38] (03PS2) 10Catrope: Document index argument correctly in addItems documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/111513 (owner: 10Trevor Parscal) [23:36:16] (03PS3) 10Catrope: Give menus of lookup widgets correct width and text size [oojs/ui] - 10https://gerrit.wikimedia.org/r/111339 (owner: 10Trevor Parscal) [23:36:18] TrevorParscal: the developer is ready to re-write tipsy to our needs, and also pointed out this: https://en.wikipedia.org/wiki/MediaWiki:Gadget-ReferenceTooltips.js [23:36:48] he also wrote once tipsy 2.0 for his own use, if you wish to review it, he is willing to push it [23:36:54] intersted? [23:37:04] (03CR) 10jenkins-bot: [V: 04-1] Implement SVGMaxSize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109604 (owner: 10Esanders) [23:37:52] (03CR) 10Catrope: [C: 032] Give menus of lookup widgets correct width and text size [oojs/ui] - 10https://gerrit.wikimedia.org/r/111339 (owner: 10Trevor Parscal) [23:38:02] (03PS5) 10Trevor Parscal: Only populate lookup widget menus asynchronously [oojs/ui] - 10https://gerrit.wikimedia.org/r/111340 [23:38:18] RoanKattouw, when we create DMs for SurfaceWidgets we don't copy over the internal list [23:38:37] would it break all the NewFromDocumentInsertion transactions if we did? [23:38:54] because without doing that, you can't insert an existing reference in an image node [23:39:05] (because internalList is empty) [23:40:53] (03Merged) 10jenkins-bot: Give menus of lookup widgets correct width and text size [oojs/ui] - 10https://gerrit.wikimedia.org/r/111339 (owner: 10Trevor Parscal) [23:48:16] matanya: um, have that guy email me or something, I have a few things I'm paying attention to in a hurry right now, but yes, I want to get the tipsy crap resolved [23:48:49] matanya: Also, please copy me too. :_) [23:51:00] edsanders: Ahm, we should be copying over internalLists, shouldn't we? [23:51:01] ok TrevorParscal and James_F|Away I asked him to do so [23:51:08] Thanks. [23:51:10] IIRC newFromDocumentInsertion assumes that you *have* done that [23:51:35] that's what I thought [23:51:39] edsanders: When you say "not copying over internal list", does that mean the {'type': 'internalList'}....{'type':'/internalList'} data in the linmod or the ve.dm.InternalList object? [23:51:59] From my recollection, getDocumentSlice() or whatever it's called these days copies over the former at least [23:52:17] The latter is what we build the ref list off of [23:52:52] (03PS7) 10Jdlrobson: Make default OOJS UI styles optional [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 [23:54:26] (03CR) 10jenkins-bot: [V: 04-1] Make default OOJS UI styles optional [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 (owner: 10Jdlrobson) [23:54:58] (03PS2) 10Esanders: Don't allow extensions to have no content by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 [23:55:00] (03PS3) 10Esanders: Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 [23:55:19] (03CR) 10Catrope: [C: 04-1] "Looks fine but doesn't need to resolve async when cached" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/111340 (owner: 10Trevor Parscal) [23:55:29] (03CR) 10Catrope: [C: 032] Document index argument correctly in addItems documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/111513 (owner: 10Trevor Parscal) [23:55:40] (03CR) 10Esanders: Don't allow extensions to have no content by default (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [23:56:08] (03Merged) 10jenkins-bot: Document index argument correctly in addItems documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/111513 (owner: 10Trevor Parscal) [23:56:14] (03CR) 10jenkins-bot: [V: 04-1] Don't allow extensions to have no content by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [23:56:49] RoanKattouw: BTW, want to do a quick re-review on code going out when I escape this evening? [23:56:58] RoanKattouw: Maybe 60-90 minutes' time? [23:57:41] Sure [23:57:45] Kk. [23:57:47] And bugs, in particular [23:58:04] (03CR) 10jenkins-bot: [V: 04-1] Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 (owner: 10Esanders) [23:58:13] (03PS3) 10Esanders: Don't allow extensions to have no content by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 [23:58:15] (03PS4) 10Esanders: Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 [23:59:11] Hmm... [23:59:27] Krenair: My idea not good? [23:59:33] (03CR) 10jenkins-bot: [V: 04-1] Don't allow extensions to have no content by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [23:59:45] I tried a 2px margin but the loading bar still shows over the top of text :( [23:59:58] How odd.