[00:00:11] (03CR) 10Catrope: [C: 04-1] Don't allow extensions to have no content by default (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [00:00:14] (And I am not a CSS wizard) [00:00:23] Krenair: Excuses. :-) [00:00:27] (03CR) 10jenkins-bot: [V: 04-1] Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 (owner: 10Esanders) [00:01:09] (03PS1) 10Catrope: Rebuild .docs/eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111655 [00:01:54] RoanKattouw, looking at the ref/media dialogs, it doesn't look like we copy over the internalList DM either [00:02:21] (03CR) 10jenkins-bot: [V: 04-1] Rebuild .docs/eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111655 (owner: 10Catrope) [00:02:34] Krenair: Hm, your change to onLoadError is broken :( trying to figure out why [00:03:10] Was that the one to catch request abort due to navigation? [00:04:08] Yes [00:04:15] It breaks when Parsoid 404s on initial load [00:04:22] Also, this.loading.abort() isn't there, that's another bug [00:04:34] James_F|Away, something to do with z-index perhaps? [00:05:04] Krenair: Sounds possible. We try to avoid z-index usage, but I think we have to for that because of Monobook(?). [00:05:12] Krenair: RoanKattouw can probably help better. [00:05:20] (Sorry, RoanKattouw.) [00:05:34] Hmm, it looks like loadError may be called differently depending on how it fails or something [00:05:59] (03PS4) 10Esanders: Don't allow extensions to have no content by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 [00:06:01] (03PS5) 10Esanders: Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 [00:06:03] (03CR) 10Trevor Parscal: "I think we should make ve.init.mw.Target more abstract, and empty out the setupToolbar button, moving it to ve.init.mw.ViewPageTarget. The" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson) [00:06:23] (03CR) 10Esanders: Don't allow extensions to have no content by default (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [00:07:14] (03CR) 10jenkins-bot: [V: 04-1] Don't allow extensions to have no content by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [00:07:50] what are these failures: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/7663/consoleFull [00:07:57] I don't know [00:08:01] They're a mystery to me too [00:08:04] Krinkle: ---^^ ?? [00:08:10] checkin [00:08:19] (03CR) 10jenkins-bot: [V: 04-1] Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 (owner: 10Esanders) [00:08:48] RoanKattouw: jquery.client outdated? [00:08:52] Did someone merge that? [00:09:24] I don't know? [00:09:37] Regression in core I imagine [00:09:44] weird though, because it's the *core* test that is failing not ours [00:10:28] that couldn't have been merged [00:10:57] RoanKattouw, Is the error "Uncaught TypeError: Cannot read property 'status' of null "? [00:16:37] Ahm, lemme see [00:17:03] Krinkle: I fixed the XHR-related stuff if that's what you mean [00:17:07] And yes it's that error [00:17:15] Fix incoming [00:18:26] RoanKattouw: ? [00:18:38] (03PS1) 10Catrope: Don't chain .then() in this.loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111666 [00:18:42] Sorry [00:18:52] I need to start being able to tell the difference between Krinkle and Krenair [00:18:57] Krinkle: Ignore me, I'm blind [00:18:59] RoanKattouw: k [00:19:05] Krenair: Those things were meant for you [00:19:16] Maybe I should start to use my real name on IRC :P [00:19:16] RoanKattouw: So, no idea why core jquery.client tests are passing for core, and failing with VisualEditor is loaded? [00:19:26] "platform": "unknown", -> "platform": "linux", [00:19:30] so weird, that module has not changed in core [00:19:37] (not yet anyway) [00:19:55] RoanKattouw, you're fixing it? okay [00:20:04] Krinkle: Do we have our own jquery.client that we're loading from somewhere? [00:20:05] (03CR) 10jenkins-bot: [V: 04-1] Don't chain .then() in this.loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111666 (owner: 10Catrope) [00:20:10] Wonder why response is undefined.. [00:20:16] we shouldn't be loading it in mw [00:20:20] maybe that's what's happening? [00:20:39] Krenair: The docs were lying. response is really jqXHR (jQuery XHR object) which can sometimes be null [00:21:01] The event's param docs didn't match the handler function's param docs, so one of them was wrong. In this case the event docs were right and the handler docs were wrong [00:21:10] (03CR) 10jenkins-bot: [V: 04-1] Fix crashes in onLoadError() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111667 (owner: 10Catrope) [00:21:33] jqXHR is null when the AJAX request succeeds but the data we get back is so bad that we retroactively declare it to be an error [00:25:24] Krinkle: I ran the tests locally but I don't get any farther than "Cannot read property 'getMessage' of undefined" [00:26:21] Except in debug mode [00:26:26] Oh look, I can reproduce in debug mode [00:27:11] yeah, getMessage is snafu because we're doing the ve.msg thing in a horrible way in visualeditor. It works in production because we lazy load things. That's never worked properly and also why we can't do it that way in standalone. [00:27:22] keep refreshing until it doesn't give getMessage or toggle debug mode [00:27:31] It didn't use to cripple the tests this badly though [00:27:32] I usually only get getMessage failure in debug mode not in non-debug [00:28:14] Hmm, so this is weirder [00:28:21] When running the jquery.client tests in isolation, they pass [00:28:32] Yeah, I just figured that out [00:28:36] There must be some state-clobbering going on [00:28:38] Yep [00:28:42] I'm on it [00:28:58] Unless you want to take it, I only just got started. [00:30:01] Hmmmm [00:30:04] modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js [00:30:05] 159: profile = $.client.profile( { 'userAgent': cases[i].userAgent, 'platform': '' } ); [00:30:08] That looks suspicious [00:30:17] No, you take it, I have other things to do [00:30:19] (Sorry) [00:30:59] k [00:37:51] (03PS8) 10Jdlrobson: Make default OOJS UI styles optional [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 [00:37:52] RoanKattouw: Hm.. so my first guess was that the default entry in profileCache for the current browser (as opposed to a custom one) in jquery.client.js is being polluted to early by VE. [00:37:53] (03PS9) 10Jdlrobson: Allow better toolbar customisation for VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 [00:37:56] Looks like it is the reverse [00:38:09] We're polluting it with custom values but only partial [00:38:20] OK [00:38:21] the cache is keyed by userAgent, but platform influences profile data as well [00:38:24] Was the line that I called out at fault? [00:38:38] Yep [00:38:50] (03PS1) 10Trevor Parscal: (Stand back) Extreme label refactoring [oojs/ui] - 10https://gerrit.wikimedia.org/r/111672 [00:39:00] Our tests are mostly different UAs (even for "similar" browsers, we happened to pick different samples in most case), except for these two [00:39:10] (03CR) 10jenkins-bot: [V: 04-1] Make default OOJS UI styles optional [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 (owner: 10Jdlrobson) [00:39:11] so we pollute it with platformless clients [00:39:23] however jquery.client is to blame as well since it should use a better cache key [00:39:42] because if one would be pc and the other mac, it will still fail and it wouldn't be our fault [00:40:13] (03CR) 10jenkins-bot: [V: 04-1] Allow better toolbar customisation for VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson) [00:40:37] I'll fix core first, we can fix the one in VE later as it is OKish [00:41:07] e.g. Iceweasel / '' is invalid and is populating platform:unknown so when core then gives it Iceweasel/Linux it gets platform:unknown [00:41:10] Krinkle: Is there a workaround we can apply in VE? [00:41:19] Because it's breaking our ability to merge /anything/ in VE right now [00:44:29] Krinkle: [16:44:17.315] Linux x86_64 [00:45:27] RoanKattouw: Not really. fixing in core now [00:45:30] OK [00:45:36] Let's get it merged fast then [00:45:52] We can give it platform: 'linux' in VE, but that will break for tests that expect win or mac there, it's just a differnet failure [00:46:13] RoanKattouw, Krinkle: are you executing locally VisualEditor tests written in Ruby and Cucumber? [00:46:38] InezK: No, just on the server; JeffHall does them locally, though. [00:46:57] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (a59dfedb74) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111675 [00:47:01] JeffHall: Did you run into any particular problems when setting them up? [00:47:07] InezK: JeffHall is our browser testing guy, Krinkle is our unit testing guy, I know nothing :) [00:47:51] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (a59dfedb74) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111675 (owner: 10Trevor Parscal) [00:47:56] Ugh, I hate Firefox [00:48:23] In an iframe that somehow isn't fully initialized yet, you can have window.getComputedStyle() return an object but have attempts to inspect the properties of that object throw DOM exceptions [00:54:15] (03PS1) 10Trevor Parscal: (Stand back again) Even moar label manias! (label refactoring) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111682 [00:56:05] (03CR) 10jenkins-bot: [V: 04-1] (Stand back again) Even moar label manias! (label refactoring) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111682 (owner: 10Trevor Parscal) [00:57:03] (03PS9) 10Jdlrobson: Make default OOJS UI styles optional [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 [00:57:05] (03PS10) 10Jdlrobson: Allow better toolbar customisation for VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 [00:57:42] (03PS2) 10Esanders: Hide automatic reference names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111626 [00:57:53] (03CR) 10Krinkle: [C: 032] "Re-submit, core should be fixed now." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111626 (owner: 10Esanders) [00:58:53] (03PS2) 10Catrope: Rebuild .docs/eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111655 [00:59:09] (03CR) 10Krinkle: [C: 032] Rebuild .docs/eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111655 (owner: 10Catrope) [00:59:26] (03PS9) 10Esanders: Implement SVGMaxSize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109604 [00:59:38] (03CR) 10Krinkle: [C: 032] "Re-submit, core should be fixed now." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109604 (owner: 10Esanders) [01:02:22] (03Merged) 10jenkins-bot: Hide automatic reference names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111626 (owner: 10Esanders) [01:04:29] (03Merged) 10jenkins-bot: Rebuild .docs/eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111655 (owner: 10Catrope) [01:06:44] (03Merged) 10jenkins-bot: Implement SVGMaxSize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109604 (owner: 10Esanders) [01:18:10] InezK_away: sorry, was heads-down on something. Do you still have a question abotu the VE browser tests? [01:20:18] (03PS1) 10Catrope: Make globalOverlay really global [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111690 [01:24:01] (03PS2) 10Jhall: [Browser test] WIP Headless test for VE verification on a fresh Mediawiki install (as on Integration server). [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110468 [01:24:09] (03CR) 10jenkins-bot: [V: 04-1] [Browser test] WIP Headless test for VE verification on a fresh Mediawiki install (as on Integration server). [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110468 (owner: 10Jhall) [01:25:33] (03CR) 10Trevor Parscal: [C: 032] Make globalOverlay really global [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111690 (owner: 10Catrope) [01:26:37] (03Merged) 10jenkins-bot: Make globalOverlay really global [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111690 (owner: 10Catrope) [01:28:08] (03PS1) 10Catrope: Update VE core submodule to master (08083de) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111691 [01:32:11] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (08083de) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111691 (owner: 10Catrope) [01:33:20] (03Merged) 10jenkins-bot: Update VE core submodule to master (08083de) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111691 (owner: 10Catrope) [01:35:17] (03Abandoned) 10Jhall: [Browser test] WIP Headless test for VE verification on a fresh Mediawiki install (as on Integration server). [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110468 (owner: 10Jhall) [01:38:56] (03PS2) 10Jhall: [Browser test] Reintroduce headless browser test support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110606 [01:39:14] (03PS1) 10Catrope: Make globalOverlay really global [VisualEditor/VisualEditor] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/111694 [01:39:41] (03Abandoned) 10Catrope: Make globalOverlay really global [VisualEditor/VisualEditor] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/111694 (owner: 10Catrope) [01:40:19] RoanKattouw, is https://gerrit.wikimedia.org/r/#/c/111666/1 really a dependency for the onLoadError issue? [01:40:39] No, not really [01:40:48] They can be rebased apart [01:41:21] (03PS1) 10Catrope: Make globalOverlay really global [VisualEditor/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111695 [01:42:38] (03PS1) 10Catrope: Update VE core submodule for 05f818a Make globalOverlay really global [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111696 [01:43:05] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule for 05f818a Make globalOverlay really global [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111696 (owner: 10Catrope) [01:47:56] (03PS1) 10Jhall: [Browser test] WIP Headless test for VE verification on a fresh Mediawiki install. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111698 [02:58:09] (03CR) 10Catrope: [C: 032] Adding alternate text to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105098 (owner: 10Mooeypoo) [02:59:22] (03Merged) 10jenkins-bot: Adding alternate text to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105098 (owner: 10Mooeypoo) [03:01:24] (03CR) 10Catrope: [C: 032] Adding position setting to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105225 (owner: 10Mooeypoo) [03:02:42] (03Merged) 10jenkins-bot: Adding position setting to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105225 (owner: 10Mooeypoo) [03:23:48] (03CR) 10Jforrester: "Should this be merged with I9c855e6381d970b5f08460822366?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 (owner: 10Mooeypoo) [03:24:08] (03PS7) 10Jforrester: [WIP] Add image type change to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105247 (owner: 10Mooeypoo) [04:15:00] (03PS5) 10Esanders: Don't allow extensions to have no content by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 [04:15:13] (03PS6) 10Esanders: Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 [04:15:42] Hey mooeypoo. :-) [04:16:01] heya [04:16:12] (03CR) 10Catrope: [C: 032] Don't allow extensions to have no content by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [04:16:34] I just came back from school, and despite being a trained well-seasoned NYC'er, I stepped right into faux-ice [04:16:43] Oops. [04:16:52] my entire foot got wet. [04:16:54] bah. [04:16:59] No galloshes? [04:17:07] ga-whoshes? [04:17:20] https://en.wikipedia.org/wiki/Galoshes [04:17:24] Single-l, apparently. [04:17:30] (03CR) 10Catrope: [C: 032] Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 (owner: 10Esanders) [04:17:40] haha i should get me those [04:17:46] no I was wearing sneakers [04:17:57] My NY family swear by them. [04:18:10] .. at least it happened as I was walking home and not on my way to school [04:18:16] that could've sucked [04:18:22] True. [04:19:07] anyways, James_F I saw your email. We need to discuss the media dialog in general, not ust the size widget now with the inline/block change... [04:19:08] (03Merged) 10jenkins-bot: Don't allow extensions to have no content by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111178 (owner: 10Esanders) [04:19:24] might be a good idea to have a short brainstorming meeting you, me, and trevor? [04:20:16] (03Merged) 10jenkins-bot: Always show 'File:' in content language for gallery placeholder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111179 (owner: 10Esanders) [04:20:51] mooeypoo: Sure. Thankfully I'm now back to normal, no full-day meetings for at least the rest of the week. :-) [04:21:23] ooh great. Tomorrow I have to get to class after standup, but I come back ~6:30pm my time (3:30pm yours) [04:21:37] * James_F nods. [04:21:44] Want to have a chat around then? [04:21:55] sounds good to me [04:22:10] it's mostly a matter of picking the best strategy for inline/block switch [04:22:21] * James_F nods. [04:22:31] they share some properties but not others.. so we need to see if we have 2 different dialog layouts, or enable/disable or hide/show etc. [04:23:31] * James_F nods. [04:38:10] James_F, replied to your email. Some of those things are bugs, I shall look why they popped up, but some we might want to choose strategies. [04:39:52] It's funny, I feel like there's this battle under the surface between the hardcore-editors who want to do things "the way they were" and those who want to transform editing to something that's independent of old habits.. [04:42:08] mooeypoo: Yeah. [04:42:19] mooeypoo: Ha. I don't know it's a "battle". [04:42:30] mooeypoo: We're all working for the same thing (making Wikipedia better). [04:42:35] mooeypoo: We just have different priorities. [04:43:01] oh yeah, I don't mean a bloody battle. [04:43:08] More like battle of wits battle. [04:43:17] "Healthy debate". [04:43:18] :-) [04:43:21] That too. [04:43:22] :D [04:43:28] A balancing act. [06:43:39] (03CR) 10Jforrester: "Can this is abandoned?" [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111696 (owner: 10Catrope) [07:20:08] mooeypoo: It seems quite likely we'll create an additional class of users with VE. [07:20:58] There will be power-users capable of doing whatever via wikitext magic (as now), people who have no idea what's going on (as now), and people who can passably get by using VisualEditor (new group). [07:25:21] * mooeypoo nods [07:25:24] hopefully, yeah. [07:26:21] I know that I still struggle a bit with some of the advanced wikitext. I can figure it out with documentation and reading other examples mostly, but what stops me (and I think it may be indicative to others, especially newbies) is that I'm worried of screwing things up or making people mad [07:26:29] so, in that aspect, VE can really help. [07:32:39] mooeypoo: go to bed :) [07:32:50] hehe yep, in a few. [07:32:56] homework! :p [07:46:04] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105247 (owner: 10Mooeypoo) [07:46:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110234 (owner: 10Mooeypoo) [08:56:11] (03CR) 10Zfilipin: "I am not sure what is going on here. Why did you revert my commit[1] and now you are creating almost identical commit?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110606 (owner: 10Jhall) [10:25:19] (03PS3) 10Esanders: Fix layout of keyboard shortcuts page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109483 [16:26:21] (03CR) 10Zfilipin: [C: 032] [Browser test] Reintroduce headless browser test support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110606 (owner: 10Jhall) [16:28:32] (03Merged) 10jenkins-bot: [Browser test] Reintroduce headless browser test support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110606 (owner: 10Jhall) [17:28:47] (03PS1) 10Esanders: Undefined variables first in selectNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111821 [17:28:49] (03PS1) 10Esanders: Don't descend into handlesOwnChildren nodes in selectNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111822 [17:57:35] (03PS2) 10Esanders: Don't descend into handlesOwnChildren nodes in selectNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111822 [18:20:54] (03PS2) 10Jforrester: Update VE core submodule for 05f818a Make globalOverlay really global [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111696 (owner: 10Catrope) [18:21:26] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule for 05f818a Make globalOverlay really global [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111696 (owner: 10Catrope) [20:02:25] (03CR) 10Alex Monk: Use accesskey=s on the save buttons (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 (owner: 10Alex Monk) [20:28:15] (03PS2) 10Jhall: [Browser test] Headless browser test for VE verification on a fresh Mediawiki install. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111698 [20:28:23] (03CR) 10jenkins-bot: [V: 04-1] [Browser test] Headless browser test for VE verification on a fresh Mediawiki install. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111698 (owner: 10Jhall) [20:32:58] (03PS6) 10Trevor Parscal: Only populate lookup widget menus asynchronously [oojs/ui] - 10https://gerrit.wikimedia.org/r/111340 [20:40:44] (03Abandoned) 10Jhall: [Browser test] Headless browser test for VE verification on a fresh Mediawiki install. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111698 (owner: 10Jhall) [20:50:29] (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111666 (owner: 10Catrope) [20:50:39] (03PS1) 10Jhall: [Browser test] New test for headless browser testing on a fresh Mediawiki install with VisualEditor. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 [21:17:03] (03CR) 10Trevor Parscal: Allow better toolbar customisation for VisualEditor (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson) [21:18:03] any strong feelings about whether it's best to throw an exception when abstract methods are called? https://gerrit.wikimedia.org/r/#/c/109806/10/modules/ve-mw/init/ve.init.mw.Target.js,unified [21:18:24] (03PS2) 10Alex Monk: Fix crashes in onLoadError() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111667 (owner: 10Catrope) [21:20:08] (03CR) 10Alex Monk: "(rebased to remove unnecessary dependency)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111667 (owner: 10Catrope) [21:26:19] (03PS5) 10Trevor Parscal: FieldLayout support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108958 [21:26:48] (03CR) 10jenkins-bot: [V: 04-1] FieldLayout support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108958 (owner: 10Trevor Parscal) [21:41:18] RoanKattouw_away, rmoen|away, TrevorParscal: I'm going to close https://bugzilla.wikimedia.org/show_bug.cgi?id=59615 unless you object [21:43:27] closed [21:49:58] (03CR) 10Alex Monk: [C: 031] Fix crashes in onLoadError() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111667 (owner: 10Catrope) [22:07:50] TrevorParscal: http://en.wikipedia.beta.wmflabs.org/wiki/Page?veaction=edit&useformat=mobile [22:13:00] edsanders: you 'round? [22:13:55] edsanders: TrevorParscal: VE silently fails on mobile because the static paste rules property assignment fails because mw.ViewPageTarget is not defined (that class is part of mw.desktop mobile, not ve-mw core, so it's not on mobile) [22:14:17] TrevorParscal: https://bugzilla.wikimedia.org/show_bug.cgi?id=60912 [22:15:17] TrevorParscal, howdy [22:15:29] * jdlrobson waves at edsanders  [22:15:50] 'sup [22:15:56] http://cl.ly/image/0D2t2C16031u [22:16:06] on mobile, ViewPageTarget isn't loaded, so this fails [22:16:48] lame [22:18:56] edsanders: Yes, your code is. :-P [22:21:23] I guess we need to move that up to the target [22:21:57] like where toolbarGroups is.... [22:22:18] do you want me to do that? it should be fairly trivial [22:25:12] edsanders: Please. [22:30:41] (03PS1) 10Esanders: Move paste rules to Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111912 [22:30:44] jdlrobson, TrevorParscal ^^ [22:36:13] (03PS2) 10Catrope: Don't chain .then() in this.loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111666 [22:37:06] (03PS6) 10Catrope: Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 [22:37:39] edsanders: You CR+2'ed https://gerrit.wikimedia.org/r/#/c/109727/ last week but it didn't merge - is it still good to go? [22:41:34] (03CR) 10Jdlrobson: [C: 031] Move paste rules to Target (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111912 (owner: 10Esanders) [22:41:52] (03PS2) 10Jdlrobson: Move paste rules to Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111912 (owner: 10Esanders) [22:42:14] (03CR) 10Jdlrobson: [C: 031] "See another suggestion on PS1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111912 (owner: 10Esanders) [22:44:58] (03CR) 10Esanders: Move paste rules to Target (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111912 (owner: 10Esanders) [22:45:15] (03CR) 10Esanders: [C: 032] Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 (owner: 10Catrope) [22:45:28] edsanders: Thanks [22:46:25] (03Merged) 10jenkins-bot: Use apiRequest() function in MWMediaEditDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109727 (owner: 10Catrope) [22:50:55] https://gerrit.wikimedia.org/r/#/c/109806/10 < James_F when TrevorP|Away get's back can you poke him to look at this? We talked about it yesterday so I'm hoping he can merge today so I can get some work on the VisualEditor toolbar unblocked! [22:51:10] if anyone else wants to [22:51:20] +2 i'd be very happy (Krinkle edsanders rmoen|away etc [22:52:46] jdlrobson, there are comments on the last patchset [22:53:04] ooh where did that one come from [22:53:27] (03CR) 10Krinkle: "How is it optional? Does jQuery not always pass it, or are we using this callback for more than 1 code path?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111667 (owner: 10Catrope) [22:53:28] edsanders: do exceptions need to be translated? i'm guessing not [22:53:33] nopr [22:53:35] e [22:54:10] (03CR) 10Krinkle: [C: 031] "Testing.." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111912 (owner: 10Esanders) [22:54:13] if you ctrl F for "must implement" you'll see an example [22:54:20] also add @throws to documentation [22:54:59] (03CR) 10JGonera: Make MobileViewTarget scroll to desired section (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110655 (owner: 10JGonera) [22:57:03] (03PS11) 10Jdlrobson: Allow better toolbar customisation for VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 [22:59:20] Hm.. toolbar padding broken again? [22:59:43] Now it's broken in the other direction [22:59:44] http://imgur.com/jezv1fu [22:59:47] James_F: ^ [23:00:22] (03CR) 10Krinkle: [C: 032] Move paste rules to Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111912 (owner: 10Esanders) [23:00:39] (03PS1) 10Jforrester: Move paste rules to Target [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111919 [23:01:34] (03Merged) 10jenkins-bot: Move paste rules to Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111912 (owner: 10Esanders) [23:07:37] (03PS1) 10Krinkle: Minor clean up and doc fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111923 [23:08:16] (03PS2) 10Krinkle: ve.ce.MWResizableNode: Fix broken @extends documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111923 [23:19:28] (03CR) 10Krinkle: Don't chain .then() in this.loading (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111666 (owner: 10Catrope) [23:21:03] (03CR) 10Esanders: [C: 032] ve.ce.MWResizableNode: Fix broken @extends documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111923 (owner: 10Krinkle) [23:23:16] edsanders: is that patch ok now? [23:23:50] (03Merged) 10jenkins-bot: ve.ce.MWResizableNode: Fix broken @extends documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111923 (owner: 10Krinkle) [23:24:03] (03CR) 10Krinkle: [C: 04-1] "-1 for comment .done/.fail" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111666 (owner: 10Catrope) [23:27:38] (03PS2) 10JGonera: Make MobileViewTarget scroll to desired section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110655 [23:27:40] (03PS1) 10JGonera: Move restoreEditSection() to mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111929 [23:30:06] Looks okay to me, will let TrevorParscal approve as they were his suggestions [23:31:49] (03CR) 10Esanders: [C: 032] Allow better toolbar customisation for VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson) [23:31:55] well if he's just going to leave.... [23:31:57] (03CR) 10jenkins-bot: [V: 04-1] Allow better toolbar customisation for VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson) [23:32:09] eeekkkkk [23:32:12] ok i'll rebase :) [23:32:21] looks like you lost rebase roulette [23:32:41] i hate that game! :) [23:38:00] (03PS12) 10Jdlrobson: Allow better toolbar customisation for VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 [23:38:10] edsanders: :) [23:39:35] (03CR) 10jenkins-bot: [V: 04-1] Allow better toolbar customisation for VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson) [23:42:28] (03CR) 10Esanders: [C: 04-1] "One More Thing (TM)" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson) [23:43:37] jdlrobson, sorry ^^ [23:44:39] (03CR) 10Jdlrobson: Allow better toolbar customisation for VisualEditor (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson) [23:45:21] (03PS13) 10Jdlrobson: Allow better toolbar customisation for VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 [23:45:24] edsanders: no problemo [23:45:27] that should be good now [23:45:32] i should have run npm test anyhow [23:46:37] (03CR) 10Esanders: [C: 032] Allow better toolbar customisation for VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson) [23:48:23] (03Merged) 10jenkins-bot: Allow better toolbar customisation for VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson)