[00:02:27] (03CR) 10Krinkle: [C: 032] Make globalOverlay really global [VisualEditor/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111695 (owner: 10Catrope) [00:04:05] (03Merged) 10jenkins-bot: Make globalOverlay really global [VisualEditor/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111695 (owner: 10Catrope) [00:06:15] (03PS3) 10Krinkle: Update VE core submodule for 05f818adb4 [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111696 (owner: 10Catrope) [00:06:35] (03CR) 10Krinkle: [C: 032] Update VE core submodule for 05f818adb4 [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111696 (owner: 10Catrope) [00:08:43] (03Merged) 10jenkins-bot: Update VE core submodule for 05f818adb4 [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111696 (owner: 10Catrope) [00:11:21] (03PS2) 10Jforrester: Move paste rules to Target [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111919 [00:11:42] (03CR) 10Krinkle: [C: 032] Move paste rules to Target [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111919 (owner: 10Jforrester) [00:13:56] (03Merged) 10jenkins-bot: Move paste rules to Target [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111919 (owner: 10Jforrester) [00:24:54] (03PS2) 10Jhall: [Browser test] WIP New test for VE Page Settings menu. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110659 [00:26:51] (03PS10) 10Jdlrobson: Make default OOJS UI styles optional [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109940 [00:29:51] (03CR) 10Physikerwelt: "For me this does not work... even if Math-Support is disabled I get the error:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [01:07:54] (03PS8) 10Mooeypoo: Add image type change to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105247 [01:08:24] TrevorParscal / James_F ^^ that's the type (without inline!) change + change to ButtonSelectWidget [01:09:07] Did you want the 'none' (position) to be an option, or an unmarking of a checkbox? [01:13:10] (03PS2) 10Jforrester: Remove the math inspector code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [01:13:40] mooeypoo: Unmarking of a checkbox. We'll need to work on the copy text, though. [01:14:30] (03CR) 10Krinkle: [C: 04-1] "There is an inconsistent behaviour with null/undefined. I'd recommend making it less hardcoded (no need to hardcode typeof number, and onl" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111929 (owner: 10JGonera) [01:14:47] (03CR) 10Jforrester: "@Physikerwelt: Yeah, that's a known bug from last month – have rebased up to new master, should be fine." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [01:15:37] hmm. James_F I actually think "none" works there as part of the options, now, but if not, I wonder if we can have a separator in the ButtonSelectWidget ? [01:15:58] "Left | Center | Right | | None" ? [01:16:05] mooeypoo: They're different concepts, though. [01:16:19] mooeypoo: this is a good first step [01:16:31] mooeypoo: "Left | Centre | Right" are answers to the question "What position should the float be set to?". [01:16:43] James_F, only to those understanding what's going on in the HTML, though, no? I mean, to the user, they're straight forward: stick to left/center/right or don't. [01:16:51] next step is to make "positioning" an option which enables the left|center|right options [01:16:52] mooeypoo: Whereas "None" is actually a response ("no") to "Should the image be floated?". [01:17:18] "flaoted" is a term html people understand.. not necessarily all users [01:17:36] if you told my sister where she wants the image to float she'd think you're offering her a new type of rootbeer. [01:17:58] My point is that I think conceptually it works as the same 'sort' of thing, no? [01:18:36] mooeypoo: Indeed, that's why we'll need to work on copy. :-) [01:19:03] ok, should I leave it as is 'till we figure out a better way, or should I add a checkbox with a label (and then we can change it as we review?) [01:19:36] It's ready for review/merge, I'm wondering if I should add that and then take off WIP or just take off WIP.. that change is on position anyways (and the commit is technically for type) [01:21:06] James_F, do you think https://gerrit.wikimedia.org/r/#/c/110862/ is taking the right approach? I'm not 100% happy with FlaggedRevs having to check for VE like this but I didn't come up with any other way. [01:21:35] Krenair: In general, FR is going to be deployed on fewer wikis than VE. [01:21:37] James_F, next step is to go over your email and fix everything, but i'll do that in a separate fixup commit, otherwise things will start getting confusing. I think I can take off the WIP off of the current one, then. [01:21:46] Krenair: So it feels right that FR checks for VE (and not the other way around). [01:22:02] I don't know if it would be possible for VE to check for FR anyway [01:22:09] That said I'm not 100% confident about the order hooks are called in [01:22:27] Krenair: But honestly, it's more of a "code smell" for MW's extensions system, sadly. [01:22:27] mooeypoo: Do it and I can fiddle with the copy trivially afterwards? [01:22:36] mooeypoo: And yeah, sorry to burden you so much. :-) [01:22:41] Krenair: Hmm. Point. [01:22:57] James_F, alright. Who would be best to ask to review it do you think? [01:23:20] no burden, I'm just trying to be methodological so I don't confuse the commits :P [01:23:33] Krenair: Roan. He's always best for MW things, and he's our CR demon. :-) [01:23:44] Krenair: But even if you don't add anyone it'll get reviewed. [01:24:13] Krenair: https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/default is scanned for new changes a few times a day. [01:24:16] Heh okay, I already added him. I guess he has a rather large pile of things to do which are more important than the tab order. [01:24:37] Yes but this is mediawiki/extensions/FlaggedRevs [01:24:45] Krenair: Yup. [01:25:58] Krenair: Seen Roan's comment on https://gerrit.wikimedia.org/r/#/c/110295/ ? Any =thoughts? [01:34:18] James_F, I don't have anything to add really, it's not an easy problem to solve as Roan said [01:39:25] Krenair: True. [01:39:35] Krenair: I'll bully Roan into just merging then. ;-) [01:47:48] hmm [01:51:39] (03PS1) 10Jhall: Revert "[Browser test] Reintroduce headless browser test support" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111951 [01:53:37] (03CR) 10Jhall: [C: 032] "Approving my own change since VisualEditor browser tests are completely broken at this point, and we've (unfortunately) been through this " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111951 (owner: 10Jhall) [01:54:22] TrevorP|Away / James_F, checkboxInputWidget isn't labeled, and I'm having issues aligning the checkbox to the label when adding it in. I am wondering if we shouldn't change that widget in OOJS to labeled..? [01:54:40] mooeypoo: There's a labelled version. [01:54:44] (03Merged) 10jenkins-bot: Revert "[Browser test] Reintroduce headless browser test support" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111951 (owner: 10Jhall) [01:54:59] ... there is? [01:55:19] oh [01:55:25] CheckboxInputWidget vs CheckboxWidget [01:55:26] ha [01:55:52] mooeypoo: Yeah. [01:56:03] mooeypoo: Sorry. :-( [01:56:40] I'm amused. I started playing around with adding the LabeledElement mixin to the CheckboxInputWidget [01:56:56] That'll teach me settling on the first widget I see.... :P [01:57:12] * James_F grins. [02:26:54] (03CR) 10Physikerwelt: "Now the visual editor loading bar is displayed for more than 3 minutes, but nothing happens. Even for pages that do not contain math or wi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [02:33:00] (03CR) 10Physikerwelt: [C: 04-1] "I think some reference to the math part is still in." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [02:37:28] James_F, tiny functionality question -- I am setting things up so if the checkbox is unmarked (so, 'none') but the user clicks an explicit direction, it automatically marks the checkbox too. [02:37:48] should I do it the other way around? unmarking = resetting the buttons ? [12:40:13] (03PS1) 10Zfilipin: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112018 [12:40:43] (03PS2) 10Zfilipin: [browser test] Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112018 [16:10:50] (03CR) 10Cmcmahon: [C: 032] [browser test] Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112018 (owner: 10Zfilipin) [16:12:00] (03Merged) 10jenkins-bot: [browser test] Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112018 (owner: 10Zfilipin) [16:17:29] (03PS1) 10Hashar: Global setting for Parsoid HTTP proxy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 [16:17:37] (03CR) 10jenkins-bot: [V: 04-1] Global setting for Parsoid HTTP proxy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [16:19:59] (03PS2) 10Hashar: [Browser test] New test for headless browser testing on a fresh Mediawiki install with VisualEditor. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [16:20:22] (03CR) 10Hashar: "Rebased: mediawiki-selenium -> mediawiki_selenium (underscore)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [16:20:28] (03PS2) 10Hashar: Global setting for Parsoid HTTP proxy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 [16:35:49] (03PS3) 10Jforrester: Remove the math inspector code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [16:35:57] (03CR) 10jenkins-bot: [V: 04-1] Remove the math inspector code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [16:36:03] (03CR) 10Jforrester: Remove the math inspector code (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [16:49:26] (03PS3) 10Hashar: Global setting for Parsoid HTTP proxy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 [17:00:30] (03CR) 10Hashar: "The reason for this change is running the browser tests on some labs instance having $wgHTTPProxy set to brewster. The MWHttpRequest will" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [17:13:57] (03CR) 10Physikerwelt: "Why does jenkins complain now?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [17:21:32] (03CR) 10Hashar: "This change has been made dependent of https://gerrit.wikimedia.org/r/#/c/111890 so I can test both changes in Jenkins :-D" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [17:22:42] (03PS4) 10Physikerwelt: Remove the math inspector code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [17:24:06] (03PS5) 10Jforrester: Remove the math inspector code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [17:24:15] (03CR) 10jenkins-bot: [V: 04-1] Remove the math inspector code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [17:29:10] (03PS6) 10Jforrester: Remove the math inspector code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [17:29:49] (03CR) 10Jforrester: "PS6 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [17:35:20] (03PS7) 10Jforrester: Remove the math inspector code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [17:38:23] (03CR) 10Physikerwelt: "oh there are a lot of math related string in the i18 folder... you probably don't want to remove them all?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [17:39:05] (03CR) 10Jforrester: "To quote Roan," [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [17:43:34] (03CR) 10Physikerwelt: "ok. that's fine. but I don't know how to move the button by myself." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105648 (owner: 10Catrope) [18:13:25] (03CR) 10Catrope: "We reuse this method for cases where the XHR itself succeeded, but upon inspecting the result we decided it was an error (e.g. if data.err" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111667 (owner: 10Catrope) [18:33:19] (03CR) 10Krinkle: [C: 032] Fix crashes in onLoadError() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111667 (owner: 10Catrope) [18:34:33] (03Merged) 10jenkins-bot: Fix crashes in onLoadError() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111667 (owner: 10Catrope) [18:39:24] (03PS1) 10Mooeypoo: Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 [18:55:18] (03CR) 10Krinkle: Global setting for Parsoid HTTP proxy (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [19:04:02] (03CR) 10Krinkle: [Browser test] New test for headless browser testing on a fresh Mediawiki install with VisualEditor. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [19:09:19] (03PS1) 10Jdlrobson: Fix toolbar placement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112047 [19:09:45] ^ Krinkle / edsanders|away / rmoen|away can i get a quick merge of that patch ? [19:09:48] i screwed up [19:11:51] also RoanKattouw_away and TrevorP|Away ^ [19:11:54] why is everyone away?! :) [19:15:17] * MatmaRex appears [19:18:56] (03CR) 10Bartosz Dziewoński: [C: 032] "Looks like a simple follow-up to I4c72b4b9128b3a74de8b8b5bce7664fbb315216b." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112047 (owner: 10Jdlrobson) [19:19:03] * MatmaRex hides [19:19:21] thanks MatmaRex :) [19:20:06] (03Merged) 10jenkins-bot: Fix toolbar placement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112047 (owner: 10Jdlrobson) [19:24:19] RoanKattouw_away: https://etherpad.wikimedia.org/p/DeploymentSystemRequirements [19:27:24] jdlrobson: Because it's Friday and we're slackers [19:32:06] (03CR) 10Catrope: "FIXME, see inline comments. I'll work on fixing this up" (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/109806 (owner: 10Jdlrobson) [19:32:37] (03CR) 10Catrope: [C: 032] Undefined variables first in selectNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111821 (owner: 10Esanders) [19:33:50] (03Merged) 10jenkins-bot: Undefined variables first in selectNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111821 (owner: 10Esanders) [19:35:16] (03CR) 10Catrope: [C: 04-1] "It's its, not it's ;)" (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111822 (owner: 10Esanders) [19:37:04] Krinkle: http://cl.ly/image/3B2k1t0b3i14 [19:43:50] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/112053/ [19:48:28] Krenair: Hmm, so https://gerrit.wikimedia.org/r/#/c/110862/ doesn't work for me [19:48:53] I still get Pending Changes between Edit and Edit(beta) [19:49:08] Interesting... I assume you refreshed. [19:49:17] Yes [19:49:18] I wonder if this has to do with hook calling order? [19:49:23] And purged, and tried logged in and logged out [19:49:26] That was my first thought too [19:49:33] I moved FR to the bottom of my LocalSettings [19:49:38] Same problem? [19:50:23] Moved it to the top now [19:50:30] Both above and below VE, doesn't matter, it fails [19:50:32] I wonder why [19:52:16] Meh, I have other code to review, I'm not going to debug this right now [19:52:17] (Sorry :( ) [19:52:45] Okay [19:53:49] RoanKattouw, hang on so I have [read][pending changes][edit][edit source][view history] [19:53:56] How do you get Edit(beta) to show? [19:54:06] Config stuff [19:54:10] Which I suppose I could try disabling [19:54:15] Lemme pastebin it for you [19:54:58] Oh! Heh I think I know why it doesn't work with my config [19:55:12] http://pastebin.com/YFx4CX7h [19:55:18] Specifically, $wgVisualEditorTabPosition = 'after'; [19:56:48] (03PS3) 10Jhall: [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 [19:57:52] maybe I should modify it to always insert after the Read tab instead of looking at what the next tab will be [19:58:05] (03PS3) 10Catrope: Don't descend into handlesOwnChildren nodes in selectNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111822 (owner: 10Esanders) [19:58:14] Krenair: That seems saner in general [19:58:31] (03CR) 10Catrope: [C: 032] Don't descend into handlesOwnChildren nodes in selectNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111822 (owner: 10Esanders) [19:59:21] Krenair: Sorry for our insane level of configurability for VE. :-( [19:59:43] (03Merged) 10jenkins-bot: Don't descend into handlesOwnChildren nodes in selectNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111822 (owner: 10Esanders) [20:01:29] alright, fixed. try that new patch set [20:03:53] OK, will review after lunch [20:04:02] (We're running away to have lunch with the Wikia folks, sorry) [20:11:01] TrevorParscal: https://gerrit.wikimedia.org/r/109940 [21:04:29] (03CR) 10Hashar: Global setting for Parsoid HTTP proxy (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [21:04:47] (03PS4) 10Hashar: Global setting for Parsoid HTTP proxy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 [21:04:58] (03CR) 10Hashar: "fix if() -> if ()" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [21:29:12] RoanKattouw, I think change to FlaggedRevs need Verified and submit [21:29:21] changes* [21:31:41] Krenair: Ugh [22:03:40] (03PS8) 10Krinkle: [WIP] Add demo for dialogs and layouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/109006 [22:06:39] (03PS1) 10Catrope: Fixes for 239bae7512 (mobile toolbar) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112127 [22:07:03] James_F, https://gerrit.wikimedia.org/r/#/c/32700/ should be pretty simple to fix up (link the terms of use and fix that whitespace issue) and I can probably approve it after that [22:09:07] (03CR) 10jenkins-bot: [V: 04-1] Fixes for 239bae7512 (mobile toolbar) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112127 (owner: 10Catrope) [22:10:58] Krenair: Cool. [22:11:08] Krenair: Not sure how bad the rebase might be… :-) [22:14:24] (03PS1) 10Jforrester: Update jquery.client to MW's master (45192156d7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/112128 [22:15:24] (03PS2) 10Catrope: Fixes for 239bae7512 (mobile toolbar) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112127 [22:16:29] James_F, heh yeah, that might be more of a pain to fix than what I brought up [22:17:56] Krenair: :-) [22:18:18] (03CR) 10Catrope: [C: 032] Update jquery.client to MW's master (45192156d7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/112128 (owner: 10Jforrester) [22:19:28] (03Merged) 10jenkins-bot: Update jquery.client to MW's master (45192156d7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/112128 (owner: 10Jforrester) [22:21:36] (03PS7) 10Jforrester: Blacklist Amazon Silk [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/72108 [22:24:39] (03CR) 10Jforrester: [C: 032] Blacklist Amazon Silk [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/72108 (owner: 10Jforrester) [22:25:29] Krenair: Also, yay. ^^^ [22:25:47] (03Merged) 10jenkins-bot: Blacklist Amazon Silk [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/72108 (owner: 10Jforrester) [22:27:21] I think I might be doing git submodules wrong. Every time I pull new commits into my clone of extensions/VisualEditor the lib/ve submodule is outdated... [22:27:33] (03PS9) 10Krinkle: [WIP] Add demo for dialogs and layouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/109006 [22:27:35] (03PS1) 10Krinkle: [WIP] Refactor dialog and window sets [oojs/ui] - 10https://gerrit.wikimedia.org/r/112132 [22:27:58] I then have to go and update that [22:27:58] Krenair: You need to do "git checkout master && git pull && git submodule update" to get to master. [22:28:09] Krenair: Because… git. [22:33:03] James_F, Roan suggested I take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=50475 at some point - but I'm not sure how to properly simulate timeout failure for this? [22:33:29] Krenair: Find a really long article with lots of complex code. :-) [22:34:39] Do you guys have any go-to enwiki pages for this? [22:35:34] Krenair: There's a D&D character page. [22:35:38] * James_F hunts through logs. [22:35:43] Krenair: Good ones are [[Barack Obama]], [[San Francisco]] and [[Argentina]] [22:35:45] Oh yes that one [22:35:55] Selan_(Dungeons_%26_Dragons) [22:35:58] Krenair: See comment #0 on that bug [22:36:02] Yeah, that too. :-) [22:36:03] http://en.wikipedia.org/wiki/List_of_Advanced_Dungeons_%26_Dragons_2nd_edition_monsters [22:36:05] Hm, well [22:36:10] I probably should have read that first. [22:42:52] (03PS5) 10Hashar: Global setting for Parsoid HTTP proxy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 [22:43:11] :-) [22:43:34] (03PS6) 10Catrope: Global setting for Parsoid HTTP proxy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [22:44:40] (03CR) 10Catrope: [C: 04-1] Global setting for Parsoid HTTP proxy (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [22:45:36] (03PS7) 10Catrope: Global setting for Parsoid HTTP proxy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [22:46:01] (03PS8) 10Catrope: Global setting for Parsoid HTTP proxy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [22:46:13] (03CR) 10Catrope: [C: 032] Global setting for Parsoid HTTP proxy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [22:48:18] (03Merged) 10jenkins-bot: Global setting for Parsoid HTTP proxy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112034 (owner: 10Hashar) [22:53:49] (03CR) 10Catrope: [C: 032] "Merging anyway after talking it through with James" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110295 (owner: 10Alex Monk) [22:54:58] (03Merged) 10jenkins-bot: Hide wikitext warning notification when the user removes the markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110295 (owner: 10Alex Monk) [22:55:06] Krenair: Reading your disambig/redirect pages commit now. For someone who's unfamiliar with JS you write damn good JS :) [23:06:16] (03CR) 10Catrope: [C: 04-1] Mark disambiguation and redirect pages in the link inspector (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk) [23:10:30] James_F, hm, maybe this one is a little too much. [23:11:01] with vagrant running in the background it froze my computer and I had to restart [23:14:42] James_F: Krenair's code for redirects/disambigs looks good sans a couple minor things (-1ed for those), here's a screenshot of what it looks like: http://imgur.com/bct8P1Y . Does that look reasonable to you? [23:15:05] James_F: (Also, the Disambiguator extension's __DISAMBIG__ magic word is something we may want to consider recognizing in VE) [23:15:58] (03PS4) 10Jhall: [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 [23:19:03] (03CR) 10Catrope: [C: 04-1] Make MobileViewTarget scroll to desired section (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110655 (owner: 10JGonera) [23:19:47] (03CR) 10Catrope: [C: 032] Auto-select first auto-added required param and fix param order [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111389 (owner: 10Trevor Parscal) [23:21:00] (03Merged) 10jenkins-bot: Auto-select first auto-added required param and fix param order [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111389 (owner: 10Trevor Parscal) [23:21:42] (03PS4) 10Catrope: Fix-up offset when transplanting transclusion parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111501 (owner: 10Trevor Parscal) [23:22:16] (03CR) 10Catrope: [C: 032] Fix-up offset when transplanting transclusion parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111501 (owner: 10Trevor Parscal) [23:22:24] (03PS1) 10Trevor Parscal: Invert dependencies for OutlineItemWidget and PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/112142 [23:22:43] (03CR) 10Catrope: Don't chain .then() in this.loading (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111666 (owner: 10Catrope) [23:22:51] merge spree [23:23:55] (03Merged) 10jenkins-bot: Fix-up offset when transplanting transclusion parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111501 (owner: 10Trevor Parscal) [23:26:08] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (2d0ae07022) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/112144 [23:26:36] (03CR) 10Catrope: [C: 032] Only populate lookup widget menus asynchronously [oojs/ui] - 10https://gerrit.wikimedia.org/r/111340 (owner: 10Trevor Parscal) [23:27:14] (03Merged) 10jenkins-bot: Only populate lookup widget menus asynchronously [oojs/ui] - 10https://gerrit.wikimedia.org/r/111340 (owner: 10Trevor Parscal) [23:28:16] (03PS6) 10Alex Monk: Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 [23:29:05] (03PS1) 10Trevor Parscal: Update use of OO.ui.PageLayout to work with changes in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112145 [23:29:27] (03PS3) 10JGonera: Make MobileViewTarget scroll to desired section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110655 [23:29:29] (03PS2) 10JGonera: Move restoreEditSection() to mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111929 [23:29:31] (03CR) 10jenkins-bot: [V: 04-1] Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk) [23:29:44] (03CR) 10jenkins-bot: [V: 04-1] Update use of OO.ui.PageLayout to work with changes in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112145 (owner: 10Trevor Parscal) [23:30:16] (03CR) 10Catrope: [C: 04-1] Mark disambiguation and redirect pages in the link inspector (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk) [23:30:38] (03PS1) 10Trevor Parscal: [WIP] Split out the guts of MediaEditDialog into separate page classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112146 [23:30:42] (03CR) 10Catrope: "Sans the jshint thing this looks good to me. James, is this OK from a product/UI/UX perspective?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk) [23:31:36] RoanKattouw, hm, why is JSHint complaining about that? Isn't it valid? [23:31:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Split out the guts of MediaEditDialog into separate page classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112146 (owner: 10Trevor Parscal) [23:38:31] Krenair: It's valid but it creates a global variable [23:38:41] oh. [23:39:57] RoanKattouw, that's weird... why is it not limited to the current function scope? [23:40:08] Krenair: So, there is this horrible thing in JS [23:40:20] If you start using a variable without declaring it, it becomes a global variable [23:40:24] This is somewhat insane [23:40:39] And it's part of the reason why "JavaScript: The Good Parts" is a thin book [23:40:53] (03PS7) 10Alex Monk: Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 [23:40:56] So, in order to avoid something being global, you have to declare it as local with 'var' [23:40:57] Hah. [23:41:14] Okay, will keep that in mind, thanks RoanKattouw [23:41:17] Because most globals of this type are not intended, jshint errors on them unless you put in an explicit comment saying it's global [23:41:57] Krenair: Don't worry, this is what we have jshint for. If you try to introduce stuff like this, your commits will just get V-1 [23:42:04] (03CR) 10jenkins-bot: [V: 04-1] Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk) [23:42:27] really. [23:43:09] RoanKattouw, ^ [23:43:17] 23:41:38 [L123:C15] W081: Too many var statements. [23:43:17] 23:41:38 for ( var index in data ) { [23:43:48] (03PS1) 10Krinkle: core: Add a 'super' property to inheriting classes [oojs/core] - 10https://gerrit.wikimedia.org/r/112148 [23:44:09] Krenair: Yeah we have a convention that you should only have one var statement, at the very top [23:44:33] Because if you declare var foo; halfway through the function, it applies to the entire function, even to code above it [23:44:34] I know but I kind of feel like this case (in a for loop or similar) should be an exception :/ [23:44:42] Yeah, well ... [23:44:47] Ew. What? Code above it? [23:44:50] If only JS had scoped vars [23:45:01] In C++, you can do things like for ( int i = 0; i [23:45:14] In C++, you can do things like for ( int i = 0; i < len; i++ ) { ... } /* i doesn't exist here */ [23:45:34] But in JS, you have /* i already exists! */ for ( var i = 0; i < len; i++ ) { ... } /* i still exists! */ [23:45:52] In fact, even /* foo already exists! */ if ( bar ) { ....; var foo; ...; } /* foo still exists! */ [23:45:53] So, yeah [23:46:24] The only thing you can scope a variable to is a function, and it's scoped retroactively [23:47:12] So we've decided (by which I mean Krinkle's decided) that we should write code that reflects how it's actually going to be executed, which means putting all local variable declarations and local functions at the top [23:47:30] Am not familiar with C++ but I used to do a bit of Java and I know I could declare the variable in a for loop and have it scope to only that block [23:47:36] If you put var foo; in the middle of a function, you're just fooling yourself and others, because the JS interpreter is just going to pretend that that line was at the top anyway [23:47:38] Yes, it makes more sense now that I understand that. [23:47:38] (03PS3) 10Jhall: [Browser test] VisualEditor availability on prod wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111142 [23:47:50] Yeah, the C++ code I wrote up there is also valid Java [23:47:53] (The rule about the number of var statements I mean) [23:48:34] It's not so much that we like variables being hoisted, but because that's what happens, we structure the code to make sure that it is obvious that it is happening and prevents variable out of scope mistakes (or accidental re-use of the same variable name) [23:48:45] (03PS8) 10Alex Monk: Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 [23:48:45] Yes, exacty [23:51:10] yay it shut up now. [23:51:18] (03PS4) 10Jhall: [Browser test] WIP VisualEditor availability on prod wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111142 [23:55:57] (03CR) 10Catrope: [C: 031] Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk) [23:57:37] (03PS3) 10Catrope: Make this.loading abortable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111666